* IPMI Panic bug
@ 2005-12-14 21:10 Paolo Galtieri
0 siblings, 0 replies; only message in thread
From: Paolo Galtieri @ 2005-12-14 21:10 UTC (permalink / raw)
To: Linux Kernel; +Cc: Corey Minyard
Folks,
while doing some testing I discovered that if the BIOS on a
board does not properly setup the DMI information it leads to
a panic in the IPMI code. The panic is due to dereferencing
a pointer which is not initialized. The pointer is initialized
in port_setup() and/or mem_setup() and used in init_one_smi() and
cleanup_one_si(), however if either port_setup() or mem_setup()
return ENODEV the pointer does not get initialized. The patch
is below done against 2.6.15-rc5-git4
Paolo
--- linux-2.6.15-rc5/drivers/char/ipmi/ipmi_si_intf.c 2005-12-05
10:02:56.000000000 -0700
+++ new-linux-2.6.15-rc5/drivers/char/ipmi/ipmi_si_intf.c 2005-12-14
13:57:02.000000000 -0700
@@ -2399,7 +2399,8 @@
new_smi->handlers->cleanup(new_smi->si_sm);
kfree(new_smi->si_sm);
}
- new_smi->io_cleanup(new_smi);
+ if (new_smi->io_cleanup)
+ new_smi->io_cleanup(new_smi);
return rv;
}
@@ -2518,7 +2519,8 @@
kfree(to_clean->si_sm);
- to_clean->io_cleanup(to_clean);
+ if (to_clean->io_cleanup)
+ to_clean->io_cleanup(to_clean);
}
static __exit void cleanup_ipmi_si(void)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-12-14 21:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-14 21:10 IPMI Panic bug Paolo Galtieri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).