linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS
@ 2006-01-10  4:06 Adrian Bunk
  2006-01-10  4:14 ` Lee Revell
  2006-01-10 18:56 ` Mauro Carvalho Chehab
  0 siblings, 2 replies; 5+ messages in thread
From: Adrian Bunk @ 2006-01-10  4:06 UTC (permalink / raw)
  To: Ricardo Cerqueira; +Cc: mchehab, video4linux-list, linux-kernel

There's no reason for an ALSA driver to select an OSS legacy userspace 
interface.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.15-mm2/drivers/media/video/saa7134/Kconfig.old	2006-01-10 02:59:30.000000000 +0100
+++ linux-2.6.15-mm2/drivers/media/video/saa7134/Kconfig	2006-01-10 03:02:57.000000000 +0100
@@ -15,7 +15,7 @@
 config VIDEO_SAA7134_ALSA
 	tristate "Philips SAA7134 DMA audio support"
 	depends on VIDEO_SAA7134 && SND
-	select SND_PCM_OSS
+	select SND_PCM
 	---help---
 	  This is a video4linux driver for direct (DMA) audio in
 	  Philips SAA713x based TV cards using ALSA


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS
  2006-01-10  4:06 [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS Adrian Bunk
@ 2006-01-10  4:14 ` Lee Revell
  2006-01-10  4:33   ` Adrian Bunk
  2006-01-10 18:56 ` Mauro Carvalho Chehab
  1 sibling, 1 reply; 5+ messages in thread
From: Lee Revell @ 2006-01-10  4:14 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Ricardo Cerqueira, mchehab, video4linux-list, linux-kernel

On Tue, 2006-01-10 at 05:06 +0100, Adrian Bunk wrote:
> There's no reason for an ALSA driver to select an OSS legacy userspace 
> interface.

Actually there is a reason.  While OSS may be deprecated the OSS API is
not - ALSA is committed to supporting it for the forseeable future.  And
as broken an interface as it is, a lot of people consider the sound
system broken if you can't just write() to /dev/dsp and have sound come
out.

Lee


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS
  2006-01-10  4:14 ` Lee Revell
@ 2006-01-10  4:33   ` Adrian Bunk
  2006-01-10  4:43     ` Lee Revell
  0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2006-01-10  4:33 UTC (permalink / raw)
  To: Lee Revell; +Cc: Ricardo Cerqueira, mchehab, video4linux-list, linux-kernel

On Mon, Jan 09, 2006 at 11:14:05PM -0500, Lee Revell wrote:
> On Tue, 2006-01-10 at 05:06 +0100, Adrian Bunk wrote:
> > There's no reason for an ALSA driver to select an OSS legacy userspace 
> > interface.
> 
> Actually there is a reason.  While OSS may be deprecated the OSS API is
> not - ALSA is committed to supporting it for the forseeable future.  And
> as broken an interface as it is, a lot of people consider the sound
> system broken if you can't just write() to /dev/dsp and have sound come
> out.

No disagreement, but that's not the point.

SND_PCM_OSS gives an OSS API interface for userspace on top of ALSA.
ALSA drivers shouldn't care whether they are controlled directly 
through ALSA or through a legacy OSS API on top of ALSA.

If someone wants to use SND_PCM_OSS that is fine, but the ALSA interface 
to my saa7134 card is working fine, so why does it force me to compile a 
legacy OSS API interface into the kernel?

> Lee

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS
  2006-01-10  4:33   ` Adrian Bunk
@ 2006-01-10  4:43     ` Lee Revell
  0 siblings, 0 replies; 5+ messages in thread
From: Lee Revell @ 2006-01-10  4:43 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Ricardo Cerqueira, mchehab, video4linux-list, linux-kernel

On Tue, 2006-01-10 at 05:33 +0100, Adrian Bunk wrote:
> On Mon, Jan 09, 2006 at 11:14:05PM -0500, Lee Revell wrote:
> > On Tue, 2006-01-10 at 05:06 +0100, Adrian Bunk wrote:
> > > There's no reason for an ALSA driver to select an OSS legacy userspace 
> > > interface.
> > 
> > Actually there is a reason.  While OSS may be deprecated the OSS API is
> > not - ALSA is committed to supporting it for the forseeable future.  And
> > as broken an interface as it is, a lot of people consider the sound
> > system broken if you can't just write() to /dev/dsp and have sound come
> > out.
> 
> No disagreement, but that's not the point.
> 
> SND_PCM_OSS gives an OSS API interface for userspace on top of ALSA.
> ALSA drivers shouldn't care whether they are controlled directly 
> through ALSA or through a legacy OSS API on top of ALSA.
> 
> If someone wants to use SND_PCM_OSS that is fine, but the ALSA interface 
> to my saa7134 card is working fine, so why does it force me to compile a 
> legacy OSS API interface into the kernel?

OK, makes sense.

Lee


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS
  2006-01-10  4:06 [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS Adrian Bunk
  2006-01-10  4:14 ` Lee Revell
@ 2006-01-10 18:56 ` Mauro Carvalho Chehab
  1 sibling, 0 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2006-01-10 18:56 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Ricardo Cerqueira, video4linux-list, linux-kernel

Em Ter, 2006-01-10 às 05:06 +0100, Adrian Bunk escreveu:
> There's no reason for an ALSA driver to select an OSS legacy userspace 
> interface.
> 
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.15-mm2/drivers/media/video/saa7134/Kconfig.old	2006-01-10 02:59:30.000000000 +0100
> +++ linux-2.6.15-mm2/drivers/media/video/saa7134/Kconfig	2006-01-10 03:02:57.000000000 +0100
> @@ -15,7 +15,7 @@
>  config VIDEO_SAA7134_ALSA
>  	tristate "Philips SAA7134 DMA audio support"
>  	depends on VIDEO_SAA7134 && SND
> -	select SND_PCM_OSS
> +	select SND_PCM
>  	---help---
>  	  This is a video4linux driver for direct (DMA) audio in
>  	  Philips SAA713x based TV cards using ALSA
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>

	I'll apply at v4l-dvb git tree.
> 
> 
Cheers, 
Mauro.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-01-10 18:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-10  4:06 [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS Adrian Bunk
2006-01-10  4:14 ` Lee Revell
2006-01-10  4:33   ` Adrian Bunk
2006-01-10  4:43     ` Lee Revell
2006-01-10 18:56 ` Mauro Carvalho Chehab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).