* [2.6 patch] arch/s390/Makefile: remove -finline-limit=10000
@ 2006-01-10 20:57 Adrian Bunk
2006-01-11 9:21 ` Martin Schwidefsky
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2006-01-10 20:57 UTC (permalink / raw)
To: schwidefsky, linux390; +Cc: linux-390, linux-kernel
-finline-limit might have been required for older compilers, but
nowadays it does no longer make sense.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-mm2-full/arch/s390/Makefile.old 2006-01-08 16:25:53.000000000 +0100
+++ linux-2.6.15-mm2-full/arch/s390/Makefile 2006-01-08 16:25:59.000000000 +0100
@@ -67,7 +67,6 @@
endif
CFLAGS += -mbackchain -msoft-float $(cflags-y)
-CFLAGS += $(call cc-option,-finline-limit=10000)
CFLAGS += -pipe -fno-strength-reduce -Wno-sign-compare
AFLAGS += $(aflags-y)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] arch/s390/Makefile: remove -finline-limit=10000
2006-01-10 20:57 [2.6 patch] arch/s390/Makefile: remove -finline-limit=10000 Adrian Bunk
@ 2006-01-11 9:21 ` Martin Schwidefsky
2006-01-11 19:56 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Martin Schwidefsky @ 2006-01-11 9:21 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux390, linux-390, linux-kernel
On Tue, 2006-01-10 at 21:57 +0100, Adrian Bunk wrote:
> -finline-limit might have been required for older compilers, but
> nowadays it does no longer make sense.
I didn't check the effects of reverting to the default inline-limit, did
you find any negative impacts? I'm thinking about the critical code
paths e.g. minor faults. There better should not be an additional
function call that would have been inlined with the bigger inline limit,
since function calls are quite expensive on s390.
--
blue skies,
Martin
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] arch/s390/Makefile: remove -finline-limit=10000
2006-01-11 9:21 ` Martin Schwidefsky
@ 2006-01-11 19:56 ` David S. Miller
0 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2006-01-11 19:56 UTC (permalink / raw)
To: schwidefsky; +Cc: bunk, linux390, linux-390, linux-kernel
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
Date: Wed, 11 Jan 2006 10:21:20 +0100
> On Tue, 2006-01-10 at 21:57 +0100, Adrian Bunk wrote:
> > -finline-limit might have been required for older compilers, but
> > nowadays it does no longer make sense.
>
> I didn't check the effects of reverting to the default inline-limit, did
> you find any negative impacts? I'm thinking about the critical code
> paths e.g. minor faults. There better should not be an additional
> function call that would have been inlined with the bigger inline limit,
> since function calls are quite expensive on s390.
You need to be careful now that -Os is specified by default
in 2.6.x
The inline-limit GCC option is interpreted differently in
gcc-4.x when -Os is given vs. when it is not.
On Sparc this caused schedule() to be inlined (I'm not kidding)
which caused all kinds of troubles.
I highly recommed you don't specify it and let the compiler
make the decisions, and add inline tags to places where you
think it is hyper-important for inlining to occur.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] arch/s390/Makefile: remove -finline-limit=10000
@ 2006-02-03 21:15 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2006-02-03 21:15 UTC (permalink / raw)
To: Andrew Morton; +Cc: schwidefsky, linux390, linux-390, linux-kernel
-finline-limit might have been required for older compilers, but
nowadays it does no longer make sense.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 10 Jan 2006
--- linux-2.6.15-mm2-full/arch/s390/Makefile.old 2006-01-08 16:25:53.000000000 +0100
+++ linux-2.6.15-mm2-full/arch/s390/Makefile 2006-01-08 16:25:59.000000000 +0100
@@ -67,7 +67,6 @@
endif
CFLAGS += -mbackchain -msoft-float $(cflags-y)
-CFLAGS += $(call cc-option,-finline-limit=10000)
CFLAGS += -pipe -fno-strength-reduce -Wno-sign-compare
AFLAGS += $(aflags-y)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-02-03 21:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-10 20:57 [2.6 patch] arch/s390/Makefile: remove -finline-limit=10000 Adrian Bunk
2006-01-11 9:21 ` Martin Schwidefsky
2006-01-11 19:56 ` David S. Miller
2006-02-03 21:15 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).