From: Kristen Accardi <kristen.c.accardi@intel.com>
To: MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com,
pcihpd-discuss@lists.sourceforge.net, len.brown@intel.com,
linux-acpi@vger.kernel.org, pavel@ucw.cz
Subject: Re: [Pcihpd-discuss] [patch 2/4] acpiphp: handle dock bridges
Date: Fri, 20 Jan 2006 09:56:59 -0800 [thread overview]
Message-ID: <1137779819.16192.5.camel@whizzy> (raw)
In-Reply-To: <87r773a8dz.wl%muneda.takahiro@jp.fujitsu.com>
On Fri, 2006-01-20 at 12:24 +0900, MUNEDA Takahiro wrote:
> Hi,
>
> At Tue, 17 Jan 2006 16:56:59 -0800,
> Kristen Accardi <kristen.c.accardi@intel.com> wrote:
> >
> > @@ -681,6 +713,88 @@ static int acpiphp_configure_ioapics(acp
> (snip)
> > +static int acpiphp_bus_add(struct acpiphp_func *func)
> > +{
> > + acpi_handle phandle;
> > + struct acpi_device *device, *pdevice;
> > + int ret_val;
> > +
> > + acpi_get_parent(func->handle, &phandle);
> > + if (acpi_bus_get_device(phandle, &pdevice)) {
> > + dbg("no parent device, assuming NULL\n");
> > + pdevice = NULL;
> > + }
> > + ret_val = acpi_bus_add(&device, pdevice, func->handle,
> > + ACPI_BUS_TYPE_DEVICE);
> > + if (ret_val)
> > + dbg("cannot add bridge to acpi list\n");
> > +
> > + /*
> > + * try to start anyway. We could have failed to add
> > + * simply because this bus had previously been added
> > + * on another dock. Don't bother with the return value
> > + * we just keep going.
> > + */
> > + ret_val = acpi_bus_start(device);
> > +
> > + return ret_val;
> > +}
> > +
> > +
> > +
>
> When the device is docked, acpi_bus_add() is called to register
> the device into acpi list. But if the device is undocked,
> acpi_bus_trim() doesn't called.
> Can you hot-add/remove the dock station repeatedly?
>
> Thanks,
> MUNE
>
Yes you can. The reason for this is because even if we fail the call to
acpi_bus_add(), we ignore the return value and call acpi_bus_start()
anyway.
next prev parent reply other threads:[~2006-01-20 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060116200218.275371000@whizzy>
2006-01-18 0:56 ` [patch 1/4] pci: return max reserved busnr Kristen Accardi
2006-01-18 0:56 ` [patch 2/4] acpiphp: handle dock bridges Kristen Accardi
2006-01-18 2:26 ` [Pcihpd-discuss] " Kenji Kaneshige
2006-01-18 5:11 ` Greg KH
2006-01-18 3:55 ` Dmitry Torokhov
2006-01-18 4:43 ` [Pcihpd-discuss] " Kenji Kaneshige
2006-01-20 3:24 ` MUNEDA Takahiro
2006-01-20 17:56 ` Kristen Accardi [this message]
2006-01-21 1:55 ` [PATCH] acpiphp: treat dck separate from dock bridge Kristen Accardi
2006-01-21 11:27 ` Pavel Machek
2006-01-21 11:29 ` Pavel Machek
2006-01-21 12:10 ` Pavel Machek
2006-01-23 19:20 ` Kristen Accardi
2006-01-18 0:57 ` [patch 3/4] pci: really fix parent's subordinate busnr Kristen Accardi
2006-01-18 0:57 ` [patch 4/4] pci: quirk for IBM Dock II cardbus controllers Kristen Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137779819.16192.5.camel@whizzy \
--to=kristen.c.accardi@intel.com \
--cc=greg@kroah.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muneda.takahiro@jp.fujitsu.com \
--cc=pavel@ucw.cz \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).