linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com,
	pcihpd-discuss@lists.sourceforge.net, len.brown@intel.com,
	linux-acpi@vger.kernel.org, pavel@ucw.cz
Subject: Re: [Pcihpd-discuss] [patch 2/4]  acpiphp: handle dock bridges
Date: Wed, 18 Jan 2006 11:26:41 +0900	[thread overview]
Message-ID: <43CDA761.5040707@jp.fujitsu.com> (raw)
In-Reply-To: <1137545819.19858.47.camel@whizzy>

Hi,

> +static struct acpiphp_func * get_func(struct acpiphp_slot *slot,
> +					struct pci_dev *dev)
> +{
> +	struct list_head *l;
> +	struct acpiphp_func *func;
> +	struct pci_bus *bus = slot->bridge->pci_bus;
> +
> +	list_for_each (l, &slot->funcs) {
> +		func = list_entry(l, struct acpiphp_func, sibling);
> +		if (pci_get_slot(bus, PCI_DEVFN(slot->device,
> +					func->function)) == dev)
> +			return func;
> +	}

This seems to leak reference counter of pci_dev. I think you
must call pci_dev_put() also.

Thanks,
Kenji Kaneshige

  reply	other threads:[~2006-01-18  2:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060116200218.275371000@whizzy>
2006-01-18  0:56 ` [patch 1/4] pci: return max reserved busnr Kristen Accardi
2006-01-18  0:56 ` [patch 2/4] acpiphp: handle dock bridges Kristen Accardi
2006-01-18  2:26   ` Kenji Kaneshige [this message]
2006-01-18  5:11     ` [Pcihpd-discuss] " Greg KH
2006-01-18  3:55   ` Dmitry Torokhov
2006-01-18  4:43   ` [Pcihpd-discuss] " Kenji Kaneshige
2006-01-20  3:24   ` MUNEDA Takahiro
2006-01-20 17:56     ` Kristen Accardi
2006-01-21  1:55   ` [PATCH] acpiphp: treat dck separate from dock bridge Kristen Accardi
2006-01-21 11:27     ` Pavel Machek
2006-01-21 11:29     ` Pavel Machek
2006-01-21 12:10     ` Pavel Machek
2006-01-23 19:20       ` Kristen Accardi
2006-01-18  0:57 ` [patch 3/4] pci: really fix parent's subordinate busnr Kristen Accardi
2006-01-18  0:57 ` [patch 4/4] pci: quirk for IBM Dock II cardbus controllers Kristen Accardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43CDA761.5040707@jp.fujitsu.com \
    --to=kaneshige.kenji@jp.fujitsu.com \
    --cc=greg@kroah.com \
    --cc=kristen.c.accardi@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pcihpd-discuss@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).