From: John McCutchan <john@johnmccutchan.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
holt@sgi.com, linux-kernel@vger.kernel.org, rml@novell.com,
arnd@arndb.de, hch@lst.de, dipankar@in.ibm.com
Subject: Re: udevd is killing file write performance.
Date: Sun, 26 Feb 2006 11:58:49 -0500 [thread overview]
Message-ID: <1140973129.15634.6.camel@localhost.localdomain> (raw)
In-Reply-To: <43FEB370.6030101@yahoo.com.au>
On Fri, 2006-24-02 at 18:19 +1100, Nick Piggin wrote:
> Andrew Morton wrote:
> > Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> >
> >>@@ -538,7 +579,7 @@ void inotify_dentry_parent_queue_event(s
> >> struct dentry *parent;
> >> struct inode *inode;
> >>
> >> - if (!atomic_read (&inotify_watches))
> >> + if (!(dentry->d_flags & DCACHE_INOTIFY_PARENT_WATCHED))
> >
> >
> > Yeah, I think that would work. One would need to wire up d_move() also -
> > for when a file is moved from a watched to non-watched directory and
> > vice-versa.
> >
> >
>
> Oh yeah of course, good catch. Are there any other cases missing?
>
> ... I'll let the others on this thread digest before spitting out
> another patch.
>
> John or Robert, is there some kind of inotify test suite around?
Unfortunately there isn't. In the past gamin's test suite was a good
start, but it hasn't been working for a while now.
--
John McCutchan <john@johnmccutchan.com>
next prev parent reply other threads:[~2006-02-26 16:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 13:42 udevd is killing file write performance Robin Holt
2006-02-22 13:55 ` Andrew Morton
2006-02-22 16:48 ` John McCutchan
2006-02-22 17:50 ` Robin Holt
2006-02-22 20:05 ` Andrew Morton
2006-02-22 21:50 ` Jeff V. Merkey
2006-02-23 12:56 ` Robin Holt
2006-02-23 13:42 ` David Chinner
2006-02-22 22:52 ` John McCutchan
2006-02-22 23:12 ` Andrew Morton
2006-02-22 23:41 ` John McCutchan
2006-02-24 0:14 ` Andrew Morton
2006-02-24 0:14 ` Andrew Morton
2006-02-24 5:47 ` John McCutchan
2006-02-24 6:00 ` Andrew Morton
2006-02-24 7:07 ` Nick Piggin
2006-02-24 7:16 ` Andrew Morton
2006-02-24 7:19 ` Nick Piggin
2006-02-26 16:58 ` John McCutchan [this message]
2006-02-24 18:56 ` Robin Holt
2006-02-25 2:44 ` Nick Piggin
2006-02-25 15:53 ` [patch] inotify: lock avoidance with parent watch status in dentry Nick Piggin
2006-02-28 0:48 ` Andrew Morton
2006-02-26 16:55 ` udevd is killing file write performance John McCutchan
2006-02-27 10:11 ` Nick Piggin
2006-02-27 20:17 ` John McCutchan
2006-02-23 20:38 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140973129.15634.6.camel@localhost.localdomain \
--to=john@johnmccutchan.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=dipankar@in.ibm.com \
--cc=hch@lst.de \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rml@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).