From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-gpio@vger.kernel.org, patches@opensource.cirrus.com
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: arizona: put pm_runtime in case of failure
Date: Fri, 5 Jun 2020 14:14:38 +0200 [thread overview]
Message-ID: <11488e76-2ea0-6478-0800-deb0438f0136@web.de> (raw)
I recommend to replace the word “pm_runtime” by the
alternative “PM run time system” in the patch subject.
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count if pm_runtime_put is not called in
> error handling paths.
Should the term “reference count” be used here?
> Call pm_runtime_put if pm_runtime_get_sync fails.
The diff hunks show an other function name.
…
> +++ b/drivers/gpio/gpio-arizona.c
> @@ -64,6 +64,7 @@ static int arizona_gpio_get(struct gpio_chip *chip, unsigned offset)
> ret = pm_runtime_get_sync(chip->parent);
> if (ret < 0) {
> dev_err(chip->parent, "Failed to resume: %d\n", ret);
> + pm_runtime_put_autosuspend(chip->parent);
> return ret;
> }
You propose to use identical statements in three if branches.
Please add a corresponding jump target for better exception handling.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=435faf5c218a47fd6258187f62d9bb1009717896#n455
Would you like to add the tag “Fixes” to the commit message?
I find it amazing how many questionable implementation details
you pointed out recently.
Were these contributions triggered by an evolving source code analysis
tool like CheQ?
https://github.com/umnsec/cheq/
Regards,
Markus
next reply other threads:[~2020-06-05 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 12:14 Markus Elfring [this message]
2020-06-10 14:54 ` [PATCH] gpio: arizona: put pm_runtime in case of failure Greg KH
-- strict thread matches above, loose matches on Subject: below --
2020-06-05 3:00 Navid Emamdoost
2020-06-05 10:56 ` Charles Keepax
2020-06-10 9:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11488e76-2ea0-6478-0800-deb0438f0136@web.de \
--to=markus.elfring@web.de \
--cc=bgolaszewski@baylibre.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).