linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	<patches@opensource.cirrus.com>, <linux-gpio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <emamd001@umn.edu>,
	<wu000273@umn.edu>, <kjlu@umn.edu>, <smccaman@umn.edu>
Subject: Re: [PATCH] gpio: arizona: put pm_runtime in case of failure
Date: Fri, 5 Jun 2020 10:56:08 +0000	[thread overview]
Message-ID: <20200605105608.GN71940@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20200605030052.78235-1-navid.emamdoost@gmail.com>

On Thu, Jun 04, 2020 at 10:00:52PM -0500, Navid Emamdoost wrote:
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count if pm_runtime_put is not called in
> error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

  reply	other threads:[~2020-06-05 10:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  3:00 [PATCH] gpio: arizona: put pm_runtime in case of failure Navid Emamdoost
2020-06-05 10:56 ` Charles Keepax [this message]
2020-06-10  9:20 ` Linus Walleij
2020-06-05 12:14 Markus Elfring
2020-06-10 14:54 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605105608.GN71940@ediswmail.ad.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=emamd001@umn.edu \
    --cc=kjlu@umn.edu \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navid.emamdoost@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=smccaman@umn.edu \
    --cc=wu000273@umn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).