* [Patch] Overrun in drivers/char/rio/riocmd.c
@ 2006-06-21 21:18 Eric Sesterhenn
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn @ 2006-06-21 21:18 UTC (permalink / raw)
To: linux-kernel
hi,
this fixes coverity bug id #1025.
The code checks if Rup is greater or equal to the size of
HostP->Mapping[], but uses Rup as an index if it is outside
the range. This patch changes the if and else cases.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git2/drivers/char/rio/riocmd.c.orig 2006-06-21 23:14:52.000000000 +0200
+++ linux-2.6.17-git2/drivers/char/rio/riocmd.c 2006-06-21 23:15:21.000000000 +0200
@@ -402,7 +402,7 @@ static int RIOCommandRup(struct rio_info
rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: Host number %Zd, name ``%s''\n", HostP - p->RIOHosts, HostP->Name);
rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: Rup number 0x%x\n", rup);
- if (Rup >= (unsigned short) MAX_RUP) {
+ if (Rup < (unsigned short) MAX_RUP) {
rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: This is the RUP for RTA ``%s''\n", HostP->Mapping[Rup].Name);
} else
rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: This is the RUP for link ``%c'' of host ``%s''\n", ('A' + Rup - MAX_RUP), HostP->Name);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-21 21:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-21 21:18 [Patch] Overrun in drivers/char/rio/riocmd.c Eric Sesterhenn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).