* all-modular snd-aoa
@ 2006-06-23 9:14 Paul Collins
2006-06-23 14:14 ` Johannes Berg
0 siblings, 1 reply; 10+ messages in thread
From: Paul Collins @ 2006-06-23 9:14 UTC (permalink / raw)
To: johannes; +Cc: alsa-devel, linux-kernel
I get this when building from Linus's current git tree:
LD sound/built-in.o
ld: sound/aoa/built-in.o: No such file: No such file or directory
make[1]: *** [sound/built-in.o] Error 1
make: *** [sound] Error 2
Doing "touch sound/aoa/built-in.o" lets the build continue and
complete successfully.
--
Paul Collins
Melbourne, Australia
Dag vijandelijk luchtschip de huismeester is dood
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: all-modular snd-aoa
2006-06-23 9:14 all-modular snd-aoa Paul Collins
@ 2006-06-23 14:14 ` Johannes Berg
2006-06-23 14:30 ` [Alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 10+ messages in thread
From: Johannes Berg @ 2006-06-23 14:14 UTC (permalink / raw)
To: Paul Collins; +Cc: alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
On Fri, 2006-06-23 at 19:14 +1000, Paul Collins wrote:
> I get this when building from Linus's current git tree:
>
> LD sound/built-in.o
> ld: sound/aoa/built-in.o: No such file: No such file or directory
> make[1]: *** [sound/built-in.o] Error 1
> make: *** [sound] Error 2
>
> Doing "touch sound/aoa/built-in.o" lets the build continue and
> complete successfully.
Ahrg! That's a mistake in my Makefile programming, I'll probably have to
move the core/ files up one dir. Sorry.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Alsa-devel] all-modular snd-aoa
2006-06-23 14:14 ` Johannes Berg
@ 2006-06-23 14:30 ` Takashi Iwai
2006-06-23 14:36 ` Johannes Berg
0 siblings, 1 reply; 10+ messages in thread
From: Takashi Iwai @ 2006-06-23 14:30 UTC (permalink / raw)
To: Johannes Berg; +Cc: Paul Collins, alsa-devel, linux-kernel
At Fri, 23 Jun 2006 16:14:55 +0200,
Johannes Berg wrote:
>
> On Fri, 2006-06-23 at 19:14 +1000, Paul Collins wrote:
> > I get this when building from Linus's current git tree:
> >
> > LD sound/built-in.o
> > ld: sound/aoa/built-in.o: No such file: No such file or directory
> > make[1]: *** [sound/built-in.o] Error 1
> > make: *** [sound] Error 2
> >
> > Doing "touch sound/aoa/built-in.o" lets the build continue and
> > complete successfully.
>
> Ahrg! That's a mistake in my Makefile programming, I'll probably have to
> move the core/ files up one dir. Sorry.
Where is the problem in Makefile? It looks OK to me...
Nevertheless, aoa/Kconfig has a wrong dependency on SND_PCM.
Takashi
--- a/sound/aoa/Kconfig Fri Jun 23 15:18:41 2006 +0200
+++ b/sound/aoa/Kconfig Fri Jun 23 16:29:14 2006 +0200
@@ -3,7 +3,8 @@ menu "Apple Onboard Audio driver"
config SND_AOA
tristate "Apple Onboard Audio driver"
- depends on SOUND && SND_PCM
+ depends on SND
+ select SND_PCM
---help---
This option enables the new driver for the various
Apple Onboard Audio components.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Alsa-devel] all-modular snd-aoa
2006-06-23 14:30 ` [Alsa-devel] " Takashi Iwai
@ 2006-06-23 14:36 ` Johannes Berg
2006-06-23 14:50 ` Takashi Iwai
0 siblings, 1 reply; 10+ messages in thread
From: Johannes Berg @ 2006-06-23 14:36 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Paul Collins, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On Fri, 2006-06-23 at 16:30 +0200, Takashi Iwai wrote:
> Where is the problem in Makefile? It looks OK to me...
Well, the problem is the fact the snd-aoa/ dir contains nothing to be
compiled and the kernel Makefiles don't like that.
> Nevertheless, aoa/Kconfig has a wrong dependency on SND_PCM.
Good point. Committing to my repository, how should we process things
like that now? Should I post some patches once a while or do you want to
commit that right away?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Alsa-devel] all-modular snd-aoa
2006-06-23 14:36 ` Johannes Berg
@ 2006-06-23 14:50 ` Takashi Iwai
2006-06-23 14:54 ` Johannes Berg
0 siblings, 1 reply; 10+ messages in thread
From: Takashi Iwai @ 2006-06-23 14:50 UTC (permalink / raw)
To: Johannes Berg; +Cc: Paul Collins, alsa-devel, linux-kernel
At Fri, 23 Jun 2006 16:36:30 +0200,
Johannes Berg wrote:
>
> On Fri, 2006-06-23 at 16:30 +0200, Takashi Iwai wrote:
>
> > Where is the problem in Makefile? It looks OK to me...
>
> Well, the problem is the fact the snd-aoa/ dir contains nothing to be
> compiled and the kernel Makefiles don't like that.
Then it's eaiser to fix sound/Makefile.
--- a/sound/Makefile Fri Jun 23 15:18:41 2006 +0200
+++ b/sound/Makefile Fri Jun 23 16:49:15 2006 +0200
@@ -4,7 +4,8 @@ obj-$(CONFIG_SOUND) += soundcore.o
obj-$(CONFIG_SOUND) += soundcore.o
obj-$(CONFIG_SOUND_PRIME) += oss/
obj-$(CONFIG_DMASOUND) += oss/
-obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ aoa/
+obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/
+obj-$(CONFIG_SND_AOA) += aoa/
ifeq ($(CONFIG_SND),y)
obj-y += last.o
> > Nevertheless, aoa/Kconfig has a wrong dependency on SND_PCM.
>
> Good point. Committing to my repository, how should we process things
> like that now? Should I post some patches once a while or do you want to
> commit that right away?
Post patches to alsa-devel (and Cc to me). Will be pushed together
with other fixes.
Takashi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Alsa-devel] all-modular snd-aoa
2006-06-23 14:50 ` Takashi Iwai
@ 2006-06-23 14:54 ` Johannes Berg
2006-06-23 15:00 ` Takashi Iwai
2006-06-23 15:07 ` Paul Collins
0 siblings, 2 replies; 10+ messages in thread
From: Johannes Berg @ 2006-06-23 14:54 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Paul Collins, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
On Fri, 2006-06-23 at 16:50 +0200, Takashi Iwai wrote:
> Then it's eaiser to fix sound/Makefile.
Ah, I should get out of fast-mail mode and think about things a bit
more. Sorry. Yeah that should work, Paul, could you verify?
> Post patches to alsa-devel (and Cc to me). Will be pushed together
> with other fixes.
Ok, but then should I assume you already committed these (your own)
patches or not?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Alsa-devel] all-modular snd-aoa
2006-06-23 14:54 ` Johannes Berg
@ 2006-06-23 15:00 ` Takashi Iwai
2006-06-23 15:03 ` Johannes Berg
2006-06-23 15:07 ` Paul Collins
1 sibling, 1 reply; 10+ messages in thread
From: Takashi Iwai @ 2006-06-23 15:00 UTC (permalink / raw)
To: Johannes Berg; +Cc: Paul Collins, alsa-devel, linux-kernel
At Fri, 23 Jun 2006 16:54:52 +0200,
Johannes Berg wrote:
>
> On Fri, 2006-06-23 at 16:50 +0200, Takashi Iwai wrote:
>
> > Then it's eaiser to fix sound/Makefile.
>
> Ah, I should get out of fast-mail mode and think about things a bit
> more. Sorry. Yeah that should work, Paul, could you verify?
>
> > Post patches to alsa-devel (and Cc to me). Will be pushed together
> > with other fixes.
>
> Ok, but then should I assume you already committed these (your own)
> patches or not?
No, basically I commit only after someone confirmed the patch is
actually working.
It'd appreciated if you test and send patches with changelogs :)
Takashi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Alsa-devel] all-modular snd-aoa
2006-06-23 15:00 ` Takashi Iwai
@ 2006-06-23 15:03 ` Johannes Berg
0 siblings, 0 replies; 10+ messages in thread
From: Johannes Berg @ 2006-06-23 15:03 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Paul Collins, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
On Fri, 2006-06-23 at 17:00 +0200, Takashi Iwai wrote:
> No, basically I commit only after someone confirmed the patch is
> actually working.
>
> It'd appreciated if you test and send patches with changelogs :)
Ok. I'll do that then as soon as Paul confirms (not true actually since
I'm away over the weekend and he's hopefully sleeping now).
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Alsa-devel] all-modular snd-aoa
2006-06-23 14:54 ` Johannes Berg
2006-06-23 15:00 ` Takashi Iwai
@ 2006-06-23 15:07 ` Paul Collins
2006-06-26 6:22 ` Johannes Berg
1 sibling, 1 reply; 10+ messages in thread
From: Paul Collins @ 2006-06-23 15:07 UTC (permalink / raw)
To: Johannes Berg; +Cc: Takashi Iwai, alsa-devel, linux-kernel
Johannes Berg <johannes@sipsolutions.net> writes:
> On Fri, 2006-06-23 at 16:50 +0200, Takashi Iwai wrote:
>
>> Then it's eaiser to fix sound/Makefile.
>
> Ah, I should get out of fast-mail mode and think about things a bit
> more. Sorry. Yeah that should work, Paul, could you verify?
Yep, builds fine now.
--
Paul Collins
Melbourne, Australia
Dag vijandelijk luchtschip de huismeester is dood
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Alsa-devel] all-modular snd-aoa
2006-06-23 15:07 ` Paul Collins
@ 2006-06-26 6:22 ` Johannes Berg
0 siblings, 0 replies; 10+ messages in thread
From: Johannes Berg @ 2006-06-26 6:22 UTC (permalink / raw)
To: Paul Collins; +Cc: Takashi Iwai, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
On Sat, 2006-06-24 at 01:07 +1000, Paul Collins wrote:
> Yep, builds fine now.
Alright, thanks.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2006-06-26 6:22 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-23 9:14 all-modular snd-aoa Paul Collins
2006-06-23 14:14 ` Johannes Berg
2006-06-23 14:30 ` [Alsa-devel] " Takashi Iwai
2006-06-23 14:36 ` Johannes Berg
2006-06-23 14:50 ` Takashi Iwai
2006-06-23 14:54 ` Johannes Berg
2006-06-23 15:00 ` Takashi Iwai
2006-06-23 15:03 ` Johannes Berg
2006-06-23 15:07 ` Paul Collins
2006-06-26 6:22 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).