From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krishna Kurapati <quic_kriskura@quicinc.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com,
quic_jackp@quicinc.com, quic_harshq@quicinc.com,
ahalaney@redhat.com, quic_shazhuss@quicinc.com
Subject: Re: [PATCH v9 09/10] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports
Date: Sat, 24 Jun 2023 00:40:59 +0200 [thread overview]
Message-ID: <115ad8f2-72ff-90fe-c27e-c298b7b00993@linaro.org> (raw)
In-Reply-To: <20230621043628.21485-10-quic_kriskura@quicinc.com>
On 21.06.2023 06:36, Krishna Kurapati wrote:
> Enable tertiary controller for SA8295P (based on SC8280XP).
> Add pinctrl support for usb ports to provide VBUS to connected peripherals.
>
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 53 ++++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> index fd253942e5e5..8b24b3c55769 100644
> --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> @@ -9,6 +9,7 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include <dt-bindings/spmi/spmi.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>
> #include "sa8540p.dtsi"
> #include "sa8540p-pmics.dtsi"
> @@ -584,6 +585,20 @@ &usb_1_qmpphy {
> status = "okay";
> };
>
> +&usb_2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb2_en_state>,
> + <&usb3_en_state>,
> + <&usb4_en_state>,
> + <&usb5_en_state>;
Please put property-names after property
> +
> + status = "okay";
> +};
> +
> +&usb_2_dwc3 {
> + dr_mode = "host";
> +};
If I understood correctly, the MP controller is host-only. In that case,
I'd say that putting this property in the SoC-dtsi node with an appropriate
comment would be beneficial.
lgtm otherwise
Konrad
> +
> &usb_2_hsphy0 {
> vdda-pll-supply = <&vreg_l5a>;
> vdda18-supply = <&vreg_l7g>;
> @@ -729,3 +744,41 @@ wake-n-pins {
> };
> };
> };
> +
> +&pmm8540c_gpios {
> + usb2_en_state: usb2-en-state {
> + pins = "gpio9";
> + function = "normal";
> + qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>;
> + output-high;
> + power-source = <0>;
> + };
> +};
> +
> +&pmm8540e_gpios {
> + usb3_en_state: usb3-en-state {
> + pins = "gpio5";
> + function = "normal";
> + qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>;
> + output-high;
> + power-source = <0>;
> + };
> +};
> +
> +&pmm8540g_gpios {
> + usb4_en_state: usb4-en-state {
> + pins = "gpio5";
> + function = "normal";
> + qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>;
> + output-high;
> + power-source = <0>;
> + };
> +
> + usb5_en_state: usb5-en-state {
> + pins = "gpio9";
> + function = "normal";
> + qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>;
> + output-high;
> + power-source = <0>;
> + };
> +};
next prev parent reply other threads:[~2023-06-23 22:41 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 4:36 [PATCH v9 00/10] Add multiport support for DWC3 controllers Krishna Kurapati
2023-06-21 4:36 ` [PATCH v9 01/10] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport Krishna Kurapati
2023-06-23 20:41 ` Rob Herring
2023-06-27 11:20 ` Johan Hovold
2023-06-27 15:38 ` Johan Hovold
2023-07-02 19:11 ` Krishna Kurapati PSSNV
2023-07-21 8:10 ` Johan Hovold
2023-06-21 4:36 ` [PATCH v9 02/10] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller Krishna Kurapati
2023-06-23 20:41 ` Rob Herring
2023-06-27 11:24 ` Johan Hovold
2023-06-21 4:36 ` [PATCH v9 03/10] usb: dwc3: core: Access XHCI address space temporarily to read port info Krishna Kurapati
2023-06-23 22:14 ` Thinh Nguyen
2023-06-27 11:45 ` Johan Hovold
2023-07-02 18:48 ` Krishna Kurapati PSSNV
2023-07-21 7:44 ` Johan Hovold
2023-07-23 14:59 ` Krishna Kurapati PSSNV
2023-07-24 15:41 ` Johan Hovold
2023-07-25 5:39 ` Krishna Kurapati PSSNV
2023-06-21 4:36 ` [PATCH v9 04/10] usb: dwc3: core: Skip setting event buffers for host only controllers Krishna Kurapati
2023-06-23 22:27 ` Thinh Nguyen
2023-06-24 7:20 ` Krishna Kurapati PSSNV
2023-06-26 23:34 ` Thinh Nguyen
2023-06-26 23:46 ` Thinh Nguyen
2023-07-02 18:45 ` Krishna Kurapati PSSNV
2023-07-05 22:40 ` Thinh Nguyen
2023-06-21 4:36 ` [PATCH v9 05/10] usb: dwc3: core: Refactor PHY logic to support Multiport Controller Krishna Kurapati
2023-06-23 22:55 ` Thinh Nguyen
2023-06-24 7:15 ` Krishna Kurapati PSSNV
2023-06-27 12:09 ` Johan Hovold
2023-07-02 18:56 ` Krishna Kurapati PSSNV
2023-07-21 7:56 ` Johan Hovold
2023-08-01 1:30 ` Thinh Nguyen
2023-10-19 13:20 ` Johan Hovold
2023-06-21 4:36 ` [PATCH v9 06/10] usb: dwc3: qcom: Add support to read IRQ's related to multiport Krishna Kurapati
2023-06-21 10:05 ` Konrad Dybcio
2023-06-21 10:08 ` Krishna Kurapati PSSNV
2023-06-27 14:31 ` Johan Hovold
2023-07-02 18:59 ` Krishna Kurapati PSSNV
2023-07-11 6:42 ` Krishna Kurapati PSSNV
2023-07-21 8:14 ` Johan Hovold
2023-07-21 8:19 ` Krishna Kurapati PSSNV
2023-07-21 9:21 ` Johan Hovold
2023-07-21 9:35 ` Krishna Kurapati PSSNV
2023-07-21 11:11 ` Johan Hovold
2023-07-12 12:12 ` Johan Hovold
2023-07-12 18:26 ` Krishna Kurapati PSSNV
2023-07-14 9:05 ` Johan Hovold
2023-07-14 10:40 ` Krishna Kurapati PSSNV
2023-07-15 19:01 ` Krishna Kurapati PSSNV
2023-07-17 15:15 ` Krishna Kurapati PSSNV
2023-07-21 8:35 ` Johan Hovold
2023-07-21 8:45 ` Krishna Kurapati PSSNV
2023-06-21 4:36 ` [PATCH v9 07/10] usb: dwc3: qcom: Add multiport suspend/resume support for wrapper Krishna Kurapati
2023-06-27 15:05 ` Johan Hovold
2023-07-02 19:02 ` Krishna Kurapati PSSNV
2023-06-21 4:36 ` [PATCH v9 08/10] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280 Krishna Kurapati
2023-06-23 22:39 ` Konrad Dybcio
2023-06-24 7:13 ` Krishna Kurapati PSSNV
2023-06-27 15:16 ` Johan Hovold
2023-07-02 19:10 ` Krishna Kurapati PSSNV
2023-07-21 8:08 ` Johan Hovold
2023-06-27 15:11 ` Johan Hovold
2023-06-21 4:36 ` [PATCH v9 09/10] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports Krishna Kurapati
2023-06-23 22:40 ` Konrad Dybcio [this message]
2023-06-21 4:36 ` [PATCH v9 10/10] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller Krishna Kurapati
2023-06-23 22:42 ` Konrad Dybcio
2023-06-24 7:11 ` Krishna Kurapati PSSNV
2023-06-27 15:19 ` [PATCH v9 00/10] Add multiport support for DWC3 controllers Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115ad8f2-72ff-90fe-c27e-c298b7b00993@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_harshq@quicinc.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).