linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* sunrpc-related Oops in latest git
@ 2007-07-15 15:05 Haavard Skinnemoen
  2007-07-16 14:52 ` Trond Myklebust
  0 siblings, 1 reply; 5+ messages in thread
From: Haavard Skinnemoen @ 2007-07-15 15:05 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: Linux Kernel

Hi Trond,

While testing my avr32 updates on the latest git tree, I got this:

VFS: Mounted root (nfs filesystem).
Freeing init memory: 56K (90000000 - 9000e000)
Unable to handle kernel NULL pointer dereference at virtual address 00000000
ptbr = 90161f44 pgd = 00000000
Oops: Kernel access of bad area, sig: 11 [#1]
FRAME_POINTER chip: 0x01f:0x1e82 rev 2
Modules linked in:
PC is at queue_work+0x2a/0x34
LR is at __init_begin+0x70000000/0x1c
pc : [<900215f2>]    lr : [<00000000>]    Not tainted
sp : 9014fcf0  r12: 00000000  r11: 90009074
r10: 00100100  r9 : 90009078  r8 : 90009078
r7 : 9014fcf0  r6 : 9025652c  r5 : 90009004  r4 : 0000106c
r3 : 00001064  r2 : 00001064  r1 : 90263000  r0 : 901b1320
Flags: qvnZc
Mode bits: hrje....g
CPU Mode: Interrupt level 0
Process: swapper [0] (task: 90153afc thread: 9014e000)
Stack: (0x9014fcf0 to 0x90150000)
fce0:                                     900f983a 9014fd08 9025652c 90009004
fd00: 0000106c 00000000 900f98a2 9014fd1c 9000906c 90009004 0000106c 900f6edc
fd20: 9014fd30 9024c000 90009004 0000106c 900f8d08 9014fd5c 00001064 90009004
fd40: 0000106c 901b1320 00001064 90263000 901b1320 900cd15a 9014fd8c 900bc7f6
fd60: 9014fd80 00000000 00000000 0000106c 90263000 0000106c 0abfffaf 901b1320
fd80: 900e6010 9014fda4 90263000 90263000 0000106c 901b1320 9025d834 0abfffaf
fda0: 901b1320 900e6406 9014fdf4 90263000 901b1344 0000106c 9016e110 9025d834
fdc0: 0abfffaf 901b1320 900d0286 0abfffad 00000011 0000106c 10775008 90268540
fde0: 00001080 00000024 0000106c 0abfffad 0abfffaf 900e65bc 9014fe18 901b1320
fe00: 00000011 10775008 00000000 9016caa0 00000800 00000500 900cf3f6 9014fe2c
fe20: 901b1320 00000011 10775008 900cf76e 9014fe50 9000a820 901b1140 10775008
fe40: 901b1164 9016caa0 00000800 00000500 900c112a 9014fe74 9016ca88 901b1140
fe60: 10775008 901af800 9016caa0 00000800 00000500 900b1f44 9014feac 901b1140
fe80: 0000003b 10775008 000004fe 901afb80 0000003b 00000500 901af800 00000040
fea0: 00000003 900b1dbc 0000003d 900c2808 9014fed4 901af918 901af800 10775008
fec0: 9016c710 9016c700 fffedde1 007f0000 0000012c 9001ae96 9014fef8 00000000
fee0: 90168174 10775008 0000000a 90161904 00000000 007f0000 9001aefa 9014ff1c
ff00: 00810022 00000000 10775008 00000000 90161904 00000000 007f0000 9001b0a0
ff20: 9014ff30 9016aa0c 00000000 10775008 9000f074 9014ff44 9016aa0c 00000000
ff40: 10775008 9000e4fe 9014ffb0 90169058 90161930 10775008 9000be70 90161904
ff60: 00000000 007f0000 00400024 9000e4da 900112ba 90268000 90153978 00000000
ff80: 90153d74 00000200 9014e000 9014ffb0 90169058 90161930 10775008 9000be70
ffa0: 90161904 00000000 007f0000 007f0000 90102df6 9014ffc4 90169058 90161930
ffc0: 10775008 9000072c 9014ffdc 90169058 90161930 10775008 9000be70 00000000
ffe0: 00000000 107cb030 10770fa0 10775008 901729c8 901729c8 00000000 007f0000
Call trace:
 [<900f983a>] __rpc_do_wake_up_task+0x18a/0x1c4
 [<900f98a2>] rpc_wake_up_task+0x2e/0x40
 [<900f6edc>] xprt_complete_rqst+0x64/0x74
 [<900f8d08>] xs_udp_data_ready+0xd0/0xf0
 [<900bc7f6>] sock_queue_rcv_skb+0xa2/0xd0
 [<900e6010>] udp_queue_rcv_skb+0x9c/0x114
 [<900e6406>] __udp4_lib_rcv+0x37e/0x528
 [<900e65bc>] udp_rcv+0xc/0x14
 [<900cf3f6>] ip_local_deliver+0x7e/0xcc
 [<900cf76e>] ip_rcv+0x32a/0x35c
 [<900c112a>] netif_receive_skb+0x136/0x188
 [<900b1f44>] macb_poll+0x27c/0x318
 [<900c2808>] net_rx_action+0x48/0xc4
 [<9001ae96>] __do_softirq+0x32/0x74
 [<9001aefa>] do_softirq+0x22/0x3c
 [<9001b0a0>] irq_exit+0x24/0x30
 [<9000f074>] do_IRQ+0x3c/0x50
 [<9000e4fe>] irq_level0+0x18/0x5e
 [<90102df6>] rest_init+0x3a/0x48
 [<9000072c>] start_kernel+0x1f0/0x220
 [<00000000>] __init_begin+0x70000000/0x1c

Kernel panic - not syncing: Fatal exception in interrupt

As you can see, I'm using nfsroot. git-bisect blames this commit:

4ada539ed77c7a2bbcb75cafbbd7bd8d2b9bef7b is first bad commit
commit 4ada539ed77c7a2bbcb75cafbbd7bd8d2b9bef7b
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date:   Thu Jun 14 17:26:17 2007 -0400

    SUNRPC: Make create_client() take a reference to the rpciod workqueue

    Ensures that an rpc_client always has the possibility to send asynchronous
    RPC calls.

    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

:040000 040000 d09b2ebe7a650d9be8a0b0606652f9768779cf18 7ec13589a51d237ecdfd32a46806b43c28a55ed8 M      net

Please let me know if there's anything I can do to help debug this.

Håvard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sunrpc-related Oops in latest git
  2007-07-15 15:05 sunrpc-related Oops in latest git Haavard Skinnemoen
@ 2007-07-16 14:52 ` Trond Myklebust
  2007-07-16 16:05   ` Haavard Skinnemoen
  2007-07-18 18:07   ` Haavard Skinnemoen
  0 siblings, 2 replies; 5+ messages in thread
From: Trond Myklebust @ 2007-07-16 14:52 UTC (permalink / raw)
  To: Haavard Skinnemoen; +Cc: Linux Kernel

On Sun, 2007-07-15 at 17:05 +0200, Haavard Skinnemoen wrote:
> Hi Trond,
> 
> While testing my avr32 updates on the latest git tree, I got this:
> 
> VFS: Mounted root (nfs filesystem).
> Freeing init memory: 56K (90000000 - 9000e000)
> Unable to handle kernel NULL pointer dereference at virtual address 00000000
> ptbr = 90161f44 pgd = 00000000
> Oops: Kernel access of bad area, sig: 11 [#1]
> FRAME_POINTER chip: 0x01f:0x1e82 rev 2
> Modules linked in:
> PC is at queue_work+0x2a/0x34
> LR is at __init_begin+0x70000000/0x1c
> pc : [<900215f2>]    lr : [<00000000>]    Not tainted
> sp : 9014fcf0  r12: 00000000  r11: 90009074
> r10: 00100100  r9 : 90009078  r8 : 90009078
> r7 : 9014fcf0  r6 : 9025652c  r5 : 90009004  r4 : 0000106c
> r3 : 00001064  r2 : 00001064  r1 : 90263000  r0 : 901b1320
> Flags: qvnZc
> Mode bits: hrje....g
> CPU Mode: Interrupt level 0
> Process: swapper [0] (task: 90153afc thread: 9014e000)
> Stack: (0x9014fcf0 to 0x90150000)
> fce0:                                     900f983a 9014fd08 9025652c 90009004
> fd00: 0000106c 00000000 900f98a2 9014fd1c 9000906c 90009004 0000106c 900f6edc
> fd20: 9014fd30 9024c000 90009004 0000106c 900f8d08 9014fd5c 00001064 90009004
> fd40: 0000106c 901b1320 00001064 90263000 901b1320 900cd15a 9014fd8c 900bc7f6
> fd60: 9014fd80 00000000 00000000 0000106c 90263000 0000106c 0abfffaf 901b1320
> fd80: 900e6010 9014fda4 90263000 90263000 0000106c 901b1320 9025d834 0abfffaf
> fda0: 901b1320 900e6406 9014fdf4 90263000 901b1344 0000106c 9016e110 9025d834
> fdc0: 0abfffaf 901b1320 900d0286 0abfffad 00000011 0000106c 10775008 90268540
> fde0: 00001080 00000024 0000106c 0abfffad 0abfffaf 900e65bc 9014fe18 901b1320
> fe00: 00000011 10775008 00000000 9016caa0 00000800 00000500 900cf3f6 9014fe2c
> fe20: 901b1320 00000011 10775008 900cf76e 9014fe50 9000a820 901b1140 10775008
> fe40: 901b1164 9016caa0 00000800 00000500 900c112a 9014fe74 9016ca88 901b1140
> fe60: 10775008 901af800 9016caa0 00000800 00000500 900b1f44 9014feac 901b1140
> fe80: 0000003b 10775008 000004fe 901afb80 0000003b 00000500 901af800 00000040
> fea0: 00000003 900b1dbc 0000003d 900c2808 9014fed4 901af918 901af800 10775008
> fec0: 9016c710 9016c700 fffedde1 007f0000 0000012c 9001ae96 9014fef8 00000000
> fee0: 90168174 10775008 0000000a 90161904 00000000 007f0000 9001aefa 9014ff1c
> ff00: 00810022 00000000 10775008 00000000 90161904 00000000 007f0000 9001b0a0
> ff20: 9014ff30 9016aa0c 00000000 10775008 9000f074 9014ff44 9016aa0c 00000000
> ff40: 10775008 9000e4fe 9014ffb0 90169058 90161930 10775008 9000be70 90161904
> ff60: 00000000 007f0000 00400024 9000e4da 900112ba 90268000 90153978 00000000
> ff80: 90153d74 00000200 9014e000 9014ffb0 90169058 90161930 10775008 9000be70
> ffa0: 90161904 00000000 007f0000 007f0000 90102df6 9014ffc4 90169058 90161930
> ffc0: 10775008 9000072c 9014ffdc 90169058 90161930 10775008 9000be70 00000000
> ffe0: 00000000 107cb030 10770fa0 10775008 901729c8 901729c8 00000000 007f0000
> Call trace:
>  [<900f983a>] __rpc_do_wake_up_task+0x18a/0x1c4
>  [<900f98a2>] rpc_wake_up_task+0x2e/0x40
>  [<900f6edc>] xprt_complete_rqst+0x64/0x74
>  [<900f8d08>] xs_udp_data_ready+0xd0/0xf0
>  [<900bc7f6>] sock_queue_rcv_skb+0xa2/0xd0
>  [<900e6010>] udp_queue_rcv_skb+0x9c/0x114
>  [<900e6406>] __udp4_lib_rcv+0x37e/0x528
>  [<900e65bc>] udp_rcv+0xc/0x14
>  [<900cf3f6>] ip_local_deliver+0x7e/0xcc
>  [<900cf76e>] ip_rcv+0x32a/0x35c
>  [<900c112a>] netif_receive_skb+0x136/0x188
>  [<900b1f44>] macb_poll+0x27c/0x318
>  [<900c2808>] net_rx_action+0x48/0xc4
>  [<9001ae96>] __do_softirq+0x32/0x74
>  [<9001aefa>] do_softirq+0x22/0x3c
>  [<9001b0a0>] irq_exit+0x24/0x30
>  [<9000f074>] do_IRQ+0x3c/0x50
>  [<9000e4fe>] irq_level0+0x18/0x5e
>  [<90102df6>] rest_init+0x3a/0x48
>  [<9000072c>] start_kernel+0x1f0/0x220
>  [<00000000>] __init_begin+0x70000000/0x1c
> 
> Kernel panic - not syncing: Fatal exception in interrupt
> 
> As you can see, I'm using nfsroot. git-bisect blames this commit:
> 
> 4ada539ed77c7a2bbcb75cafbbd7bd8d2b9bef7b is first bad commit
> commit 4ada539ed77c7a2bbcb75cafbbd7bd8d2b9bef7b
> Author: Trond Myklebust <Trond.Myklebust@netapp.com>
> Date:   Thu Jun 14 17:26:17 2007 -0400
> 
>     SUNRPC: Make create_client() take a reference to the rpciod workqueue
> 
>     Ensures that an rpc_client always has the possibility to send asynchronous
>     RPC calls.
> 
>     Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> 
> :040000 040000 d09b2ebe7a650d9be8a0b0606652f9768779cf18 7ec13589a51d237ecdfd32a46806b43c28a55ed8 M      net
> 
> Please let me know if there's anything I can do to help debug this.
> 
> Håvard

So you are saying that if you revert this patch, and only this patch,
then it fixes nfsroot? (sorry, I tend not to trust git-bisect)

Trond

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sunrpc-related Oops in latest git
  2007-07-16 14:52 ` Trond Myklebust
@ 2007-07-16 16:05   ` Haavard Skinnemoen
  2007-07-18 18:07   ` Haavard Skinnemoen
  1 sibling, 0 replies; 5+ messages in thread
From: Haavard Skinnemoen @ 2007-07-16 16:05 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: Linux Kernel

On Mon, 16 Jul 2007 10:52:14 -0400
Trond Myklebust <Trond.Myklebust@netapp.com> wrote:

> So you are saying that if you revert this patch, and only this patch,
> then it fixes nfsroot? (sorry, I tend not to trust git-bisect)

Reverting only that patch gives me the following error:

/home/hskinnemoen/git/linux/net/sunrpc/sched.c: In function ‘rpciod_killall’:
/home/hskinnemoen/git/linux/net/sunrpc/sched.c:974: error: ‘rpc_sched_lock’ undeclared (first use in this function)
/home/hskinnemoen/git/linux/net/sunrpc/sched.c:974: error: (Each undeclared identifier is reported only once
/home/hskinnemoen/git/linux/net/sunrpc/sched.c:974: error: for each function it appears in.)
/home/hskinnemoen/git/linux/net/sunrpc/sched.c:975: error: ‘all_clients’ undeclared (first use in this function)
/home/hskinnemoen/git/linux/net/sunrpc/sched.c:983: error: ‘client_kill_wait’ undeclared (first use in this function)
/home/hskinnemoen/git/linux/net/sunrpc/sched.c: At top level:
/home/hskinnemoen/git/linux/net/sunrpc/sched.c:992: error: expected identifier or ‘(’ before ‘if’

So I tried reverting 188fef11db "SUNRPC: Move rpc_register_client and
friends into net/sunrpc/clnt.c" as well, which resulted in a clean
build, but the same Oops. So I guess you're right that git bisect
didn't work in this case...

Or hang on...it still oopses in queue_work(), but this time it's not
in interrupt context. I've included it below as another data point.

Perhaps the problem isn't as reproducible as I thought, and some of my
good bisection points weren't good after all...

Håvard

IP-Config: Complete:
      device=eth0, addr=10.191.255.173, mask=255.255.254.0, gw=10.191.254.1,
     host=stk1000, domain=, nis-domain=(none),
     bootserver=10.191.255.175, rootserver=10.191.255.175, rootpath=
Looking up port of RPC 100003/2 on 10.191.255.175
Unable to handle kernel NULL pointer dereference at virtual address 00000000
ptbr = 901669d4 pgd = 00000000
Oops: Kernel access of bad area, sig: 11 [#1]
FRAME_POINTER chip: 0x01f:0x1e82 rev 2
Modules linked in:
PC is at queue_work+0x2a/0x34
LR is at __init_begin+0x70000000/0x1c
pc : [<9002159a>]    lr : [<00000000>]    Not tainted
sp : 901a1c9c  r12: 00000000  r11: 901e9640
r10: 901e9640  r9 : 901e9644  r8 : 901e9644
r7 : 901a1c9c  r6 : 901e9400  r5 : 00000000  r4 : 00000000
r3 : 901b45a0  r2 : 901e958c  r1 : 000186a3  r0 : 901a1e24
Flags: qvnZc
Mode bits: hrje....g
CPU Mode: Supervisor
Process: swapper [1] (task: 9019e000 thread: 901a0000)
Stack: (0x901a1c9c to 0x901a2000)
1c80:                                                                900216d8
1ca0: 901a1cb0 901e9400 00000000 00000000 900fa92c 901a1cc4 901e9400 00000000
1cc0: 00000000 900f9eaa 901a1cd8 00000001 901e9400 00000000 900f8c90 901a1cfc
1ce0: 901e9400 901b45a0 00000000 901b45a0 901a1e4c 000186a3 901a1e24 900fc1c4
1d00: 901a1d10 901b4608 00000000 00000000 900fc362 901a1d34 901b45a0 901b45a0
1d20: 00000000 900f9030 901a1e4c 000186a3 901a1e24 900f838c 901a1d50 00000000
1d40: 901b45a0 00000000 00000000 00000000 900f83f4 901a1d74 901eb300 901eb300
1d60: 00000000 901a1e98 00000002 000186a3 901a1e24 901019e8 901a1e5c 901eb300
1d80: 901eb300 00000000 00000000 000186a3 00000002 00000011 00000000 00000000
1da0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
1dc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
1de0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
1e00: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
1e20: 00000000 31302e31 39312e32 35352e31 37350035 00000001 00000001 00000000
1e40: 90158f88 901a1e6c 9000c7f0 90165e40 901a1d88 901a1d98 00000000 90007c24
1e60: 901a1ea8 9000c7f0 00000011 00000000 00000002 000186a3 9000d8b8 00000000
1e80: 000186a3 00000002 0000000a 000000bf 000000ff 000000af 0002006f 0abfffaf
1ea0: 00000000 901a1ebc 90007d58 901a1f60 00000011 00000001 00000000 9000c7ec
1ec0: 900199d8 9000d8b8 00000000 90191100 00000000 9004a68a 9004c5e2 901a1f4c
1ee0: 00000000 fffffffe 00000000 901955d0 9018f000 9000d8b8 00000000 9019507c
1f00: 90191100 93825d88 0000000c 9018f001 00000010 00000000 00000000 9000bd0d
1f20: 00000000 000000ff 00000000 9000d8b8 00000000 9000eb04 901a1f74 9000bd08
1f40: 00000080 00000000 0abffe01 9004c62a 901a1f70 9000bd54 00000000 00000000
1f60: 90000a18 901a1f84 901663c8 00000000 00000000 00000000 900199d8 9000d8b8
1f80: 00000000 90000b32 901a1f98 9000bd54 00000000 00000000 90000512 901a1fdc
1fa0: 901663b8 00000000 00000000 00000000 00000000 00000000 00400000 90010d20
1fc0: 90010d20 901a2000 00000000 00000000 00000000 00000000 00000000 900199d8
1fe0: 00000000 00000000 00000000 00000000 00000000 900199d8 9000037c 00000000
Call trace:
 [<900216d8>] queue_delayed_work+0x10/0x1c
 [<900fa92c>] xs_connect+0x94/0xa8
 [<900f9eaa>] xprt_connect+0xb2/0xc8
 [<900f8c90>] call_connect+0x60/0x74
 [<900fc1c4>] __rpc_execute+0x5c/0x1d4
 [<900fc362>] rpc_execute+0x1a/0x1c
 [<900f838c>] rpc_do_run_task+0x6c/0x80
 [<900f83f4>] rpc_call_sync+0x14/0x28
 [<901019e8>] rpcb_getport_sync+0xc4/0xf4
 [<90007c24>] root_nfs_getport+0x48/0x58
 [<90007d58>] nfs_root_data+0x124/0x240
 [<90000a18>] mount_root+0x10/0xb0
 [<90000b32>] prepare_namespace+0x7a/0xbc
 [<90000512>] kernel_init+0x196/0x1c0
 [<900199d8>] do_exit+0x0/0x534

Kernel panic - not syncing: Attempted to kill init!

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sunrpc-related Oops in latest git
  2007-07-16 14:52 ` Trond Myklebust
  2007-07-16 16:05   ` Haavard Skinnemoen
@ 2007-07-18 18:07   ` Haavard Skinnemoen
  2007-07-18 18:57     ` Trond Myklebust
  1 sibling, 1 reply; 5+ messages in thread
From: Haavard Skinnemoen @ 2007-07-18 18:07 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: Linux Kernel, Michal Piotrowski

On Mon, 16 Jul 2007 10:52:14 -0400
Trond Myklebust <Trond.Myklebust@netapp.com> wrote:

> > Please let me know if there's anything I can do to help debug this.
> > 
> > Håvard  
> 
> So you are saying that if you revert this patch, and only this patch,
> then it fixes nfsroot? (sorry, I tend not to trust git-bisect)

Well, what do you know. My atomics are broken.

The patch below fixes it. I'll include it in my next pull request,
which I'll send in a moment. Sorry to bother you about this.

Håvard

>From 0cb061fcc12ec7811fc7404fda54f9819d6560bd Mon Sep 17 00:00:00 2001
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
Date: Wed, 18 Jul 2007 20:06:04 +0200
Subject: [AVR32] Fix atomic_add_unless() and atomic_sub_unless()

These functions depend on "result" being initalized to 0, but "result"
is not included as an input constraint to the inline assembly block
following its initialization, only as an output constraint. Thus gcc
thinks it doesn't need to initialize it, so result ends up undefined
if the "unless" condition is true.

This fixes an oops in sunrpc where the faulty atomics caused
rpciod_up() to not start the workqueue as it should.

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
---
 include/asm-avr32/atomic.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-avr32/atomic.h b/include/asm-avr32/atomic.h
index b9c2548..7ef3862 100644
--- a/include/asm-avr32/atomic.h
+++ b/include/asm-avr32/atomic.h
@@ -101,7 +101,7 @@ static inline int atomic_sub_unless(atomic_t *v, int a, int u)
 		"	mov	%1, 1\n"
 		"1:"
 		: "=&r"(tmp), "=&r"(result), "=o"(v->counter)
-		: "m"(v->counter), "rKs21"(a), "rKs21"(u)
+		: "m"(v->counter), "rKs21"(a), "rKs21"(u), "1"(result)
 		: "cc", "memory");
 
 	return result;
@@ -137,7 +137,7 @@ static inline int atomic_add_unless(atomic_t *v, int a, int u)
 			"	mov	%1, 1\n"
 			"1:"
 			: "=&r"(tmp), "=&r"(result), "=o"(v->counter)
-			: "m"(v->counter), "r"(a), "ir"(u)
+			: "m"(v->counter), "r"(a), "ir"(u), "1"(result)
 			: "cc", "memory");
 	}
 
-- 
1.5.2.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: sunrpc-related Oops in latest git
  2007-07-18 18:07   ` Haavard Skinnemoen
@ 2007-07-18 18:57     ` Trond Myklebust
  0 siblings, 0 replies; 5+ messages in thread
From: Trond Myklebust @ 2007-07-18 18:57 UTC (permalink / raw)
  To: Haavard Skinnemoen; +Cc: Linux Kernel, Michal Piotrowski

On Wed, 2007-07-18 at 20:07 +0200, Haavard Skinnemoen wrote:
> On Mon, 16 Jul 2007 10:52:14 -0400
> Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> 
> > > Please let me know if there's anything I can do to help debug this.
> > > 
> > > Håvard  
> > 
> > So you are saying that if you revert this patch, and only this patch,
> > then it fixes nfsroot? (sorry, I tend not to trust git-bisect)
> 
> Well, what do you know. My atomics are broken.
> 
> The patch below fixes it. I'll include it in my next pull request,
> which I'll send in a moment. Sorry to bother you about this.
> 
> Håvard

That is good news. Thanks Håvard! :-)

Trond

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-07-18 18:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-15 15:05 sunrpc-related Oops in latest git Haavard Skinnemoen
2007-07-16 14:52 ` Trond Myklebust
2007-07-16 16:05   ` Haavard Skinnemoen
2007-07-18 18:07   ` Haavard Skinnemoen
2007-07-18 18:57     ` Trond Myklebust

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).