* [PATCH 00/59] trivial - Add missing "space" in multiline quoted strings [not found] <ee1678e1bc8b80b7ae420059fffc7241486ea91a.1195454434.git.joe@perches.com> @ 2007-11-20 1:47 ` Joe Perches 2007-11-20 1:47 ` [PATCH 01/59] arch/ia64: Add missing "space" Joe Perches ` (59 subsequent siblings) 60 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:47 UTC (permalink / raw) To: linux-kernel Fix quoted string which do not have a space separating the next word on continuation quoted strings. for example: "a line with a word" "but no space" is equivalent to: "a line with a wordbut no space" which becomes: "a line with a word " "but no space" Signed-off-by: Joe Perches <joe@perches.com> ^ permalink raw reply [flat|nested] 103+ messages in thread
* [PATCH 01/59] arch/ia64: Add missing "space" [not found] <ee1678e1bc8b80b7ae420059fffc7241486ea91a.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 00/59] trivial - Add missing "space" in multiline quoted strings Joe Perches @ 2007-11-20 1:47 ` Joe Perches [not found] ` <23f0badf8dab73294c2aa142fafb9301ca843e88.1195454434.git.joe@perches.com> ` (58 subsequent siblings) 60 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:47 UTC (permalink / raw) To: linux-kernel; +Cc: Jes Sorensen, Tony Luck, linux-altix, linux-ia64 Signed-off-by: Joe Perches <joe@perches.com> --- arch/ia64/kernel/kprobes.c | 10 +++++----- arch/ia64/mm/tlb.c | 2 +- arch/ia64/sn/kernel/io_common.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/ia64/kernel/kprobes.c b/arch/ia64/kernel/kprobes.c index 5fd65d8..90518e4 100644 --- a/arch/ia64/kernel/kprobes.c +++ b/arch/ia64/kernel/kprobes.c @@ -182,8 +182,8 @@ static int __kprobes unsupported_inst(uint template, uint slot, qp = kprobe_inst & 0x3f; if (is_cmp_ctype_unc_inst(template, slot, major_opcode, kprobe_inst)) { if (slot == 1 && qp) { - printk(KERN_WARNING "Kprobes on cmp unc" - "instruction on slot 1 at <0x%lx>" + printk(KERN_WARNING "Kprobes on cmp unc " + "instruction on slot 1 at <0x%lx> " "is not supported\n", addr); return -EINVAL; @@ -221,8 +221,8 @@ static int __kprobes unsupported_inst(uint template, uint slot, * bit 12 to be equal to 1 */ if (slot == 1 && qp) { - printk(KERN_WARNING "Kprobes on test bit" - "instruction on slot at <0x%lx>" + printk(KERN_WARNING "Kprobes on test bit " + "instruction on slot at <0x%lx> " "is not supported\n", addr); return -EINVAL; } @@ -242,7 +242,7 @@ static int __kprobes unsupported_inst(uint template, uint slot, */ int x6=(kprobe_inst >> 27) & 0x3F; if ((x6 == 0x10) || (x6 == 0x11)) { - printk(KERN_WARNING "Kprobes on" + printk(KERN_WARNING "Kprobes on " "Indirect Predict is not supported\n"); return -EINVAL; } diff --git a/arch/ia64/mm/tlb.c b/arch/ia64/mm/tlb.c index 1682fc6..cef1647 100644 --- a/arch/ia64/mm/tlb.c +++ b/arch/ia64/mm/tlb.c @@ -180,7 +180,7 @@ ia64_tlb_init (void) long status; if ((status = ia64_pal_vm_page_size(&tr_pgbits, &purge.mask)) != 0) { - printk(KERN_ERR "PAL_VM_PAGE_SIZE failed with status=%ld;" + printk(KERN_ERR "PAL_VM_PAGE_SIZE failed with status=%ld; " "defaulting to architected purge page-sizes.\n", status); purge.mask = 0x115557000UL; } diff --git a/arch/ia64/sn/kernel/io_common.c b/arch/ia64/sn/kernel/io_common.c index 4594770..710bf51 100644 --- a/arch/ia64/sn/kernel/io_common.c +++ b/arch/ia64/sn/kernel/io_common.c @@ -347,7 +347,7 @@ sn_common_bus_fixup(struct pci_bus *bus, if (controller->node >= num_online_nodes()) { struct pcibus_bussoft *b = SN_PCIBUS_BUSSOFT(bus); - printk(KERN_WARNING "Device ASIC=%u XID=%u PBUSNUM=%u" + printk(KERN_WARNING "Device ASIC=%u XID=%u PBUSNUM=%u " "L_IO=%lx L_MEM=%lx BASE=%lx\n", b->bs_asic_type, b->bs_xid, b->bs_persist_busnum, b->bs_legacy_io, b->bs_legacy_mem, b->bs_base); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <23f0badf8dab73294c2aa142fafb9301ca843e88.1195454434.git.joe@perches.com>]
* [PATCH 02/59] arch/mips: Add missing "space" [not found] ` <23f0badf8dab73294c2aa142fafb9301ca843e88.1195454434.git.joe@perches.com> @ 2007-11-20 1:47 ` Joe Perches 2007-11-21 22:34 ` Ralf Baechle 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:47 UTC (permalink / raw) To: linux-kernel; +Cc: Ralf Baechle, linux-mips Signed-off-by: Joe Perches <joe@perches.com> --- arch/mips/kernel/vpe.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c index 38bd33f..c06eb81 100644 --- a/arch/mips/kernel/vpe.c +++ b/arch/mips/kernel/vpe.c @@ -470,7 +470,7 @@ static int apply_r_mips_lo16(struct module *me, uint32_t *location, */ if (v != l->value) { printk(KERN_DEBUG "VPE loader: " - "apply_r_mips_lo16/hi16: " + "apply_r_mips_lo16/hi16: \t" "inconsistent value information\n"); return -ENOEXEC; } @@ -629,7 +629,7 @@ static void simplify_symbols(Elf_Shdr * sechdrs, break; case SHN_MIPS_SCOMMON: - printk(KERN_DEBUG "simplify_symbols: ignoring SHN_MIPS_SCOMMON" + printk(KERN_DEBUG "simplify_symbols: ignoring SHN_MIPS_SCOMMON " "symbol <%s> st_shndx %d\n", strtab + sym[i].st_name, sym[i].st_shndx); // .sbss section -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 02/59] arch/mips: Add missing "space" [not found] ` <23f0badf8dab73294c2aa142fafb9301ca843e88.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 02/59] arch/mips: " Joe Perches @ 2007-11-21 22:34 ` Ralf Baechle 1 sibling, 0 replies; 103+ messages in thread From: Ralf Baechle @ 2007-11-21 22:34 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, linux-mips On Mon, Nov 19, 2007 at 05:47:54PM -0800, Joe Perches wrote: Queued for 2.6.25. Thanks, Ralf ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <0c0c76b8a44447bbeb8b0b502f5b4f2750bd8cc6.1195454434.git.joe@perches.com>]
* [PATCH 03/59] arch/powerpc: Add missing "space" [not found] ` <0c0c76b8a44447bbeb8b0b502f5b4f2750bd8cc6.1195454434.git.joe@perches.com> @ 2007-11-20 1:47 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:47 UTC (permalink / raw) To: linux-kernel; +Cc: Anton Blanchard, Paul Mackerras, anton, linuxppc-dev, paulus Signed-off-by: Joe Perches <joe@perches.com> --- arch/powerpc/kernel/isa-bridge.c | 4 ++-- arch/powerpc/mm/fault.c | 2 +- arch/powerpc/platforms/8xx/m8xx_setup.c | 2 +- arch/powerpc/platforms/celleb/io-workarounds.c | 2 +- arch/powerpc/platforms/celleb/scc_epci.c | 2 +- arch/powerpc/sysdev/fsl_pci.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kernel/isa-bridge.c b/arch/powerpc/kernel/isa-bridge.c index f0f49d1..965bfcc 100644 --- a/arch/powerpc/kernel/isa-bridge.c +++ b/arch/powerpc/kernel/isa-bridge.c @@ -108,7 +108,7 @@ static void __devinit pci_process_ISA_OF_ranges(struct device_node *isa_node, if (size > 0x10000) size = 0x10000; - printk(KERN_ERR "no ISA IO ranges or unexpected isa range," + printk(KERN_ERR "no ISA IO ranges or unexpected isa range, " "mapping 64k\n"); __ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE, @@ -116,7 +116,7 @@ static void __devinit pci_process_ISA_OF_ranges(struct device_node *isa_node, return; inval_range: - printk(KERN_ERR "no ISA IO ranges or unexpected isa range," + printk(KERN_ERR "no ISA IO ranges or unexpected isa range, " "mapping 64k\n"); __ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE, 0x10000, _PAGE_NO_CACHE|_PAGE_GUARDED); diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c index 8135da0..10dda22 100644 --- a/arch/powerpc/mm/fault.c +++ b/arch/powerpc/mm/fault.c @@ -189,7 +189,7 @@ int __kprobes do_page_fault(struct pt_regs *regs, unsigned long address, return SIGSEGV; /* in_atomic() in user mode is really bad, as is current->mm == NULL. */ - printk(KERN_EMERG "Page fault in user mode with" + printk(KERN_EMERG "Page fault in user mode with " "in_atomic() = %d mm = %p\n", in_atomic(), mm); printk(KERN_EMERG "NIP = %lx MSR = %lx\n", regs->nip, regs->msr); diff --git a/arch/powerpc/platforms/8xx/m8xx_setup.c b/arch/powerpc/platforms/8xx/m8xx_setup.c index d35eda8..ba645c2 100644 --- a/arch/powerpc/platforms/8xx/m8xx_setup.c +++ b/arch/powerpc/platforms/8xx/m8xx_setup.c @@ -120,7 +120,7 @@ void __init mpc8xx_calibrate_decr(void) ppc_tb_freq /= 16; ppc_proc_freq = 50000000; if (!get_freq("clock-frequency", &ppc_proc_freq)) - printk(KERN_ERR "WARNING: Estimating processor frequency" + printk(KERN_ERR "WARNING: Estimating processor frequency " "(not found)\n"); printk("Decrementer Frequency = 0x%lx\n", ppc_tb_freq); diff --git a/arch/powerpc/platforms/celleb/io-workarounds.c b/arch/powerpc/platforms/celleb/io-workarounds.c index 2b91214..32b9cec 100644 --- a/arch/powerpc/platforms/celleb/io-workarounds.c +++ b/arch/powerpc/platforms/celleb/io-workarounds.c @@ -256,7 +256,7 @@ int __init celleb_pci_workaround_init(void) celleb_dummy_page_va = kmalloc(PAGE_SIZE, GFP_KERNEL); if (!celleb_dummy_page_va) { - printk(KERN_ERR "Celleb: dummy read disabled." + printk(KERN_ERR "Celleb: dummy read disabled. " "Alloc celleb_dummy_page_va failed\n"); return 1; } diff --git a/arch/powerpc/platforms/celleb/scc_epci.c b/arch/powerpc/platforms/celleb/scc_epci.c index 9d07642..a3c7cfb 100644 --- a/arch/powerpc/platforms/celleb/scc_epci.c +++ b/arch/powerpc/platforms/celleb/scc_epci.c @@ -95,7 +95,7 @@ void __init epci_workaround_init(struct pci_controller *hose) private->dummy_page_da = dma_map_single(hose->parent, celleb_dummy_page_va, PAGE_SIZE, DMA_FROM_DEVICE); if (private->dummy_page_da == DMA_ERROR_CODE) { - printk(KERN_ERR "EPCI: dummy read disabled." + printk(KERN_ERR "EPCI: dummy read disabled. " "Map dummy page failed.\n"); return; } diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 33df4c3..87e58e0 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c @@ -222,7 +222,7 @@ int __init fsl_add_bridge(struct device_node *dev, int is_primary) hose->indirect_type |= PPC_INDIRECT_TYPE_NO_PCIE_LINK; } - printk(KERN_INFO "Found FSL PCI host bridge at 0x%016llx." + printk(KERN_INFO "Found FSL PCI host bridge at 0x%016llx. " "Firmware bus number: %d->%d\n", (unsigned long long)rsrc.start, hose->first_busno, hose->last_busno); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <351afce2b8242a88389176a36d5bf75935385fdd.1195454434.git.joe@perches.com>]
* [PATCH 04/59] arch/ppc: Add missing "space" [not found] ` <351afce2b8242a88389176a36d5bf75935385fdd.1195454434.git.joe@perches.com> @ 2007-11-20 1:47 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:47 UTC (permalink / raw) To: linux-kernel; +Cc: Paul Mackerras, linuxppc-dev Signed-off-by: Joe Perches <joe@perches.com> --- arch/ppc/platforms/ev64260.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ppc/platforms/ev64260.c b/arch/ppc/platforms/ev64260.c index 976270d..c1f77e1 100644 --- a/arch/ppc/platforms/ev64260.c +++ b/arch/ppc/platforms/ev64260.c @@ -336,7 +336,7 @@ ev64260_early_serial_map(void) #endif if (early_serial_setup(&port) != 0) - printk(KERN_WARNING "Early serial init of port 0" + printk(KERN_WARNING "Early serial init of port 0 " "failed\n"); first_time = 0; @@ -388,7 +388,7 @@ ev64260_setup_arch(void) ev64260_early_serial_map(); #endif - printk(KERN_INFO "%s %s port (C) 2001 MontaVista Software, Inc." + printk(KERN_INFO "%s %s port (C) 2001 MontaVista Software, Inc. " "(source@mvista.com)\n", BOARD_VENDOR, BOARD_MACHINE); if (ppc_md.progress) -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <ebeb1446c117c71636bb6f2308645a85f81edac5.1195454434.git.joe@perches.com>]
* [PATCH 05/59] arch/s390: Add missing "space" [not found] ` <ebeb1446c117c71636bb6f2308645a85f81edac5.1195454434.git.joe@perches.com> @ 2007-11-20 1:47 ` Joe Perches 2007-11-20 8:27 ` Heiko Carstens 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:47 UTC (permalink / raw) To: linux-kernel; +Cc: Heiko Carstens, Martin Schwidefsky, linux-s390, linux390 Signed-off-by: Joe Perches <joe@perches.com> --- arch/s390/crypto/aes_s390.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/s390/crypto/aes_s390.c b/arch/s390/crypto/aes_s390.c index 5126696..e2f6216 100644 --- a/arch/s390/crypto/aes_s390.c +++ b/arch/s390/crypto/aes_s390.c @@ -341,7 +341,7 @@ static int __init aes_init(void) ecb_aes_alg.cra_u.blkcipher.max_keysize = AES_MIN_KEY_SIZE; cbc_aes_alg.cra_u.blkcipher.max_keysize = AES_MIN_KEY_SIZE; printk(KERN_INFO - "aes_s390: hardware acceleration only available for" + "aes_s390: hardware acceleration only available for " "128 bit keys\n"); } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 05/59] arch/s390: Add missing "space" [not found] ` <ebeb1446c117c71636bb6f2308645a85f81edac5.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 05/59] arch/s390: " Joe Perches @ 2007-11-20 8:27 ` Heiko Carstens 1 sibling, 0 replies; 103+ messages in thread From: Heiko Carstens @ 2007-11-20 8:27 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Martin Schwidefsky, linux-s390, linux390 On Mon, Nov 19, 2007 at 05:47:57PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > arch/s390/crypto/aes_s390.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/s390/crypto/aes_s390.c b/arch/s390/crypto/aes_s390.c > index 5126696..e2f6216 100644 > --- a/arch/s390/crypto/aes_s390.c > +++ b/arch/s390/crypto/aes_s390.c > @@ -341,7 +341,7 @@ static int __init aes_init(void) > ecb_aes_alg.cra_u.blkcipher.max_keysize = AES_MIN_KEY_SIZE; > cbc_aes_alg.cra_u.blkcipher.max_keysize = AES_MIN_KEY_SIZE; > printk(KERN_INFO > - "aes_s390: hardware acceleration only available for" > + "aes_s390: hardware acceleration only available for " > "128 bit keys\n"); Applied. Thanks! ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <afdfa525934b9dada1a5b7b459486d923dc0e780.1195454434.git.joe@perches.com>]
* [PATCH 06/59] arch/sparc: Add missing "space" [not found] ` <afdfa525934b9dada1a5b7b459486d923dc0e780.1195454434.git.joe@perches.com> @ 2007-11-20 1:47 ` Joe Perches 2007-11-20 7:45 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:47 UTC (permalink / raw) To: linux-kernel; +Cc: William L. Irwin, sparclinux Signed-off-by: Joe Perches <joe@perches.com> --- arch/sparc/kernel/pcic.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/sparc/kernel/pcic.c b/arch/sparc/kernel/pcic.c index f2d432e..396718b 100644 --- a/arch/sparc/kernel/pcic.c +++ b/arch/sparc/kernel/pcic.c @@ -329,7 +329,7 @@ int __init pcic_probe(void) pcic->pcic_res_cfg_addr.name = "pcic_cfg_addr"; if ((pcic->pcic_config_space_addr = ioremap(regs[2].phys_addr, regs[2].reg_size * 2)) == 0) { - prom_printf("PCIC: Error, cannot map" + prom_printf("PCIC: Error, cannot map " "PCI Configuration Space Address.\n"); prom_halt(); } @@ -341,7 +341,7 @@ int __init pcic_probe(void) pcic->pcic_res_cfg_data.name = "pcic_cfg_data"; if ((pcic->pcic_config_space_data = ioremap(regs[3].phys_addr, regs[3].reg_size * 2)) == 0) { - prom_printf("PCIC: Error, cannot map" + prom_printf("PCIC: Error, cannot map " "PCI Configuration Space Data.\n"); prom_halt(); } @@ -518,8 +518,8 @@ static void pcic_map_pci_device(struct linux_pcic *pcic, * board in a PCI slot. We must remap it * under 64K but it is not done yet. XXX */ - printk("PCIC: Skipping I/O space at 0x%lx," - "this will Oops if a driver attaches;" + printk("PCIC: Skipping I/O space at 0x%lx, " + "this will Oops if a driver attaches " "device '%s' at %02x:%02x)\n", address, namebuf, dev->bus->number, dev->devfn); } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 06/59] arch/sparc: Add missing "space" 2007-11-20 1:47 ` [PATCH 06/59] arch/sparc: " Joe Perches @ 2007-11-20 7:45 ` David Miller 2007-11-20 7:48 ` Joe Perches 0 siblings, 1 reply; 103+ messages in thread From: David Miller @ 2007-11-20 7:45 UTC (permalink / raw) To: joe; +Cc: linux-kernel, wli, sparclinux From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:47:58 -0800 > Signed-off-by: Joe Perches <joe@perches.com> Please check your patches, for trailing white "space". Adds trailing whitespace. diff:10: prom_printf("PCIC: Error, cannot map " Adds trailing whitespace. diff:19: prom_printf("PCIC: Error, cannot map " warning: 2 lines add whitespace errors. I've fixed it up this time. ^ permalink raw reply [flat|nested] 103+ messages in thread
* Re: [PATCH 06/59] arch/sparc: Add missing "space" 2007-11-20 7:45 ` David Miller @ 2007-11-20 7:48 ` Joe Perches 2007-11-20 8:05 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 7:48 UTC (permalink / raw) To: David Miller; +Cc: linux-kernel, wli, sparclinux On Mon, 2007-11-19 at 23:45 -0800, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Mon, 19 Nov 2007 17:47:58 -0800 > > Signed-off-by: Joe Perches <joe@perches.com> > Please check your patches, for trailing white "space". > Adds trailing whitespace. > diff:10: prom_printf("PCIC: Error, cannot map " > Adds trailing whitespace. > diff:19: prom_printf("PCIC: Error, cannot map " > warning: 2 lines add whitespace errors. > I've fixed it up this time. It doesn't add whitespace, but it does keep the trailing whitespace that's already there. cheers, Joe ^ permalink raw reply [flat|nested] 103+ messages in thread
* Re: [PATCH 06/59] arch/sparc: Add missing "space" 2007-11-20 7:48 ` Joe Perches @ 2007-11-20 8:05 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 8:05 UTC (permalink / raw) To: joe; +Cc: linux-kernel, wli, sparclinux From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 23:48:36 -0800 > On Mon, 2007-11-19 at 23:45 -0800, David Miller wrote: > > From: Joe Perches <joe@perches.com> > > Date: Mon, 19 Nov 2007 17:47:58 -0800 > > > Signed-off-by: Joe Perches <joe@perches.com> > > Please check your patches, for trailing white "space". > > Adds trailing whitespace. > > diff:10: prom_printf("PCIC: Error, cannot map " > > Adds trailing whitespace. > > diff:19: prom_printf("PCIC: Error, cannot map " > > warning: 2 lines add whitespace errors. > > I've fixed it up this time. > > It doesn't add whitespace, but it does keep the trailing > whitespace that's already there. I know that, you should still do sanity checks and fix these kinds of things up because they trigger errors in my patch applying scripts and that of many other developers. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <2cb1c8daa0f34a5506b88cf5b350660896c8a45b.1195454434.git.joe@perches.com>]
* [PATCH 07/59] arch/sparc64: Add missing "space" [not found] ` <2cb1c8daa0f34a5506b88cf5b350660896c8a45b.1195454434.git.joe@perches.com> @ 2007-11-20 1:47 ` Joe Perches 2007-11-20 7:43 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:47 UTC (permalink / raw) To: linux-kernel; +Cc: David S. Miller, sparclinux Signed-off-by: Joe Perches <joe@perches.com> --- arch/sparc64/kernel/smp.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sparc64/kernel/smp.c b/arch/sparc64/kernel/smp.c index 7cd8d94..894b506 100644 --- a/arch/sparc64/kernel/smp.c +++ b/arch/sparc64/kernel/smp.c @@ -236,8 +236,9 @@ void smp_synchronize_tick_client(void) t[i].rt, t[i].master, t[i].diff, t[i].lat); #endif - printk(KERN_INFO "CPU %d: synchronized TICK with master CPU (last diff %ld cycles," - "maxerr %lu cycles)\n", smp_processor_id(), delta, rt); + printk(KERN_INFO "CPU %d: synchronized TICK with master CPU " + "(last diff %ld cycles, maxerr %lu cycles)\n", + smp_processor_id(), delta, rt); } static void smp_start_sync_tick_client(int cpu); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 07/59] arch/sparc64: Add missing "space" 2007-11-20 1:47 ` [PATCH 07/59] arch/sparc64: " Joe Perches @ 2007-11-20 7:43 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 7:43 UTC (permalink / raw) To: joe; +Cc: linux-kernel, sparclinux From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:47:59 -0800 > > Signed-off-by: Joe Perches <joe@perches.com> Applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <c2f1bd6f19828452d5916728ebaa8d5f1bd0b152.1195454434.git.joe@perches.com>]
* [PATCH 09/59] arch/x86: Add missing "space" [not found] ` <c2f1bd6f19828452d5916728ebaa8d5f1bd0b152.1195454434.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 2:05 ` Dave Jones 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Cc: Dave Jones, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, cpufreq, linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- arch/x86/kernel/cpu/cpufreq/powernow-k7.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k7.c b/arch/x86/kernel/cpu/cpufreq/powernow-k7.c index b5a9863..b73dce0 100644 --- a/arch/x86/kernel/cpu/cpufreq/powernow-k7.c +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k7.c @@ -460,7 +460,7 @@ static int powernow_decode_bios (int maxfid, int startvid) latency = psb->settlingtime; if (latency < 100) { - printk (KERN_INFO PFX "BIOS set settling time to %d microseconds." + printk (KERN_INFO PFX "BIOS set settling time to %d microseconds. " "Should be at least 100. Correcting.\n", latency); latency = 100; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 09/59] arch/x86: Add missing "space" [not found] ` <c2f1bd6f19828452d5916728ebaa8d5f1bd0b152.1195454434.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 09/59] arch/x86: " Joe Perches @ 2007-11-20 2:05 ` Dave Jones 1 sibling, 0 replies; 103+ messages in thread From: Dave Jones @ 2007-11-20 2:05 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Dave Jones, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, cpufreq On Mon, Nov 19, 2007 at 05:48:01PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > arch/x86/kernel/cpu/cpufreq/powernow-k7.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks Joe, applied. Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <07a846daef42aa7262f9e08a8be5c3ed8684ed77.1195454434.git.joe@perches.com>]
* [PATCH 10/59] drivers/acpi: Add missing "space" [not found] ` <07a846daef42aa7262f9e08a8be5c3ed8684ed77.1195454434.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 2:53 ` Len Brown 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Alexey Starikovskiy, Len Brown, lenb, linux-acpi Signed-off-by: Joe Perches <joe@perches.com> --- drivers/acpi/ec.c | 4 ++-- drivers/acpi/processor_core.c | 2 +- drivers/acpi/tables/tbutils.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 06b78e5..cb09e5e 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -175,12 +175,12 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll) if (acpi_ec_check_status(ec, event)) { if (event == ACPI_EC_EVENT_OBF_1) { /* miss OBF = 1 GPE, don't expect it anymore */ - printk(KERN_INFO PREFIX "missing OBF_1 confirmation," + printk(KERN_INFO PREFIX "missing OBF_1 confirmation, " "switching to degraded mode.\n"); set_bit(EC_FLAGS_ONLY_IBF_GPE, &ec->flags); } else { /* missing GPEs, switch back to poll mode */ - printk(KERN_INFO PREFIX "missing IBF_1 confirmations," + printk(KERN_INFO PREFIX "missing IBF_1 confirmations, " "switch off interrupt mode.\n"); clear_bit(EC_FLAGS_GPE_MODE, &ec->flags); } diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c index 235a51e..44156e7 100644 --- a/drivers/acpi/processor_core.c +++ b/drivers/acpi/processor_core.c @@ -647,7 +647,7 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device) */ if (processor_device_array[pr->id] != NULL && processor_device_array[pr->id] != device) { - printk(KERN_WARNING "BIOS reported wrong ACPI id" + printk(KERN_WARNING "BIOS reported wrong ACPI id " "for the processor\n"); return -ENODEV; } diff --git a/drivers/acpi/tables/tbutils.c b/drivers/acpi/tables/tbutils.c index 5f1d85f..010f196 100644 --- a/drivers/acpi/tables/tbutils.c +++ b/drivers/acpi/tables/tbutils.c @@ -449,7 +449,7 @@ acpi_tb_parse_root_table(acpi_physical_address rsdp_address, u8 flags) /* XSDT has NULL entry, RSDT is used */ address = rsdt_address; table_entry_size = sizeof(u32); - ACPI_WARNING((AE_INFO, "BIOS XSDT has NULL entry," + ACPI_WARNING((AE_INFO, "BIOS XSDT has NULL entry, " "using RSDT")); } } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 10/59] drivers/acpi: Add missing "space" 2007-11-20 1:48 ` [PATCH 10/59] drivers/acpi: " Joe Perches @ 2007-11-20 2:53 ` Len Brown 0 siblings, 0 replies; 103+ messages in thread From: Len Brown @ 2007-11-20 2:53 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Alexey Starikovskiy, linux-acpi applied. thanks, -len On Monday 19 November 2007 20:48, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/acpi/ec.c | 4 ++-- > drivers/acpi/processor_core.c | 2 +- > drivers/acpi/tables/tbutils.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index 06b78e5..cb09e5e 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -175,12 +175,12 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll) > if (acpi_ec_check_status(ec, event)) { > if (event == ACPI_EC_EVENT_OBF_1) { > /* miss OBF = 1 GPE, don't expect it anymore */ > - printk(KERN_INFO PREFIX "missing OBF_1 confirmation," > + printk(KERN_INFO PREFIX "missing OBF_1 confirmation, " > "switching to degraded mode.\n"); > set_bit(EC_FLAGS_ONLY_IBF_GPE, &ec->flags); > } else { > /* missing GPEs, switch back to poll mode */ > - printk(KERN_INFO PREFIX "missing IBF_1 confirmations," > + printk(KERN_INFO PREFIX "missing IBF_1 confirmations, " > "switch off interrupt mode.\n"); > clear_bit(EC_FLAGS_GPE_MODE, &ec->flags); > } > diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c > index 235a51e..44156e7 100644 > --- a/drivers/acpi/processor_core.c > +++ b/drivers/acpi/processor_core.c > @@ -647,7 +647,7 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device) > */ > if (processor_device_array[pr->id] != NULL && > processor_device_array[pr->id] != device) { > - printk(KERN_WARNING "BIOS reported wrong ACPI id" > + printk(KERN_WARNING "BIOS reported wrong ACPI id " > "for the processor\n"); > return -ENODEV; > } > diff --git a/drivers/acpi/tables/tbutils.c b/drivers/acpi/tables/tbutils.c > index 5f1d85f..010f196 100644 > --- a/drivers/acpi/tables/tbutils.c > +++ b/drivers/acpi/tables/tbutils.c > @@ -449,7 +449,7 @@ acpi_tb_parse_root_table(acpi_physical_address rsdp_address, u8 flags) > /* XSDT has NULL entry, RSDT is used */ > address = rsdt_address; > table_entry_size = sizeof(u32); > - ACPI_WARNING((AE_INFO, "BIOS XSDT has NULL entry," > + ACPI_WARNING((AE_INFO, "BIOS XSDT has NULL entry, " > "using RSDT")); > } > } ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <06ac5c8ff3114d38896fe59a453dd1b77b11cdec.1195454434.git.joe@perches.com>]
* [PATCH 11/59] drivers/block: Add missing "space" [not found] ` <06ac5c8ff3114d38896fe59a453dd1b77b11cdec.1195454434.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- drivers/block/DAC960.c | 2 +- drivers/block/cpqarray.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index 9030c37..72c5e96 100644 --- a/drivers/block/DAC960.c +++ b/drivers/block/DAC960.c @@ -2999,7 +2999,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device, } if (!DAC960_V1_EnableMemoryMailboxInterface(Controller)) { - DAC960_Error("Unable to allocate DMA mapped memory" + DAC960_Error("Unable to allocate DMA mapped memory " "for Controller at\n", Controller); goto Failure; } diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c index c8132d9..a8acd10 100644 --- a/drivers/block/cpqarray.c +++ b/drivers/block/cpqarray.c @@ -367,7 +367,7 @@ static void __devexit cpqarray_remove_one_pci (struct pci_dev *pdev) tmp_ptr = pci_get_drvdata(pdev); i = tmp_ptr->ctlr; if (hba[i] == NULL) { - printk(KERN_ERR "cpqarray: controller %d appears to have" + printk(KERN_ERR "cpqarray: controller %d appears to have " "already been removed \n", i); return; } @@ -382,7 +382,7 @@ static void __devexit cpqarray_remove_one_pci (struct pci_dev *pdev) static void __devexit cpqarray_remove_one_eisa (int i) { if (hba[i] == NULL) { - printk(KERN_ERR "cpqarray: controller %d appears to have" + printk(KERN_ERR "cpqarray: controller %d appears to have " "already been removed \n", i); return; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <51d5cae73b21c33174340db0e389ac810bba63fa.1195454434.git.joe@perches.com>]
* [PATCH 12/59] drivers/cdrom: Add missing "space" [not found] ` <51d5cae73b21c33174340db0e389ac810bba63fa.1195454434.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- drivers/cdrom/viocd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/cdrom/viocd.c b/drivers/cdrom/viocd.c index d8bb44b..1ca73d1 100644 --- a/drivers/cdrom/viocd.c +++ b/drivers/cdrom/viocd.c @@ -129,7 +129,7 @@ static int proc_viocd_show(struct seq_file *m, void *v) int i; for (i = 0; i < viocd_numdev; i++) { - seq_printf(m, "viocd device %d is iSeries resource %10.10s" + seq_printf(m, "viocd device %d is iSeries resource %10.10s " "type %4.4s, model %3.3s\n", i, viocd_diskinfo[i].rsrcname, viocd_diskinfo[i].type, -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <552e08f56ca307c471834197a8e880045b4f024e.1195454434.git.joe@perches.com>]
* [PATCH 13/59] drivers/char: Add missing "space" [not found] ` <552e08f56ca307c471834197a8e880045b4f024e.1195454434.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Corey Minyard, David Airlie, openipmi-developer Signed-off-by: Joe Perches <joe@perches.com> --- drivers/char/agp/generic.c | 4 ++-- drivers/char/agp/intel-agp.c | 2 +- drivers/char/ipmi/ipmi_watchdog.c | 2 +- drivers/char/snsc.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c index 64b2f6d..9d73933 100644 --- a/drivers/char/agp/generic.c +++ b/drivers/char/agp/generic.c @@ -485,12 +485,12 @@ static void agp_v2_parse_one(u32 *requested_mode, u32 *bridge_agpstat, u32 *vga_ switch (*bridge_agpstat & 7) { case 4: *bridge_agpstat |= (AGPSTAT2_2X | AGPSTAT2_1X); - printk(KERN_INFO PFX "BIOS bug. AGP bridge claims to only support x4 rate" + printk(KERN_INFO PFX "BIOS bug. AGP bridge claims to only support x4 rate. " "Fixing up support for x2 & x1\n"); break; case 2: *bridge_agpstat |= AGPSTAT2_1X; - printk(KERN_INFO PFX "BIOS bug. AGP bridge claims to only support x2 rate" + printk(KERN_INFO PFX "BIOS bug. AGP bridge claims to only support x2 rate. " "Fixing up support for x1\n"); break; default: diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index d879619..fb621cc 100644 --- a/drivers/char/agp/intel-agp.c +++ b/drivers/char/agp/intel-agp.c @@ -1922,7 +1922,7 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev, if (intel_agp_chipsets[i].name == NULL) { if (cap_ptr) - printk(KERN_WARNING PFX "Unsupported Intel chipset" + printk(KERN_WARNING PFX "Unsupported Intel chipset " "(device id: %04x)\n", pdev->device); agp_put_bridge(bridge); return -ENODEV; diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c index e686fc9..ee62617 100644 --- a/drivers/char/ipmi/ipmi_watchdog.c +++ b/drivers/char/ipmi/ipmi_watchdog.c @@ -293,7 +293,7 @@ MODULE_PARM_DESC(preop, "Pretimeout driver operation. One of: " "preop_none, preop_panic, preop_give_data."); module_param(start_now, int, 0444); -MODULE_PARM_DESC(start_now, "Set to 1 to start the watchdog as" +MODULE_PARM_DESC(start_now, "Set to 1 to start the watchdog as " "soon as the driver is loaded."); module_param(nowayout, int, 0644); diff --git a/drivers/char/snsc.c b/drivers/char/snsc.c index b9c1dba..a9681d0 100644 --- a/drivers/char/snsc.c +++ b/drivers/char/snsc.c @@ -402,7 +402,7 @@ scdrv_init(void) scd = kzalloc(sizeof (struct sysctl_data_s), GFP_KERNEL); if (!scd) { - printk("%s: failed to allocate device info" + printk("%s: failed to allocate device info " "for %s/%s\n", __FUNCTION__, SYSCTL_BASENAME, devname); continue; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <f6014cdba9a3d017d1dcd0623a5da61777c919bb.1195454435.git.joe@perches.com>]
* [PATCH 14/59] drivers/cpufreq: Add missing "space" [not found] ` <f6014cdba9a3d017d1dcd0623a5da61777c919bb.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 2:06 ` Dave Jones 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Dave Jones, cpufreq Signed-off-by: Joe Perches <joe@perches.com> --- drivers/cpufreq/cpufreq.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 5e626b1..5d5f52f 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -287,7 +287,7 @@ static void adjust_jiffies(unsigned long val, struct cpufreq_freqs *ci) if (!l_p_j_ref_freq) { l_p_j_ref = loops_per_jiffy; l_p_j_ref_freq = ci->old; - dprintk("saving %lu as reference value for loops_per_jiffy;" + dprintk("saving %lu as reference value for loops_per_jiffy; " "freq is %u kHz\n", l_p_j_ref, l_p_j_ref_freq); } if ((val == CPUFREQ_PRECHANGE && ci->old < ci->new) || @@ -295,7 +295,7 @@ static void adjust_jiffies(unsigned long val, struct cpufreq_freqs *ci) (val == CPUFREQ_RESUMECHANGE || val == CPUFREQ_SUSPENDCHANGE)) { loops_per_jiffy = cpufreq_scale(l_p_j_ref, l_p_j_ref_freq, ci->new); - dprintk("scaling loops_per_jiffy to %lu" + dprintk("scaling loops_per_jiffy to %lu " "for frequency %u kHz\n", loops_per_jiffy, ci->new); } } @@ -1311,7 +1311,7 @@ static int cpufreq_resume(struct sys_device * sysdev) struct cpufreq_freqs freqs; if (!(cpufreq_driver->flags & CPUFREQ_PM_NO_WARN)) - dprintk("Warning: CPU frequency" + dprintk("Warning: CPU frequency " "is %u, cpufreq assumed %u kHz.\n", cur_freq, cpu_policy->cur); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 14/59] drivers/cpufreq: Add missing "space" [not found] ` <f6014cdba9a3d017d1dcd0623a5da61777c919bb.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 14/59] drivers/cpufreq: " Joe Perches @ 2007-11-20 2:06 ` Dave Jones 1 sibling, 0 replies; 103+ messages in thread From: Dave Jones @ 2007-11-20 2:06 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Dave Jones, cpufreq On Mon, Nov 19, 2007 at 05:48:06PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/cpufreq/cpufreq.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Also applied, thanks. Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <239a2d17c4e7f18b0aa0f34e1856f4d72a38e0d8.1195454435.git.joe@perches.com>]
* [PATCH 16/59] drivers/i2c: Add missing "space" [not found] ` <239a2d17c4e7f18b0aa0f34e1856f4d72a38e0d8.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 19:51 ` Jean Delvare 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Jean Delvare, i2c Signed-off-by: Joe Perches <joe@perches.com> --- drivers/i2c/busses/i2c-davinci.c | 4 ++-- drivers/i2c/busses/i2c-omap.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index bd7aaff..6767988 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -404,7 +404,7 @@ static irqreturn_t i2c_davinci_isr(int this_irq, void *dev_id) DAVINCI_I2C_STR_REG, w); } else - dev_err(dev->dev, "RDR IRQ while no" + dev_err(dev->dev, "RDR IRQ while no " "data requested\n"); break; @@ -423,7 +423,7 @@ static irqreturn_t i2c_davinci_isr(int this_irq, void *dev_id) DAVINCI_I2C_IMR_REG, w); } else - dev_err(dev->dev, "TDR IRQ while no data to" + dev_err(dev->dev, "TDR IRQ while no data to " "send\n"); break; diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 89a3002..cb55cf2 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -203,7 +203,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) while (!(omap_i2c_read_reg(dev, OMAP_I2C_SYSS_REG) & OMAP_I2C_SYSS_RDONE)) { if (time_after(jiffies, timeout)) { - dev_warn(dev->dev, "timeout waiting" + dev_warn(dev->dev, "timeout waiting " "for controller reset\n"); return -ETIMEDOUT; } @@ -483,7 +483,7 @@ omap_i2c_isr(int this_irq, void *dev_id) dev->buf_len--; } } else - dev_err(dev->dev, "RRDY IRQ while no data" + dev_err(dev->dev, "RRDY IRQ while no data " "requested\n"); omap_i2c_ack_stat(dev, OMAP_I2C_STAT_RRDY); continue; @@ -498,7 +498,7 @@ omap_i2c_isr(int this_irq, void *dev_id) dev->buf_len--; } } else - dev_err(dev->dev, "XRDY IRQ while no" + dev_err(dev->dev, "XRDY IRQ while no " "data to send\n"); omap_i2c_write_reg(dev, OMAP_I2C_DATA_REG, w); omap_i2c_ack_stat(dev, OMAP_I2C_STAT_XRDY); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 16/59] drivers/i2c: Add missing "space" 2007-11-20 1:48 ` [PATCH 16/59] drivers/i2c: " Joe Perches @ 2007-11-20 19:51 ` Jean Delvare 0 siblings, 0 replies; 103+ messages in thread From: Jean Delvare @ 2007-11-20 19:51 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, i2c Hi Joe, On Mon, 19 Nov 2007 17:48:08 -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/i2c/busses/i2c-davinci.c | 4 ++-- > drivers/i2c/busses/i2c-omap.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > (...) Good catch. Patch applied, thanks. -- Jean Delvare ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <3c52bdbf8c60392df6b4fc91e6188f4a382b5310.1195454435.git.joe@perches.com>]
* [PATCH 17/59] drivers/ide: Add missing "space" [not found] ` <3c52bdbf8c60392df6b4fc91e6188f4a382b5310.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-22 21:23 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Bartlomiej Zolnierkiewicz, linux-ide Signed-off-by: Joe Perches <joe@perches.com> --- drivers/ide/ppc/pmac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c index 5afdfef..7f7a598 100644 --- a/drivers/ide/ppc/pmac.c +++ b/drivers/ide/ppc/pmac.c @@ -1513,7 +1513,7 @@ pmac_ide_build_dmatable(ide_drive_t *drive, struct request *rq) if (pmif->broken_dma && cur_addr & (L1_CACHE_BYTES - 1)) { if (pmif->broken_dma_warn == 0) { - printk(KERN_WARNING "%s: DMA on non aligned address," + printk(KERN_WARNING "%s: DMA on non aligned address, " "switching to PIO on Ohare chipset\n", drive->name); pmif->broken_dma_warn = 1; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 17/59] drivers/ide: Add missing "space" 2007-11-20 1:48 ` [PATCH 17/59] drivers/ide: " Joe Perches @ 2007-11-22 21:23 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 103+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2007-11-22 21:23 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, linux-ide On Tuesday 20 November 2007, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> applied ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <00c276347dd7ef0da4abbb8e7f2c0aa776e685c2.1195454435.git.joe@perches.com>]
* [PATCH 18/59] drivers/ieee1394: Add missing "space" [not found] ` <00c276347dd7ef0da4abbb8e7f2c0aa776e685c2.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-22 19:23 ` Stefan Richter 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Ben Collins, Dan Dennedy, Stefan Richter, linux1394-devel Signed-off-by: Joe Perches <joe@perches.com> --- drivers/ieee1394/raw1394.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ieee1394/raw1394.c b/drivers/ieee1394/raw1394.c index cadf047..37e7e10 100644 --- a/drivers/ieee1394/raw1394.c +++ b/drivers/ieee1394/raw1394.c @@ -858,7 +858,7 @@ static int arm_read(struct hpsb_host *host, int nodeid, quadlet_t * buffer, int found = 0, size = 0, rcode = -1; struct arm_request_response *arm_req_resp = NULL; - DBGMSG("arm_read called by node: %X" + DBGMSG("arm_read called by node: %X " "addr: %4.4x %8.8x length: %Zu", nodeid, (u16) ((addr >> 32) & 0xFFFF), (u32) (addr & 0xFFFFFFFF), length); @@ -1012,7 +1012,7 @@ static int arm_write(struct hpsb_host *host, int nodeid, int destid, int found = 0, size = 0, rcode = -1, length_conflict = 0; struct arm_request_response *arm_req_resp = NULL; - DBGMSG("arm_write called by node: %X" + DBGMSG("arm_write called by node: %X " "addr: %4.4x %8.8x length: %Zu", nodeid, (u16) ((addr >> 32) & 0xFFFF), (u32) (addr & 0xFFFFFFFF), length); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 18/59] drivers/ieee1394: Add missing "space" 2007-11-20 1:48 ` [PATCH 18/59] drivers/ieee1394: " Joe Perches @ 2007-11-22 19:23 ` Stefan Richter 0 siblings, 0 replies; 103+ messages in thread From: Stefan Richter @ 2007-11-22 19:23 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Ben Collins, Dan Dennedy, linux1394-devel Joe Perches wrote: > drivers/ieee1394/raw1394.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) ... > - DBGMSG("arm_read called by node: %X" > + DBGMSG("arm_read called by node: %X " ... Committed to linux1394-2.6.git. Thanks, -- Stefan Richter -=====-=-=== =-== =-==- http://arcgraph.de/sr/ ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <de3db785bf1d8f7f5ae308ca366794cc3e5def83.1195454435.git.joe@perches.com>]
* [PATCH 19/59] drivers/infiniband: Add missing "space" [not found] ` <de3db785bf1d8f7f5ae308ca366794cc3e5def83.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 21:14 ` Roland Dreier 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Cc: Christoph Raisch, Hal Rosenstock, Hoang-Nam Nguyen, Roland Dreier, Sean Hefty, general Signed-off-by: Joe Perches <joe@perches.com> --- drivers/infiniband/hw/ehca/ehca_cq.c | 2 +- drivers/infiniband/hw/ehca/ehca_qp.c | 6 +++--- drivers/infiniband/ulp/iser/iser_initiator.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ehca_cq.c b/drivers/infiniband/hw/ehca/ehca_cq.c index 79c25f5..0467c15 100644 --- a/drivers/infiniband/hw/ehca/ehca_cq.c +++ b/drivers/infiniband/hw/ehca/ehca_cq.c @@ -246,7 +246,7 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, int cqe, int comp_vector, } else { if (h_ret != H_PAGE_REGISTERED) { ehca_err(device, "Registration of page failed " - "ehca_cq=%p cq_num=%x h_ret=%li" + "ehca_cq=%p cq_num=%x h_ret=%li " "counter=%i act_pages=%i", my_cq, my_cq->cq_number, h_ret, counter, param.act_pages); diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c b/drivers/infiniband/hw/ehca/ehca_qp.c index 2e3e654..091985b 100644 --- a/drivers/infiniband/hw/ehca/ehca_qp.c +++ b/drivers/infiniband/hw/ehca/ehca_qp.c @@ -858,7 +858,7 @@ struct ib_srq *ehca_create_srq(struct ib_pd *pd, update_mask, mqpcb, my_qp->galpas.kernel); if (hret != H_SUCCESS) { - ehca_err(pd->device, "Could not modify SRQ to INIT" + ehca_err(pd->device, "Could not modify SRQ to INIT " "ehca_qp=%p qp_num=%x h_ret=%li", my_qp, my_qp->real_qp_num, hret); goto create_srq2; @@ -872,7 +872,7 @@ struct ib_srq *ehca_create_srq(struct ib_pd *pd, update_mask, mqpcb, my_qp->galpas.kernel); if (hret != H_SUCCESS) { - ehca_err(pd->device, "Could not enable SRQ" + ehca_err(pd->device, "Could not enable SRQ " "ehca_qp=%p qp_num=%x h_ret=%li", my_qp, my_qp->real_qp_num, hret); goto create_srq2; @@ -886,7 +886,7 @@ struct ib_srq *ehca_create_srq(struct ib_pd *pd, update_mask, mqpcb, my_qp->galpas.kernel); if (hret != H_SUCCESS) { - ehca_err(pd->device, "Could not modify SRQ to RTR" + ehca_err(pd->device, "Could not modify SRQ to RTR " "ehca_qp=%p qp_num=%x h_ret=%li", my_qp, my_qp->real_qp_num, hret); goto create_srq2; diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index a6f2303..ba1b455 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++ b/drivers/infiniband/ulp/iser/iser_initiator.c @@ -561,7 +561,7 @@ void iser_rcv_completion(struct iser_desc *rx_desc, if (opcode == ISCSI_OP_SCSI_CMD_RSP) { itt = get_itt(hdr->itt); /* mask out cid and age bits */ if (!(itt < session->cmds_max)) - iser_err("itt can't be matched to task!!!" + iser_err("itt can't be matched to task!!! " "conn %p opcode %d cmds_max %d itt %d\n", conn->iscsi_conn,opcode,session->cmds_max,itt); /* use the mapping given with the cmds array indexed by itt */ -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 19/59] drivers/infiniband: Add missing "space" 2007-11-20 1:48 ` [PATCH 19/59] drivers/infiniband: " Joe Perches @ 2007-11-20 21:14 ` Roland Dreier 0 siblings, 0 replies; 103+ messages in thread From: Roland Dreier @ 2007-11-20 21:14 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Christoph Raisch, Hal Rosenstock, Hoang-Nam Nguyen, Roland Dreier, Sean Hefty, general thanks, applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <f56e301a22202f30e5443b129f4ea15fa20c5226.1195454435.git.joe@perches.com>]
* [PATCH 20/59] drivers/input: Add missing "space" [not found] ` <f56e301a22202f30e5443b129f4ea15fa20c5226.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- drivers/input/keyboard/omap-keypad.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c index babc913..ce6206f 100644 --- a/drivers/input/keyboard/omap-keypad.c +++ b/drivers/input/keyboard/omap-keypad.c @@ -335,7 +335,7 @@ static int __init omap_kp_probe(struct platform_device *pdev) /* Cols: outputs */ for (col_idx = 0; col_idx < omap_kp->cols; col_idx++) { if (omap_request_gpio(col_gpios[col_idx]) < 0) { - printk(KERN_ERR "Failed to request" + printk(KERN_ERR "Failed to request " "GPIO%d for keypad\n", col_gpios[col_idx]); goto err1; @@ -345,7 +345,7 @@ static int __init omap_kp_probe(struct platform_device *pdev) /* Rows: inputs */ for (row_idx = 0; row_idx < omap_kp->rows; row_idx++) { if (omap_request_gpio(row_gpios[row_idx]) < 0) { - printk(KERN_ERR "Failed to request" + printk(KERN_ERR "Failed to request " "GPIO%d for keypad\n", row_gpios[row_idx]); goto err2; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <d82909a235a0ca88319aaf7990fc94f7ebb649bb.1195454435.git.joe@perches.com>]
* [PATCH 21/59] drivers/isdn: Add missing "space" [not found] ` <d82909a235a0ca88319aaf7990fc94f7ebb649bb.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Karsten Keil, isdn4linux Signed-off-by: Joe Perches <joe@perches.com> --- drivers/isdn/i4l/isdn_ppp.c | 2 +- drivers/isdn/i4l/isdn_x25iface.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/isdn/i4l/isdn_ppp.c b/drivers/isdn/i4l/isdn_ppp.c index 9f5fe37..742e0f6 100644 --- a/drivers/isdn/i4l/isdn_ppp.c +++ b/drivers/isdn/i4l/isdn_ppp.c @@ -2472,7 +2472,7 @@ static void isdn_ppp_ccp_reset_ack_rcvd(struct ippp_struct *is, " for id %d but not expected\n", id); } else { printk(KERN_INFO "ippp_ccp: ResetAck received out of" - "sync for id %d\n", id); + " sync for id %d\n", id); } if(rs->ta) { rs->ta = 0; diff --git a/drivers/isdn/i4l/isdn_x25iface.c b/drivers/isdn/i4l/isdn_x25iface.c index 8b3efc2..a2121c1 100644 --- a/drivers/isdn/i4l/isdn_x25iface.c +++ b/drivers/isdn/i4l/isdn_x25iface.c @@ -65,7 +65,7 @@ static struct concap_proto_ops ix25_pops = { /* error message helper function */ static void illegal_state_warn( unsigned state, unsigned char firstbyte) { - printk( KERN_WARNING "isdn_x25iface: firstbyte %x illegal in" + printk( KERN_WARNING "isdn_x25iface: firstbyte %x illegal in " "current state %d\n",firstbyte, state ); } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <e898ed30e34f209e9309667be632d75945672cd5.1195454435.git.joe@perches.com>]
* [PATCH 22/59] drivers/macintosh: Add missing "space" [not found] ` <e898ed30e34f209e9309667be632d75945672cd5.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- drivers/macintosh/smu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index d409f67..0568313 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c @@ -194,7 +194,7 @@ static irqreturn_t smu_db_intr(int irq, void *arg) reply_len = rc == 0 ? smu->cmd_buf->length : 0; DPRINTK("SMU: reply len: %d\n", reply_len); if (reply_len > cmd->reply_len) { - printk(KERN_WARNING "SMU: reply buffer too small," + printk(KERN_WARNING "SMU: reply buffer too small, " "got %d bytes for a %d bytes buffer\n", reply_len, cmd->reply_len); reply_len = cmd->reply_len; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <5ce69261b8ce239633c31431c61538234b0f8065.1195454435.git.joe@perches.com>]
* [PATCH 23/59] drivers/media/dvb: Add missing "space" [not found] ` <5ce69261b8ce239633c31431c61538234b0f8065.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: LinuxTV.org Project Signed-off-by: Joe Perches <joe@perches.com> --- drivers/media/dvb/frontends/ves1820.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/frontends/ves1820.c b/drivers/media/dvb/frontends/ves1820.c index 60433b5..8791701 100644 --- a/drivers/media/dvb/frontends/ves1820.c +++ b/drivers/media/dvb/frontends/ves1820.c @@ -65,7 +65,7 @@ static int ves1820_writereg(struct ves1820_state *state, u8 reg, u8 data) ret = i2c_transfer(state->i2c, &msg, 1); if (ret != 1) - printk("ves1820: %s(): writereg error (reg == 0x%02x," + printk("ves1820: %s(): writereg error (reg == 0x%02x, " "val == 0x%02x, ret == %i)\n", __FUNCTION__, reg, data, ret); return (ret != 1) ? -EREMOTEIO : 0; @@ -84,7 +84,7 @@ static u8 ves1820_readreg(struct ves1820_state *state, u8 reg) ret = i2c_transfer(state->i2c, msg, 2); if (ret != 2) - printk("ves1820: %s(): readreg error (reg == 0x%02x," + printk("ves1820: %s(): readreg error (reg == 0x%02x, " "ret == %i)\n", __FUNCTION__, reg, ret); return b1[0]; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <150c45e2fd3ccb01decbe9aff70d13fb45b347b7.1195454435.git.joe@perches.com>]
* [PATCH 24/59] drivers/media/radio: Add missing "space" [not found] ` <150c45e2fd3ccb01decbe9aff70d13fb45b347b7.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: LinuxTV.org Project, Mauro Carvalho Chehab, video4linux-list Signed-off-by: Joe Perches <joe@perches.com> --- drivers/media/radio/radio-gemtek.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/radio-gemtek.c b/drivers/media/radio/radio-gemtek.c index 5e4b9dd..9dafc35 100644 --- a/drivers/media/radio/radio-gemtek.c +++ b/drivers/media/radio/radio-gemtek.c @@ -58,10 +58,10 @@ static int initmute = 1; static int radio_nr = -1; module_param(io, int, 0444); -MODULE_PARM_DESC(io, "Force I/O port for the GemTek Radio card if automatic" +MODULE_PARM_DESC(io, "Force I/O port for the GemTek Radio card if automatic " "probing is disabled or fails. The most common I/O ports are: 0x20c " "0x30c, 0x24c or 0x34c (0x20c, 0x248 and 0x28c have been reported to " - " work for the combined sound/radiocard)."); + "work for the combined sound/radiocard)."); module_param(probe, bool, 0444); MODULE_PARM_DESC(probe, "Enable automatic device probing. Note: only the most " -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <8cdb362d494c702f6f0cf095e8e24435550bf5ce.1195454435.git.joe@perches.com>]
* [PATCH 25/59] drivers/media/video: Add missing "space" [not found] ` <8cdb362d494c702f6f0cf095e8e24435550bf5ce.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 2:24 ` [v4l-dvb-maintainer] " Brandon Philips 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Cc: LinuxTV.org Project, Mauro Carvalho Chehab, Stelian Pop, video4linux-list Signed-off-by: Joe Perches <joe@perches.com> --- drivers/media/video/cx25840/cx25840-vbi.c | 2 +- drivers/media/video/meye.c | 2 +- drivers/media/video/saa7134/saa7134-input.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/cx25840/cx25840-vbi.c b/drivers/media/video/cx25840/cx25840-vbi.c index ced13fe..d2949e5 100644 --- a/drivers/media/video/cx25840/cx25840-vbi.c +++ b/drivers/media/video/cx25840/cx25840-vbi.c @@ -180,7 +180,7 @@ void cx25840_vbi_setup(struct i2c_client *client) fsc/1000000,fsc%1000000); v4l_dbg(1, cx25840_debug, client, "hblank %i, hactive %i, " - "vblank %i , vactive %i, vblank656 %i, src_dec %i," + "vblank %i , vactive %i, vblank656 %i, src_dec %i, " "burst 0x%02x, luma_lpf %i, uv_lpf %i, comb 0x%02x," " sc 0x%06x\n", hblank, hactive, vblank, vactive, vblank656, diff --git a/drivers/media/video/meye.c b/drivers/media/video/meye.c index c311632..3d51fa0 100644 --- a/drivers/media/video/meye.c +++ b/drivers/media/video/meye.c @@ -2023,7 +2023,7 @@ static int __init meye_init(void) if (gbufsize < 0 || gbufsize > MEYE_MAX_BUFSIZE) gbufsize = MEYE_MAX_BUFSIZE; gbufsize = PAGE_ALIGN(gbufsize); - printk(KERN_INFO "meye: using %d buffers with %dk (%dk total)" + printk(KERN_INFO "meye: using %d buffers with %dk (%dk total) " "for capture\n", gbuffers, gbufsize / 1024, gbuffers * gbufsize / 1024); diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c index 3abaa1b..a485185 100644 --- a/drivers/media/video/saa7134/saa7134-input.c +++ b/drivers/media/video/saa7134/saa7134-input.c @@ -49,7 +49,7 @@ module_param(repeat_delay, int, 0644); MODULE_PARM_DESC(repeat_delay, "delay before key repeat started"); static int repeat_period = 33; module_param(repeat_period, int, 0644); -MODULE_PARM_DESC(repeat_period, "repeat period between" +MODULE_PARM_DESC(repeat_period, "repeat period between " "keypresses when key is down"); #define dprintk(fmt, arg...) if (ir_debug) \ -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [v4l-dvb-maintainer] [PATCH 25/59] drivers/media/video: Add missing "space" [not found] ` <8cdb362d494c702f6f0cf095e8e24435550bf5ce.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 25/59] drivers/media/video: " Joe Perches @ 2007-11-20 2:24 ` Brandon Philips 2007-11-20 4:08 ` Joe Perches 1 sibling, 1 reply; 103+ messages in thread From: Brandon Philips @ 2007-11-20 2:24 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Stelian Pop, LinuxTV.org Project, video4linux-list, Mauro Carvalho Chehab On 17:48 Mon 19 Nov 2007, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/media/video/cx25840/cx25840-vbi.c | 2 +- > drivers/media/video/meye.c | 2 +- > drivers/media/video/saa7134/saa7134-input.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/video/cx25840/cx25840-vbi.c b/drivers/media/video/cx25840/cx25840-vbi.c > index ced13fe..d2949e5 100644 > --- a/drivers/media/video/cx25840/cx25840-vbi.c > +++ b/drivers/media/video/cx25840/cx25840-vbi.c > @@ -180,7 +180,7 @@ void cx25840_vbi_setup(struct i2c_client *client) > fsc/1000000,fsc%1000000); > > v4l_dbg(1, cx25840_debug, client, "hblank %i, hactive %i, " > - "vblank %i , vactive %i, vblank656 %i, src_dec %i," > + "vblank %i , vactive %i, vblank656 %i, src_dec %i, " ^^^^^ can you remove that unintended space too? Thanks, Brandon ^ permalink raw reply [flat|nested] 103+ messages in thread
* Re: [v4l-dvb-maintainer] [PATCH 25/59] drivers/media/video: Add missing "space" 2007-11-20 2:24 ` [v4l-dvb-maintainer] " Brandon Philips @ 2007-11-20 4:08 ` Joe Perches 2007-11-20 12:06 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 4:08 UTC (permalink / raw) To: Brandon Philips Cc: linux-kernel, Stelian Pop, LinuxTV.org Project, video4linux-list, Mauro Carvalho Chehab On Mon, 2007-11-19 at 18:24 -0800, Brandon Philips wrote: > On 17:48 Mon 19 Nov 2007, Joe Perches wrote: > > v4l_dbg(1, cx25840_debug, client, "hblank %i, hactive %i, " > > - "vblank %i , vactive %i, vblank656 %i, src_dec %i," > > + "vblank %i , vactive %i, vblank656 %i, src_dec %i, " > ^^^^^ > can you remove that unintended diff --git a/drivers/media/video/cx25840/cx25840-vbi.c b/drivers/media/video/cx25840/cx25840-vbi.c index ced13fe..d2949e5 100644 --- a/drivers/media/video/cx25840/cx25840-vbi.c +++ b/drivers/media/video/cx25840/cx25840-vbi.c @@ -180,7 +180,7 @@ void cx25840_vbi_setup(struct i2c_client *client) fsc/1000000,fsc%1000000); v4l_dbg(1, cx25840_debug, client, "hblank %i, hactive %i, " - "vblank %i , vactive %i, vblank656 %i, src_dec %i," + "vblank %i, vactive %i, vblank656 %i, src_dec %i, " "burst 0x%02x, luma_lpf %i, uv_lpf %i, comb 0x%02x," " sc 0x%06x\n", hblank, hactive, vblank, vactive, vblank656, ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [v4l-dvb-maintainer] [PATCH 25/59] drivers/media/video: Add missing "space" 2007-11-20 4:08 ` Joe Perches @ 2007-11-20 12:06 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 103+ messages in thread From: Mauro Carvalho Chehab @ 2007-11-20 12:06 UTC (permalink / raw) To: Joe Perches Cc: Brandon Philips, linux-kernel, Stelian Pop, LinuxTV.org Project, video4linux-list > @@ -180,7 +180,7 @@ void cx25840_vbi_setup(struct i2c_client *client) > fsc/1000000,fsc%1000000); > > v4l_dbg(1, cx25840_debug, client, "hblank %i, hactive %i, " > - "vblank %i , vactive %i, vblank656 %i, src_dec %i," > + "vblank %i, vactive %i, vblank656 %i, src_dec %i, " Ok, I've replaced the old hunk by the newer one you've just sent. I'm committing the two drivers/media patches on my tree. > -- Cheers, Mauro ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <48f19e3c182fdbd1ccd30b544209f962d16d7dc9.1195454435.git.joe@perches.com>]
* [PATCH 26/59] drivers/message: Add missing "space" [not found] ` <48f19e3c182fdbd1ccd30b544209f962d16d7dc9.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- drivers/message/i2o/exec-osm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/message/i2o/exec-osm.c b/drivers/message/i2o/exec-osm.c index 6cbcc21..16177c2 100644 --- a/drivers/message/i2o/exec-osm.c +++ b/drivers/message/i2o/exec-osm.c @@ -503,7 +503,7 @@ static int i2o_exec_reply(struct i2o_controller *c, u32 m, * to aid in debugging. * */ - printk(KERN_WARNING "%s: Unsolicited message reply sent to core!" + printk(KERN_WARNING "%s: Unsolicited message reply sent to core! " "Message dumped to syslog\n", c->name); i2o_dump_message(msg); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <0b52e7ee42f854a4f4f6873a7a7bc496a7247d3c.1195454435.git.joe@perches.com>]
* [PATCH 27/59] drivers/misc: Add missing "space" [not found] ` <0b52e7ee42f854a4f4f6873a7a7bc496a7247d3c.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- drivers/misc/ioc4.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/misc/ioc4.c b/drivers/misc/ioc4.c index 05172d2..e5e7755 100644 --- a/drivers/misc/ioc4.c +++ b/drivers/misc/ioc4.c @@ -200,7 +200,7 @@ ioc4_clock_calibrate(struct ioc4_driver_data *idd) if (period > IOC4_CALIBRATE_LOW_LIMIT || period < IOC4_CALIBRATE_HIGH_LIMIT) { printk(KERN_INFO - "IOC4 %s: Clock calibration failed. Assuming" + "IOC4 %s: Clock calibration failed. Assuming " "PCI clock is %d ns.\n", pci_name(idd->idd_pdev), IOC4_CALIBRATE_DEFAULT / IOC4_EXTINT_COUNT_DIVISOR); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <3ad6205457781910c10dd7261e606de0bf7bafac.1195454435.git.joe@perches.com>]
* [PATCH 28/59] drivers/mtd: Add missing "space" [not found] ` <3ad6205457781910c10dd7261e606de0bf7bafac.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: David Woodhouse, Kyungmin Park, linux-mtd Signed-off-by: Joe Perches <joe@perches.com> --- drivers/mtd/nand/nandsim.c | 2 +- drivers/mtd/onenand/onenand_base.c | 4 ++-- drivers/mtd/ssfdc.c | 4 ++-- drivers/mtd/ubi/build.c | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c index 10490b4..54be667 100644 --- a/drivers/mtd/nand/nandsim.c +++ b/drivers/mtd/nand/nandsim.c @@ -1425,7 +1425,7 @@ static int do_state_action(struct nandsim *ns, uint32_t action) case ACTION_HALFOFF: if (!(ns->options & OPT_PAGE512_8BIT)) { - NS_ERR("do_state_action: BUG! can't skip half of page for non-512" + NS_ERR("do_state_action: BUG! can't skip half of page for non-512 " "byte page size 8x chips\n"); return -1; } diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 1b0b320..89ddbaf 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -1119,7 +1119,7 @@ static int onenand_bbt_wait(struct mtd_info *mtd, int state) if (ecc & ONENAND_ECC_2BIT_ALL) return ONENAND_BBT_READ_ERROR; } else { - printk(KERN_ERR "onenand_bbt_wait: read timeout!" + printk(KERN_ERR "onenand_bbt_wait: read timeout! " "ctrl=0x%04x intr=0x%04x\n", ctrl, interrupt); return ONENAND_BBT_READ_FATAL_ERROR; } @@ -2542,7 +2542,7 @@ static void onenand_resume(struct mtd_info *mtd) if (this->state == FL_PM_SUSPENDED) onenand_release_device(mtd); else - printk(KERN_ERR "resume() called for the chip which is not" + printk(KERN_ERR "resume() called for the chip which is not " "in suspended state\n"); } diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index a5f3d60..9a38328 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -222,7 +222,7 @@ static int get_logical_address(uint8_t *oob_buf) if (get_parity(block_address, 10) != parity) { DEBUG(MTD_DEBUG_LEVEL0, - "SSFDC_RO: logical address field%d" + "SSFDC_RO: logical address field%d " "parity error(0x%04X)\n", j+1, block_address); } else { @@ -280,7 +280,7 @@ static int build_logical_block_map(struct ssfdcr_record *ssfdc) (unsigned short)phys_block; DEBUG(MTD_DEBUG_LEVEL2, - "SSFDC_RO: build_block_map() phys_block=%d," + "SSFDC_RO: build_block_map() phys_block=%d, " "logic_block_addr=%d, zone=%d\n", phys_block, block_address, zone_index); } diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 0236539..c3b37e7 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -852,10 +852,10 @@ MODULE_PARM_DESC(mtd, "MTD devices to attach. Parameter format: " "Optional \"vid_hdr_offs\" and \"data_offs\" parameters " "specify UBI VID header position and data starting " "position to be used by UBI.\n" - "Example: mtd=content,1984,2048 mtd=4 - attach MTD device" - "with name content using VID header offset 1984 and data " - "start 2048, and MTD device number 4 using default " - "offsets"); + "Example: mtd=content,1984,2048 mtd=4 - attach MTD " + "device with name content using VID header offset 1984 " + "and data start 2048, and MTD device number 4 using " + "default offsets"); MODULE_VERSION(__stringify(UBI_VERSION)); MODULE_DESCRIPTION("UBI - Unsorted Block Images"); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <6a2d5da40bdf6d7a6595ac2482dd88b7182a74b1.1195454435.git.joe@perches.com>]
* [PATCH 29/59] drivers/net/chelsio: Add missing "space" [not found] ` <6a2d5da40bdf6d7a6595ac2482dd88b7182a74b1.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-24 1:57 ` Jeff Garzik 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Jeff Garzik, netdev Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/chelsio/cxgb2.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c index 2dbf8dc..3eca4e3 100644 --- a/drivers/net/chelsio/cxgb2.c +++ b/drivers/net/chelsio/cxgb2.c @@ -1006,7 +1006,7 @@ static int __devinit init_one(struct pci_dev *pdev, pci_using_dac = 1; if (pci_set_consistent_dma_mask(pdev, DMA_64BIT_MASK)) { - CH_ERR("%s: unable to obtain 64-bit DMA for" + CH_ERR("%s: unable to obtain 64-bit DMA for " "consistent allocations\n", pci_name(pdev)); err = -ENODEV; goto out_disable_pdev; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 29/59] drivers/net/chelsio: Add missing "space" 2007-11-20 1:48 ` [PATCH 29/59] drivers/net/chelsio: " Joe Perches @ 2007-11-24 1:57 ` Jeff Garzik 0 siblings, 0 replies; 103+ messages in thread From: Jeff Garzik @ 2007-11-24 1:57 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, netdev Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/chelsio/cxgb2.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) appied 29-36 to netdev#upstream ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <1020259349705ef83d6011e837dce32c1f08299c.1195454435.git.joe@perches.com>]
* [PATCH 30/59] drivers/net/cxgb3: Add missing "space" [not found] ` <1020259349705ef83d6011e837dce32c1f08299c.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Jeff Garzik, netdev Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/cxgb3/cxgb3_offload.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_offload.c b/drivers/net/cxgb3/cxgb3_offload.c index bd25421..7086f76 100644 --- a/drivers/net/cxgb3/cxgb3_offload.c +++ b/drivers/net/cxgb3/cxgb3_offload.c @@ -1004,7 +1004,7 @@ void cxgb_redirect(struct dst_entry *old, struct dst_entry *new) if (!is_offloading(olddev)) return; if (!is_offloading(newdev)) { - printk(KERN_WARNING "%s: Redirect to non-offload" + printk(KERN_WARNING "%s: Redirect to non-offload " "device ignored.\n", __FUNCTION__); return; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <3723ae7bfde66a86c6bf3b044dfbd63b144623d9.1195454435.git.joe@perches.com>]
* [PATCH 31/59] drivers/net/ixgb: Add missing "space" [not found] ` <3723ae7bfde66a86c6bf3b044dfbd63b144623d9.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-26 23:16 ` Kok, Auke 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Jeff Garzik, netdev Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/ixgbe/ixgbe_common.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_common.c b/drivers/net/ixgbe/ixgbe_common.c index 512e3b2..b7e50bc 100644 --- a/drivers/net/ixgbe/ixgbe_common.c +++ b/drivers/net/ixgbe/ixgbe_common.c @@ -950,7 +950,7 @@ s32 ixgbe_setup_fc(struct ixgbe_hw *hw, s32 packetbuf_num) u32 rmcs_reg; if (packetbuf_num < 0 || packetbuf_num > 7) - hw_dbg(hw, "Invalid packet buffer number [%d], expected range" + hw_dbg(hw, "Invalid packet buffer number [%d], expected range " "is 0-7\n", packetbuf_num); frctl_reg = IXGBE_READ_REG(hw, IXGBE_FCTRL); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 31/59] drivers/net/ixgb: Add missing "space" 2007-11-20 1:48 ` [PATCH 31/59] drivers/net/ixgb: " Joe Perches @ 2007-11-26 23:16 ` Kok, Auke 0 siblings, 0 replies; 103+ messages in thread From: Kok, Auke @ 2007-11-26 23:16 UTC (permalink / raw) To: Jeff Garzik; +Cc: Joe Perches, linux-kernel, netdev Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/ixgbe/ixgbe_common.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_common.c b/drivers/net/ixgbe/ixgbe_common.c > index 512e3b2..b7e50bc 100644 > --- a/drivers/net/ixgbe/ixgbe_common.c > +++ b/drivers/net/ixgbe/ixgbe_common.c > @@ -950,7 +950,7 @@ s32 ixgbe_setup_fc(struct ixgbe_hw *hw, s32 packetbuf_num) > u32 rmcs_reg; > > if (packetbuf_num < 0 || packetbuf_num > 7) > - hw_dbg(hw, "Invalid packet buffer number [%d], expected range" > + hw_dbg(hw, "Invalid packet buffer number [%d], expected range " > "is 0-7\n", packetbuf_num); > > frctl_reg = IXGBE_READ_REG(hw, IXGBE_FCTRL); Jeff, please apply in case you didn't do so yet. Acked-by: Auke Kok <auke-jan.h.kok@intel.com> Auke ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <3ed0b0aee275e6a8632b1be454a61f3a2b73639c.1195454435.git.joe@perches.com>]
* [PATCH 32/59] drivers/net/netxen: Add missing "space" [not found] ` <3ed0b0aee275e6a8632b1be454a61f3a2b73639c.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Amit S. Kale, Jeff Garzik, netdev Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/netxen/netxen_nic_hw.c | 2 +- drivers/net/netxen/netxen_nic_init.c | 4 ++-- drivers/net/netxen/netxen_nic_main.c | 6 +++--- drivers/net/netxen/netxen_nic_niu.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_hw.c b/drivers/net/netxen/netxen_nic_hw.c index 2c19b8d..8d692e2 100644 --- a/drivers/net/netxen/netxen_nic_hw.c +++ b/drivers/net/netxen/netxen_nic_hw.c @@ -664,7 +664,7 @@ void netxen_nic_pci_change_crbwindow(struct netxen_adapter *adapter, u32 wndw) NETXEN_PCIX_PH_REG(PCIX_CRB_WINDOW_F3)); break; default: - printk(KERN_INFO "Changing the window for PCI function" + printk(KERN_INFO "Changing the window for PCI function " "%d\n", adapter->ahw.pci_func); offset = PCI_OFFSET_SECOND_RANGE(adapter, NETXEN_PCIX_PH_REG(PCIX_CRB_WINDOW)); diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c index 3758926..89d9b53 100644 --- a/drivers/net/netxen/netxen_nic_init.c +++ b/drivers/net/netxen/netxen_nic_init.c @@ -1102,8 +1102,8 @@ netxen_process_rcv(struct netxen_adapter *adapter, int ctxid, } if (buffer->lro_current_frags != buffer->lro_expected_frags) { if (buffer->lro_expected_frags != 0) { - printk("LRO: (refhandle:%x) recv frag." - "wait for last. flags: %x expected:%d" + printk("LRO: (refhandle:%x) recv frag. " + "wait for last. flags: %x expected:%d " "have:%d\n", index, netxen_get_sts_desc_lro_last_frag(desc), buffer->lro_expected_frags, diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index a80f0cd..f648d43 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c @@ -287,7 +287,7 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) printk(KERN_INFO "%s \n", netxen_nic_driver_string); if (pdev->class != 0x020000) { - printk(KERN_ERR"NetXen function %d, class %x will not" + printk(KERN_ERR"NetXen function %d, class %x will not " "be enabled.\n",pci_func_id, pdev->class); return -ENODEV; } @@ -511,7 +511,7 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) vmalloc(RCV_BUFFSIZE); if (rcv_desc->rx_buf_arr == NULL) { - printk(KERN_ERR "%s: Could not allocate" + printk(KERN_ERR "%s: Could not allocate " "rcv_desc->rx_buf_arr memory:%d\n", netxen_nic_driver_name, (int)RCV_BUFFSIZE); @@ -983,7 +983,7 @@ static int netxen_nic_xmit_frame(struct sk_buff *skb, struct net_device *netdev) } if (frag_count > MAX_BUFFERS_PER_CMD) { - printk("%s: %s netxen_nic_xmit_frame: frag_count (%d)" + printk("%s: %s netxen_nic_xmit_frame: frag_count (%d) " "too large, can handle only %d frags\n", netxen_nic_driver_name, netdev->name, frag_count, MAX_BUFFERS_PER_CMD); diff --git a/drivers/net/netxen/netxen_nic_niu.c b/drivers/net/netxen/netxen_nic_niu.c index 5b9e1b3..155429d 100644 --- a/drivers/net/netxen/netxen_nic_niu.c +++ b/drivers/net/netxen/netxen_nic_niu.c @@ -544,8 +544,8 @@ int netxen_niu_gbe_handle_phy_interrupt(struct netxen_adapter *adapter, port, enable); } else { - printk(KERN_ERR PFX "ERROR reading" - "PHY status. Illegal speed.\n"); + printk(KERN_ERR PFX "ERROR reading " + "PHY status. Invalid speed.\n"); result = -1; } } else { -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <938a74cb7895afece561b299f11d28785214bade.1195454435.git.joe@perches.com>]
* [PATCH 33/59] drivers/net/sk98lin: Add missing "space" [not found] ` <938a74cb7895afece561b299f11d28785214bade.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Jeff Garzik, netdev Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/sk98lin/skgepnmi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sk98lin/skgepnmi.c b/drivers/net/sk98lin/skgepnmi.c index b36dd9a..678659f 100644 --- a/drivers/net/sk98lin/skgepnmi.c +++ b/drivers/net/sk98lin/skgepnmi.c @@ -383,7 +383,7 @@ int Level) /* Initialization level */ SK_ERR_LOG(pAC, SK_ERRCL_SW, SK_PNMI_ERR049, SK_PNMI_ERR049MSG); SK_DBG_MSG(pAC, SK_DBGMOD_PNMI, SK_DBGCAT_INIT | SK_DBGCAT_FATAL, - ("CounterOffset struct size (%d) differs from" + ("CounterOffset struct size (%d) differs from " "SK_PNMI_MAX_IDX (%d)\n", SK_PNMI_CNT_NO, SK_PNMI_MAX_IDX)); } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <8c0ecd8ae2baa9b0596d352f53c4c3527f3528bd.1195454435.git.joe@perches.com>]
* [PATCH 34/59] drivers/net/wan: Add missing "space" [not found] ` <8c0ecd8ae2baa9b0596d352f53c4c3527f3528bd.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 23:52 ` Krzysztof Halasa 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Jeff Garzik, Krzysztof Halasa, netdev Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/wan/wanxl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index 8e320b7..ad8c865 100644 --- a/drivers/net/wan/wanxl.c +++ b/drivers/net/wan/wanxl.c @@ -743,7 +743,7 @@ static int __devinit wanxl_pci_init_one(struct pci_dev *pdev, }while (time_after(timeout, jiffies)); if (!stat) { - printk(KERN_WARNING "wanXL %s: timeout while initializing card" + printk(KERN_WARNING "wanXL %s: timeout while initializing card " "firmware\n", pci_name(pdev)); wanxl_pci_remove_one(pdev); return -ENODEV; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 34/59] drivers/net/wan: Add missing "space" 2007-11-20 1:48 ` [PATCH 34/59] drivers/net/wan: " Joe Perches @ 2007-11-20 23:52 ` Krzysztof Halasa 0 siblings, 0 replies; 103+ messages in thread From: Krzysztof Halasa @ 2007-11-20 23:52 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Jeff Garzik, netdev Joe Perches <joe@perches.com> writes: > --- a/drivers/net/wan/wanxl.c > +++ b/drivers/net/wan/wanxl.c > @@ -743,7 +743,7 @@ static int __devinit wanxl_pci_init_one(struct pci_dev *pdev, > }while (time_after(timeout, jiffies)); > > if (!stat) { > - printk(KERN_WARNING "wanXL %s: timeout while initializing card" > + printk(KERN_WARNING "wanXL %s: timeout while initializing card " > "firmware\n", pci_name(pdev)); > wanxl_pci_remove_one(pdev); > return -ENODEV; Acked-by: Krzysztof Halasa <khc@pm.waw.pl> Thanks. -- Krzysztof Halasa ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <fef2c4f213c930a3c1c1e58c8961249886621caa.1195454435.git.joe@perches.com>]
* [PATCH 36/59] drivers/net: Add missing "space" [not found] ` <fef2c4f213c930a3c1c1e58c8961249886621caa.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Cc: Daniele Venzano, James Chapman, Jeff Garzik, Ramkrishna Vepa, Rastapur Santosh, Roger Luethi, Ron Mercer, Sivakumar Subramani, Sreenivasa Honnur, netdev Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/3c507.c | 4 ++-- drivers/net/amd8111e.c | 4 ++-- drivers/net/at1700.c | 2 +- drivers/net/pppol2tp.c | 2 +- drivers/net/qla3xxx.c | 2 +- drivers/net/rrunner.c | 2 +- drivers/net/s2io.c | 6 +++--- drivers/net/sis900.c | 6 +++--- drivers/net/smc9194.c | 2 +- drivers/net/via-rhine.c | 2 +- 10 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/3c507.c b/drivers/net/3c507.c index 964d31a..f90ede9 100644 --- a/drivers/net/3c507.c +++ b/drivers/net/3c507.c @@ -747,7 +747,7 @@ static void init_82586_mem(struct net_device *dev) int boguscnt = 50; while (readw(shmem+iSCB_STATUS) == 0) if (--boguscnt == 0) { - printk("%s: i82586 initialization timed out with status %04x," + printk("%s: i82586 initialization timed out with status %04x, " "cmd %04x.\n", dev->name, readw(shmem+iSCB_STATUS), readw(shmem+iSCB_CMD)); break; @@ -832,7 +832,7 @@ static void el16_rx(struct net_device *dev) if (rfd_cmd != 0 || data_buffer_addr != rx_head + 22 || (pkt_len & 0xC000) != 0xC000) { - printk("%s: Rx frame at %#x corrupted, status %04x cmd %04x" + printk("%s: Rx frame at %#x corrupted, status %04x cmd %04x " "next %04x data-buf @%04x %04x.\n", dev->name, rx_head, frame_status, rfd_cmd, next_rx_frame, data_buffer_addr, pkt_len); diff --git a/drivers/net/amd8111e.c b/drivers/net/amd8111e.c index eebf5bb..3430cc3 100644 --- a/drivers/net/amd8111e.c +++ b/drivers/net/amd8111e.c @@ -1939,13 +1939,13 @@ static int __devinit amd8111e_probe_one(struct pci_dev *pdev, err = pci_enable_device(pdev); if(err){ - printk(KERN_ERR "amd8111e: Cannot enable new PCI device," + printk(KERN_ERR "amd8111e: Cannot enable new PCI device, " "exiting.\n"); return err; } if(!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM)){ - printk(KERN_ERR "amd8111e: Cannot find PCI base address" + printk(KERN_ERR "amd8111e: Cannot find PCI base address, " "exiting.\n"); err = -ENODEV; goto err_disable_pdev; diff --git a/drivers/net/at1700.c b/drivers/net/at1700.c index b032c1b..9704171 100644 --- a/drivers/net/at1700.c +++ b/drivers/net/at1700.c @@ -465,7 +465,7 @@ found: /* Snarf the interrupt vector now. */ ret = request_irq(irq, &net_interrupt, 0, DRV_NAME, dev); if (ret) { - printk (" AT1700 at %#3x is unusable due to a conflict on" + printk (" AT1700 at %#3x is unusable due to a conflict on " "IRQ %d.\n", ioaddr, irq); goto err_mca; } diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c index a7556cd..1b51bb6 100644 --- a/drivers/net/pppol2tp.c +++ b/drivers/net/pppol2tp.c @@ -2489,7 +2489,7 @@ static void __exit pppol2tp_exit(void) module_init(pppol2tp_init); module_exit(pppol2tp_exit); -MODULE_AUTHOR("Martijn van Oosterhout <kleptog@svana.org>," +MODULE_AUTHOR("Martijn van Oosterhout <kleptog@svana.org>, " "James Chapman <jchapman@katalix.com>"); MODULE_DESCRIPTION("PPP over L2TP over UDP"); MODULE_LICENSE("GPL"); diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index a579111..4f5d3d4 100644 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -711,7 +711,7 @@ static int ql_mii_write_reg_ex(struct ql3_adapter *qdev, if (ql_wait_for_mii_ready(qdev)) { if (netif_msg_link(qdev)) printk(KERN_WARNING PFX - "%s: Timed out waiting for management port to" + "%s: Timed out waiting for management port to " "get free before issuing command.\n", qdev->ndev->name); return -1; diff --git a/drivers/net/rrunner.c b/drivers/net/rrunner.c index 73a7e65..379ded5 100644 --- a/drivers/net/rrunner.c +++ b/drivers/net/rrunner.c @@ -878,7 +878,7 @@ static u32 rr_handle_event(struct net_device *dev, u32 prodidx, u32 eidx) dev->name); goto drop; case E_FLG_SYN_ERR: - printk(KERN_WARNING "%s: Flag sync. lost during" + printk(KERN_WARNING "%s: Flag sync. lost during " "packet\n", dev->name); goto drop; case E_RX_INV_BUF: diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 6326667..8aff21c 100644 --- a/drivers/net/s2io.c +++ b/drivers/net/s2io.c @@ -3762,7 +3762,7 @@ static int __devinit s2io_test_msi(struct s2io_nic *sp) if (!sp->msi_detected) { /* MSI(X) test failed, go back to INTx mode */ - DBG_PRINT(ERR_DBG, "%s: PCI %s: No interrupt was generated" + DBG_PRINT(ERR_DBG, "%s: PCI %s: No interrupt was generated " "using MSI(X) during test\n", sp->dev->name, pci_name(pdev)); @@ -6705,7 +6705,7 @@ static int s2io_add_isr(struct s2io_nic * sp) /* If either data or addr is zero print it */ if(!(sp->msix_info[i].addr && sp->msix_info[i].data)) { - DBG_PRINT(ERR_DBG, "%s @ Addr:0x%llx" + DBG_PRINT(ERR_DBG, "%s @ Addr:0x%llx " "Data:0x%lx\n",sp->desc[i], (unsigned long long) sp->msix_info[i].addr, @@ -6723,7 +6723,7 @@ static int s2io_add_isr(struct s2io_nic * sp) /* If either data or addr is zero print it */ if(!(sp->msix_info[i].addr && sp->msix_info[i].data)) { - DBG_PRINT(ERR_DBG, "%s @ Addr:0x%llx" + DBG_PRINT(ERR_DBG, "%s @ Addr:0x%llx " "Data:0x%lx\n",sp->desc[i], (unsigned long long) sp->msix_info[i].addr, diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c index 0857d2c..ec95e49 100644 --- a/drivers/net/sis900.c +++ b/drivers/net/sis900.c @@ -419,7 +419,7 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev, i = pci_set_dma_mask(pci_dev, DMA_32BIT_MASK); if(i){ - printk(KERN_ERR "sis900.c: architecture does not support" + printk(KERN_ERR "sis900.c: architecture does not support " "32bit PCI busmaster DMA\n"); return i; } @@ -1667,7 +1667,7 @@ static irqreturn_t sis900_interrupt(int irq, void *dev_instance) /* something strange happened !!! */ if (status & HIBERR) { if(netif_msg_intr(sis_priv)) - printk(KERN_INFO "%s: Abnormal interrupt," + printk(KERN_INFO "%s: Abnormal interrupt, " "status %#8.8x.\n", net_dev->name, status); break; } @@ -1820,7 +1820,7 @@ refill_rx_ring: * how the hardware will react to this kind * of degenerated buffer */ if (netif_msg_rx_err(sis_priv)) - printk(KERN_INFO "%s: Memory squeeze," + printk(KERN_INFO "%s: Memory squeeze, " "deferring packet.\n", net_dev->name); net_dev->stats.rx_dropped++; diff --git a/drivers/net/smc9194.c b/drivers/net/smc9194.c index cb2698d..de67744 100644 --- a/drivers/net/smc9194.c +++ b/drivers/net/smc9194.c @@ -906,7 +906,7 @@ static int __init smc_probe(struct net_device *dev, int ioaddr) SMC_SELECT_BANK(1); base_address_register = inw( ioaddr + BASE ); if ( ioaddr != ( base_address_register >> 3 & 0x3E0 ) ) { - printk(CARDNAME ": IOADDR %x doesn't match configuration (%x)." + printk(CARDNAME ": IOADDR %x doesn't match configuration (%x). " "Probably not a SMC chip\n", ioaddr, base_address_register >> 3 & 0x3E0 ); /* well, the base address register didn't match. Must not have diff --git a/drivers/net/via-rhine.c b/drivers/net/via-rhine.c index 07263cd..87c180b 100644 --- a/drivers/net/via-rhine.c +++ b/drivers/net/via-rhine.c @@ -1338,7 +1338,7 @@ static irqreturn_t rhine_interrupt(int irq, void *dev_instance) if (debug > 2 && ioread8(ioaddr+ChipCmd) & CmdTxOn) printk(KERN_WARNING "%s: " - "rhine_interrupt() Tx engine" + "rhine_interrupt() Tx engine " "still on.\n", dev->name); } rhine_tx(dev); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <b56ad31ff9f8151583eaf50f5adb924b2e0ccb88.1195454435.git.joe@perches.com>]
* [PATCH 37/59] drivers/pci: Add missing "space" [not found] ` <b56ad31ff9f8151583eaf50f5adb924b2e0ccb88.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Cc: Greg Kroah-Hartman, Kristen Carlson Accardi, linux-kernel, linux-pci Signed-off-by: Joe Perches <joe@perches.com> --- drivers/pci/hotplug/pci_hotplug_core.c | 2 +- drivers/pci/probe.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c index 01c351c..b491a36 100644 --- a/drivers/pci/hotplug/pci_hotplug_core.c +++ b/drivers/pci/hotplug/pci_hotplug_core.c @@ -627,7 +627,7 @@ int pci_hp_register (struct hotplug_slot *slot) if ((slot->info == NULL) || (slot->ops == NULL)) return -EINVAL; if (slot->release == NULL) { - dbg("Why are you trying to register a hotplug slot" + dbg("Why are you trying to register a hotplug slot " "without a proper release function?\n"); return -EINVAL; } diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 463a5a9..bd6995f 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -658,13 +658,13 @@ int pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max, int pass (child->number > bus->subordinate) || (child->number < bus->number) || (child->subordinate < bus->number)) { - pr_debug("PCI: Bus #%02x (-#%02x) is %s" + pr_debug("PCI: Bus #%02x (-#%02x) is %s " "hidden behind%s bridge #%02x (-#%02x)\n", child->number, child->subordinate, (bus->number > child->subordinate && bus->subordinate < child->number) ? - "wholly " : " partially", - bus->self->transparent ? " transparent" : " ", + "wholly" : "partially", + bus->self->transparent ? " transparent" : "", bus->number, bus->subordinate); } bus = bus->parent; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <d04f5b45e26dfc3ae3e8f69f01e3a20738f14b32.1195454435.git.joe@perches.com>]
* [PATCH 38/59] drivers/rtc: Add missing "space" [not found] ` <d04f5b45e26dfc3ae3e8f69f01e3a20738f14b32.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Alessandro Zummo, Paul Gortmaker, linux-kernel, rtc-linux Signed-off-by: Joe Perches <joe@perches.com> --- drivers/rtc/rtc-v3020.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-v3020.c b/drivers/rtc/rtc-v3020.c index a6b5729..0e7a15d 100644 --- a/drivers/rtc/rtc-v3020.c +++ b/drivers/rtc/rtc-v3020.c @@ -200,7 +200,7 @@ static int rtc_probe(struct platform_device *pdev) * are all disabled */ v3020_set_reg(chip, V3020_STATUS_0, 0x0); - dev_info(&pdev->dev, "Chip available at physical address 0x%llx," + dev_info(&pdev->dev, "Chip available at physical address 0x%llx, " "data connected to D%d\n", (unsigned long long)pdev->resource[0].start, chip->leftshift); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <f9ffd78f5eb1f49e89fc578611de786ae7b9ac87.1195454436.git.joe@perches.com>]
* [PATCH 40/59] drivers/scsi/aic7xxx: Add missing "space" [not found] ` <f9ffd78f5eb1f49e89fc578611de786ae7b9ac87.1195454436.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Hannes Reinecke, James E.J. Bottomley, linux-scsi Signed-off-by: Joe Perches <joe@perches.com> --- drivers/scsi/aic7xxx/aic79xx_osm.c | 2 +- drivers/scsi/aic7xxx/aic79xx_osm_pci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c index 2d02040..581ac18 100644 --- a/drivers/scsi/aic7xxx/aic79xx_osm.c +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c @@ -338,7 +338,7 @@ MODULE_PARM_DESC(aic79xx, " amplitude:<int> Set the signal amplitude (0-7).\n" " seltime:<int> Selection Timeout:\n" " (0/256ms,1/128ms,2/64ms,3/32ms)\n" -" slowcrc Turn on the SLOWCRC bit (Rev B only)\n" +" slowcrc Turn on the SLOWCRC bit (Rev B only)\n" "\n" " Sample /etc/modprobe.conf line:\n" " Enable verbose logging\n" diff --git a/drivers/scsi/aic7xxx/aic79xx_osm_pci.c b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c index 66f0259..8ec99e2 100644 --- a/drivers/scsi/aic7xxx/aic79xx_osm_pci.c +++ b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c @@ -374,7 +374,7 @@ ahd_pci_map_registers(struct ahd_softc *ahd) ahd->bshs[1].ioport = base2; command |= PCIM_CMD_PORTEN; } else { - printf("aic79xx: PCI%d:%d:%d IO regions 0x%lx and 0x%lx" + printf("aic79xx: PCI%d:%d:%d IO regions 0x%lx and 0x%lx " "unavailable. Cannot map device.\n", ahd_get_pci_bus(ahd->dev_softc), ahd_get_pci_slot(ahd->dev_softc), -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <6cd7c30e31d1e1a732eeb7f08636afa5061d5f44.1195454436.git.joe@perches.com>]
* [PATCH 41/59] drivers/scsi/aic94xx: Add missing "space" [not found] ` <6cd7c30e31d1e1a732eeb7f08636afa5061d5f44.1195454436.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: James E.J. Bottomley, linux-scsi Signed-off-by: Joe Perches <joe@perches.com> --- drivers/scsi/aic94xx/aic94xx_sds.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_sds.c b/drivers/scsi/aic94xx/aic94xx_sds.c index 06509bf..f45f0b9 100644 --- a/drivers/scsi/aic94xx/aic94xx_sds.c +++ b/drivers/scsi/aic94xx/aic94xx_sds.c @@ -325,8 +325,8 @@ asd_hwi_check_ocm_access (struct asd_ha_struct *asd_ha) goto out; } - printk(KERN_INFO "OCM is not initialized by BIOS," - "reinitialize it and ignore it, current IntrptStatus" + printk(KERN_INFO "OCM is not initialized by BIOS, " + "reinitialize it and ignore it, current IntrptStatus " "is 0x%x\n", v); if (v) -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <0d5c0d474aaeba86c0899848a6eb16ef92d308bc.1195454436.git.joe@perches.com>]
* [PATCH 42/59] drivers/scsi/lpfc: Add missing "space" [not found] ` <0d5c0d474aaeba86c0899848a6eb16ef92d308bc.1195454436.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: James E.J. Bottomley, James Smart, linux-scsi Signed-off-by: Joe Perches <joe@perches.com> --- drivers/scsi/lpfc/lpfc_attr.c | 2 +- drivers/scsi/lpfc/lpfc_ct.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 80a1121..d9d6791 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -1182,7 +1182,7 @@ lpfc_nodev_tmo_set(struct lpfc_vport *vport, int val) } lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT, "0403 lpfc_nodev_tmo attribute cannot be set to" - "%d, allowed range is [%d, %d]\n", + " %d, allowed range is [%d, %d]\n", val, LPFC_MIN_DEVLOSS_TMO, LPFC_MAX_DEVLOSS_TMO); return -EINVAL; } diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c index c701e4d..88b39d5 100644 --- a/drivers/scsi/lpfc/lpfc_ct.c +++ b/drivers/scsi/lpfc/lpfc_ct.c @@ -473,7 +473,7 @@ lpfc_ns_rsp(struct lpfc_vport *vport, struct lpfc_dmabuf *mp, uint32_t Size) KERN_INFO, LOG_DISCOVERY, "0238 Process " - "x%x NameServer Rsp" + "x%x NameServer Rsp " "Data: x%x x%x x%x\n", Did, ndlp->nlp_flag, vport->fc_flag, -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <769fa1b17e5b66a91e59e7c5899b6747b39b5731.1195454436.git.joe@perches.com>]
* [PATCH 43/59] drivers/scsi/qla4xxx: Add missing "space" [not found] ` <769fa1b17e5b66a91e59e7c5899b6747b39b5731.1195454436.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 1:53 ` Joe Perches 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: James E.J. Bottomley, linux-scsi Signed-off-by: Joe Perches <joe@perches.com> --- drivers/scsi/qla4xxx/ql4_init.c | 2 +- drivers/scsi/qla4xxx/ql4_os.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c index d692c71..ab619a8 100644 --- a/drivers/scsi/qla4xxx/ql4_init.c +++ b/drivers/scsi/qla4xxx/ql4_init.c @@ -1184,7 +1184,7 @@ int qla4xxx_initialize_adapter(struct scsi_qla_host *ha, */ status = qla4xxx_initialize_ddb_list(ha); if (status == QLA_ERROR) { - DEBUG2(printk("%s(%ld) Error occurred during build" + DEBUG2(printk("%s(%ld) Error occurred during build " "ddb list\n", __func__, ha->host_no)); goto exit_init_hba; } diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 89460d2..7aa64ca 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -1016,7 +1016,7 @@ static void qla4xxx_do_dpc(struct work_struct *work) struct ddb_entry *ddb_entry, *dtemp; int status = QLA_ERROR; - DEBUG2(printk("scsi%ld: %s: DPC handler waking up." + DEBUG2(printk("scsi%ld: %s: DPC handler waking up. " "flags = 0x%08lx, dpc_flags = 0x%08lx ctrl_stat = 0x%08x\n", ha->host_no, __func__, ha->flags, ha->dpc_flags, readw(&ha->reg->ctrl_status))); @@ -1563,7 +1563,7 @@ static int qla4xxx_eh_device_reset(struct scsi_cmnd *cmd) cmd->device->channel, cmd->device->id, cmd->device->lun); DEBUG2(printk(KERN_INFO - "scsi%ld: DEVICE_RESET cmd=%p jiffies = 0x%lx, to=%x," + "scsi%ld: DEVICE_RESET cmd=%p jiffies = 0x%lx, to=%x, " "dpc_flags=%lx, status=%x allowed=%d\n", ha->host_no, cmd, jiffies, cmd->timeout_per_command / HZ, ha->dpc_flags, cmd->result, cmd->allowed)); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* [PATCH 43/59] drivers/scsi/qla4xxx: Add missing "space" [not found] ` <769fa1b17e5b66a91e59e7c5899b6747b39b5731.1195454436.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 43/59] drivers/scsi/qla4xxx: " Joe Perches @ 2007-11-20 1:53 ` Joe Perches 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel; +Cc: James E.J. Bottomley, linux-scsi Signed-off-by: Joe Perches <joe@perches.com> --- drivers/scsi/qla4xxx/ql4_init.c | 2 +- drivers/scsi/qla4xxx/ql4_os.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c index d692c71..ab619a8 100644 --- a/drivers/scsi/qla4xxx/ql4_init.c +++ b/drivers/scsi/qla4xxx/ql4_init.c @@ -1184,7 +1184,7 @@ int qla4xxx_initialize_adapter(struct scsi_qla_host *ha, */ status = qla4xxx_initialize_ddb_list(ha); if (status == QLA_ERROR) { - DEBUG2(printk("%s(%ld) Error occurred during build" + DEBUG2(printk("%s(%ld) Error occurred during build " "ddb list\n", __func__, ha->host_no)); goto exit_init_hba; } diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 89460d2..7aa64ca 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -1016,7 +1016,7 @@ static void qla4xxx_do_dpc(struct work_struct *work) struct ddb_entry *ddb_entry, *dtemp; int status = QLA_ERROR; - DEBUG2(printk("scsi%ld: %s: DPC handler waking up." + DEBUG2(printk("scsi%ld: %s: DPC handler waking up. " "flags = 0x%08lx, dpc_flags = 0x%08lx ctrl_stat = 0x%08x\n", ha->host_no, __func__, ha->flags, ha->dpc_flags, readw(&ha->reg->ctrl_status))); @@ -1563,7 +1563,7 @@ static int qla4xxx_eh_device_reset(struct scsi_cmnd *cmd) cmd->device->channel, cmd->device->id, cmd->device->lun); DEBUG2(printk(KERN_INFO - "scsi%ld: DEVICE_RESET cmd=%p jiffies = 0x%lx, to=%x," + "scsi%ld: DEVICE_RESET cmd=%p jiffies = 0x%lx, to=%x, " "dpc_flags=%lx, status=%x allowed=%d\n", ha->host_no, cmd, jiffies, cmd->timeout_per_command / HZ, ha->dpc_flags, cmd->result, cmd->allowed)); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <adb8f5a3245d3e618c861f99db3acd43362c92c7.1195454436.git.joe@perches.com>]
* [PATCH 44/59] drivers/scsi: Add missing "space" [not found] ` <adb8f5a3245d3e618c861f99db3acd43362c92c7.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 10:39 ` Alistair John Strachan 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Cc: Ali Akcaagac, James E.J. Bottomley, Jamie Lenehan, Oliver Neukum, dc395x, linux-scsi Signed-off-by: Joe Perches <joe@perches.com> --- drivers/scsi/NCR_D700.c | 2 +- drivers/scsi/aic7xxx_old.c | 2 +- drivers/scsi/dc395x.c | 2 +- drivers/scsi/hosts.c | 2 +- drivers/scsi/iscsi_tcp.c | 6 +++--- drivers/scsi/scsi_proc.c | 2 +- drivers/scsi/scsi_scan.c | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c index 9e64b21..99403a6 100644 --- a/drivers/scsi/NCR_D700.c +++ b/drivers/scsi/NCR_D700.c @@ -182,7 +182,7 @@ NCR_D700_probe_one(struct NCR_D700_private *p, int siop, int irq, hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL); if (!hostdata) { - printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host" + printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host " "data, detatching\n", siop); return -ENOMEM; } diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c index 8f8db5f..c79a452 100644 --- a/drivers/scsi/aic7xxx_old.c +++ b/drivers/scsi/aic7xxx_old.c @@ -3716,7 +3716,7 @@ aic7xxx_pci_intr(struct aic7xxx_host *p) pci_read_config_byte(p->pdev, PCI_STATUS + 1, &status1); if ( (status1 & DPE) && (aic7xxx_verbose & VERBOSE_MINOR_ERROR) ) - printk(WARN_LEAD "Data Parity Error during PCI address or PCI write" + printk(WARN_LEAD "Data Parity Error during PCI address or PCI write " "phase.\n", p->host_no, -1, -1, -1); if ( (status1 & SSE) && (aic7xxx_verbose & VERBOSE_MINOR_ERROR) ) printk(WARN_LEAD "Signal System Error Detected\n", p->host_no, diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index a9def6e..f98747c 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -1520,7 +1520,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb, } #endif if (acb->active_dcb) { - dprintkl(KERN_DEBUG, "start_scsi: (pid#%li) Attempt to start a" + dprintkl(KERN_DEBUG, "start_scsi: (pid#%li) Attempt to start a " "command while another command (pid#%li) is active.", srb->cmd->serial_number, acb->active_dcb->active_srb ? diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 24271a8..b53f681 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -141,7 +141,7 @@ int scsi_host_set_state(struct Scsi_Host *shost, enum scsi_host_state state) illegal: SCSI_LOG_ERROR_RECOVERY(1, shost_printk(KERN_ERR, shost, - "Illegal host state transition" + "Invalid host state transition " "%s->%s\n", scsi_host_state_name(oldstate), scsi_host_state_name(state))); diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 4bcf916..2e0d9a1 100644 --- a/drivers/scsi/iscsi_tcp.c +++ b/drivers/scsi/iscsi_tcp.c @@ -389,7 +389,7 @@ iscsi_r2t_rsp(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask) } if (r2t->data_length > session->max_burst) - debug_scsi("invalid R2T with data len %u and max burst %u." + debug_scsi("invalid R2T with data len %u and max burst %u. " "Attempting to execute request.\n", r2t->data_length, session->max_burst); @@ -900,13 +900,13 @@ more: memcpy(&recv_digest, conn->data, sizeof(uint32_t)); if (recv_digest != tcp_conn->in.datadgst) { - debug_tcp("iscsi_tcp: data digest error!" + debug_tcp("iscsi_tcp: data digest error! " "0x%x != 0x%x\n", recv_digest, tcp_conn->in.datadgst); iscsi_conn_failure(conn, ISCSI_ERR_DATA_DGST); return 0; } else { - debug_tcp("iscsi_tcp: data digest match!" + debug_tcp("iscsi_tcp: data digest match! " "0x%x == 0x%x\n", recv_digest, tcp_conn->in.datadgst); tcp_conn->in_progress = IN_PROGRESS_WAIT_HEADER; diff --git a/drivers/scsi/scsi_proc.c b/drivers/scsi/scsi_proc.c index bb6f051..781dc85 100644 --- a/drivers/scsi/scsi_proc.c +++ b/drivers/scsi/scsi_proc.c @@ -123,7 +123,7 @@ void scsi_proc_host_add(struct Scsi_Host *shost) p = create_proc_read_entry(name, S_IFREG | S_IRUGO | S_IWUSR, sht->proc_dir, proc_scsi_read, shost); if (!p) { - printk(KERN_ERR "%s: Failed to register host %d in" + printk(KERN_ERR "%s: Failed to register host %d in " "%s\n", __FUNCTION__, shost->host_no, sht->proc_name); return; diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 40ea71c..e0a47ed 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1124,7 +1124,7 @@ static void scsi_sequential_lun_scan(struct scsi_target *starget, unsigned int sparse_lun, lun, max_dev_lun; struct Scsi_Host *shost = dev_to_shost(starget->dev.parent); - SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO "scsi scan: Sequential scan of" + SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO "scsi scan: Sequential scan of " "%s\n", starget->dev.bus_id)); max_dev_lun = min(max_scsi_luns, shost->max_lun); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 44/59] drivers/scsi: Add missing "space" 2007-11-20 1:53 ` [PATCH 44/59] drivers/scsi: " Joe Perches @ 2007-11-20 10:39 ` Alistair John Strachan 2007-11-20 15:17 ` Joe Perches 0 siblings, 1 reply; 103+ messages in thread From: Alistair John Strachan @ 2007-11-20 10:39 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Ali Akcaagac, James E.J. Bottomley, Jamie Lenehan, Oliver Neukum, dc395x, linux-scsi On Tuesday 20 November 2007 01:53:31 Joe Perches wrote: > diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c > index 9e64b21..99403a6 100644 > --- a/drivers/scsi/NCR_D700.c > +++ b/drivers/scsi/NCR_D700.c > @@ -182,7 +182,7 @@ NCR_D700_probe_one(struct NCR_D700_private *p, int > siop, int irq, > > hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL); > if (!hostdata) { > - printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host" > + printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host " > "data, detatching\n", siop); > return -ENOMEM; > } If you're going to sneak in unrelated spelling/grammar changes, you might as well do it unilaterally. "detached" please. -- Cheers, Alistair. 137/1 Warrender Park Road, Edinburgh, UK. ^ permalink raw reply [flat|nested] 103+ messages in thread
* Re: [PATCH 44/59] drivers/scsi: Add missing "space" 2007-11-20 10:39 ` Alistair John Strachan @ 2007-11-20 15:17 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 15:17 UTC (permalink / raw) To: Alistair John Strachan Cc: linux-kernel, Ali Akcaagac, James E.J. Bottomley, Jamie Lenehan, Oliver Neukum, dc395x, linux-scsi On Tue, 2007-11-20 at 10:39 +0000, Alistair John Strachan wrote: > On Tuesday 20 November 2007 01:53:31 Joe Perches wrote: > > diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c > > index 9e64b21..99403a6 100644 > > --- a/drivers/scsi/NCR_D700.c > > +++ b/drivers/scsi/NCR_D700.c > > @@ -182,7 +182,7 @@ NCR_D700_probe_one(struct NCR_D700_private *p, int > > siop, int irq, > > > > hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL); > > if (!hostdata) { > > - printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host" > > + printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host " > > "data, detatching\n", siop); > > return -ENOMEM; > > } > > If you're going to sneak in unrelated spelling/grammar changes, you might as > well do it unilaterally. drivers/scsi/NCR_D700.c | 4 ++-- drivers/scsi/aic7xxx_old.c | 2 +- drivers/scsi/dc395x.c | 2 +- drivers/scsi/hosts.c | 2 +- drivers/scsi/iscsi_tcp.c | 6 +++--- drivers/scsi/scsi_proc.c | 2 +- drivers/scsi/scsi_scan.c | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c index 9e64b21..36281c5 100644 --- a/drivers/scsi/NCR_D700.c +++ b/drivers/scsi/NCR_D700.c @@ -182,8 +182,8 @@ NCR_D700_probe_one(struct NCR_D700_private *p, int siop, int irq, hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL); if (!hostdata) { - printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host" - "data, detatching\n", siop); + printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host " + "data, detaching\n", siop); return -ENOMEM; } diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c index 8f8db5f..c79a452 100644 --- a/drivers/scsi/aic7xxx_old.c +++ b/drivers/scsi/aic7xxx_old.c @@ -3716,7 +3716,7 @@ aic7xxx_pci_intr(struct aic7xxx_host *p) pci_read_config_byte(p->pdev, PCI_STATUS + 1, &status1); if ( (status1 & DPE) && (aic7xxx_verbose & VERBOSE_MINOR_ERROR) ) - printk(WARN_LEAD "Data Parity Error during PCI address or PCI write" + printk(WARN_LEAD "Data Parity Error during PCI address or PCI write " "phase.\n", p->host_no, -1, -1, -1); if ( (status1 & SSE) && (aic7xxx_verbose & VERBOSE_MINOR_ERROR) ) printk(WARN_LEAD "Signal System Error Detected\n", p->host_no, diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index a9def6e..f98747c 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -1520,7 +1520,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb, } #endif if (acb->active_dcb) { - dprintkl(KERN_DEBUG, "start_scsi: (pid#%li) Attempt to start a" + dprintkl(KERN_DEBUG, "start_scsi: (pid#%li) Attempt to start a " "command while another command (pid#%li) is active.", srb->cmd->serial_number, acb->active_dcb->active_srb ? diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 24271a8..b53f681 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -141,7 +141,7 @@ int scsi_host_set_state(struct Scsi_Host *shost, enum scsi_host_state state) illegal: SCSI_LOG_ERROR_RECOVERY(1, shost_printk(KERN_ERR, shost, - "Illegal host state transition" + "Invalid host state transition " "%s->%s\n", scsi_host_state_name(oldstate), scsi_host_state_name(state))); diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 4bcf916..2e0d9a1 100644 --- a/drivers/scsi/iscsi_tcp.c +++ b/drivers/scsi/iscsi_tcp.c @@ -389,7 +389,7 @@ iscsi_r2t_rsp(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask) } if (r2t->data_length > session->max_burst) - debug_scsi("invalid R2T with data len %u and max burst %u." + debug_scsi("invalid R2T with data len %u and max burst %u. " "Attempting to execute request.\n", r2t->data_length, session->max_burst); @@ -900,13 +900,13 @@ more: memcpy(&recv_digest, conn->data, sizeof(uint32_t)); if (recv_digest != tcp_conn->in.datadgst) { - debug_tcp("iscsi_tcp: data digest error!" + debug_tcp("iscsi_tcp: data digest error! " "0x%x != 0x%x\n", recv_digest, tcp_conn->in.datadgst); iscsi_conn_failure(conn, ISCSI_ERR_DATA_DGST); return 0; } else { - debug_tcp("iscsi_tcp: data digest match!" + debug_tcp("iscsi_tcp: data digest match! " "0x%x == 0x%x\n", recv_digest, tcp_conn->in.datadgst); tcp_conn->in_progress = IN_PROGRESS_WAIT_HEADER; diff --git a/drivers/scsi/scsi_proc.c b/drivers/scsi/scsi_proc.c index bb6f051..781dc85 100644 --- a/drivers/scsi/scsi_proc.c +++ b/drivers/scsi/scsi_proc.c @@ -123,7 +123,7 @@ void scsi_proc_host_add(struct Scsi_Host *shost) p = create_proc_read_entry(name, S_IFREG | S_IRUGO | S_IWUSR, sht->proc_dir, proc_scsi_read, shost); if (!p) { - printk(KERN_ERR "%s: Failed to register host %d in" + printk(KERN_ERR "%s: Failed to register host %d in " "%s\n", __FUNCTION__, shost->host_no, sht->proc_name); return; diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 40ea71c..e0a47ed 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1124,7 +1124,7 @@ static void scsi_sequential_lun_scan(struct scsi_target *starget, unsigned int sparse_lun, lun, max_dev_lun; struct Scsi_Host *shost = dev_to_shost(starget->dev.parent); - SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO "scsi scan: Sequential scan of" + SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO "scsi scan: Sequential scan of " "%s\n", starget->dev.bus_id)); max_dev_lun = min(max_scsi_luns, shost->max_lun); ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <03356091a4d026aa495102d7da9509feffa4b2d8.1195454436.git.joe@perches.com>]
* [PATCH 45/59] drivers/serial: Add missing "space" [not found] ` <03356091a4d026aa495102d7da9509feffa4b2d8.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- drivers/serial/mpc52xx_uart.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c index ec36ad7..2fe8a7d 100644 --- a/drivers/serial/mpc52xx_uart.c +++ b/drivers/serial/mpc52xx_uart.c @@ -333,7 +333,7 @@ mpc52xx_uart_set_termios(struct uart_port *port, struct ktermios *new, if (!j) printk( KERN_ERR "mpc52xx_uart.c: " - "Unable to flush RX & TX fifos in-time in set_termios." + "Unable to flush RX & TX fifos in-time in set_termios. " "Some chars may have been lost.\n" ); /* Reset the TX & RX */ -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <e65bfe9bbcf02e9c9c6204e6b52b79e13dfaa446.1195454436.git.joe@perches.com>]
* [PATCH 46/59] drivers/usb: Add missing "space" [not found] ` <e65bfe9bbcf02e9c9c6204e6b52b79e13dfaa446.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 2:19 ` David Brownell 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Cc: David Brownell, Greg Kroah-Hartman, Thomas Dahlmann, info-linux, linux-usb-devel, linux-usb-users Signed-off-by: Joe Perches <joe@perches.com> --- drivers/usb/atm/ueagle-atm.c | 4 ++-- drivers/usb/gadget/amd5536udc.c | 2 +- drivers/usb/gadget/m66592-udc.c | 2 +- drivers/usb/gadget/net2280.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 389c5b1..fad5d91 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -1990,7 +1990,7 @@ static void uea_dispatch_cmv_e1(struct uea_softc *sc, struct intr_pkt *intr) return; bad2: - uea_err(INS_TO_USBDEV(sc), "unexpected cmv received," + uea_err(INS_TO_USBDEV(sc), "unexpected cmv received, " "Function : %d, Subfunction : %d\n", E1_FUNCTION_TYPE(cmv->bFunction), E1_FUNCTION_SUBTYPE(cmv->bFunction)); @@ -2038,7 +2038,7 @@ static void uea_dispatch_cmv_e4(struct uea_softc *sc, struct intr_pkt *intr) return; bad2: - uea_err(INS_TO_USBDEV(sc), "unexpected cmv received," + uea_err(INS_TO_USBDEV(sc), "unexpected cmv received, " "Function : %d, Subfunction : %d\n", E4_FUNCTION_TYPE(cmv->wFunction), E4_FUNCTION_SUBTYPE(cmv->wFunction)); diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c index c72e962..66e10da 100644 --- a/drivers/usb/gadget/amd5536udc.c +++ b/drivers/usb/gadget/amd5536udc.c @@ -1244,7 +1244,7 @@ udc_queue(struct usb_ep *usbep, struct usb_request *usbreq, gfp_t gfp) /* stop OUT naking */ if (!ep->in) { if (!use_dma && udc_rxfifo_pending) { - DBG(dev, "udc_queue(): pending bytes in" + DBG(dev, "udc_queue(): pending bytes in " "rxfifo after nyet\n"); /* * read pending bytes afer nyet: diff --git a/drivers/usb/gadget/m66592-udc.c b/drivers/usb/gadget/m66592-udc.c index ebc5536..20942be 100644 --- a/drivers/usb/gadget/m66592-udc.c +++ b/drivers/usb/gadget/m66592-udc.c @@ -709,7 +709,7 @@ static void irq_ep0_write(struct m66592_ep *ep, struct m66592_request *req) do { tmp = m66592_read(m66592, ep->fifoctr); if (i++ > 100000) { - printk(KERN_ERR "pipe0 is busy. maybe cpu i/o bus" + printk(KERN_ERR "pipe0 is busy. maybe cpu i/o bus " "conflict. please power off this controller."); return; } diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index d5d473f..33469cf 100644 --- a/drivers/usb/gadget/net2280.c +++ b/drivers/usb/gadget/net2280.c @@ -2435,7 +2435,7 @@ static void handle_stat0_irqs (struct net2280 *dev, u32 stat) break; default: delegate: - VDEBUG (dev, "setup %02x.%02x v%04x i%04x l%04x" + VDEBUG (dev, "setup %02x.%02x v%04x i%04x l%04x " "ep_cfg %08x\n", u.r.bRequestType, u.r.bRequest, w_value, w_index, w_length, -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 46/59] drivers/usb: Add missing "space" 2007-11-20 1:53 ` [PATCH 46/59] drivers/usb: " Joe Perches @ 2007-11-20 2:19 ` David Brownell 0 siblings, 0 replies; 103+ messages in thread From: David Brownell @ 2007-11-20 2:19 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, David Brownell, Greg Kroah-Hartman, Thomas Dahlmann, info-linux, linux-usb-devel, linux-usb-users On Monday 19 November 2007, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/usb/atm/ueagle-atm.c | 4 ++-- > drivers/usb/gadget/amd5536udc.c | 2 +- > drivers/usb/gadget/m66592-udc.c | 2 +- > drivers/usb/gadget/net2280.c | 2 +- ACK for the three USB peripheral controller drivers. > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c > index 389c5b1..fad5d91 100644 > --- a/drivers/usb/atm/ueagle-atm.c > +++ b/drivers/usb/atm/ueagle-atm.c > @@ -1990,7 +1990,7 @@ static void uea_dispatch_cmv_e1(struct uea_softc *sc, struct intr_pkt *intr) > return; > > bad2: > - uea_err(INS_TO_USBDEV(sc), "unexpected cmv received," > + uea_err(INS_TO_USBDEV(sc), "unexpected cmv received, " > "Function : %d, Subfunction : %d\n", > E1_FUNCTION_TYPE(cmv->bFunction), > E1_FUNCTION_SUBTYPE(cmv->bFunction)); > @@ -2038,7 +2038,7 @@ static void uea_dispatch_cmv_e4(struct uea_softc *sc, struct intr_pkt *intr) > return; > > bad2: > - uea_err(INS_TO_USBDEV(sc), "unexpected cmv received," > + uea_err(INS_TO_USBDEV(sc), "unexpected cmv received, " > "Function : %d, Subfunction : %d\n", > E4_FUNCTION_TYPE(cmv->wFunction), > E4_FUNCTION_SUBTYPE(cmv->wFunction)); > diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c > index c72e962..66e10da 100644 > --- a/drivers/usb/gadget/amd5536udc.c > +++ b/drivers/usb/gadget/amd5536udc.c > @@ -1244,7 +1244,7 @@ udc_queue(struct usb_ep *usbep, struct usb_request *usbreq, gfp_t gfp) > /* stop OUT naking */ > if (!ep->in) { > if (!use_dma && udc_rxfifo_pending) { > - DBG(dev, "udc_queue(): pending bytes in" > + DBG(dev, "udc_queue(): pending bytes in " > "rxfifo after nyet\n"); > /* > * read pending bytes afer nyet: > diff --git a/drivers/usb/gadget/m66592-udc.c b/drivers/usb/gadget/m66592-udc.c > index ebc5536..20942be 100644 > --- a/drivers/usb/gadget/m66592-udc.c > +++ b/drivers/usb/gadget/m66592-udc.c > @@ -709,7 +709,7 @@ static void irq_ep0_write(struct m66592_ep *ep, struct m66592_request *req) > do { > tmp = m66592_read(m66592, ep->fifoctr); > if (i++ > 100000) { > - printk(KERN_ERR "pipe0 is busy. maybe cpu i/o bus" > + printk(KERN_ERR "pipe0 is busy. maybe cpu i/o bus " > "conflict. please power off this controller."); > return; > } > diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c > index d5d473f..33469cf 100644 > --- a/drivers/usb/gadget/net2280.c > +++ b/drivers/usb/gadget/net2280.c > @@ -2435,7 +2435,7 @@ static void handle_stat0_irqs (struct net2280 *dev, u32 stat) > break; > default: > delegate: > - VDEBUG (dev, "setup %02x.%02x v%04x i%04x l%04x" > + VDEBUG (dev, "setup %02x.%02x v%04x i%04x l%04x " > "ep_cfg %08x\n", > u.r.bRequestType, u.r.bRequest, > w_value, w_index, w_length, > -- > 1.5.3.5.652.gf192c > ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <82a29b02f6151dd2d9a34d071e24f0726b8466d0.1195454436.git.joe@perches.com>]
* [PATCH 47/59] fs/ocfs2: Add missing "space" [not found] ` <82a29b02f6151dd2d9a34d071e24f0726b8466d0.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 2:13 ` Mark Fasheh 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel; +Cc: Kurt Hackel, Mark Fasheh, ocfs2-devel Signed-off-by: Joe Perches <joe@perches.com> --- fs/ocfs2/dlm/dlmmaster.c | 4 ++-- fs/ocfs2/inode.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c index 62e4a7d..a54d33d 100644 --- a/fs/ocfs2/dlm/dlmmaster.c +++ b/fs/ocfs2/dlm/dlmmaster.c @@ -908,7 +908,7 @@ lookup: * but they might own this lockres. wait on them. */ bit = find_next_bit(dlm->recovery_map, O2NM_MAX_NODES, 0); if (bit < O2NM_MAX_NODES) { - mlog(ML_NOTICE, "%s:%.*s: at least one node (%d) to" + mlog(ML_NOTICE, "%s:%.*s: at least one node (%d) to " "recover before lock mastery can begin\n", dlm->name, namelen, (char *)lockid, bit); wait_on_recovery = 1; @@ -962,7 +962,7 @@ redo_request: spin_lock(&dlm->spinlock); bit = find_next_bit(dlm->recovery_map, O2NM_MAX_NODES, 0); if (bit < O2NM_MAX_NODES) { - mlog(ML_NOTICE, "%s:%.*s: at least one node (%d) to" + mlog(ML_NOTICE, "%s:%.*s: at least one node (%d) to " "recover before lock mastery can begin\n", dlm->name, namelen, (char *)lockid, bit); wait_on_recovery = 1; diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 1d5e0cb..9e3e7df 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -863,7 +863,7 @@ static int ocfs2_query_inode_wipe(struct inode *inode, status = ocfs2_try_open_lock(inode, 1); if (status == -EAGAIN) { status = 0; - mlog(0, "Skipping delete of %llu because it is in use on" + mlog(0, "Skipping delete of %llu because it is in use on " "other nodes\n", (unsigned long long)oi->ip_blkno); goto bail; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 47/59] fs/ocfs2: Add missing "space" [not found] ` <82a29b02f6151dd2d9a34d071e24f0726b8466d0.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 47/59] fs/ocfs2: " Joe Perches @ 2007-11-20 2:13 ` Mark Fasheh 1 sibling, 0 replies; 103+ messages in thread From: Mark Fasheh @ 2007-11-20 2:13 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Kurt Hackel, ocfs2-devel On Mon, Nov 19, 2007 at 05:53:34PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > fs/ocfs2/dlm/dlmmaster.c | 4 ++-- > fs/ocfs2/inode.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Thanks, I'll put this in ocfs2.git. --Mark -- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@oracle.com ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <9668a3b988be3ea263473a390e297005695807ba.1195454436.git.joe@perches.com>]
* [PATCH 48/59] fs/proc: Add missing "space" [not found] ` <9668a3b988be3ea263473a390e297005695807ba.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- fs/proc/vmcore.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index 523e109..7c7b3ed 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -521,7 +521,7 @@ static int __init parse_crash_elf64_headers(void) ehdr.e_ehsize != sizeof(Elf64_Ehdr) || ehdr.e_phentsize != sizeof(Elf64_Phdr) || ehdr.e_phnum == 0) { - printk(KERN_WARNING "Warning: Core image elf header is not" + printk(KERN_WARNING "Warning: Core image elf header is not " "sane\n"); return -EINVAL; } @@ -577,7 +577,7 @@ static int __init parse_crash_elf32_headers(void) ehdr.e_ehsize != sizeof(Elf32_Ehdr) || ehdr.e_phentsize != sizeof(Elf32_Phdr) || ehdr.e_phnum == 0) { - printk(KERN_WARNING "Warning: Core image elf header is not" + printk(KERN_WARNING "Warning: Core image elf header is not " "sane\n"); return -EINVAL; } @@ -621,8 +621,8 @@ static int __init parse_crash_elf_headers(void) if (rc < 0) return rc; if (memcmp(e_ident, ELFMAG, SELFMAG) != 0) { - printk(KERN_WARNING "Warning: Core image elf header" - " not found\n"); + printk(KERN_WARNING "Warning: Core image elf header " + "not found\n"); return -EINVAL; } @@ -641,8 +641,8 @@ static int __init parse_crash_elf_headers(void) /* Determine vmcore size. */ vmcore_size = get_vmcore_size_elf32(elfcorebuf); } else { - printk(KERN_WARNING "Warning: Core image elf header is not" - " sane\n"); + printk(KERN_WARNING "Warning: Core image elf header is not " + "sane\n"); return -EINVAL; } return 0; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
[parent not found: <ffd427b1785990d5c177b795ce4f9a9fc4d614ec.1195454436.git.joe@perches.com>]
* [PATCH 49/59] fs/ufs: Add missing "space" [not found] ` <ffd427b1785990d5c177b795ce4f9a9fc4d614ec.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-22 4:02 ` Evgeniy Dushistov 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel; +Cc: Evgeniy Dushistov, linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- fs/ufs/dir.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c index 30f8c2b..d19dfe8 100644 --- a/fs/ufs/dir.c +++ b/fs/ufs/dir.c @@ -180,7 +180,7 @@ bad_entry: Eend: p = (struct ufs_dir_entry *)(kaddr + offs); ufs_error (sb, "ext2_check_page", - "entry in directory #%lu spans the page boundary" + "entry in directory #%lu spans the page boundary " "offset=%lu", dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs); fail: -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 49/59] fs/ufs: Add missing "space" 2007-11-20 1:53 ` [PATCH 49/59] fs/ufs: " Joe Perches @ 2007-11-22 4:02 ` Evgeniy Dushistov 0 siblings, 0 replies; 103+ messages in thread From: Evgeniy Dushistov @ 2007-11-22 4:02 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel On Mon, Nov 19, 2007 at 05:53:36PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > fs/ufs/dir.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c > index 30f8c2b..d19dfe8 100644 > --- a/fs/ufs/dir.c > +++ b/fs/ufs/dir.c > @@ -180,7 +180,7 @@ bad_entry: > Eend: > p = (struct ufs_dir_entry *)(kaddr + offs); > ufs_error (sb, "ext2_check_page", If you touch this code, it will be good, if you also replace "ext2_check_page" with something like __FUNCTION__. > - "entry in directory #%lu spans the page boundary" > + "entry in directory #%lu spans the page boundary " > "offset=%lu", > dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs); > fail: > -- > 1.5.3.5.652.gf192c -- /Evgeniy ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <9a9f50d85954bdc384d07e363cc586161a37f93b.1195454436.git.joe@perches.com>]
* [PATCH 50/59] net/bridge: Add missing "space" [not found] ` <9a9f50d85954bdc384d07e363cc586161a37f93b.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 7:48 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Cc: Bart De Schuymer, Networking Team, Patrick McHardy, coreteam, ebtables-devel, ebtables-user, netfilter-devel, netfilter Signed-off-by: Joe Perches <joe@perches.com> --- net/bridge/netfilter/ebt_among.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bridge/netfilter/ebt_among.c b/net/bridge/netfilter/ebt_among.c index 392d877..6436d30 100644 --- a/net/bridge/netfilter/ebt_among.c +++ b/net/bridge/netfilter/ebt_among.c @@ -187,7 +187,7 @@ static int ebt_among_check(const char *tablename, unsigned int hookmask, if (datalen != EBT_ALIGN(expected_length)) { printk(KERN_WARNING - "ebtables: among: wrong size: %d" + "ebtables: among: wrong size: %d " "against expected %d, rounded to %Zd\n", datalen, expected_length, EBT_ALIGN(expected_length)); -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 50/59] net/bridge: Add missing "space" 2007-11-20 1:53 ` [PATCH 50/59] net/bridge: " Joe Perches @ 2007-11-20 7:48 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 7:48 UTC (permalink / raw) To: joe Cc: linux-kernel, bart.de.schuymer, netdev, kaber, coreteam, ebtables-devel, ebtables-user, netfilter-devel, netfilter From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:53:37 -0800 > > Signed-off-by: Joe Perches <joe@perches.com> Applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <29542305a25cef11c0f5f7e978d9bf50ef60b4b3.1195454436.git.joe@perches.com>]
* [PATCH 51/59] net/dccp: Add missing "space" [not found] ` <29542305a25cef11c0f5f7e978d9bf50ef60b4b3.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 7:48 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel; +Cc: Arnaldo Carvalho de Melo, Networking Team, dccp Signed-off-by: Joe Perches <joe@perches.com> --- net/dccp/ccids/lib/loss_interval.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/dccp/ccids/lib/loss_interval.c b/net/dccp/ccids/lib/loss_interval.c index 40ad428..d26b88d 100644 --- a/net/dccp/ccids/lib/loss_interval.c +++ b/net/dccp/ccids/lib/loss_interval.c @@ -166,7 +166,7 @@ static u32 dccp_li_calc_first_li(struct sock *sk, } if (unlikely(interval == 0)) { - DCCP_WARN("%s(%p), Could not find a win_count interval > 0." + DCCP_WARN("%s(%p), Could not find a win_count interval > 0. " "Defaulting to 1\n", dccp_role(sk), sk); interval = 1; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 51/59] net/dccp: Add missing "space" 2007-11-20 1:53 ` [PATCH 51/59] net/dccp: " Joe Perches @ 2007-11-20 7:48 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 7:48 UTC (permalink / raw) To: joe; +Cc: linux-kernel, acme, netdev, dccp From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:53:38 -0800 > Signed-off-by: Joe Perches <joe@perches.com> Applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <f047768599df11a74301f81e61903c87417ea9e4.1195454436.git.joe@perches.com>]
* [PATCH 52/59] net/ipv4: Add missing "space" [not found] ` <f047768599df11a74301f81e61903c87417ea9e4.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 7:48 ` David Miller 2007-11-20 6:59 ` Simon Horman 1 sibling, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Cc: Pekka Savola (ipv6), Alexey Kuznetsov, David S. Miller, Hideaki YOSHIFUJI, James Morris, Networking Team, Patrick McHardy, coreteam, netfilter-devel, netfilter Signed-off-by: Joe Perches <joe@perches.com> --- net/ipv4/ipvs/ip_vs_core.c | 2 +- net/ipv4/netfilter/iptable_raw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipvs/ip_vs_core.c b/net/ipv4/ipvs/ip_vs_core.c index 20c884a..8fba202 100644 --- a/net/ipv4/ipvs/ip_vs_core.c +++ b/net/ipv4/ipvs/ip_vs_core.c @@ -637,7 +637,7 @@ static int ip_vs_out_icmp(struct sk_buff *skb, int *related) verdict = NF_DROP; if (IP_VS_FWD_METHOD(cp) != 0) { - IP_VS_ERR("shouldn't reach here, because the box is on the" + IP_VS_ERR("shouldn't reach here, because the box is on the " "half connection in the tun/dr module.\n"); } diff --git a/net/ipv4/netfilter/iptable_raw.c b/net/ipv4/netfilter/iptable_raw.c index 5de6e57..f867865 100644 --- a/net/ipv4/netfilter/iptable_raw.c +++ b/net/ipv4/netfilter/iptable_raw.c @@ -66,7 +66,7 @@ ipt_local_hook(unsigned int hook, if (skb->len < sizeof(struct iphdr) || ip_hdrlen(skb) < sizeof(struct iphdr)) { if (net_ratelimit()) - printk("iptable_raw: ignoring short SOCK_RAW" + printk("iptable_raw: ignoring short SOCK_RAW " "packet.\n"); return NF_ACCEPT; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 52/59] net/ipv4: Add missing "space" 2007-11-20 1:53 ` [PATCH 52/59] net/ipv4: " Joe Perches @ 2007-11-20 7:48 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 7:48 UTC (permalink / raw) To: joe Cc: linux-kernel, pekkas, kuznet, yoshfuji, jmorris, netdev, kaber, coreteam, netfilter-devel, netfilter From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:53:39 -0800 > > Signed-off-by: Joe Perches <joe@perches.com> Applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
* Re: [PATCH 52/59] net/ipv4: Add missing "space" [not found] ` <f047768599df11a74301f81e61903c87417ea9e4.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 52/59] net/ipv4: " Joe Perches @ 2007-11-20 6:59 ` Simon Horman 1 sibling, 0 replies; 103+ messages in thread From: Simon Horman @ 2007-11-20 6:59 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Pekka Savola (ipv6), Alexey Kuznetsov, David S. Miller, Hideaki YOSHIFUJI, James Morris, Networking Team, Patrick McHardy, coreteam, netfilter-devel, netfilter On Mon, Nov 19, 2007 at 05:53:39PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Simon Horman <horms@verge.net.au> > --- > net/ipv4/ipvs/ip_vs_core.c | 2 +- > net/ipv4/netfilter/iptable_raw.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/ipv4/ipvs/ip_vs_core.c b/net/ipv4/ipvs/ip_vs_core.c > index 20c884a..8fba202 100644 > --- a/net/ipv4/ipvs/ip_vs_core.c > +++ b/net/ipv4/ipvs/ip_vs_core.c > @@ -637,7 +637,7 @@ static int ip_vs_out_icmp(struct sk_buff *skb, int *related) > verdict = NF_DROP; > > if (IP_VS_FWD_METHOD(cp) != 0) { > - IP_VS_ERR("shouldn't reach here, because the box is on the" > + IP_VS_ERR("shouldn't reach here, because the box is on the " > "half connection in the tun/dr module.\n"); > } > > diff --git a/net/ipv4/netfilter/iptable_raw.c b/net/ipv4/netfilter/iptable_raw.c > index 5de6e57..f867865 100644 > --- a/net/ipv4/netfilter/iptable_raw.c > +++ b/net/ipv4/netfilter/iptable_raw.c > @@ -66,7 +66,7 @@ ipt_local_hook(unsigned int hook, > if (skb->len < sizeof(struct iphdr) || > ip_hdrlen(skb) < sizeof(struct iphdr)) { > if (net_ratelimit()) > - printk("iptable_raw: ignoring short SOCK_RAW" > + printk("iptable_raw: ignoring short SOCK_RAW " > "packet.\n"); > return NF_ACCEPT; > } > -- > 1.5.3.5.652.gf192c > > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Horms ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <e6a341b03ca9134b944d3021738a795c4e9085c7.1195454436.git.joe@perches.com>]
* [PATCH 53/59] net/ipv6: Add missing "space" [not found] ` <e6a341b03ca9134b944d3021738a795c4e9085c7.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 7:48 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Cc: Pekka Savola (ipv6), Alexey Kuznetsov, David S. Miller, Hideaki YOSHIFUJI, James Morris, Networking Team, Patrick McHardy Signed-off-by: Joe Perches <joe@perches.com> --- net/ipv6/addrconf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 1bd8d81..567664e 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -967,7 +967,7 @@ int ipv6_dev_get_saddr(struct net_device *daddr_dev, if (unlikely(score.addr_type == IPV6_ADDR_ANY || score.addr_type & IPV6_ADDR_MULTICAST)) { LIMIT_NETDEBUG(KERN_DEBUG - "ADDRCONF: unspecified / multicast address" + "ADDRCONF: unspecified / multicast address " "assigned as unicast address on %s", dev->name); continue; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 53/59] net/ipv6: Add missing "space" 2007-11-20 1:53 ` [PATCH 53/59] net/ipv6: " Joe Perches @ 2007-11-20 7:48 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 7:48 UTC (permalink / raw) To: joe; +Cc: linux-kernel, pekkas, kuznet, yoshfuji, jmorris, netdev, kaber From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:53:40 -0800 > > Signed-off-by: Joe Perches <joe@perches.com> Applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <40f9ed858135b417a27a0a628667cc0da0d91e73.1195454436.git.joe@perches.com>]
* [PATCH 54/59] net/irda: Add missing "space" [not found] ` <40f9ed858135b417a27a0a628667cc0da0d91e73.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 7:49 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel; +Cc: Networking Team, Samuel Ortiz Signed-off-by: Joe Perches <joe@perches.com> --- net/irda/iriap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/irda/iriap.c b/net/irda/iriap.c index dc5e34a..a86a5d8 100644 --- a/net/irda/iriap.c +++ b/net/irda/iriap.c @@ -928,7 +928,7 @@ void iriap_call_indication(struct iriap_cb *self, struct sk_buff *skb) opcode = fp[0]; if (~opcode & 0x80) { - IRDA_WARNING("%s: IrIAS multiframe commands or results" + IRDA_WARNING("%s: IrIAS multiframe commands or results " "is not implemented yet!\n", __FUNCTION__); return; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 54/59] net/irda: Add missing "space" 2007-11-20 1:53 ` [PATCH 54/59] net/irda: " Joe Perches @ 2007-11-20 7:49 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 7:49 UTC (permalink / raw) To: joe; +Cc: linux-kernel, netdev, samuel From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:53:41 -0800 > > Signed-off-by: Joe Perches <joe@perches.com> Applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <c7b79830e5796ae4499e169a357b575320fb0fe0.1195454436.git.joe@perches.com>]
* [PATCH 55/59] net/sctp: Add missing "space" [not found] ` <c7b79830e5796ae4499e169a357b575320fb0fe0.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 7:49 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Cc: Networking Team, Sridhar Samudrala, Vlad Yasevich, lksctp-developers Signed-off-by: Joe Perches <joe@perches.com> --- net/sctp/sm_statefuns.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 5ebbe80..b8bbb96 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -1146,7 +1146,7 @@ sctp_disposition_t sctp_sf_backbeat_8_3(const struct sctp_endpoint *ep, /* Check if the timestamp looks valid. */ if (time_after(hbinfo->sent_at, jiffies) || time_after(jiffies, hbinfo->sent_at + max_interval)) { - SCTP_DEBUG_PRINTK("%s: HEARTBEAT ACK with invalid timestamp" + SCTP_DEBUG_PRINTK("%s: HEARTBEAT ACK with invalid timestamp " "received for transport: %p\n", __FUNCTION__, link); return SCTP_DISPOSITION_DISCARD; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 55/59] net/sctp: Add missing "space" 2007-11-20 1:53 ` [PATCH 55/59] net/sctp: " Joe Perches @ 2007-11-20 7:49 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 7:49 UTC (permalink / raw) To: joe; +Cc: linux-kernel, netdev, sri, vladislav.yasevich, lksctp-developers From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:53:42 -0800 > > Signed-off-by: Joe Perches <joe@perches.com> Applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <4a6aeee33cf9dc9a3e329e73b6bc584b7650ed51.1195454436.git.joe@perches.com>]
* [PATCH 56/59] net/sunrpc: Add missing "space" [not found] ` <4a6aeee33cf9dc9a3e329e73b6bc584b7650ed51.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 7:49 ` David Miller 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel Cc: J. Bruce Fields, Neil Brown, Networking Team, Trond Myklebust, linux-kernel, nfs Signed-off-by: Joe Perches <joe@perches.com> --- net/sunrpc/auth_gss/auth_gss.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 53995af..22906b8 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -967,7 +967,7 @@ gss_validate(struct rpc_task *task, __be32 *p) if (maj_stat == GSS_S_CONTEXT_EXPIRED) clear_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags); if (maj_stat) { - dprintk("RPC: %5u gss_validate: gss_verify_mic returned" + dprintk("RPC: %5u gss_validate: gss_verify_mic returned " "error 0x%08x\n", task->tk_pid, maj_stat); goto out_bad; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 56/59] net/sunrpc: Add missing "space" 2007-11-20 1:53 ` [PATCH 56/59] net/sunrpc: " Joe Perches @ 2007-11-20 7:49 ` David Miller 0 siblings, 0 replies; 103+ messages in thread From: David Miller @ 2007-11-20 7:49 UTC (permalink / raw) To: joe; +Cc: linux-kernel, bfields, neilb, netdev, trond.myklebust, nfs From: Joe Perches <joe@perches.com> Date: Mon, 19 Nov 2007 17:53:43 -0800 > > Signed-off-by: Joe Perches <joe@perches.com> Applied. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <33ce09d8744eb1941b300c2a9986ae29d0660e02.1195454436.git.joe@perches.com>]
* [PATCH 57/59] security/selinux: Add missing "space" [not found] ` <33ce09d8744eb1941b300c2a9986ae29d0660e02.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-20 3:10 ` James Morris 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel; +Cc: Eric Paris, James Morris, Stephen Smalley, linux-kernel Signed-off-by: Joe Perches <joe@perches.com> --- security/selinux/ss/avtab.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/security/selinux/ss/avtab.c b/security/selinux/ss/avtab.c index 9e70a16..cd10e27 100644 --- a/security/selinux/ss/avtab.c +++ b/security/selinux/ss/avtab.c @@ -280,7 +280,7 @@ int avtab_alloc(struct avtab *h, u32 nrules) h->nel = 0; h->nslot = nslot; h->mask = mask; - printk(KERN_DEBUG "SELinux:%d avtab hash slots allocated." + printk(KERN_DEBUG "SELinux:%d avtab hash slots allocated. " "Num of rules:%d\n", h->nslot, nrules); return 0; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 57/59] security/selinux: Add missing "space" 2007-11-20 1:53 ` [PATCH 57/59] security/selinux: " Joe Perches @ 2007-11-20 3:10 ` James Morris 0 siblings, 0 replies; 103+ messages in thread From: James Morris @ 2007-11-20 3:10 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Eric Paris, Stephen Smalley Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris <jmorris@namei.org> ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <5dcd734c020cccb2215a61da5eb4728e2d7ef8db.1195454436.git.joe@perches.com>]
* [PATCH 58/59] sound/isa: Add missing "space" [not found] ` <5dcd734c020cccb2215a61da5eb4728e2d7ef8db.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 2007-11-26 7:25 ` Takashi Iwai 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel; +Cc: Jaroslav Kysela Signed-off-by: Joe Perches <joe@perches.com> --- sound/isa/sc6000.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c index 94daf83..bc0c379 100644 --- a/sound/isa/sc6000.c +++ b/sound/isa/sc6000.c @@ -390,7 +390,7 @@ static int __devinit sc6000_init_board(char __iomem *vport, int irq, int dma, err = sc6000_init_mss(vport, config, vmss_port, mss_config); if (err < 0) { - snd_printk(KERN_ERR "Can not initialize" + snd_printk(KERN_ERR "Can not initialize " "Microsoft Sound System mode.\n"); return -ENODEV; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 58/59] sound/isa: Add missing "space" 2007-11-20 1:53 ` [PATCH 58/59] sound/isa: " Joe Perches @ 2007-11-26 7:25 ` Takashi Iwai 0 siblings, 0 replies; 103+ messages in thread From: Takashi Iwai @ 2007-11-26 7:25 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Jaroslav Kysela At Mon, 19 Nov 2007 17:53:45 -0800, Joe Perches wrote: > > > Signed-off-by: Joe Perches <joe@perches.com> Applied to ALSA tree. Thanks. Takashi > --- > sound/isa/sc6000.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c > index 94daf83..bc0c379 100644 > --- a/sound/isa/sc6000.c > +++ b/sound/isa/sc6000.c > @@ -390,7 +390,7 @@ static int __devinit sc6000_init_board(char __iomem *vport, int irq, int dma, > > err = sc6000_init_mss(vport, config, vmss_port, mss_config); > if (err < 0) { > - snd_printk(KERN_ERR "Can not initialize" > + snd_printk(KERN_ERR "Can not initialize " > "Microsoft Sound System mode.\n"); > return -ENODEV; > } > -- > 1.5.3.5.652.gf192c > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <e138039432625a469859ede2281982263db71cac.1195454436.git.joe@perches.com>]
* [PATCH 59/59] sound/oss: Add missing "space" [not found] ` <e138039432625a469859ede2281982263db71cac.1195454436.git.joe@perches.com> @ 2007-11-20 1:53 ` Joe Perches 0 siblings, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:53 UTC (permalink / raw) To: linux-kernel; +Cc: Jaroslav Kysela, Riccardo Facchetti Signed-off-by: Joe Perches <joe@perches.com> --- sound/oss/aedsp16.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/oss/aedsp16.c b/sound/oss/aedsp16.c index 51e1fde..f0d2bd9 100644 --- a/sound/oss/aedsp16.c +++ b/sound/oss/aedsp16.c @@ -1092,7 +1092,7 @@ static int __init aedsp16_init_board(void) if (ae_config.mss_base != -1) { if (ae_config.init & INIT_MSS) { if (aedsp16_init_mss(ae_config.base_io) == FALSE) { - printk("[AEDSP16] Can not initialize" + printk("[AEDSP16] Can not initialize " "Microsoft Sound System mode.\n"); return FALSE; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 01/59] arch/ia64: Add missing "space" [not found] <ee1678e1bc8b80b7ae420059fffc7241486ea91a.1195454434.git.joe@perches.com> ` (55 preceding siblings ...) [not found] ` <e138039432625a469859ede2281982263db71cac.1195454436.git.joe@perches.com> @ 2007-11-20 6:54 ` Simon Horman 2007-11-20 7:09 ` Joe Perches [not found] ` <d9fb5d88f80db783c403b0d7c8e13c1e82c9ad32.1195454435.git.joe@perches.com> ` (3 subsequent siblings) 60 siblings, 1 reply; 103+ messages in thread From: Simon Horman @ 2007-11-20 6:54 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Jes Sorensen, Tony Luck, linux-altix, linux-ia64 [snip] > diff --git a/arch/ia64/kernel/kprobes.c b/arch/ia64/kernel/kprobes.c > index 5fd65d8..90518e4 100644 > --- a/arch/ia64/kernel/kprobes.c > +++ b/arch/ia64/kernel/kprobes.c > @@ -182,8 +182,8 @@ static int __kprobes unsupported_inst(uint template, uint slot, > qp = kprobe_inst & 0x3f; > if (is_cmp_ctype_unc_inst(template, slot, major_opcode, kprobe_inst)) { > if (slot == 1 && qp) { > - printk(KERN_WARNING "Kprobes on cmp unc" > - "instruction on slot 1 at <0x%lx>" > + printk(KERN_WARNING "Kprobes on cmp unc " > + "instruction on slot 1 at <0x%lx> " > "is not supported\n", addr); > return -EINVAL; > > @@ -221,8 +221,8 @@ static int __kprobes unsupported_inst(uint template, uint slot, > * bit 12 to be equal to 1 > */ > if (slot == 1 && qp) { > - printk(KERN_WARNING "Kprobes on test bit" > - "instruction on slot at <0x%lx>" > + printk(KERN_WARNING "Kprobes on test bit " > + "instruction on slot at <0x%lx> " > "is not supported\n", addr); > return -EINVAL; > } Is it really neccessary for this fragment to create a line that is greater than 80 characters long? Persumably the entire reason that the printk line was split in the first place was to avoid a long line. [snip] -- Horms ^ permalink raw reply [flat|nested] 103+ messages in thread
* Re: [PATCH 01/59] arch/ia64: Add missing "space" 2007-11-20 6:54 ` [PATCH 01/59] arch/ia64: " Simon Horman @ 2007-11-20 7:09 ` Joe Perches 2007-11-20 7:41 ` Simon Horman 0 siblings, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 7:09 UTC (permalink / raw) To: Simon Horman Cc: linux-kernel, Jes Sorensen, Tony Luck, linux-altix, linux-ia64 On Tue, 2007-11-20 at 15:54 +0900, Simon Horman wrote: > Is it really neccessary for this fragment to create a line that > is greater than 80 characters long? Persumably the entire reason > that the printk line was split in the first place was to avoid > a long line. No. Many other lines in that source file are > 80 char. My initial preference was to reformat the indented lines to the printk open parenthesis, but the minimal change seemed better. cheers, Joe ^ permalink raw reply [flat|nested] 103+ messages in thread
* Re: [PATCH 01/59] arch/ia64: Add missing "space" 2007-11-20 7:09 ` Joe Perches @ 2007-11-20 7:41 ` Simon Horman 0 siblings, 0 replies; 103+ messages in thread From: Simon Horman @ 2007-11-20 7:41 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Jes Sorensen, Tony Luck, linux-altix, linux-ia64 On Mon, Nov 19, 2007 at 11:09:25PM -0800, Joe Perches wrote: > On Tue, 2007-11-20 at 15:54 +0900, Simon Horman wrote: > > Is it really neccessary for this fragment to create a line that > > is greater than 80 characters long? Persumably the entire reason > > that the printk line was split in the first place was to avoid > > a long line. > > No. Many other lines in that source file are > 80 char. That may be so, but surely adding another one makes things slightly worse. > My initial preference was to reformat the indented lines to the > printk open parenthesis, but the minimal change seemed better. > > cheers, Joe -- Horms ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <d9fb5d88f80db783c403b0d7c8e13c1e82c9ad32.1195454435.git.joe@perches.com>]
* [PATCH 39/59] drivers/s390: Add missing "space" [not found] ` <d9fb5d88f80db783c403b0d7c8e13c1e82c9ad32.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 8:52 ` Heiko Carstens 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Cc: Frank Blaschka, Swen Schillig, Ursula Braun, linux-s390, linux390 Signed-off-by: Joe Perches <joe@perches.com> --- drivers/s390/char/monwriter.c | 2 +- drivers/s390/char/vmlogrdr.c | 2 +- drivers/s390/cio/chsc.c | 2 +- drivers/s390/net/claw.c | 2 +- drivers/s390/net/lcs.c | 2 +- drivers/s390/scsi/zfcp_fsf.c | 10 +++++----- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/s390/char/monwriter.c b/drivers/s390/char/monwriter.c index 20442fb..a86c053 100644 --- a/drivers/s390/char/monwriter.c +++ b/drivers/s390/char/monwriter.c @@ -295,7 +295,7 @@ module_init(mon_init); module_exit(mon_exit); module_param_named(max_bufs, mon_max_bufs, int, 0644); -MODULE_PARM_DESC(max_bufs, "Maximum number of sample monitor data buffers" +MODULE_PARM_DESC(max_bufs, "Maximum number of sample monitor data buffers " "that can be active at one time"); MODULE_AUTHOR("Melissa Howland <Melissa.Howland@us.ibm.com>"); diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c index e0c4c50..d364e0b 100644 --- a/drivers/s390/char/vmlogrdr.c +++ b/drivers/s390/char/vmlogrdr.c @@ -683,7 +683,7 @@ static int vmlogrdr_register_driver(void) /* Register with iucv driver */ ret = iucv_register(&vmlogrdr_iucv_handler, 1); if (ret) { - printk (KERN_ERR "vmlogrdr: failed to register with" + printk (KERN_ERR "vmlogrdr: failed to register with " "iucv driver\n"); goto out; } diff --git a/drivers/s390/cio/chsc.c b/drivers/s390/cio/chsc.c index 597c0c7..bda3ea6 100644 --- a/drivers/s390/cio/chsc.c +++ b/drivers/s390/cio/chsc.c @@ -1075,7 +1075,7 @@ chsc_determine_css_characteristics(void) scsc_area = (void *)get_zeroed_page(GFP_KERNEL | GFP_DMA); if (!scsc_area) { - CIO_MSG_EVENT(0, "Was not able to determine available" + CIO_MSG_EVENT(0, "Was not able to determine available " "CHSCs due to no memory.\n"); return -ENOMEM; } diff --git a/drivers/s390/net/claw.c b/drivers/s390/net/claw.c index 3561982..f63b518 100644 --- a/drivers/s390/net/claw.c +++ b/drivers/s390/net/claw.c @@ -2416,7 +2416,7 @@ init_ccw_bk(struct net_device *dev) privptr->p_buff_pages_perwrite); #endif if (p_buff==NULL) { - printk(KERN_INFO "%s:%s __get_free_pages" + printk(KERN_INFO "%s:%s __get_free_pages " "for writes buf failed : get is for %d pages\n", dev->name, __FUNCTION__, diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c index 0fd663b..7bfe8d7 100644 --- a/drivers/s390/net/lcs.c +++ b/drivers/s390/net/lcs.c @@ -1115,7 +1115,7 @@ list_modified: rc = lcs_send_setipm(card, ipm); spin_lock_irqsave(&card->ipm_lock, flags); if (rc) { - PRINT_INFO("Adding multicast address failed." + PRINT_INFO("Adding multicast address failed. " "Table possibly full!\n"); /* store ipm in failed list -> will be added * to ipm_list again, so a retry will be done diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c index ff866eb..260b1ce 100644 --- a/drivers/s390/scsi/zfcp_fsf.c +++ b/drivers/s390/scsi/zfcp_fsf.c @@ -502,7 +502,7 @@ zfcp_fsf_fsfstatus_qual_eval(struct zfcp_fsf_req *fsf_req) fsf_req->status |= ZFCP_STATUS_FSFREQ_ERROR; break; case FSF_SQ_NO_RECOM: - ZFCP_LOG_NORMAL("bug: No recommendation could be given for a" + ZFCP_LOG_NORMAL("bug: No recommendation could be given for a " "problem on the adapter %s " "Stopping all operations on this adapter. ", zfcp_get_busid_by_adapter(fsf_req->adapter)); @@ -813,7 +813,7 @@ zfcp_fsf_status_read_port_closed(struct zfcp_fsf_req *fsf_req) read_unlock_irqrestore(&zfcp_data.config_lock, flags); if (!port || (port->d_id != (status_buffer->d_id & ZFCP_DID_MASK))) { - ZFCP_LOG_NORMAL("bug: Reopen port indication received for" + ZFCP_LOG_NORMAL("bug: Reopen port indication received for " "nonexisting port with d_id 0x%06x on " "adapter %s. Ignored.\n", status_buffer->d_id & ZFCP_DID_MASK, @@ -2280,7 +2280,7 @@ zfcp_fsf_exchange_port_data(struct zfcp_erp_action *erp_action) &lock_flags, &fsf_req); if (retval) { ZFCP_LOG_INFO("error: Out of resources. Could not create an " - "exchange port data request for" + "exchange port data request for " "the adapter %s.\n", zfcp_get_busid_by_adapter(adapter)); write_unlock_irqrestore(&adapter->request_queue.queue_lock, @@ -2339,7 +2339,7 @@ zfcp_fsf_exchange_port_data_sync(struct zfcp_adapter *adapter, 0, NULL, &lock_flags, &fsf_req); if (retval) { ZFCP_LOG_INFO("error: Out of resources. Could not create an " - "exchange port data request for" + "exchange port data request for " "the adapter %s.\n", zfcp_get_busid_by_adapter(adapter)); write_unlock_irqrestore(&adapter->request_queue.queue_lock, @@ -4725,7 +4725,7 @@ zfcp_fsf_req_create(struct zfcp_adapter *adapter, u32 fsf_cmd, int req_flags, /* allocate new FSF request */ fsf_req = zfcp_fsf_req_alloc(pool, req_flags); if (unlikely(NULL == fsf_req)) { - ZFCP_LOG_DEBUG("error: Could not put an FSF request into" + ZFCP_LOG_DEBUG("error: Could not put an FSF request into " "the outbound (send) queue.\n"); ret = -ENOMEM; goto failed_fsf_req; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 39/59] drivers/s390: Add missing "space" [not found] ` <d9fb5d88f80db783c403b0d7c8e13c1e82c9ad32.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 39/59] drivers/s390: " Joe Perches @ 2007-11-20 8:52 ` Heiko Carstens 1 sibling, 0 replies; 103+ messages in thread From: Heiko Carstens @ 2007-11-20 8:52 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Frank Blaschka, Swen Schillig, Ursula Braun, linux-s390, linux390 On Mon, Nov 19, 2007 at 05:48:31PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/s390/char/monwriter.c | 2 +- > drivers/s390/char/vmlogrdr.c | 2 +- > drivers/s390/cio/chsc.c | 2 +- > drivers/s390/net/claw.c | 2 +- > drivers/s390/net/lcs.c | 2 +- > drivers/s390/scsi/zfcp_fsf.c | 10 +++++----- > 6 files changed, 10 insertions(+), 10 deletions(-) Applied as well. Thanks. ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <5908c0bbfc91b572502351586cdf98fe9ca9aeec.1195454435.git.joe@perches.com>]
* [PATCH 35/59] drivers/net/wireless: Add missing "space" [not found] ` <5908c0bbfc91b572502351586cdf98fe9ca9aeec.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 16:41 ` Dan Williams 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel Cc: Dan Williams, Jeff Garzik, Larry Finger, Michael Buesch, Stefano Brivio, libertas-dev, linux-wireless, netdev Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/wireless/b43/phy.c | 2 +- drivers/net/wireless/b43legacy/phy.c | 2 +- drivers/net/wireless/bcm43xx/bcm43xx_phy.c | 2 +- drivers/net/wireless/libertas/wext.c | 2 +- drivers/net/wireless/netwave_cs.c | 2 +- drivers/net/wireless/p54usb.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/b43/phy.c b/drivers/net/wireless/b43/phy.c index 3d4ed64..7ff091e 100644 --- a/drivers/net/wireless/b43/phy.c +++ b/drivers/net/wireless/b43/phy.c @@ -2214,7 +2214,7 @@ int b43_phy_init_tssi2dbm_table(struct b43_wldev *dev) } dyn_tssi2dbm = kmalloc(64, GFP_KERNEL); if (dyn_tssi2dbm == NULL) { - b43err(dev->wl, "Could not allocate memory" + b43err(dev->wl, "Could not allocate memory " "for tssi2dbm table\n"); return -ENOMEM; } diff --git a/drivers/net/wireless/b43legacy/phy.c b/drivers/net/wireless/b43legacy/phy.c index 22a4b3d..491e518 100644 --- a/drivers/net/wireless/b43legacy/phy.c +++ b/drivers/net/wireless/b43legacy/phy.c @@ -2020,7 +2020,7 @@ int b43legacy_phy_init_tssi2dbm_table(struct b43legacy_wldev *dev) phy->idle_tssi = 62; dyn_tssi2dbm = kmalloc(64, GFP_KERNEL); if (dyn_tssi2dbm == NULL) { - b43legacyerr(dev->wl, "Could not allocate memory" + b43legacyerr(dev->wl, "Could not allocate memory " "for tssi2dbm table\n"); return -ENOMEM; } diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_phy.c b/drivers/net/wireless/bcm43xx/bcm43xx_phy.c index b37f1e3..af3de33 100644 --- a/drivers/net/wireless/bcm43xx/bcm43xx_phy.c +++ b/drivers/net/wireless/bcm43xx/bcm43xx_phy.c @@ -2149,7 +2149,7 @@ int bcm43xx_phy_init_tssi2dbm_table(struct bcm43xx_private *bcm) } dyn_tssi2dbm = kmalloc(64, GFP_KERNEL); if (dyn_tssi2dbm == NULL) { - printk(KERN_ERR PFX "Could not allocate memory" + printk(KERN_ERR PFX "Could not allocate memory " "for tssi2dbm table\n"); return -ENOMEM; } diff --git a/drivers/net/wireless/libertas/wext.c b/drivers/net/wireless/libertas/wext.c index c6f5aa3..395b788 100644 --- a/drivers/net/wireless/libertas/wext.c +++ b/drivers/net/wireless/libertas/wext.c @@ -1528,7 +1528,7 @@ static int wlan_set_encodeext(struct net_device *dev, && (ext->key_len != KEY_LEN_WPA_TKIP)) || ((alg == IW_ENCODE_ALG_CCMP) && (ext->key_len != KEY_LEN_WPA_AES))) { - lbs_deb_wext("invalid size %d for key of alg" + lbs_deb_wext("invalid size %d for key of alg " "type %d\n", ext->key_len, alg); diff --git a/drivers/net/wireless/netwave_cs.c b/drivers/net/wireless/netwave_cs.c index 2402cb8..d2fa079 100644 --- a/drivers/net/wireless/netwave_cs.c +++ b/drivers/net/wireless/netwave_cs.c @@ -806,7 +806,7 @@ static int netwave_pcmcia_config(struct pcmcia_device *link) { for (i = 0; i < 6; i++) dev->dev_addr[i] = readb(ramBase + NETWAVE_EREG_PA + i); - printk(KERN_INFO "%s: Netwave: port %#3lx, irq %d, mem %lx" + printk(KERN_INFO "%s: Netwave: port %#3lx, irq %d, mem %lx, " "id %c%c, hw_addr %s\n", dev->name, dev->base_addr, dev->irq, (u_long) ramBase, diff --git a/drivers/net/wireless/p54usb.c b/drivers/net/wireless/p54usb.c index 755482a..60d286e 100644 --- a/drivers/net/wireless/p54usb.c +++ b/drivers/net/wireless/p54usb.c @@ -308,7 +308,7 @@ static int p54u_read_eeprom(struct ieee80211_hw *dev) buf = kmalloc(0x2020, GFP_KERNEL); if (!buf) { - printk(KERN_ERR "prism54usb: cannot allocate memory for" + printk(KERN_ERR "prism54usb: cannot allocate memory for " "eeprom readback!\n"); return -ENOMEM; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [PATCH 35/59] drivers/net/wireless: Add missing "space" [not found] ` <5908c0bbfc91b572502351586cdf98fe9ca9aeec.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 35/59] drivers/net/wireless: " Joe Perches @ 2007-11-20 16:41 ` Dan Williams 1 sibling, 0 replies; 103+ messages in thread From: Dan Williams @ 2007-11-20 16:41 UTC (permalink / raw) To: Joe Perches Cc: linux-kernel, Jeff Garzik, Larry Finger, Michael Buesch, Stefano Brivio, libertas-dev, linux-wireless, netdev On Mon, 2007-11-19 at 17:48 -0800, Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/wireless/b43/phy.c | 2 +- > drivers/net/wireless/b43legacy/phy.c | 2 +- > drivers/net/wireless/bcm43xx/bcm43xx_phy.c | 2 +- > drivers/net/wireless/libertas/wext.c | 2 +- > drivers/net/wireless/netwave_cs.c | 2 +- > drivers/net/wireless/p54usb.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/wireless/b43/phy.c b/drivers/net/wireless/b43/phy.c > index 3d4ed64..7ff091e 100644 > --- a/drivers/net/wireless/b43/phy.c > +++ b/drivers/net/wireless/b43/phy.c > @@ -2214,7 +2214,7 @@ int b43_phy_init_tssi2dbm_table(struct b43_wldev *dev) > } > dyn_tssi2dbm = kmalloc(64, GFP_KERNEL); > if (dyn_tssi2dbm == NULL) { > - b43err(dev->wl, "Could not allocate memory" > + b43err(dev->wl, "Could not allocate memory " > "for tssi2dbm table\n"); > return -ENOMEM; > } > diff --git a/drivers/net/wireless/b43legacy/phy.c b/drivers/net/wireless/b43legacy/phy.c > index 22a4b3d..491e518 100644 > --- a/drivers/net/wireless/b43legacy/phy.c > +++ b/drivers/net/wireless/b43legacy/phy.c > @@ -2020,7 +2020,7 @@ int b43legacy_phy_init_tssi2dbm_table(struct b43legacy_wldev *dev) > phy->idle_tssi = 62; > dyn_tssi2dbm = kmalloc(64, GFP_KERNEL); > if (dyn_tssi2dbm == NULL) { > - b43legacyerr(dev->wl, "Could not allocate memory" > + b43legacyerr(dev->wl, "Could not allocate memory " > "for tssi2dbm table\n"); > return -ENOMEM; > } > diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_phy.c b/drivers/net/wireless/bcm43xx/bcm43xx_phy.c > index b37f1e3..af3de33 100644 > --- a/drivers/net/wireless/bcm43xx/bcm43xx_phy.c > +++ b/drivers/net/wireless/bcm43xx/bcm43xx_phy.c > @@ -2149,7 +2149,7 @@ int bcm43xx_phy_init_tssi2dbm_table(struct bcm43xx_private *bcm) > } > dyn_tssi2dbm = kmalloc(64, GFP_KERNEL); > if (dyn_tssi2dbm == NULL) { > - printk(KERN_ERR PFX "Could not allocate memory" > + printk(KERN_ERR PFX "Could not allocate memory " > "for tssi2dbm table\n"); > return -ENOMEM; > } > diff --git a/drivers/net/wireless/libertas/wext.c b/drivers/net/wireless/libertas/wext.c > index c6f5aa3..395b788 100644 > --- a/drivers/net/wireless/libertas/wext.c > +++ b/drivers/net/wireless/libertas/wext.c > @@ -1528,7 +1528,7 @@ static int wlan_set_encodeext(struct net_device *dev, > && (ext->key_len != KEY_LEN_WPA_TKIP)) > || ((alg == IW_ENCODE_ALG_CCMP) > && (ext->key_len != KEY_LEN_WPA_AES))) { > - lbs_deb_wext("invalid size %d for key of alg" > + lbs_deb_wext("invalid size %d for key of alg " > "type %d\n", > ext->key_len, > alg); Acked-by: Dan Williams <dcbw@redhat.com> > diff --git a/drivers/net/wireless/netwave_cs.c b/drivers/net/wireless/netwave_cs.c > index 2402cb8..d2fa079 100644 > --- a/drivers/net/wireless/netwave_cs.c > +++ b/drivers/net/wireless/netwave_cs.c > @@ -806,7 +806,7 @@ static int netwave_pcmcia_config(struct pcmcia_device *link) { > for (i = 0; i < 6; i++) > dev->dev_addr[i] = readb(ramBase + NETWAVE_EREG_PA + i); > > - printk(KERN_INFO "%s: Netwave: port %#3lx, irq %d, mem %lx" > + printk(KERN_INFO "%s: Netwave: port %#3lx, irq %d, mem %lx, " > "id %c%c, hw_addr %s\n", > dev->name, dev->base_addr, dev->irq, > (u_long) ramBase, > diff --git a/drivers/net/wireless/p54usb.c b/drivers/net/wireless/p54usb.c > index 755482a..60d286e 100644 > --- a/drivers/net/wireless/p54usb.c > +++ b/drivers/net/wireless/p54usb.c > @@ -308,7 +308,7 @@ static int p54u_read_eeprom(struct ieee80211_hw *dev) > > buf = kmalloc(0x2020, GFP_KERNEL); > if (!buf) { > - printk(KERN_ERR "prism54usb: cannot allocate memory for" > + printk(KERN_ERR "prism54usb: cannot allocate memory for " > "eeprom readback!\n"); > return -ENOMEM; > } ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <fbeb04f6d7134565611741ad0148e1b401362ef9.1195454434.git.joe@perches.com>]
* [PATCH 08/59] arch/um: Add missing "space" [not found] ` <fbeb04f6d7134565611741ad0148e1b401362ef9.1195454434.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-20 17:05 ` [uml-devel] " Jeff Dike 1 sibling, 0 replies; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Jeff Dike, user-mode-linux-devel, user-mode-linux-user Signed-off-by: Joe Perches <joe@perches.com> --- arch/um/drivers/vde_user.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/um/drivers/vde_user.c b/arch/um/drivers/vde_user.c index d9941fe..56533db 100644 --- a/arch/um/drivers/vde_user.c +++ b/arch/um/drivers/vde_user.c @@ -80,7 +80,7 @@ void vde_init_libstuff(struct vde_data *vpri, struct vde_init *init) vpri->args = kmalloc(sizeof(struct vde_open_args), UM_GFP_KERNEL); if (vpri->args == NULL) { - printk(UM_KERN_ERR "vde_init_libstuff - vde_open_args" + printk(UM_KERN_ERR "vde_init_libstuff - vde_open_args " "allocation failed"); return; } -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [uml-devel] [PATCH 08/59] arch/um: Add missing "space" [not found] ` <fbeb04f6d7134565611741ad0148e1b401362ef9.1195454434.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 08/59] arch/um: " Joe Perches @ 2007-11-20 17:05 ` Jeff Dike 1 sibling, 0 replies; 103+ messages in thread From: Jeff Dike @ 2007-11-20 17:05 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, user-mode-linux-user, user-mode-linux-devel On Mon, Nov 19, 2007 at 05:48:00PM -0800, Joe Perches wrote: > - printk(UM_KERN_ERR "vde_init_libstuff - vde_open_args" > + printk(UM_KERN_ERR "vde_init_libstuff - vde_open_args " Applied, thanks. Jeff -- Work email - jdike at linux dot intel dot com ^ permalink raw reply [flat|nested] 103+ messages in thread
[parent not found: <e2a957ca2937d67956712a66e7388dcd2f95cf90.1195454435.git.joe@perches.com>]
* [PATCH 15/59] drivers/hwmon: Add missing "space" [not found] ` <e2a957ca2937d67956712a66e7388dcd2f95cf90.1195454435.git.joe@perches.com> @ 2007-11-20 1:48 ` Joe Perches 2007-11-21 18:37 ` [lm-sensors] " Jean Delvare 2007-12-06 13:21 ` Mark M. Hoffman 1 sibling, 1 reply; 103+ messages in thread From: Joe Perches @ 2007-11-20 1:48 UTC (permalink / raw) To: linux-kernel; +Cc: Mark M. Hoffman, Roger Lucas, lm-sensors Signed-off-by: Joe Perches <joe@perches.com> --- drivers/hwmon/vt8231.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c index 2196a84..f876617 100644 --- a/drivers/hwmon/vt8231.c +++ b/drivers/hwmon/vt8231.c @@ -504,7 +504,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr, case 4: data->fan_div[nr] = 2; break; case 8: data->fan_div[nr] = 3; break; default: - dev_err(dev, "fan_div value %ld not supported." + dev_err(dev, "fan_div value %ld not supported. " "Choose one of 1, 2, 4 or 8!\n", val); mutex_unlock(&data->update_lock); return -EINVAL; -- 1.5.3.5.652.gf192c ^ permalink raw reply related [flat|nested] 103+ messages in thread
* Re: [lm-sensors] [PATCH 15/59] drivers/hwmon: Add missing "space" 2007-11-20 1:48 ` [PATCH 15/59] drivers/hwmon: " Joe Perches @ 2007-11-21 18:37 ` Jean Delvare 0 siblings, 0 replies; 103+ messages in thread From: Jean Delvare @ 2007-11-21 18:37 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Mark M. Hoffman, lm-sensors Hi Joe, On Mon, 19 Nov 2007 17:48:07 -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/hwmon/vt8231.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c > index 2196a84..f876617 100644 > --- a/drivers/hwmon/vt8231.c > +++ b/drivers/hwmon/vt8231.c > @@ -504,7 +504,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr, > case 4: data->fan_div[nr] = 2; break; > case 8: data->fan_div[nr] = 3; break; > default: > - dev_err(dev, "fan_div value %ld not supported." > + dev_err(dev, "fan_div value %ld not supported. " > "Choose one of 1, 2, 4 or 8!\n", val); > mutex_unlock(&data->update_lock); > return -EINVAL; Obviously correct, thanks. Acked-by: Jean Delvare <khali@linux-fr.org> -- Jean Delvare ^ permalink raw reply [flat|nested] 103+ messages in thread
* Re: [PATCH 15/59] drivers/hwmon: Add missing "space" [not found] ` <e2a957ca2937d67956712a66e7388dcd2f95cf90.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 15/59] drivers/hwmon: " Joe Perches @ 2007-12-06 13:21 ` Mark M. Hoffman 1 sibling, 0 replies; 103+ messages in thread From: Mark M. Hoffman @ 2007-12-06 13:21 UTC (permalink / raw) To: Joe Perches; +Cc: linux-kernel, Roger Lucas, lm-sensors * Joe Perches <joe@perches.com> [2007-11-19 17:48:07 -0800]: > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/hwmon/vt8231.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c > index 2196a84..f876617 100644 > --- a/drivers/hwmon/vt8231.c > +++ b/drivers/hwmon/vt8231.c > @@ -504,7 +504,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr, > case 4: data->fan_div[nr] = 2; break; > case 8: data->fan_div[nr] = 3; break; > default: > - dev_err(dev, "fan_div value %ld not supported." > + dev_err(dev, "fan_div value %ld not supported. " > "Choose one of 1, 2, 4 or 8!\n", val); > mutex_unlock(&data->update_lock); > return -EINVAL; > -- > 1.5.3.5.652.gf192c Applied to hwmon-2.6.git/testing, thanks. -- Mark M. Hoffman mhoffman@lightlink.com ^ permalink raw reply [flat|nested] 103+ messages in thread
end of thread, other threads:[~2007-12-06 13:24 UTC | newest] Thread overview: 103+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <ee1678e1bc8b80b7ae420059fffc7241486ea91a.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 00/59] trivial - Add missing "space" in multiline quoted strings Joe Perches 2007-11-20 1:47 ` [PATCH 01/59] arch/ia64: Add missing "space" Joe Perches [not found] ` <23f0badf8dab73294c2aa142fafb9301ca843e88.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 02/59] arch/mips: " Joe Perches 2007-11-21 22:34 ` Ralf Baechle [not found] ` <0c0c76b8a44447bbeb8b0b502f5b4f2750bd8cc6.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 03/59] arch/powerpc: " Joe Perches [not found] ` <351afce2b8242a88389176a36d5bf75935385fdd.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 04/59] arch/ppc: " Joe Perches [not found] ` <ebeb1446c117c71636bb6f2308645a85f81edac5.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 05/59] arch/s390: " Joe Perches 2007-11-20 8:27 ` Heiko Carstens [not found] ` <afdfa525934b9dada1a5b7b459486d923dc0e780.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 06/59] arch/sparc: " Joe Perches 2007-11-20 7:45 ` David Miller 2007-11-20 7:48 ` Joe Perches 2007-11-20 8:05 ` David Miller [not found] ` <2cb1c8daa0f34a5506b88cf5b350660896c8a45b.1195454434.git.joe@perches.com> 2007-11-20 1:47 ` [PATCH 07/59] arch/sparc64: " Joe Perches 2007-11-20 7:43 ` David Miller [not found] ` <c2f1bd6f19828452d5916728ebaa8d5f1bd0b152.1195454434.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 09/59] arch/x86: " Joe Perches 2007-11-20 2:05 ` Dave Jones [not found] ` <07a846daef42aa7262f9e08a8be5c3ed8684ed77.1195454434.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 10/59] drivers/acpi: " Joe Perches 2007-11-20 2:53 ` Len Brown [not found] ` <06ac5c8ff3114d38896fe59a453dd1b77b11cdec.1195454434.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 11/59] drivers/block: " Joe Perches [not found] ` <51d5cae73b21c33174340db0e389ac810bba63fa.1195454434.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 12/59] drivers/cdrom: " Joe Perches [not found] ` <552e08f56ca307c471834197a8e880045b4f024e.1195454434.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 13/59] drivers/char: " Joe Perches [not found] ` <f6014cdba9a3d017d1dcd0623a5da61777c919bb.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 14/59] drivers/cpufreq: " Joe Perches 2007-11-20 2:06 ` Dave Jones [not found] ` <239a2d17c4e7f18b0aa0f34e1856f4d72a38e0d8.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 16/59] drivers/i2c: " Joe Perches 2007-11-20 19:51 ` Jean Delvare [not found] ` <3c52bdbf8c60392df6b4fc91e6188f4a382b5310.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 17/59] drivers/ide: " Joe Perches 2007-11-22 21:23 ` Bartlomiej Zolnierkiewicz [not found] ` <00c276347dd7ef0da4abbb8e7f2c0aa776e685c2.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 18/59] drivers/ieee1394: " Joe Perches 2007-11-22 19:23 ` Stefan Richter [not found] ` <de3db785bf1d8f7f5ae308ca366794cc3e5def83.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 19/59] drivers/infiniband: " Joe Perches 2007-11-20 21:14 ` Roland Dreier [not found] ` <f56e301a22202f30e5443b129f4ea15fa20c5226.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 20/59] drivers/input: " Joe Perches [not found] ` <d82909a235a0ca88319aaf7990fc94f7ebb649bb.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 21/59] drivers/isdn: " Joe Perches [not found] ` <e898ed30e34f209e9309667be632d75945672cd5.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 22/59] drivers/macintosh: " Joe Perches [not found] ` <5ce69261b8ce239633c31431c61538234b0f8065.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 23/59] drivers/media/dvb: " Joe Perches [not found] ` <150c45e2fd3ccb01decbe9aff70d13fb45b347b7.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 24/59] drivers/media/radio: " Joe Perches [not found] ` <8cdb362d494c702f6f0cf095e8e24435550bf5ce.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 25/59] drivers/media/video: " Joe Perches 2007-11-20 2:24 ` [v4l-dvb-maintainer] " Brandon Philips 2007-11-20 4:08 ` Joe Perches 2007-11-20 12:06 ` Mauro Carvalho Chehab [not found] ` <48f19e3c182fdbd1ccd30b544209f962d16d7dc9.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 26/59] drivers/message: " Joe Perches [not found] ` <0b52e7ee42f854a4f4f6873a7a7bc496a7247d3c.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 27/59] drivers/misc: " Joe Perches [not found] ` <3ad6205457781910c10dd7261e606de0bf7bafac.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 28/59] drivers/mtd: " Joe Perches [not found] ` <6a2d5da40bdf6d7a6595ac2482dd88b7182a74b1.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 29/59] drivers/net/chelsio: " Joe Perches 2007-11-24 1:57 ` Jeff Garzik [not found] ` <1020259349705ef83d6011e837dce32c1f08299c.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 30/59] drivers/net/cxgb3: " Joe Perches [not found] ` <3723ae7bfde66a86c6bf3b044dfbd63b144623d9.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 31/59] drivers/net/ixgb: " Joe Perches 2007-11-26 23:16 ` Kok, Auke [not found] ` <3ed0b0aee275e6a8632b1be454a61f3a2b73639c.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 32/59] drivers/net/netxen: " Joe Perches [not found] ` <938a74cb7895afece561b299f11d28785214bade.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 33/59] drivers/net/sk98lin: " Joe Perches [not found] ` <8c0ecd8ae2baa9b0596d352f53c4c3527f3528bd.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 34/59] drivers/net/wan: " Joe Perches 2007-11-20 23:52 ` Krzysztof Halasa [not found] ` <fef2c4f213c930a3c1c1e58c8961249886621caa.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 36/59] drivers/net: " Joe Perches [not found] ` <b56ad31ff9f8151583eaf50f5adb924b2e0ccb88.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 37/59] drivers/pci: " Joe Perches [not found] ` <d04f5b45e26dfc3ae3e8f69f01e3a20738f14b32.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 38/59] drivers/rtc: " Joe Perches [not found] ` <f9ffd78f5eb1f49e89fc578611de786ae7b9ac87.1195454436.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 40/59] drivers/scsi/aic7xxx: " Joe Perches [not found] ` <6cd7c30e31d1e1a732eeb7f08636afa5061d5f44.1195454436.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 41/59] drivers/scsi/aic94xx: " Joe Perches [not found] ` <0d5c0d474aaeba86c0899848a6eb16ef92d308bc.1195454436.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 42/59] drivers/scsi/lpfc: " Joe Perches [not found] ` <769fa1b17e5b66a91e59e7c5899b6747b39b5731.1195454436.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 43/59] drivers/scsi/qla4xxx: " Joe Perches 2007-11-20 1:53 ` Joe Perches [not found] ` <adb8f5a3245d3e618c861f99db3acd43362c92c7.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 44/59] drivers/scsi: " Joe Perches 2007-11-20 10:39 ` Alistair John Strachan 2007-11-20 15:17 ` Joe Perches [not found] ` <03356091a4d026aa495102d7da9509feffa4b2d8.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 45/59] drivers/serial: " Joe Perches [not found] ` <e65bfe9bbcf02e9c9c6204e6b52b79e13dfaa446.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 46/59] drivers/usb: " Joe Perches 2007-11-20 2:19 ` David Brownell [not found] ` <82a29b02f6151dd2d9a34d071e24f0726b8466d0.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 47/59] fs/ocfs2: " Joe Perches 2007-11-20 2:13 ` Mark Fasheh [not found] ` <9668a3b988be3ea263473a390e297005695807ba.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 48/59] fs/proc: " Joe Perches [not found] ` <ffd427b1785990d5c177b795ce4f9a9fc4d614ec.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 49/59] fs/ufs: " Joe Perches 2007-11-22 4:02 ` Evgeniy Dushistov [not found] ` <9a9f50d85954bdc384d07e363cc586161a37f93b.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 50/59] net/bridge: " Joe Perches 2007-11-20 7:48 ` David Miller [not found] ` <29542305a25cef11c0f5f7e978d9bf50ef60b4b3.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 51/59] net/dccp: " Joe Perches 2007-11-20 7:48 ` David Miller [not found] ` <f047768599df11a74301f81e61903c87417ea9e4.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 52/59] net/ipv4: " Joe Perches 2007-11-20 7:48 ` David Miller 2007-11-20 6:59 ` Simon Horman [not found] ` <e6a341b03ca9134b944d3021738a795c4e9085c7.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 53/59] net/ipv6: " Joe Perches 2007-11-20 7:48 ` David Miller [not found] ` <40f9ed858135b417a27a0a628667cc0da0d91e73.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 54/59] net/irda: " Joe Perches 2007-11-20 7:49 ` David Miller [not found] ` <c7b79830e5796ae4499e169a357b575320fb0fe0.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 55/59] net/sctp: " Joe Perches 2007-11-20 7:49 ` David Miller [not found] ` <4a6aeee33cf9dc9a3e329e73b6bc584b7650ed51.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 56/59] net/sunrpc: " Joe Perches 2007-11-20 7:49 ` David Miller [not found] ` <33ce09d8744eb1941b300c2a9986ae29d0660e02.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 57/59] security/selinux: " Joe Perches 2007-11-20 3:10 ` James Morris [not found] ` <5dcd734c020cccb2215a61da5eb4728e2d7ef8db.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 58/59] sound/isa: " Joe Perches 2007-11-26 7:25 ` Takashi Iwai [not found] ` <e138039432625a469859ede2281982263db71cac.1195454436.git.joe@perches.com> 2007-11-20 1:53 ` [PATCH 59/59] sound/oss: " Joe Perches 2007-11-20 6:54 ` [PATCH 01/59] arch/ia64: " Simon Horman 2007-11-20 7:09 ` Joe Perches 2007-11-20 7:41 ` Simon Horman [not found] ` <d9fb5d88f80db783c403b0d7c8e13c1e82c9ad32.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 39/59] drivers/s390: " Joe Perches 2007-11-20 8:52 ` Heiko Carstens [not found] ` <5908c0bbfc91b572502351586cdf98fe9ca9aeec.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 35/59] drivers/net/wireless: " Joe Perches 2007-11-20 16:41 ` Dan Williams [not found] ` <fbeb04f6d7134565611741ad0148e1b401362ef9.1195454434.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 08/59] arch/um: " Joe Perches 2007-11-20 17:05 ` [uml-devel] " Jeff Dike [not found] ` <e2a957ca2937d67956712a66e7388dcd2f95cf90.1195454435.git.joe@perches.com> 2007-11-20 1:48 ` [PATCH 15/59] drivers/hwmon: " Joe Perches 2007-11-21 18:37 ` [lm-sensors] " Jean Delvare 2007-12-06 13:21 ` Mark M. Hoffman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).