From: Matt Mackall <mpm@selenic.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: bryan.wu@analog.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: blackfin compile error
Date: Wed, 06 Feb 2008 10:23:35 -0600 [thread overview]
Message-ID: <1202315015.17934.242.camel@cinder.waste.org> (raw)
In-Reply-To: <20080206151830.GI505@cs181133002.pp.htv.fi>
On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
> Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
>
> <-- snip -->
>
> ...
> CC mm/vmscan.o
> In file included from
> /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
> make[2]: *** [mm/vmscan.o] Error 1
This suggests that no one's tried to compile -mm on Blackfin since
before September, I think.
Is there somewhere more appropriate to move it? I can't find one.
Failing that, we can wrap it in CONFIG_MMU, I suppose.
Signed-off-by: Matt Mackall <mpm@selenic.com>
diff -r 50a6e531a9f2 include/linux/swapops.h
--- a/include/linux/swapops.h Mon Feb 04 20:23:02 2008 -0600
+++ b/include/linux/swapops.h Wed Feb 06 10:21:32 2008 -0600
@@ -42,11 +42,13 @@
return entry.val & SWP_OFFSET_MASK(entry);
}
+#ifdef CONFIG_MMU
/* check whether a pte points to a swap entry */
static inline int is_swap_pte(pte_t pte)
{
return !pte_none(pte) && !pte_present(pte) && !pte_file(pte);
}
+#endif
/*
* Convert the arch-dependent pte representation of a swp_entry_t into an
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-02-06 16:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 15:18 blackfin compile error Adrian Bunk
2008-02-06 16:23 ` Matt Mackall [this message]
2008-02-06 19:12 ` Robin Getz
2008-02-06 19:37 ` Andrew Morton
2008-02-07 7:26 ` Bryan Wu
2008-02-07 16:03 ` Mike Frysinger
2008-02-07 19:37 ` Bryan Wu
2008-02-07 20:31 ` Mike Frysinger
2008-02-07 21:32 ` Robin Getz
2008-02-08 5:25 ` Mike Frysinger
2008-02-08 18:53 ` Bryan Wu
2008-02-08 20:04 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2007-12-02 0:42 Adrian Bunk
2007-12-02 6:42 ` Bryan Wu
2007-12-02 6:59 ` David Brownell
2007-12-02 7:05 ` Andrew Morton
2007-12-03 1:30 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202315015.17934.242.camel@cinder.waste.org \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).