From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Bryan Wu" <cooloney.lkml@gmail.com>,
"Adrian Bunk" <bunk@kernel.org>, "Bryan Wu" <bryan.wu@analog.com>,
linux-kernel@vger.kernel.org
Subject: Re: blackfin compile error
Date: Sun, 2 Dec 2007 17:30:43 -0800 [thread overview]
Message-ID: <200712021730.44208.david-b@pacbell.net> (raw)
In-Reply-To: <20071201230501.dac3b217.akpm@linux-foundation.org>
On Saturday 01 December 2007, Andrew Morton wrote:
> I have all these:
>
> spi-at25-driver-is-for-eeprom-not-flash.patch
I'd be tempted to merge that since it's documentation-only,
and I like to see such stuff merged ASAP. But otherwise
it's non-essential.
> spi-use-mutex-not-semaphore.patch
Non-essential.
> spi-simplify-spi_sync-calling-convention.patch
> spi-use-simplified-spi_sync-calling-convention.patch
The first one fixes some minor bugs, so would be good to merge.
The second does minor associated cleanup ... non-essential.
> #
> spi-initial-bf54x-spi-support.patch
> spi-bfin-spi-uses-portmux-calls.patch
> spi-spi_bfin-cleanups-error-handling.patch
> spi-spi_bfin-handles-spi_transfercs_change.patch
> spi-spi_bfin-dont-bypass-spi-framework.patch
> spi-spi_bfin-uses-platform-device-resources.patch
> spi-spi_bfin-uses-portmux-for-additional-busses.patch
> spi-spi_bfin-rearrange-portmux-calls.patch
> spi-spi_bfin-change-handling-of-communication-parameters.patch
> spi-spi_bfin-relocate-spin-waits.patch
> spi-spi_bfin-handle-multiple-spi_masters.patch
> spi-spi_bfin-bugfix-for-816-bit-word-sizes.patch
> spi-spi_bfin-update-handling-of-delay-after-deselect.patch
> spi-spi_bfin-resequence-dma-start-stop.patch
> #
> blackfin-spi-driver-use-cpu_relax-to-replace-continue-in-while-busywait.patch
> blackfin-spi-driver-use-void-__iomem-for-regs_base.patch
> blackfin-spi-driver-move-hard-coded-pin_req-to-board-file.patch
> blackfin-spi-driver-reconfigure-speed_hz-and-bits_per_word-in-each-spi-transfer.patch
The fix to the compile error is in the next-to-last of these.
Bryan says they're highly interdependent, and they also
include quite a number of bugfixes (some "critical") that
have been used in Analog's treee for many months now.
That makes sense to me, since they've been bouncing around
for quite a while now. I'd be OK with merging all of them;
if something breaks, it'd be no worse than the current state
(and would only affect Blackfin).
> atmel_spi-throughput-improvement.patch
> atmel_spi-chain-dma-transfers.patch
> atmel_spi-fix-dmachain-oops-with-debug-enabled.patch
Those can wait; they're performance updates.
> queued for 2.6.25. If some of them need to be bumped up to 2.6.24: which
> ones and why?
I'd say all those Blackfin patches should go, and the one
calling convention patch, are appropriate as bugfixes.
And the doc patch, unless there's a reason to hold it back.
- Dave
next prev parent reply other threads:[~2007-12-03 1:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 0:42 blackfin compile error Adrian Bunk
2007-12-02 6:42 ` Bryan Wu
2007-12-02 6:59 ` David Brownell
2007-12-02 7:05 ` Andrew Morton
2007-12-03 1:30 ` David Brownell [this message]
2008-02-06 15:18 Adrian Bunk
2008-02-06 16:23 ` Matt Mackall
2008-02-06 19:12 ` Robin Getz
2008-02-06 19:37 ` Andrew Morton
2008-02-07 7:26 ` Bryan Wu
2008-02-07 16:03 ` Mike Frysinger
2008-02-07 19:37 ` Bryan Wu
2008-02-07 20:31 ` Mike Frysinger
2008-02-07 21:32 ` Robin Getz
2008-02-08 5:25 ` Mike Frysinger
2008-02-08 18:53 ` Bryan Wu
2008-02-08 20:04 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712021730.44208.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=bunk@kernel.org \
--cc=cooloney.lkml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).