From: William Cohen <wcohen@redhat.com>
To: John Garry <john.garry@huawei.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
jolsa@redhat.com, alexander.shishkin@linux.intel.com,
namhyung@kernel.org, ak@linux.intel.com, will.deacon@arm.com,
ganapatrao.kulkarni@cavium.com, catalin.marinas@arm.com,
mark.rutland@arm.com
Cc: xuwei5@hisilicon.com, linuxarm@huawei.com,
zhangshaokun@hisilicon.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/5] perf events patches for improved ARM64 support
Date: Wed, 6 Dec 2017 11:42:38 -0500 [thread overview]
Message-ID: <12034446-ccc9-9a88-6b2c-3318216f4817@redhat.com> (raw)
In-Reply-To: <1512490399-94107-1-git-send-email-john.garry@huawei.com>
On 12/05/2017 11:13 AM, John Garry wrote:
> This patchset adds support for some perf events features,
> targeted at ARM64, implemented in a generic fashion.
>
> The two main features are as follows:
> - support for arch/vendor/platform pmu events directory structure
> - support for parsing architecture recommended pmu events
>
> On the back of these, the Cavium ThunderX2 and HiSilicon hip08
> JSONs are relocated/added.
>
> TODO:
> - Documentation needs to be updated for recommended
> events format in the JSON
> - tidy up patches a bit
>
> John Garry (5):
> perf jevents: add support for pmu events vendor subdirectory
> perf jevents: add support for arch recommended events
> perf vendor events arm64: add armv8 recommended events JSON
> perf vendor events arm64: relocate thunderx2 JSON
> perf vendor events arm64: add HiSilicon hip08 JSON
>
> .../pmu-events/arch/arm64/armv8-recommended.json | 452 +++++++++++++++++++++
> .../arch/arm64/cavium/thunderx2-imp-def.json | 62 ---
> .../arch/arm64/cavium/thunderx2/core-imp-def.json | 32 ++
> .../arch/arm64/hisilicon/hip08/core-imp-def.json | 122 ++++++
> tools/perf/pmu-events/arch/arm64/mapfile.csv | 3 +-
> tools/perf/pmu-events/jevents.c | 272 ++++++++++++-
> 6 files changed, 859 insertions(+), 84 deletions(-)
> create mode 100644 tools/perf/pmu-events/arch/arm64/armv8-recommended.json
> delete mode 100644 tools/perf/pmu-events/arch/arm64/cavium/thunderx2-imp-def.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/cavium/thunderx2/core-imp-def.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/core-imp-def.json
>
Hi,
How is this code dealing with the possible different configurations within the aach64 architecture? For example the Cortex-A53 implementations may exclude the L2 cache and not have L2 cache events implemented? Is there some way that perf could make use of the PMCEID0 and PMCEID1 register information to accurately get the subset of events the processor supports? Using this information could eliminate a lot of busy work adding implementation specific descriptions due to slight implementation differences.
-Will Cohen
next prev parent reply other threads:[~2017-12-06 16:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 16:13 [RFC PATCH 0/5] perf events patches for improved ARM64 support John Garry
2017-12-05 16:13 ` [RFC PATCH 1/5] perf jevents: add support for pmu events vendor subdirectory John Garry
2017-12-06 13:38 ` Jiri Olsa
2017-12-06 14:41 ` John Garry
2017-12-05 16:13 ` [RFC PATCH 2/5] perf jevents: add support for arch recommended events John Garry
2017-12-05 17:27 ` Andi Kleen
2017-12-06 8:34 ` John Garry
2017-12-06 13:36 ` Jiri Olsa
2017-12-06 15:20 ` John Garry
2017-12-08 12:29 ` Jiri Olsa
2017-12-08 15:42 ` John Garry
2017-12-09 7:31 ` Jiri Olsa
2017-12-11 10:25 ` John Garry
2017-12-15 11:22 ` John Garry
2017-12-16 18:47 ` Andi Kleen
2018-01-02 12:07 ` John Garry
2018-01-02 17:48 ` Andi Kleen
2018-01-03 12:22 ` John Garry
2017-12-21 19:39 ` Jiri Olsa
2018-01-04 17:17 ` John Garry
2018-01-08 14:08 ` Jiri Olsa
2017-12-06 13:37 ` Jiri Olsa
2017-12-06 14:40 ` John Garry
2017-12-08 12:31 ` Jiri Olsa
2017-12-08 15:38 ` John Garry
2017-12-09 7:26 ` Jiri Olsa
2017-12-05 16:13 ` [RFC PATCH 3/5] perf vendor events arm64: add armv8 recommended events JSON John Garry
2017-12-05 16:13 ` [RFC PATCH 4/5] perf vendor events arm64: relocate thunderx2 JSON John Garry
2017-12-05 16:13 ` [RFC PATCH 5/5] perf vendor events arm64: add HiSilicon hip08 JSON John Garry
2017-12-06 16:42 ` William Cohen [this message]
2017-12-06 17:35 ` [RFC PATCH 0/5] perf events patches for improved ARM64 support John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12034446-ccc9-9a88-6b2c-3318216f4817@redhat.com \
--to=wcohen@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=ganapatrao.kulkarni@cavium.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).