* pro_arm_davinci_watchdog_fix.patch
@ 2008-07-22 11:36 Egorov Evgeny
2008-07-31 0:20 ` pro_arm_davinci_watchdog_fix.patch Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Egorov Evgeny @ 2008-07-22 11:36 UTC (permalink / raw)
To: wim; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 92 bytes --]
This patch fix bug of watchdog driver's write fuction which allow to
prevent wdt timeout.
[-- Attachment #2: pro_arm_davinci_watchdog_fix.patch --]
[-- Type: text/x-patch, Size: 800 bytes --]
Source: MontaVista Software, Inc.
MR:26833
Type: Fix Bug
Disposition: Submitted to Wim van Sebroek
Signed-off-by: Egorov Evgeny <eegorov@ru.mvista.com>
Description:
This patch fix bug of watchdog driver's write fuction
which allow to prevent wdt timeout.
Index: linux-2.6.18/drivers/char/watchdog/davinci_wdt.c
===================================================================
--- linux-2.6.18.orig/drivers/char/watchdog/davinci_wdt.c
+++ linux-2.6.18/drivers/char/watchdog/davinci_wdt.c
@@ -133,13 +133,8 @@ static ssize_t
davinci_wdt_write(struct file *file, const char *data, size_t len,
loff_t *ppos)
{
- /* Can't seek (pwrite) on this device */
- if (ppos != &file->f_pos)
- return -ESPIPE;
-
if (len)
wdt_service();
-
return len;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: pro_arm_davinci_watchdog_fix.patch
2008-07-22 11:36 pro_arm_davinci_watchdog_fix.patch Egorov Evgeny
@ 2008-07-31 0:20 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-07-31 0:20 UTC (permalink / raw)
To: eegorov; +Cc: wim, linux-kernel
On Tue, 22 Jul 2008 15:36:39 +0400
Egorov Evgeny <eegorov@ru.mvista.com> wrote:
> This patch fix bug of watchdog driver's write fuction
> which allow to prevent wdt timeout.
>
> Index: linux-2.6.18/drivers/char/watchdog/davinci_wdt.c
> ===================================================================
> --- linux-2.6.18.orig/drivers/char/watchdog/davinci_wdt.c
> +++ linux-2.6.18/drivers/char/watchdog/davinci_wdt.c
> @@ -133,13 +133,8 @@ static ssize_t
> davinci_wdt_write(struct file *file, const char *data, size_t len,
> loff_t *ppos)
> {
> - /* Can't seek (pwrite) on this device */
> - if (ppos != &file->f_pos)
> - return -ESPIPE;
> -
> if (len)
> wdt_service();
> -
> return len;
> }
Thanks, but 2.6.25's drivers/watchdog/davinci_wdt.c already has this
fix, and we're not maintaining any kernels which are older than that.
^ permalink raw reply [flat|nested] 3+ messages in thread
* pro_arm_davinci_watchdog_fix.patch
@ 2008-07-30 15:15 Egorov Evgeny
0 siblings, 0 replies; 3+ messages in thread
From: Egorov Evgeny @ 2008-07-30 15:15 UTC (permalink / raw)
To: linux-kernel
This patch fix bug of watchdog driver's write fuction which allow to
prevent wdt timeout.
[I cann't to send my mail to Maintainer of WDT driver -
wim@iguana.be
Probably, this address is not valid]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-31 0:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-22 11:36 pro_arm_davinci_watchdog_fix.patch Egorov Evgeny
2008-07-31 0:20 ` pro_arm_davinci_watchdog_fix.patch Andrew Morton
2008-07-30 15:15 pro_arm_davinci_watchdog_fix.patch Egorov Evgeny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).