* [PATCH] fix warning in arch/x86/mm/pgtable.c
@ 2008-07-26 16:50 Michael Borisov
2008-07-28 16:06 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Michael Borisov @ 2008-07-26 16:50 UTC (permalink / raw)
To: kernel-janitors, linux-kernel
This patch fixes the following compile warning:
arch/x86/mm/pgtable.c: In function ‘pgd_mop_up_pmds’:
arch/x86/mm/pgtable.c:194: warning: unused variable ‘pmd’
Signed-off-by: Michael Borisov <niro@tut.by>
---
diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
index 557b2ab..2d57735 100644
--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -163,7 +163,8 @@ static int preallocate_pmds(pmd_t *pmds[])
bool failed = false;
for(i = 0; i < PREALLOCATED_PMDS; i++) {
- pmd_t *pmd = (pmd_t *)get_zeroed_page(GFP_KERNEL|
__GFP_REPEAT);
+ pmd_t *pmd;
+ pmd = (pmd_t *)get_zeroed_page(GFP_KERNEL|__GFP_REPEAT);
if (pmd == NULL)
failed = true;
pmds[i] = pmd;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix warning in arch/x86/mm/pgtable.c
2008-07-26 16:50 [PATCH] fix warning in arch/x86/mm/pgtable.c Michael Borisov
@ 2008-07-28 16:06 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-07-28 16:06 UTC (permalink / raw)
To: Michael Borisov
Cc: kernel-janitors, linux-kernel, Jeremy Fitzhardinge,
the arch/x86 maintainers
* Michael Borisov <niro@tut.by> wrote:
> This patch fixes the following compile warning:
>
> arch/x86/mm/pgtable.c: In function ‘pgd_mop_up_pmds’:
> arch/x86/mm/pgtable.c:194: warning: unused variable ‘pmd’
> - pmd_t *pmd = (pmd_t *)get_zeroed_page(GFP_KERNEL|
> __GFP_REPEAT);
> + pmd_t *pmd;
> + pmd = (pmd_t *)get_zeroed_page(GFP_KERNEL|__GFP_REPEAT);
what gcc version are you using? Seems to be a compiler bug.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-28 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-26 16:50 [PATCH] fix warning in arch/x86/mm/pgtable.c Michael Borisov
2008-07-28 16:06 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).