[PATCH] netns: fix ip_rt_frag_needed rt_is_expired

[PATCH] netns: fix ip_rt_frag_needed rt_is_expired

[Hugh Dickins]

Running recent kernels, and using a particular vpn gateway, I've been
having to edit my mails down to get them accepted by the smtp server.

Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 -
netns: place rt_genid into struct net.  The conversion from a != test
to rt_is_expired() put one negative too many: and now my mail works.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
Ingo was having strange distcc problems, might this help him too?

 net/ipv4/route.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 2.6.26-git/net/ipv4/route.c	2008-07-26 12:31:50.000000000 +0100
+++ linux/net/ipv4/route.c	2008-07-26 13:10:04.000000000 +0100
@@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct 
 				    rth->fl.iif != 0 ||
 				    dst_metric_locked(&rth->u.dst, RTAX_MTU) ||
 				    !net_eq(dev_net(rth->u.dst.dev), net) ||
-				    !rt_is_expired(rth))
+				    rt_is_expired(rth))
 					continue;
 
 				if (new_mtu < 68 || new_mtu >= old_mtu) {

Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

[Denis V. Lunev]

Acked-by: Denis V. Lunev <den@openvz.org>

Thanks for founding this issue...

On Sat, 2008-07-26 at 13:48 +0100, Hugh Dickins wrote:
> Running recent kernels, and using a particular vpn gateway, I've been
> having to edit my mails down to get them accepted by the smtp server.
> 
> Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 -
> netns: place rt_genid into struct net.  The conversion from a != test
> to rt_is_expired() put one negative too many: and now my mail works.
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Ingo was having strange distcc problems, might this help him too?
> 
>  net/ipv4/route.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 2.6.26-git/net/ipv4/route.c	2008-07-26 12:31:50.000000000 +0100
> +++ linux/net/ipv4/route.c	2008-07-26 13:10:04.000000000 +0100
> @@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct 
>  				    rth->fl.iif != 0 ||
>  				    dst_metric_locked(&rth->u.dst, RTAX_MTU) ||
>  				    !net_eq(dev_net(rth->u.dst.dev), net) ||
> -				    !rt_is_expired(rth))
> +				    rt_is_expired(rth))
>  					continue;
>  
>  				if (new_mtu < 68 || new_mtu >= old_mtu) {

Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

[Denis V. Lunev]

On Sat, 2008-07-26 at 20:40 +0400, Denis V. Lunev wrote:
> Acked-by: Denis V. Lunev <den@openvz.org>
> 
> Thanks for founding this issue...

oops... I mean finding and fixing... my fault again

Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

[Hugh Dickins]

On Sat, 26 Jul 2008, Denis V. Lunev wrote:
> On Sat, 2008-07-26 at 20:40 +0400, Denis V. Lunev wrote:
> > Acked-by: Denis V. Lunev <den@openvz.org>
> > 
> > Thanks for founding this issue...
> 
> oops... I mean finding and fixing... my fault again

No problem - and both errors were quite understandable!

Hugh

Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired

[David Miller]

From: "Denis V. Lunev" <den@openvz.org>
Date: Sat, 26 Jul 2008 20:37:32 +0400

> Acked-by: Denis V. Lunev <den@openvz.org>

Applied, thanks a lot everyone.