linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, dwmw2@infradead.org,
	fujita.tomonori@lab.ntt.co.jp, netdev@vger.kernel.org,
	iommu@lists.linux-foundation.org,
	Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 04/16] dma-debug: add allocator code
Date: Fri, 9 Jan 2009 17:19:18 +0100	[thread overview]
Message-ID: <1231517970-20288-5-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1231517970-20288-1-git-send-email-joerg.roedel@amd.com>

Impact: add allocator code for struct dma_debug_entry

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 lib/dma-debug.c |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 57 insertions(+), 0 deletions(-)

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 74a0f36..c5444d4 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -49,6 +49,16 @@ struct hash_bucket {
 
 /* Hash list to save the allocated dma addresses */
 static struct hash_bucket dma_entry_hash[HASH_SIZE];
+/* List of pre-allocated dma_debug_entry's */
+static LIST_HEAD(free_entries);
+/* Lock for the list above */
+static DEFINE_SPINLOCK(free_entries_lock);
+
+/* Global disable flag - will be set in case of an error */
+static bool global_disable __read_mostly;
+
+static u32 num_free_entries;
+static u32 min_free_entries;
 
 /*
  * Hash related functions
@@ -138,3 +148,50 @@ static void add_dma_entry(struct dma_debug_entry *entry)
 	put_hash_bucket(bucket, &flags);
 }
 
+/* struct dma_entry allocator
+ *
+ * The next two functions implement the allocator for
+ * struct dma_debug_entries.
+ */
+static struct dma_debug_entry *dma_entry_alloc(void)
+{
+	struct dma_debug_entry *entry = NULL;
+	unsigned long flags;
+
+	spin_lock_irqsave(&free_entries_lock, flags);
+
+	if (list_empty(&free_entries)) {
+		printk(KERN_ERR "DMA-API: debugging out of memory "
+				"- disabling\n");
+		global_disable = true;
+		goto out;
+	}
+
+	entry = list_entry(free_entries.next, struct dma_debug_entry, list);
+	list_del(&entry->list);
+	memset(entry, 0, sizeof(*entry));
+
+	num_free_entries -= 1;
+	if (num_free_entries < min_free_entries)
+		min_free_entries = num_free_entries;
+
+out:
+	spin_unlock_irqrestore(&free_entries_lock, flags);
+
+	return entry;
+}
+
+static void dma_entry_free(struct dma_debug_entry *entry)
+{
+	unsigned long flags;
+
+	/*
+	 * add to beginning of the list - this way the entries are
+	 * more likely cache hot when they are reallocated.
+	 */
+	spin_lock_irqsave(&free_entries_lock, flags);
+	list_add(&entry->list, &free_entries);
+	num_free_entries += 1;
+	spin_unlock_irqrestore(&free_entries_lock, flags);
+}
+
-- 
1.5.6.4



  parent reply	other threads:[~2009-01-09 16:35 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-09 16:19 [PATCH 0/16] DMA-API debugging facility v2 Joerg Roedel
2009-01-09 16:19 ` [PATCH 01/16] dma-debug: add Kconfig entry Joerg Roedel
2009-01-09 20:12   ` Randy Dunlap
2009-01-09 16:19 ` [PATCH 02/16] dma-debug: add header file and core data structures Joerg Roedel
2009-01-11  6:25   ` FUJITA Tomonori
2009-01-09 16:19 ` [PATCH 03/16] dma-debug: add hash functions for dma_debug_entries Joerg Roedel
2009-01-09 17:55   ` Evgeniy Polyakov
2009-01-09 18:14     ` Joerg Roedel
2009-01-09 18:23       ` Evgeniy Polyakov
2009-01-09 18:40         ` Joerg Roedel
2009-01-13  8:51   ` Andrew Morton
2009-01-13  8:59     ` David Woodhouse
2009-01-14 11:43     ` Ingo Molnar
2009-01-14 17:39       ` Andrew Morton
2009-01-14 17:43         ` Ingo Molnar
2009-01-14 17:48         ` Ingo Molnar
2009-01-15  3:44           ` FUJITA Tomonori
2009-01-14 17:48         ` David Woodhouse
2009-01-14 17:51         ` Joerg Roedel
2009-01-09 16:19 ` Joerg Roedel [this message]
2009-01-10 23:43   ` [PATCH 04/16] dma-debug: add allocator code Ingo Molnar
2009-01-09 16:19 ` [PATCH 05/16] dma-debug: add initialization code Joerg Roedel
2009-01-09 17:58   ` Evgeniy Polyakov
2009-01-09 18:17     ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 06/16] dma-debug: add kernel command line parameters Joerg Roedel
2009-01-09 16:19 ` [PATCH 07/16] dma-debug: add debugfs interface Joerg Roedel
2009-01-10 23:08   ` Ingo Molnar
2009-01-11  7:52     ` Joerg Roedel
2009-01-14 15:22     ` Joerg Roedel
2009-01-10 23:15   ` Ingo Molnar
2009-01-09 16:19 ` [PATCH 08/16] dma-debug: add core checking functions Joerg Roedel
2009-01-10 23:11   ` Ingo Molnar
2009-01-11  7:57     ` Joerg Roedel
2009-01-11  8:34       ` Joerg Roedel
2009-01-14 11:44     ` Joerg Roedel
2009-01-14 11:48       ` Ingo Molnar
2009-01-10 23:12   ` Ingo Molnar
2009-01-11  7:54     ` Joerg Roedel
2009-01-10 23:13   ` Ingo Molnar
2009-01-09 16:19 ` [PATCH 09/16] dma-debug: add checking for map/unmap_single Joerg Roedel
2009-01-09 16:19 ` [PATCH 10/16] dma-debug: add add checking for map/unmap_sg Joerg Roedel
2009-01-09 18:08   ` Evgeniy Polyakov
2009-01-09 18:11     ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 11/16] dma-debug: add checking for [alloc|free]_coherent Joerg Roedel
2009-01-11  6:25   ` FUJITA Tomonori
2009-01-11  6:30     ` FUJITA Tomonori
2009-01-11  7:59       ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 12/16] dma-debug: add checks for sync_single_* Joerg Roedel
2009-01-09 16:19 ` [PATCH 13/16] dma-debug: add checks for sync_single_range_* Joerg Roedel
2009-01-09 16:19 ` [PATCH 14/16] dma-debug: add checks for sync_single_sg_* Joerg Roedel
2009-01-10 23:46   ` Ingo Molnar
2009-01-11  8:00     ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 15/16] dma-debug: x86 architecture bindings Joerg Roedel
2009-01-10 23:04   ` Ingo Molnar
2009-01-10 23:48   ` Ingo Molnar
2009-01-11  6:25   ` FUJITA Tomonori
2009-01-11  8:08     ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 16/16] dma-debug: Documentation update Joerg Roedel
2009-01-09 21:24 ` [PATCH 0/16] DMA-API debugging facility v2 Michael Chan
2009-01-09 22:33   ` Joerg Roedel
2009-01-09 22:37     ` Joerg Roedel
2009-01-11  6:25       ` FUJITA Tomonori
2009-01-10 23:54 ` Ingo Molnar
2009-01-11  8:11   ` Joerg Roedel
2009-02-05 22:52 ` David Woodhouse
2009-02-06  2:05   ` Chris Wright
2009-02-06  7:56     ` David Woodhouse
2009-02-06 16:08       ` Chris Wright
2009-02-06 18:20       ` Chris Wright
2009-02-12 14:48     ` Joerg Roedel
2009-02-06  2:27   ` Chris Wright
2009-02-12 15:20   ` Joerg Roedel
2009-01-19 14:46 [PATCH 0/16] DMA-API debugging facility v3 Joerg Roedel
2009-01-19 14:46 ` [PATCH 04/16] dma-debug: add allocator code Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231517970-20288-5-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=dwmw2@infradead.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).