From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: joerg.roedel@amd.com
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
dwmw2@infradead.org, fujita.tomonori@lab.ntt.co.jp,
netdev@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH 11/16] dma-debug: add checking for [alloc|free]_coherent
Date: Sun, 11 Jan 2009 15:25:42 +0900 [thread overview]
Message-ID: <20090111150026Y.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <1231517970-20288-12-git-send-email-joerg.roedel@amd.com>
On Fri, 9 Jan 2009 17:19:25 +0100
Joerg Roedel <joerg.roedel@amd.com> wrote:
> Impact: add debug callbacks for dma_[alloc|free]_coherent
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
> include/linux/dma-debug.h | 16 ++++++++++++++++
> lib/dma-debug.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 61 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/dma-debug.h b/include/linux/dma-debug.h
> index b2131f4..a28a701 100644
> --- a/include/linux/dma-debug.h
> +++ b/include/linux/dma-debug.h
> @@ -40,6 +40,12 @@ extern void debug_map_sg(struct device *dev, struct scatterlist *sg,
> extern void debug_unmap_sg(struct device *dev, struct scatterlist *sglist,
> int nelems, int dir);
>
> +extern void debug_alloc_coherent(struct device *dev, size_t size,
> + dma_addr_t dma_addr, void *virt);
> +
> +extern void debug_free_coherent(struct device *dev, size_t size,
> + void *virt, dma_addr_t addr);
> +
> #else /* CONFIG_DMA_API_DEBUG */
>
> static inline void dma_debug_init(u32 num_entries)
> @@ -68,6 +74,16 @@ static inline void debug_unmap_sg(struct device *dev,
> {
> }
>
> +static inline void debug_alloc_coherent(struct device *dev, size_t size,
> + dma_addr_t dma_addr, void *virt)
> +{
> +}
> +
> +static inline void debug_free_coherent(struct device *dev, size_t size,
> + void *virt, dma_addr_t addr)
> +{
> +}
> +
> #endif /* CONFIG_DMA_API_DEBUG */
>
> #endif /* __DMA_DEBUG_H */
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index e6d45f9..a4a5b0f 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -604,3 +604,48 @@ void debug_unmap_sg(struct device *dev, struct scatterlist *sglist,
> }
> EXPORT_SYMBOL(debug_unmap_sg);
>
> +void debug_alloc_coherent(struct device *dev, size_t size,
> + dma_addr_t dma_addr, void *virt)
> +{
> + struct dma_debug_entry *entry;
> +
> + if (global_disable)
> + return;
> +
> + if (dma_addr == bad_dma_address)
> + return;
Only X86 has 'bad_dma_address' (IA64 also has with some configurations
though). You need to use dma_mapping_error, as I pointed out in the
previous submission.
I recommend you to try this on one non-x86 box (at least). Even if you
don't have non x86, you can use cross compiler.
next prev parent reply other threads:[~2009-01-11 6:26 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 16:19 [PATCH 0/16] DMA-API debugging facility v2 Joerg Roedel
2009-01-09 16:19 ` [PATCH 01/16] dma-debug: add Kconfig entry Joerg Roedel
2009-01-09 20:12 ` Randy Dunlap
2009-01-09 16:19 ` [PATCH 02/16] dma-debug: add header file and core data structures Joerg Roedel
2009-01-11 6:25 ` FUJITA Tomonori
2009-01-09 16:19 ` [PATCH 03/16] dma-debug: add hash functions for dma_debug_entries Joerg Roedel
2009-01-09 17:55 ` Evgeniy Polyakov
2009-01-09 18:14 ` Joerg Roedel
2009-01-09 18:23 ` Evgeniy Polyakov
2009-01-09 18:40 ` Joerg Roedel
2009-01-13 8:51 ` Andrew Morton
2009-01-13 8:59 ` David Woodhouse
2009-01-14 11:43 ` Ingo Molnar
2009-01-14 17:39 ` Andrew Morton
2009-01-14 17:43 ` Ingo Molnar
2009-01-14 17:48 ` Ingo Molnar
2009-01-15 3:44 ` FUJITA Tomonori
2009-01-14 17:48 ` David Woodhouse
2009-01-14 17:51 ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 04/16] dma-debug: add allocator code Joerg Roedel
2009-01-10 23:43 ` Ingo Molnar
2009-01-09 16:19 ` [PATCH 05/16] dma-debug: add initialization code Joerg Roedel
2009-01-09 17:58 ` Evgeniy Polyakov
2009-01-09 18:17 ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 06/16] dma-debug: add kernel command line parameters Joerg Roedel
2009-01-09 16:19 ` [PATCH 07/16] dma-debug: add debugfs interface Joerg Roedel
2009-01-10 23:08 ` Ingo Molnar
2009-01-11 7:52 ` Joerg Roedel
2009-01-14 15:22 ` Joerg Roedel
2009-01-10 23:15 ` Ingo Molnar
2009-01-09 16:19 ` [PATCH 08/16] dma-debug: add core checking functions Joerg Roedel
2009-01-10 23:11 ` Ingo Molnar
2009-01-11 7:57 ` Joerg Roedel
2009-01-11 8:34 ` Joerg Roedel
2009-01-14 11:44 ` Joerg Roedel
2009-01-14 11:48 ` Ingo Molnar
2009-01-10 23:12 ` Ingo Molnar
2009-01-11 7:54 ` Joerg Roedel
2009-01-10 23:13 ` Ingo Molnar
2009-01-09 16:19 ` [PATCH 09/16] dma-debug: add checking for map/unmap_single Joerg Roedel
2009-01-09 16:19 ` [PATCH 10/16] dma-debug: add add checking for map/unmap_sg Joerg Roedel
2009-01-09 18:08 ` Evgeniy Polyakov
2009-01-09 18:11 ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 11/16] dma-debug: add checking for [alloc|free]_coherent Joerg Roedel
2009-01-11 6:25 ` FUJITA Tomonori [this message]
2009-01-11 6:30 ` FUJITA Tomonori
2009-01-11 7:59 ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 12/16] dma-debug: add checks for sync_single_* Joerg Roedel
2009-01-09 16:19 ` [PATCH 13/16] dma-debug: add checks for sync_single_range_* Joerg Roedel
2009-01-09 16:19 ` [PATCH 14/16] dma-debug: add checks for sync_single_sg_* Joerg Roedel
2009-01-10 23:46 ` Ingo Molnar
2009-01-11 8:00 ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 15/16] dma-debug: x86 architecture bindings Joerg Roedel
2009-01-10 23:04 ` Ingo Molnar
2009-01-10 23:48 ` Ingo Molnar
2009-01-11 6:25 ` FUJITA Tomonori
2009-01-11 8:08 ` Joerg Roedel
2009-01-09 16:19 ` [PATCH 16/16] dma-debug: Documentation update Joerg Roedel
2009-01-09 21:24 ` [PATCH 0/16] DMA-API debugging facility v2 Michael Chan
2009-01-09 22:33 ` Joerg Roedel
2009-01-09 22:37 ` Joerg Roedel
2009-01-11 6:25 ` FUJITA Tomonori
2009-01-10 23:54 ` Ingo Molnar
2009-01-11 8:11 ` Joerg Roedel
2009-02-05 22:52 ` David Woodhouse
2009-02-06 2:05 ` Chris Wright
2009-02-06 7:56 ` David Woodhouse
2009-02-06 16:08 ` Chris Wright
2009-02-06 18:20 ` Chris Wright
2009-02-12 14:48 ` Joerg Roedel
2009-02-06 2:27 ` Chris Wright
2009-02-12 15:20 ` Joerg Roedel
2009-01-19 14:46 [PATCH 0/16] DMA-API debugging facility v3 Joerg Roedel
2009-01-19 14:46 ` [PATCH 11/16] dma-debug: add checking for [alloc|free]_coherent Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090111150026Y.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).