linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] s_umount in sget()
@ 2009-01-29 15:00 J. R. Okajima
  0 siblings, 0 replies; only message in thread
From: J. R. Okajima @ 2009-01-29 15:00 UTC (permalink / raw)
  To: linux-kernel, linux-fsdevel; +Cc: J. R. Okajima

It seems to be forgotten to release s_umount rwsem in a error path of
sget(). I don't think it harmful generally since the rwsem is freed. But
I am afarid unnecessary info left in some debugging subsystem (lockdep
or something).

Signed-off-by: J. R. Okajima <hooanon05@yahoo.co.jp>
---
 fs/super.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/super.c b/fs/super.c
index 645e540..0331ff9 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -372,6 +372,7 @@ retry:
 	err = set(s, data);
 	if (err) {
 		spin_unlock(&sb_lock);
+		up_write(&s->s_umount);
 		destroy_super(s);
 		return ERR_PTR(err);
 	}
-- 
1.6.1.284.g5dc13


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-01-29 15:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-29 15:00 [PATCH 1/1] s_umount in sget() J. R. Okajima

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).