* [RE-SEND PATCH 1/3] tracing: use the more proper parameter.
@ 2009-02-17 6:07 Wenji Huang
2009-02-17 6:09 ` [PATCH 2/3] tracing: fix the return value of trace selftest Wenji Huang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wenji Huang @ 2009-02-17 6:07 UTC (permalink / raw)
To: linux-kernel; +Cc: rostedt, Wenji Huang
Pass tsk to tracing_record_cmdline instead of current.
Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
---
kernel/trace/trace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 95f99a7..dc61e82 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -336,7 +336,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
data->rt_priority = tsk->rt_priority;
/* record this tasks comm */
- tracing_record_cmdline(current);
+ tracing_record_cmdline(tsk);
}
static void
--
1.5.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] tracing: fix the return value of trace selftest.
2009-02-17 6:07 [RE-SEND PATCH 1/3] tracing: use the more proper parameter Wenji Huang
@ 2009-02-17 6:09 ` Wenji Huang
2009-02-17 6:10 ` [PATCH 3/3] tracing: fix typing mistake in hint message and comments Wenji Huang
2009-02-17 17:39 ` [RE-SEND PATCH 1/3] tracing: use the more proper parameter Steven Rostedt
2 siblings, 0 replies; 4+ messages in thread
From: Wenji Huang @ 2009-02-17 6:09 UTC (permalink / raw)
To: linux-kernel; +Cc: rostedt, Wenji Huang
This patch is to fix the return value of trace_selftest_startup_sysprof
and trace_selftest_startup_branch on failure.
Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
---
kernel/trace/trace_selftest.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
index 0c9aa14..c72e749 100644
--- a/kernel/trace/trace_selftest.c
+++ b/kernel/trace/trace_selftest.c
@@ -622,7 +622,7 @@ trace_selftest_startup_sysprof(struct tracer *trace, struct trace_array *tr)
ret = tracer_init(trace, tr);
if (ret) {
warn_failed_init_tracer(trace, ret);
- return 0;
+ return ret;
}
/* Sleep for a 1/10 of a second */
@@ -634,6 +634,11 @@ trace_selftest_startup_sysprof(struct tracer *trace, struct trace_array *tr)
trace->reset(tr);
tracing_start();
+ if (!ret && !count) {
+ printk(KERN_CONT ".. no entries found ..");
+ ret = -1;
+ }
+
return ret;
}
#endif /* CONFIG_SYSPROF_TRACER */
@@ -661,6 +666,11 @@ trace_selftest_startup_branch(struct tracer *trace, struct trace_array *tr)
trace->reset(tr);
tracing_start();
+ if (!ret && !count) {
+ printk(KERN_CONT ".. no entries found ..");
+ ret = -1;
+ }
+
return ret;
}
#endif /* CONFIG_BRANCH_TRACER */
--
1.5.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] tracing: fix typing mistake in hint message and comments.
2009-02-17 6:07 [RE-SEND PATCH 1/3] tracing: use the more proper parameter Wenji Huang
2009-02-17 6:09 ` [PATCH 2/3] tracing: fix the return value of trace selftest Wenji Huang
@ 2009-02-17 6:10 ` Wenji Huang
2009-02-17 17:39 ` [RE-SEND PATCH 1/3] tracing: use the more proper parameter Steven Rostedt
2 siblings, 0 replies; 4+ messages in thread
From: Wenji Huang @ 2009-02-17 6:10 UTC (permalink / raw)
To: linux-kernel; +Cc: rostedt, Wenji Huang
Impact: cleanup
Fix incorrect hint message in code and typos in comments.
Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
---
kernel/trace/trace_irqsoff.c | 2 +-
kernel/trace/trace_sched_switch.c | 2 +-
kernel/trace/trace_sched_wakeup.c | 2 +-
kernel/trace/trace_selftest.c | 4 ++--
kernel/trace/trace_stat.c | 2 +-
kernel/trace/trace_sysprof.c | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
index c6b442d..9e5ebd8 100644
--- a/kernel/trace/trace_irqsoff.c
+++ b/kernel/trace/trace_irqsoff.c
@@ -1,5 +1,5 @@
/*
- * trace irqs off criticall timings
+ * trace irqs off critical timings
*
* Copyright (C) 2007-2008 Steven Rostedt <srostedt@redhat.com>
* Copyright (C) 2008 Ingo Molnar <mingo@redhat.com>
diff --git a/kernel/trace/trace_sched_switch.c b/kernel/trace/trace_sched_switch.c
index 30e14fe..82fbb5a 100644
--- a/kernel/trace/trace_sched_switch.c
+++ b/kernel/trace/trace_sched_switch.c
@@ -93,7 +93,7 @@ static int tracing_sched_register(void)
ret = register_trace_sched_switch(probe_sched_switch);
if (ret) {
pr_info("sched trace: Couldn't activate tracepoint"
- " probe to kernel_sched_schedule\n");
+ " probe to kernel_sched_switch\n");
goto fail_deprobe_wake_new;
}
diff --git a/kernel/trace/trace_sched_wakeup.c b/kernel/trace/trace_sched_wakeup.c
index 96d7164..276c51a 100644
--- a/kernel/trace/trace_sched_wakeup.c
+++ b/kernel/trace/trace_sched_wakeup.c
@@ -284,7 +284,7 @@ static void start_wakeup_tracer(struct trace_array *tr)
ret = register_trace_sched_switch(probe_wakeup_sched_switch);
if (ret) {
pr_info("sched trace: Couldn't activate tracepoint"
- " probe to kernel_sched_schedule\n");
+ " probe to kernel_sched_switch\n");
goto fail_deprobe_wake_new;
}
diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
index c72e749..01415f4 100644
--- a/kernel/trace/trace_selftest.c
+++ b/kernel/trace/trace_selftest.c
@@ -107,9 +107,9 @@ int trace_selftest_startup_dynamic_tracing(struct tracer *trace,
func();
/*
- * Some archs *cough*PowerPC*cough* add charachters to the
+ * Some archs *cough*PowerPC*cough* add characters to the
* start of the function names. We simply put a '*' to
- * accomodate them.
+ * accommodate them.
*/
func_name = "*" STR(DYN_FTRACE_TEST_NAME);
diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c
index eae9cef..39310e3 100644
--- a/kernel/trace/trace_stat.c
+++ b/kernel/trace/trace_stat.c
@@ -30,7 +30,7 @@ struct tracer_stat_session {
struct dentry *file;
};
-/* All of the sessions currently in use. Each stat file embeed one session */
+/* All of the sessions currently in use. Each stat file embed one session */
static LIST_HEAD(all_stat_sessions);
static DEFINE_MUTEX(all_stat_sessions_mutex);
diff --git a/kernel/trace/trace_sysprof.c b/kernel/trace/trace_sysprof.c
index 7c9a2d8..c771af4 100644
--- a/kernel/trace/trace_sysprof.c
+++ b/kernel/trace/trace_sysprof.c
@@ -327,5 +327,5 @@ void init_tracer_sysprof_debugfs(struct dentry *d_tracer)
d_tracer, NULL, &sysprof_sample_fops);
if (entry)
return;
- pr_warning("Could not create debugfs 'dyn_ftrace_total_info' entry\n");
+ pr_warning("Could not create debugfs 'sysprof_sample_period' entry\n");
}
--
1.5.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RE-SEND PATCH 1/3] tracing: use the more proper parameter.
2009-02-17 6:07 [RE-SEND PATCH 1/3] tracing: use the more proper parameter Wenji Huang
2009-02-17 6:09 ` [PATCH 2/3] tracing: fix the return value of trace selftest Wenji Huang
2009-02-17 6:10 ` [PATCH 3/3] tracing: fix typing mistake in hint message and comments Wenji Huang
@ 2009-02-17 17:39 ` Steven Rostedt
2 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2009-02-17 17:39 UTC (permalink / raw)
To: Wenji Huang; +Cc: linux-kernel
Thanks, I've applied all three patches.
Just a small nit pick. Please do not include a period in the subject line.
Thanks,
-- Steve
On Tue, 17 Feb 2009, Wenji Huang wrote:
> Pass tsk to tracing_record_cmdline instead of current.
>
> Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
> ---
> kernel/trace/trace.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 95f99a7..dc61e82 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -336,7 +336,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
> data->rt_priority = tsk->rt_priority;
>
> /* record this tasks comm */
> - tracing_record_cmdline(current);
> + tracing_record_cmdline(tsk);
> }
>
> static void
> --
> 1.5.6
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-02-17 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-17 6:07 [RE-SEND PATCH 1/3] tracing: use the more proper parameter Wenji Huang
2009-02-17 6:09 ` [PATCH 2/3] tracing: fix the return value of trace selftest Wenji Huang
2009-02-17 6:10 ` [PATCH 3/3] tracing: fix typing mistake in hint message and comments Wenji Huang
2009-02-17 17:39 ` [RE-SEND PATCH 1/3] tracing: use the more proper parameter Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).