* Re: [tip:tracing/core] tracing/bkl: Add bkl ftrace events
[not found] <tip-96a2c464de07d7c72988db851c029b204fc59108@git.kernel.org>
@ 2009-09-26 10:05 ` Steven Rostedt
2009-09-28 8:48 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2009-09-26 10:05 UTC (permalink / raw)
To: linux-kernel, mingo, hpa, fweisbec, lizf, tglx; +Cc: linux-tip-commits
On Fri, 2009-09-25 at 06:19 +0000, tip-bot for Frederic Weisbecker
wrote:
> Commit-ID: 96a2c464de07d7c72988db851c029b204fc59108
> +#if !defined(_TRACE_BKL_H) || defined(TRACE_HEADER_MULTI_READ)
> +#define _TRACE_BKL_H
> +
> +#include <linux/tracepoint.h>
> +
> +TRACE_EVENT(lock_kernel,
> +
> + TP_PROTO(const char *func, const char *file, int line),
> +
> + TP_ARGS(func, file, line),
> +
> + TP_STRUCT__entry(
> + __field( int, lock_depth )
FYI,
By your request I added this as a common field ;-)
With commit:
637e7e864103a7a68c1ce43ada27dfc25c0d113f
But since other utilities outside of ftrace may use this trace point, it
may be OK to keep the duplicate information in the kernel lock API trace
points.
-- Steve
> + __field_ext( const char *, func, FILTER_PTR_STRING )
> + __field_ext( const char *, file, FILTER_PTR_STRING )
> + __field( int, line )
> + ),
> +
> + TP_fast_assign(
> + /* We want to record the lock_depth after lock is acquired */
> + __entry->lock_depth = current->lock_depth + 1;
> + __entry->func = func;
> + __entry->file = file;
> + __entry->line = line;
> + ),
> +
> + TP_printk("depth: %d, %s:%d %s()", __entry->lock_depth,
> + __entry->file, __entry->line, __entry->func)
> +);
> +
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tip:tracing/core] tracing/bkl: Add bkl ftrace events
2009-09-26 10:05 ` [tip:tracing/core] tracing/bkl: Add bkl ftrace events Steven Rostedt
@ 2009-09-28 8:48 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2009-09-28 8:48 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linux-kernel, mingo, hpa, lizf, tglx, linux-tip-commits
On Sat, Sep 26, 2009 at 06:05:54AM -0400, Steven Rostedt wrote:
> On Fri, 2009-09-25 at 06:19 +0000, tip-bot for Frederic Weisbecker
> wrote:
> > Commit-ID: 96a2c464de07d7c72988db851c029b204fc59108
>
> > +#if !defined(_TRACE_BKL_H) || defined(TRACE_HEADER_MULTI_READ)
> > +#define _TRACE_BKL_H
> > +
> > +#include <linux/tracepoint.h>
> > +
> > +TRACE_EVENT(lock_kernel,
> > +
> > + TP_PROTO(const char *func, const char *file, int line),
> > +
> > + TP_ARGS(func, file, line),
> > +
> > + TP_STRUCT__entry(
> > + __field( int, lock_depth )
>
> FYI,
>
> By your request I added this as a common field ;-)
>
> With commit:
>
> 637e7e864103a7a68c1ce43ada27dfc25c0d113f
>
> But since other utilities outside of ftrace may use this trace point, it
> may be OK to keep the duplicate information in the kernel lock API trace
> points.
>
> -- Steve
Right, or may be we can define this tracepoint as a latency format
user by default. It's not possible yet for an event to do that but
I guess we can set a flag for this purpose or something...
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-28 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-96a2c464de07d7c72988db851c029b204fc59108@git.kernel.org>
2009-09-26 10:05 ` [tip:tracing/core] tracing/bkl: Add bkl ftrace events Steven Rostedt
2009-09-28 8:48 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).