linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value'
@ 2009-12-29 23:49 René Bolldorf
  2009-12-30  0:01 ` Felipe Balbi
  0 siblings, 1 reply; 4+ messages in thread
From: René Bolldorf @ 2009-12-29 23:49 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel

The variable 'value' is unused in 'set_reset_quirk()'.

Greetings René Bolldorf

--- ./drivers/usb/core/sysfs.c	2009-12-29 23:57:30.579982912 +0100
+++ ./drivers/usb/core/sysfs.c	2009-12-29 23:58:19.114982484 +0100
@@ -198,7 +198,7 @@ set_reset_quirk(struct device *dev, stru
  		const char *buf, size_t count)
  {
  	struct usb_device	*udev = to_usb_device(dev);
-	int			config, value;
+	int			config;

  	if (sscanf(buf, "%d", &config) != 1 || config < 0 || config > 1)
  		return -EINVAL;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value'
  2009-12-29 23:49 [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value' René Bolldorf
@ 2009-12-30  0:01 ` Felipe Balbi
  2009-12-30 11:27   ` Sergei Shtylyov
  0 siblings, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2009-12-30  0:01 UTC (permalink / raw)
  To: René Bolldorf; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel

On Wed, 2009-12-30 at 00:49 +0100, René Bolldorf wrote:
> The variable 'value' is unused in 'set_reset_quirk()'.
> 
> Greetings René Bolldorf

I already sent a patch for that [1]

[1] http://marc.info/?l=linux-usb&m=126203765207545&w=2

-- 
balbi


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value'
  2009-12-30  0:01 ` Felipe Balbi
@ 2009-12-30 11:27   ` Sergei Shtylyov
  2009-12-30 12:16     ` Felipe Balbi
  0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2009-12-30 11:27 UTC (permalink / raw)
  To: me; +Cc: René Bolldorf, Greg Kroah-Hartman, linux-usb, linux-kernel

Hello.

Felipe Balbi wrote:

>> The variable 'value' is unused in 'set_reset_quirk()'.
>>
>> Greetings René Bolldorf
>>     
>
> I already sent a patch for that [1]
>
> [1] http://marc.info/?l=linux-usb&m=126203765207545&w=2
>   

   And you weren't the first one:

http://marc.info/?l=linux-usb&m=126165643307894


WBR, Sergei



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value'
  2009-12-30 11:27   ` Sergei Shtylyov
@ 2009-12-30 12:16     ` Felipe Balbi
  0 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2009-12-30 12:16 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: René Bolldorf, Greg Kroah-Hartman, linux-usb, linux-kernel

On Wed, 2009-12-30 at 14:27 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> Felipe Balbi wrote:
> 
> >> The variable 'value' is unused in 'set_reset_quirk()'.
> >>
> >> Greetings René Bolldorf
> >>     
> >
> > I already sent a patch for that [1]
> >
> > [1] http://marc.info/?l=linux-usb&m=126203765207545&w=2
> >   
> 
>    And you weren't the first one:
> 
> http://marc.info/?l=linux-usb&m=126165643307894

hah, beat me by a few days :-p


-- 
balbi


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-12-30 12:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-29 23:49 [PATCH]drivers/usb/core/sysfs.c:201 unused variable 'value' René Bolldorf
2009-12-30  0:01 ` Felipe Balbi
2009-12-30 11:27   ` Sergei Shtylyov
2009-12-30 12:16     ` Felipe Balbi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).