* 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?
@ 2010-03-28 11:31 Thomas Meyer
2010-03-31 23:32 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Meyer @ 2010-03-28 11:31 UTC (permalink / raw)
To: linux-kernel
This warning/error/notice is new in 2.6.34-rc2+:
[ 1878.810147] PM: Syncing filesystems ... done.
[ 1878.903316] Freezing user space processes ... (elapsed 0.01 seconds) done.
[ 1878.916589] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
[ 1878.929866] Suspending console(s) (use no_console_suspend to debug)
[ 1878.930229] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[ 1878.930370] sd 0:0:0:0: [sda] Stopping disk
[ 1878.981086] atl1c 0000:01:00.0: PCI INT A disabled
[ 1878.981369] uhci_hcd 0000:00:1d.2: PCI INT D disabled
[ 1878.981379] uhci_hcd 0000:00:1d.1: PCI INT B disabled
[ 1878.981389] uhci_hcd 0000:00:1d.0: PCI INT A disabled
[ 1878.981454] HDA Intel 0000:00:1b.0: PCI INT A disabled
[ 1878.981500] ACPI handle has no context!
[ 1878.981529] ehci_hcd 0000:00:1a.7: PCI INT D disabled
[ 1878.981540] uhci_hcd 0000:00:1a.0: PCI INT A disabled
[ 1878.981602] IMA: unmeasured files on fsmagic: 1021994
[ 1878.981605] ima_dec_counts: open/free imbalance (r:0 w:-1 o:-1)
[ 1878.981609] Pid: 4888, comm: async/10 Tainted: G W 2.6.34-rc2 #88
[ 1878.981612] Call Trace:
[ 1878.981620] [<c0886ac2>] ? printk+0x1d/0x23
[ 1878.981627] [<c05f966f>] ima_file_free+0x16f/0x210
[ 1878.981632] [<c04d7132>] __fput+0xf2/0x1f0
[ 1878.981636] [<c04d724d>] fput+0x1d/0x30
[ 1878.981641] [<c06cbd2f>] drm_gem_object_free_common+0x1f/0x40
[ 1878.981645] [<c06cbdd0>] ? drm_gem_object_free+0x0/0x40
[ 1878.981649] [<c06cbe01>] drm_gem_object_free+0x31/0x40
[ 1878.981653] [<c061d20c>] kref_put+0x2c/0x60
[ 1878.981658] [<c06e8078>] i915_gem_cleanup_ringbuffer+0x48/0x70
[ 1878.981662] [<c06e97ec>] i915_gem_idle+0x9c/0x120
[ 1878.981666] [<c06dcefd>] i915_drm_freeze+0x3d/0xa0
[ 1878.981670] [<c06dd01e>] i915_pm_suspend+0x2e/0x80
[ 1878.981674] [<c08871ca>] ? wait_for_common+0x1a/0x100
[ 1878.981679] [<c0636269>] pci_pm_suspend+0x49/0x110
[ 1878.981682] [<c0636220>] ? pci_pm_suspend+0x0/0x110
[ 1878.981687] [<c07194f1>] pm_op+0x181/0x1d0
[ 1878.981691] [<c07126f4>] ? device_for_each_child+0x54/0x60
[ 1878.981695] [<c0719eaf>] __device_suspend+0xbf/0x110
[ 1878.981699] [<c071a2f3>] async_suspend+0x23/0x60
[ 1878.981703] [<c044ff25>] async_thread+0xc5/0x210
[ 1878.981707] [<c0886e31>] ? schedule+0x1e1/0x450
[ 1878.981713] [<c042c030>] ? default_wake_function+0x0/0x20
[ 1878.981716] [<c044fe60>] ? async_thread+0x0/0x210
[ 1878.981720] [<c0449254>] kthread+0x74/0x80
[ 1878.981724] [<c04491e0>] ? kthread+0x0/0x80
[ 1878.981728] [<c04034be>] kernel_thread_helper+0x6/0x10
[ 1878.986489] iint_free: writecount: -1
[ 1878.986492] iint_free: opencount: -1
[ 1878.986494] iint_free: writecount: -1
[ 1878.986496] iint_free: opencount: -1
[ 1878.993205] ehci_hcd 0000:00:1d.7: PCI INT A disabled
[ 1879.649836] PM: suspend of devices complete after 719.812 msecs
[ 1879.676555] PM: late suspend of devices complete after 26.714 msecs
[ 1879.677144] ACPI: Preparing to enter system sleep state S3
[ 1879.677144] Back to C!
Does anybody care?
mfg
thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?
2010-03-28 11:31 2.6.34-rc2: "ima_dec_counts: open/free imbalance"? Thomas Meyer
@ 2010-03-31 23:32 ` Andrew Morton
2010-04-01 2:41 ` Eric Paris
2010-04-12 12:54 ` Daniel Vetter
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Morton @ 2010-03-31 23:32 UTC (permalink / raw)
To: Thomas Meyer
Cc: linux-kernel, Mimi Zohar, James Morris, Eric Paris, dri-devel
On Sun, 28 Mar 2010 13:31:49 +0200
Thomas Meyer <thomas@m3y3r.de> wrote:
> This warning/error/notice is new in 2.6.34-rc2+:
Let's add some cc's. It might be a DRM bug.
I'll ask Rafael and Maciej to track this as a post-2.6.33 regression,
thanks.
> [ 1878.810147] PM: Syncing filesystems ... done.
> [ 1878.903316] Freezing user space processes ... (elapsed 0.01 seconds) done.
> [ 1878.916589] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
> [ 1878.929866] Suspending console(s) (use no_console_suspend to debug)
> [ 1878.930229] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> [ 1878.930370] sd 0:0:0:0: [sda] Stopping disk
> [ 1878.981086] atl1c 0000:01:00.0: PCI INT A disabled
> [ 1878.981369] uhci_hcd 0000:00:1d.2: PCI INT D disabled
> [ 1878.981379] uhci_hcd 0000:00:1d.1: PCI INT B disabled
> [ 1878.981389] uhci_hcd 0000:00:1d.0: PCI INT A disabled
> [ 1878.981454] HDA Intel 0000:00:1b.0: PCI INT A disabled
> [ 1878.981500] ACPI handle has no context!
> [ 1878.981529] ehci_hcd 0000:00:1a.7: PCI INT D disabled
> [ 1878.981540] uhci_hcd 0000:00:1a.0: PCI INT A disabled
> [ 1878.981602] IMA: unmeasured files on fsmagic: 1021994
> [ 1878.981605] ima_dec_counts: open/free imbalance (r:0 w:-1 o:-1)
> [ 1878.981609] Pid: 4888, comm: async/10 Tainted: G W 2.6.34-rc2 #88
> [ 1878.981612] Call Trace:
> [ 1878.981620] [<c0886ac2>] ? printk+0x1d/0x23
> [ 1878.981627] [<c05f966f>] ima_file_free+0x16f/0x210
> [ 1878.981632] [<c04d7132>] __fput+0xf2/0x1f0
> [ 1878.981636] [<c04d724d>] fput+0x1d/0x30
> [ 1878.981641] [<c06cbd2f>] drm_gem_object_free_common+0x1f/0x40
> [ 1878.981645] [<c06cbdd0>] ? drm_gem_object_free+0x0/0x40
> [ 1878.981649] [<c06cbe01>] drm_gem_object_free+0x31/0x40
> [ 1878.981653] [<c061d20c>] kref_put+0x2c/0x60
> [ 1878.981658] [<c06e8078>] i915_gem_cleanup_ringbuffer+0x48/0x70
> [ 1878.981662] [<c06e97ec>] i915_gem_idle+0x9c/0x120
> [ 1878.981666] [<c06dcefd>] i915_drm_freeze+0x3d/0xa0
> [ 1878.981670] [<c06dd01e>] i915_pm_suspend+0x2e/0x80
> [ 1878.981674] [<c08871ca>] ? wait_for_common+0x1a/0x100
> [ 1878.981679] [<c0636269>] pci_pm_suspend+0x49/0x110
> [ 1878.981682] [<c0636220>] ? pci_pm_suspend+0x0/0x110
> [ 1878.981687] [<c07194f1>] pm_op+0x181/0x1d0
> [ 1878.981691] [<c07126f4>] ? device_for_each_child+0x54/0x60
> [ 1878.981695] [<c0719eaf>] __device_suspend+0xbf/0x110
> [ 1878.981699] [<c071a2f3>] async_suspend+0x23/0x60
> [ 1878.981703] [<c044ff25>] async_thread+0xc5/0x210
> [ 1878.981707] [<c0886e31>] ? schedule+0x1e1/0x450
> [ 1878.981713] [<c042c030>] ? default_wake_function+0x0/0x20
> [ 1878.981716] [<c044fe60>] ? async_thread+0x0/0x210
> [ 1878.981720] [<c0449254>] kthread+0x74/0x80
> [ 1878.981724] [<c04491e0>] ? kthread+0x0/0x80
> [ 1878.981728] [<c04034be>] kernel_thread_helper+0x6/0x10
> [ 1878.986489] iint_free: writecount: -1
> [ 1878.986492] iint_free: opencount: -1
> [ 1878.986494] iint_free: writecount: -1
> [ 1878.986496] iint_free: opencount: -1
> [ 1878.993205] ehci_hcd 0000:00:1d.7: PCI INT A disabled
> [ 1879.649836] PM: suspend of devices complete after 719.812 msecs
> [ 1879.676555] PM: late suspend of devices complete after 26.714 msecs
> [ 1879.677144] ACPI: Preparing to enter system sleep state S3
> [ 1879.677144] Back to C!
>
> Does anybody care?
>
> mfg
> thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?
2010-03-31 23:32 ` Andrew Morton
@ 2010-04-01 2:41 ` Eric Paris
2010-04-01 18:17 ` Thomas Meyer
2010-04-12 12:54 ` Daniel Vetter
1 sibling, 1 reply; 6+ messages in thread
From: Eric Paris @ 2010-04-01 2:41 UTC (permalink / raw)
To: Andrew Morton
Cc: Thomas Meyer, linux-kernel, Mimi Zohar, James Morris, dri-devel
On Wed, 2010-03-31 at 16:32 -0700, Andrew Morton wrote:
> On Sun, 28 Mar 2010 13:31:49 +0200
> Thomas Meyer <thomas@m3y3r.de> wrote:
>
> > This warning/error/notice is new in 2.6.34-rc2+:
>
> Let's add some cc's. It might be a DRM bug.
>
> I'll ask Rafael and Maciej to track this as a post-2.6.33 regression,
> thanks.
The IMA code hasn't changed since .33 so my guess is something new the
drm code is doing with obj->filp.
Thomas, any idea what the newest kernel was that didn't show you this
problem? It might help cut down my search in the morning....
-Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?
2010-04-01 2:41 ` Eric Paris
@ 2010-04-01 18:17 ` Thomas Meyer
2010-04-12 11:27 ` Mimi Zohar
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Meyer @ 2010-04-01 18:17 UTC (permalink / raw)
To: Eric Paris
Cc: Andrew Morton, linux-kernel, Mimi Zohar, James Morris, dri-devel
Am 01.04.2010 um 04:41 schrieb Eric Paris <eparis@redhat.com>:
> On Wed, 2010-03-31 at 16:32 -0700, Andrew Morton wrote:
>> On Sun, 28 Mar 2010 13:31:49 +0200
>> Thomas Meyer <thomas@m3y3r.de> wrote:
>>
>>> This warning/error/notice is new in 2.6.34-rc2+:
>>
>> Let's add some cc's. It might be a DRM bug.
>>
>> I'll ask Rafael and Maciej to track this as a post-2.6.33 regression,
>> thanks.
>
> The IMA code hasn't changed since .33 so my guess is something new the
> drm code is doing with obj->filp.
>
> Thomas, any idea what the newest kernel was that didn't show you this
> problem?
I first saw this message in 2.6.34-rc2 (+free_init_pages patch), but
that was also the first bootable kernel for me as I was hit by the
NO_BOOTMEM bug...
> It might help cut down my search in the morning....
>
> -Eric
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?
2010-04-01 18:17 ` Thomas Meyer
@ 2010-04-12 11:27 ` Mimi Zohar
0 siblings, 0 replies; 6+ messages in thread
From: Mimi Zohar @ 2010-04-12 11:27 UTC (permalink / raw)
To: Thomas Meyer
Cc: Eric Paris, Andrew Morton, linux-kernel, Mimi Zohar,
James Morris, dri-devel
On Thu, 2010-04-01 at 20:17 +0200, Thomas Meyer wrote:
> Am 01.04.2010 um 04:41 schrieb Eric Paris <eparis@redhat.com>:
>
> > On Wed, 2010-03-31 at 16:32 -0700, Andrew Morton wrote:
> >> On Sun, 28 Mar 2010 13:31:49 +0200
> >> Thomas Meyer <thomas@m3y3r.de> wrote:
> >>
> >>> This warning/error/notice is new in 2.6.34-rc2+:
> >>
> >> Let's add some cc's. It might be a DRM bug.
> >>
> >> I'll ask Rafael and Maciej to track this as a post-2.6.33 regression,
> >> thanks.
> >
> > The IMA code hasn't changed since .33 so my guess is something new the
> > drm code is doing with obj->filp.
> >
> > Thomas, any idea what the newest kernel was that didn't show you this
> > problem?
>
> I first saw this message in 2.6.34-rc2 (+free_init_pages patch), but
> that was also the first bootable kernel for me as I was hit by the
> NO_BOOTMEM bug...
>
> > It might help cut down my search in the morning....
> >
> > -Eric
> >
The call to shmem_file_setup() in drm_gem_object_alloc() should properly
increment the IMA counters and the fput() in
drm_gem_object_free_common() should decrement them.
I noticed the 'bump' comment in 'include/drm/drmP.h' doesn't match the
code, but in fact does the exact opposite. Not sure if this is related.
static inline void
drm_gem_object_handle_unreference(struct drm_gem_object *obj)
{
if (obj == NULL)
return;
/*
* Must bump handle count first as this may be the last
* ref, in which case the object would disappear before we
* checked for a name
*/
kref_put(&obj->handlecount, drm_gem_object_handle_free);
drm_gem_object_unreference(obj);
}
Mimi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.34-rc2: "ima_dec_counts: open/free imbalance"?
2010-03-31 23:32 ` Andrew Morton
2010-04-01 2:41 ` Eric Paris
@ 2010-04-12 12:54 ` Daniel Vetter
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2010-04-12 12:54 UTC (permalink / raw)
To: Andrew Morton
Cc: Thomas Meyer, Mimi Zohar, James Morris, Eric Paris, linux-kernel,
dri-devel
On Wed, Mar 31, 2010 at 04:32:34PM -0700, Andrew Morton wrote:
> On Sun, 28 Mar 2010 13:31:49 +0200
> Thomas Meyer <thomas@m3y3r.de> wrote:
>
> > This warning/error/notice is new in 2.6.34-rc2+:
>
> Let's add some cc's. It might be a DRM bug.
>
> I'll ask Rafael and Maciej to track this as a post-2.6.33 regression,
> thanks.
I myself and a few testers have hit another strange inconsistency in the
gem shm handling code which might be related (some internal refcount that
gets out-of-sync and no refcount imbalances in the code). Unfortunately I
can't reproduce it anymore and I currently don't yet have a clue about
what's wrong. Currently I'm suspecting a locking goof-up.
Is there a bugzilla entry to track this?
-Daniel
> > [ 1878.810147] PM: Syncing filesystems ... done.
> > [ 1878.903316] Freezing user space processes ... (elapsed 0.01 seconds) done.
> > [ 1878.916589] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
> > [ 1878.929866] Suspending console(s) (use no_console_suspend to debug)
> > [ 1878.930229] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> > [ 1878.930370] sd 0:0:0:0: [sda] Stopping disk
> > [ 1878.981086] atl1c 0000:01:00.0: PCI INT A disabled
> > [ 1878.981369] uhci_hcd 0000:00:1d.2: PCI INT D disabled
> > [ 1878.981379] uhci_hcd 0000:00:1d.1: PCI INT B disabled
> > [ 1878.981389] uhci_hcd 0000:00:1d.0: PCI INT A disabled
> > [ 1878.981454] HDA Intel 0000:00:1b.0: PCI INT A disabled
> > [ 1878.981500] ACPI handle has no context!
> > [ 1878.981529] ehci_hcd 0000:00:1a.7: PCI INT D disabled
> > [ 1878.981540] uhci_hcd 0000:00:1a.0: PCI INT A disabled
> > [ 1878.981602] IMA: unmeasured files on fsmagic: 1021994
> > [ 1878.981605] ima_dec_counts: open/free imbalance (r:0 w:-1 o:-1)
> > [ 1878.981609] Pid: 4888, comm: async/10 Tainted: G W 2.6.34-rc2 #88
> > [ 1878.981612] Call Trace:
> > [ 1878.981620] [<c0886ac2>] ? printk+0x1d/0x23
> > [ 1878.981627] [<c05f966f>] ima_file_free+0x16f/0x210
> > [ 1878.981632] [<c04d7132>] __fput+0xf2/0x1f0
> > [ 1878.981636] [<c04d724d>] fput+0x1d/0x30
> > [ 1878.981641] [<c06cbd2f>] drm_gem_object_free_common+0x1f/0x40
> > [ 1878.981645] [<c06cbdd0>] ? drm_gem_object_free+0x0/0x40
> > [ 1878.981649] [<c06cbe01>] drm_gem_object_free+0x31/0x40
> > [ 1878.981653] [<c061d20c>] kref_put+0x2c/0x60
> > [ 1878.981658] [<c06e8078>] i915_gem_cleanup_ringbuffer+0x48/0x70
> > [ 1878.981662] [<c06e97ec>] i915_gem_idle+0x9c/0x120
> > [ 1878.981666] [<c06dcefd>] i915_drm_freeze+0x3d/0xa0
> > [ 1878.981670] [<c06dd01e>] i915_pm_suspend+0x2e/0x80
> > [ 1878.981674] [<c08871ca>] ? wait_for_common+0x1a/0x100
> > [ 1878.981679] [<c0636269>] pci_pm_suspend+0x49/0x110
> > [ 1878.981682] [<c0636220>] ? pci_pm_suspend+0x0/0x110
> > [ 1878.981687] [<c07194f1>] pm_op+0x181/0x1d0
> > [ 1878.981691] [<c07126f4>] ? device_for_each_child+0x54/0x60
> > [ 1878.981695] [<c0719eaf>] __device_suspend+0xbf/0x110
> > [ 1878.981699] [<c071a2f3>] async_suspend+0x23/0x60
> > [ 1878.981703] [<c044ff25>] async_thread+0xc5/0x210
> > [ 1878.981707] [<c0886e31>] ? schedule+0x1e1/0x450
> > [ 1878.981713] [<c042c030>] ? default_wake_function+0x0/0x20
> > [ 1878.981716] [<c044fe60>] ? async_thread+0x0/0x210
> > [ 1878.981720] [<c0449254>] kthread+0x74/0x80
> > [ 1878.981724] [<c04491e0>] ? kthread+0x0/0x80
> > [ 1878.981728] [<c04034be>] kernel_thread_helper+0x6/0x10
> > [ 1878.986489] iint_free: writecount: -1
> > [ 1878.986492] iint_free: opencount: -1
> > [ 1878.986494] iint_free: writecount: -1
> > [ 1878.986496] iint_free: opencount: -1
> > [ 1878.993205] ehci_hcd 0000:00:1d.7: PCI INT A disabled
> > [ 1879.649836] PM: suspend of devices complete after 719.812 msecs
> > [ 1879.676555] PM: late suspend of devices complete after 26.714 msecs
> > [ 1879.677144] ACPI: Preparing to enter system sleep state S3
> > [ 1879.677144] Back to C!
> >
> > Does anybody care?
> >
> > mfg
> > thomas
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-04-12 12:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-28 11:31 2.6.34-rc2: "ima_dec_counts: open/free imbalance"? Thomas Meyer
2010-03-31 23:32 ` Andrew Morton
2010-04-01 2:41 ` Eric Paris
2010-04-01 18:17 ` Thomas Meyer
2010-04-12 11:27 ` Mimi Zohar
2010-04-12 12:54 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).