linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Munsie <imunsie@au1.ibm.com>
To: Jason Baron <jbaron@redhat.com>
Cc: fweisbec <fweisbec@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/14] tracing: add compat syscall support v3
Date: Thu, 17 Jun 2010 17:39:07 +1000	[thread overview]
Message-ID: <1276759528-sup-4850@au1.ibm.com> (raw)
In-Reply-To: <20100521132405.GA2109@redhat.com>

Excerpts from Jason Baron's message of Fri May 21 23:24:07 +1000 2010:
> On Fri, May 21, 2010 at 07:40:21PM +1000, Ian Munsie wrote:
> > Hi Jason,
> > 
> > I'm currently in the process of implementing syscall tracepoints for
> > PowerPC, and a considerable amount of my work is going to end up
> > requiring these patches of yours. I've reviewed and tested your patches
> > (and spent a good chunk of time rebasing them on top of
> > tip/tracing/core) and they all seem pretty good.
> > 
> > I *particularly* like the way in which they prevent ftrace syscalls from
> > reporting that sys_swapoff was constantly firing on x86_64 kernels with
> > a 32bit userspace ;)
> > 
> > Anyway, I'm just wondering if you have an ETA for the v4 patchset to
> > address the remaining issues that Frederic raised so that they can be
> > merged.
> > 
> > Cheers,
> > -Ian
> > 
> 
> hi Ian,
> 
> I think the main issue left was that I am using the same meta data for
> both the 32-bit and 64-bit table entries, when they reference the same
> syscall. for example, for x86 both the compat and underlying 64-bit
> kernel reference 'sys_rename'. Thus, i am pointing both perf events at
> the same meta data. Frederic was saying they need to be separate. I'm
> not sure i completely understand why, since the 32-bit are just sign
> extended to 64-bit in this case. Frederic, perhaps, you can explain this
> a bit more for me?
> 
> thanks,
> 
> -Jason

Hi Jason,

I'm currently cleaning up my patch series for ftrace syscalls on PowerPC
and want to release it soon.

It's probably easiest for me if I release your compat syscall support v3
patches as part of the series. You'd still be marked as the author of
those commits - the only changes I have made to them was rebasing them
against the current tip tree and resolving the conflicts that I came
across.

Is that OK with you? Otherwise I can wait until you put out the v4
patches then rebase mine on top of those.

Cheers,
-Ian

  parent reply	other threads:[~2010-06-17  7:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 17:46 [PATCH 00/14] tracing: add compat syscall support v3 Jason Baron
2010-03-16 17:46 ` [PATCH 01/14] x86: add NR_syscalls_compat, make ia32 syscall table visible Jason Baron
2010-03-16 17:46 ` [PATCH 02/14] x86: add arch_compat_syscall_addr() Jason Baron
2010-03-17 19:11   ` Frederic Weisbecker
2010-03-16 17:46 ` [PATCH 03/14] compat: have generic is_compat_task for !CONFIG_COMPAT Jason Baron
2010-03-16 17:46 ` [PATCH 04/14] tracing: remove syscall bitmaps in preparation for compat support Jason Baron
2010-03-16 17:46 ` [PATCH 05/14] tracing: move __start_ftrace_events and __stop_ftrace_events to header file Jason Baron
2010-03-16 17:46 ` [PATCH 06/14] tracing: add tracing support for compat syscalls Jason Baron
2010-03-20  6:12   ` Frederic Weisbecker
2010-03-22 20:21     ` Jason Baron
2010-03-27  4:40       ` Frederic Weisbecker
2010-03-16 17:46 ` [PATCH 07/14] syscalls: add ARCH_COMPAT_SYSCALL_DEFINE() Jason Baron
2010-03-18 18:29   ` [PATCH 07/14 re-post] " Jason Baron
2010-03-27  4:56     ` Frederic Weisbecker
2010-05-24  7:05   ` [PATCH 07/14] " Ian Munsie
2010-05-24 20:26     ` Jason Baron
2010-03-16 17:46 ` [PATCH 08/14] x86, compat: convert ia32 layer to use Jason Baron
2010-03-16 17:46 ` [PATCH 09/14] syscalls: add new COMPAT_SYSCALL_DEFINE#N() macro Jason Baron
2010-03-16 17:46 ` [PATCH 10/14] compat: convert to use COMPAT_SYSCALL_DEFINE#N() Jason Baron
2010-03-16 17:47 ` [PATCH 11/14] compat: convert fs compat to use COMPAT_SYSCALL_DEFINE#N() macros Jason Baron
2010-03-16 17:47 ` [PATCH 12/14] tags: recognize compat syscalls Jason Baron
2010-03-16 17:47 ` [PATCH 13/14] cleanup: remove arg from TRACE_SYS_ENTER_PROFILE_INIT() macro Jason Baron
2010-03-16 17:47 ` [PATCH 14/14] tracing: make a "compat_syscalls" tracing subsys Jason Baron
2010-03-18 18:22 ` [PATCH 15/14] compat_syscalls: introduce CONFIG_COMPAT_FTRACE_SYSCALLS Jason Baron
2010-03-27  5:00 ` [PATCH 00/14] tracing: add compat syscall support v3 Frederic Weisbecker
2010-05-21  9:40 ` Ian Munsie
2010-05-21 13:24   ` Jason Baron
2010-05-21 13:31     ` Frederic Weisbecker
2010-06-17  7:39     ` Ian Munsie [this message]
2010-06-17  7:46       ` Frederic Weisbecker
2010-06-17 15:39       ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276759528-sup-4850@au1.ibm.com \
    --to=imunsie@au1.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).