From: Frederic Weisbecker <fweisbec@gmail.com>
To: Jason Baron <jbaron@redhat.com>
Cc: mingo@elte.hu, rostedt@goodmis.org, linux-kernel@vger.kernel.org,
laijs@cn.fujitsu.com, lizf@cn.fujitsu.com, hpa@zytor.com,
tglx@linutronix.de, mhiramat@redhat.com,
heiko.carstens@de.ibm.com, benh@kernel.crashing.org,
davem@davemloft.net, lethal@linux-sh.org, schwidefsky@de.ibm.com,
brueckner@linux.vnet.ibm.com, tony.luck@intel.com
Subject: Re: [PATCH 02/14] x86: add arch_compat_syscall_addr()
Date: Wed, 17 Mar 2010 20:11:39 +0100 [thread overview]
Message-ID: <20100317191136.GB5059@nowhere> (raw)
In-Reply-To: <371f973b778391a685e63986193b54f87a8c64b3.1268749695.git.jbaron@redhat.com>
On Tue, Mar 16, 2010 at 01:46:17PM -0400, Jason Baron wrote:
> Add arch_compat_syscall_addr(int nr) for x86_64. This is in preparation for adding
> compat syscall support to the event tracer.
>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
> arch/x86/include/asm/syscall.h | 5 +++++
> arch/x86/kernel/ftrace.c | 8 ++++++++
> 2 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h
> index c4a348f..4e462cc 100644
> --- a/arch/x86/include/asm/syscall.h
> +++ b/arch/x86/include/asm/syscall.h
> @@ -16,7 +16,12 @@
> #include <linux/sched.h>
> #include <linux/err.h>
>
> +#if defined(CONFIG_COMPAT) && defined(CONFIG_FTRACE_SYSCALLS)
> + #define __HAVE_ARCH_FTRACE_COMPAT_SYSCALLS
> +#endif
> +
A config would be better:
arch/Kconfig:
config HAVE_COMPAT_FTRACE_SYSCALLS
bool
config COMPAT_FTRACE_SYSCALLS
def_bool y
depends on COMPAT && FTRACE_SYSCALLS && HAVE_COMPAT_FTRACE_SYSCALLS
arch/x86/Kconfig:
config X86
[...]
select HAVE_COMPAT_FTRACE_SYSCALLS
[...]
So that we centralize the definition of COMPAT_FTRACE_SYSCALLS and
we don't need every archs to redefine the dependency and to stay sync
with potential dependency changes.
Thanks.
> extern const unsigned long sys_call_table[];
> +extern const unsigned long *ia32_sys_call_table;
>
> /*
> * Only the low 32 bits of orig_ax are meaningful, so we return int.
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index cd37469..4b36a0b 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -26,6 +26,7 @@
> #include <asm/ftrace.h>
> #include <asm/nops.h>
> #include <asm/nmi.h>
> +#include <asm/syscall.h>
>
>
> #ifdef CONFIG_DYNAMIC_FTRACE
> @@ -510,3 +511,10 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr,
> }
> }
> #endif /* CONFIG_FUNCTION_GRAPH_TRACER */
> +
> +#ifdef __HAVE_ARCH_FTRACE_COMPAT_SYSCALLS
> +unsigned long __init arch_compat_syscall_addr(int nr)
> +{
> + return (unsigned long)(&ia32_sys_call_table)[nr];
> +}
> +#endif
> --
> 1.6.5.1
>
next prev parent reply other threads:[~2010-03-17 19:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 17:46 [PATCH 00/14] tracing: add compat syscall support v3 Jason Baron
2010-03-16 17:46 ` [PATCH 01/14] x86: add NR_syscalls_compat, make ia32 syscall table visible Jason Baron
2010-03-16 17:46 ` [PATCH 02/14] x86: add arch_compat_syscall_addr() Jason Baron
2010-03-17 19:11 ` Frederic Weisbecker [this message]
2010-03-16 17:46 ` [PATCH 03/14] compat: have generic is_compat_task for !CONFIG_COMPAT Jason Baron
2010-03-16 17:46 ` [PATCH 04/14] tracing: remove syscall bitmaps in preparation for compat support Jason Baron
2010-03-16 17:46 ` [PATCH 05/14] tracing: move __start_ftrace_events and __stop_ftrace_events to header file Jason Baron
2010-03-16 17:46 ` [PATCH 06/14] tracing: add tracing support for compat syscalls Jason Baron
2010-03-20 6:12 ` Frederic Weisbecker
2010-03-22 20:21 ` Jason Baron
2010-03-27 4:40 ` Frederic Weisbecker
2010-03-16 17:46 ` [PATCH 07/14] syscalls: add ARCH_COMPAT_SYSCALL_DEFINE() Jason Baron
2010-03-18 18:29 ` [PATCH 07/14 re-post] " Jason Baron
2010-03-27 4:56 ` Frederic Weisbecker
2010-05-24 7:05 ` [PATCH 07/14] " Ian Munsie
2010-05-24 20:26 ` Jason Baron
2010-03-16 17:46 ` [PATCH 08/14] x86, compat: convert ia32 layer to use Jason Baron
2010-03-16 17:46 ` [PATCH 09/14] syscalls: add new COMPAT_SYSCALL_DEFINE#N() macro Jason Baron
2010-03-16 17:46 ` [PATCH 10/14] compat: convert to use COMPAT_SYSCALL_DEFINE#N() Jason Baron
2010-03-16 17:47 ` [PATCH 11/14] compat: convert fs compat to use COMPAT_SYSCALL_DEFINE#N() macros Jason Baron
2010-03-16 17:47 ` [PATCH 12/14] tags: recognize compat syscalls Jason Baron
2010-03-16 17:47 ` [PATCH 13/14] cleanup: remove arg from TRACE_SYS_ENTER_PROFILE_INIT() macro Jason Baron
2010-03-16 17:47 ` [PATCH 14/14] tracing: make a "compat_syscalls" tracing subsys Jason Baron
2010-03-18 18:22 ` [PATCH 15/14] compat_syscalls: introduce CONFIG_COMPAT_FTRACE_SYSCALLS Jason Baron
2010-03-27 5:00 ` [PATCH 00/14] tracing: add compat syscall support v3 Frederic Weisbecker
2010-05-21 9:40 ` Ian Munsie
2010-05-21 13:24 ` Jason Baron
2010-05-21 13:31 ` Frederic Weisbecker
2010-06-17 7:39 ` Ian Munsie
2010-06-17 7:46 ` Frederic Weisbecker
2010-06-17 15:39 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317191136.GB5059@nowhere \
--to=fweisbec@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).