* [PATCH] video: simplify strlen()==0 check in fb_get_options()
@ 2010-06-24 16:16 Denys Vlasenko
0 siblings, 0 replies; only message in thread
From: Denys Vlasenko @ 2010-06-24 16:16 UTC (permalink / raw)
To: Rafael J. Wysocki, James Simmons, linux-fbdev, Denys Vlasenko
Cc: linux-kernel, Denys Vlasenko
Replaced !strlen(str) check with !str[0]. Removed the variable
which was used solely to store strlen result.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---
drivers/video/fbmem.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 731fce6..a8500c6 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1786,7 +1786,7 @@ static int ofonly __read_mostly;
int fb_get_options(char *name, char **option)
{
char *opt, *options = NULL;
- int opt_len, retval = 0;
+ int retval = 0;
int name_len = strlen(name), i;
if (name_len && ofonly && strncmp(name, "offb", 4))
@@ -1796,8 +1796,7 @@ int fb_get_options(char *name, char **option)
for (i = 0; i < FB_MAX; i++) {
if (video_options[i] == NULL)
continue;
- opt_len = strlen(video_options[i]);
- if (!opt_len)
+ if (!video_options[i][0])
continue;
opt = video_options[i];
if (!strncmp(name, opt, name_len) &&
--
1.6.2.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-06-24 14:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-24 16:16 [PATCH] video: simplify strlen()==0 check in fb_get_options() Denys Vlasenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).