* [PATCH] msi-laptop: make struct rfkill_ops const
@ 2010-07-08 2:08 Axel Lin
0 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2010-07-08 2:08 UTC (permalink / raw)
To: linux-kernel
Cc: Lennart Poettering, Matthew Garrett, Lee, Chun-Yi,
Greg Kroah-Hartman, Richard Purdie, platform-driver-x86
rfkill uses a const struct rfkill_ops pointer.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/platform/x86/msi-laptop.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
index afd762b..05634f8 100644
--- a/drivers/platform/x86/msi-laptop.c
+++ b/drivers/platform/x86/msi-laptop.c
@@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
return 0;
}
-static struct rfkill_ops rfkill_bluetooth_ops = {
+static const struct rfkill_ops rfkill_bluetooth_ops = {
.set_block = rfkill_bluetooth_set
};
-static struct rfkill_ops rfkill_wlan_ops = {
+static const struct rfkill_ops rfkill_wlan_ops = {
.set_block = rfkill_wlan_set
};
-static struct rfkill_ops rfkill_threeg_ops = {
+static const struct rfkill_ops rfkill_threeg_ops = {
.set_block = rfkill_threeg_set
};
--
1.5.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] msi-laptop: make struct rfkill_ops const
@ 2010-07-09 10:26 Joey Lee
0 siblings, 0 replies; 5+ messages in thread
From: Joey Lee @ 2010-07-09 10:26 UTC (permalink / raw)
To: axel.lin
Cc: mzxreary, rpurdie, mjg, gregkh, linux-kernel, platform-driver-x86
Hi Axel,
於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> rfkill uses a const struct rfkill_ops pointer.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/platform/x86/msi-laptop.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> index afd762b..05634f8 100644
> --- a/drivers/platform/x86/msi-laptop.c
> +++ b/drivers/platform/x86/msi-laptop.c
> @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> return 0;
> }
>
> -static struct rfkill_ops rfkill_bluetooth_ops = {
> +static const struct rfkill_ops rfkill_bluetooth_ops = {
> .set_block = rfkill_bluetooth_set
> };
>
> -static struct rfkill_ops rfkill_wlan_ops = {
> +static const struct rfkill_ops rfkill_wlan_ops = {
> .set_block = rfkill_wlan_set
> };
>
> -static struct rfkill_ops rfkill_threeg_ops = {
> +static const struct rfkill_ops rfkill_threeg_ops = {
> .set_block = rfkill_threeg_set
> };
>
The patch is good to me, thank's a lot!
Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
Joey Lee
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] msi-laptop: make struct rfkill_ops const
@ 2010-07-09 10:24 Joey Lee
0 siblings, 0 replies; 5+ messages in thread
From: Joey Lee @ 2010-07-09 10:24 UTC (permalink / raw)
To: greg
Cc: mzxreary, axel.lin, rpurdie, mjg, gregkh, linux-kernel,
platform-driver-x86
Hi Greg,
於 四，2010-07-08 於 11:39 -0700，Greg KH 提到：
> On Thu, Jul 08, 2010 at 11:53:15AM -0600, Joey Lee wrote:
> > Hi Axel,
> >
> > 於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> > > rfkill uses a const struct rfkill_ops pointer.
> > >
> > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > > ---
> > > drivers/platform/x86/msi-laptop.c | 6 +++---
> > > 1 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> > > index afd762b..05634f8 100644
> > > --- a/drivers/platform/x86/msi-laptop.c
> > > +++ b/drivers/platform/x86/msi-laptop.c
> > > @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> > > return 0;
> > > }
> > >
> > > -static struct rfkill_ops rfkill_bluetooth_ops = {
> > > +static const struct rfkill_ops rfkill_bluetooth_ops = {
> > > .set_block = rfkill_bluetooth_set
> > > };
> > >
> > > -static struct rfkill_ops rfkill_wlan_ops = {
> > > +static const struct rfkill_ops rfkill_wlan_ops = {
> > > .set_block = rfkill_wlan_set
> > > };
> > >
> > > -static struct rfkill_ops rfkill_threeg_ops = {
> > > +static const struct rfkill_ops rfkill_threeg_ops = {
> > > .set_block = rfkill_threeg_set
> > > };
> > >
> >
> > The patch good to me, do I need Signed-off it?
> > How can I signed off a patch?
>
> You can say:
> Signed-off-by: your name <your_email>
>
> and then Matthew will add it.
>
> Or you can take the original patch, add your signed-off-by, and resend
> it to Matthew keeping the correct authorship information there by making
> sure the first line in the body of the email has:
> From: Original author <email>
>
> so git will get it right.
>
> hope this helps,
Thank's for your kindly teach, it's useful to a rookie. :-)
Joey Lee
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] msi-laptop: make struct rfkill_ops const
2010-07-08 17:53 Joey Lee
@ 2010-07-08 18:39 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2010-07-08 18:39 UTC (permalink / raw)
To: Joey Lee
Cc: axel.lin, mzxreary, rpurdie, mjg, gregkh, linux-kernel,
platform-driver-x86
On Thu, Jul 08, 2010 at 11:53:15AM -0600, Joey Lee wrote:
> Hi Axel,
>
> 於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> > rfkill uses a const struct rfkill_ops pointer.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > ---
> > drivers/platform/x86/msi-laptop.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> > index afd762b..05634f8 100644
> > --- a/drivers/platform/x86/msi-laptop.c
> > +++ b/drivers/platform/x86/msi-laptop.c
> > @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> > return 0;
> > }
> >
> > -static struct rfkill_ops rfkill_bluetooth_ops = {
> > +static const struct rfkill_ops rfkill_bluetooth_ops = {
> > .set_block = rfkill_bluetooth_set
> > };
> >
> > -static struct rfkill_ops rfkill_wlan_ops = {
> > +static const struct rfkill_ops rfkill_wlan_ops = {
> > .set_block = rfkill_wlan_set
> > };
> >
> > -static struct rfkill_ops rfkill_threeg_ops = {
> > +static const struct rfkill_ops rfkill_threeg_ops = {
> > .set_block = rfkill_threeg_set
> > };
> >
>
> The patch good to me, do I need Signed-off it?
> How can I signed off a patch?
You can say:
Signed-off-by: your name <your_email>
and then Matthew will add it.
Or you can take the original patch, add your signed-off-by, and resend
it to Matthew keeping the correct authorship information there by making
sure the first line in the body of the email has:
From: Original author <email>
so git will get it right.
hope this helps,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] msi-laptop: make struct rfkill_ops const
@ 2010-07-08 17:53 Joey Lee
2010-07-08 18:39 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Joey Lee @ 2010-07-08 17:53 UTC (permalink / raw)
To: axel.lin
Cc: mzxreary, rpurdie, mjg, gregkh, linux-kernel, platform-driver-x86
Hi Axel,
於 四，2010-07-08 於 10:08 +0800，Axel Lin 提到：
> rfkill uses a const struct rfkill_ops pointer.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/platform/x86/msi-laptop.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
> index afd762b..05634f8 100644
> --- a/drivers/platform/x86/msi-laptop.c
> +++ b/drivers/platform/x86/msi-laptop.c
> @@ -562,15 +562,15 @@ static int rfkill_threeg_set(void *data, bool blocked)
> return 0;
> }
>
> -static struct rfkill_ops rfkill_bluetooth_ops = {
> +static const struct rfkill_ops rfkill_bluetooth_ops = {
> .set_block = rfkill_bluetooth_set
> };
>
> -static struct rfkill_ops rfkill_wlan_ops = {
> +static const struct rfkill_ops rfkill_wlan_ops = {
> .set_block = rfkill_wlan_set
> };
>
> -static struct rfkill_ops rfkill_threeg_ops = {
> +static const struct rfkill_ops rfkill_threeg_ops = {
> .set_block = rfkill_threeg_set
> };
>
The patch good to me, do I need Signed-off it?
How can I signed off a patch?
Thank's a lot!
Joey Lee
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-07-09 10:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-08 2:08 [PATCH] msi-laptop: make struct rfkill_ops const Axel Lin
2010-07-08 17:53 Joey Lee
2010-07-08 18:39 ` Greg KH
2010-07-09 10:24 Joey Lee
2010-07-09 10:26 Joey Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).