linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND 1/2] signals: annotate lock context change on ptrace_stop()
@ 2010-09-26  3:53 Namhyung Kim
  2010-09-26  3:53 ` [PATCH RESEND 2/2] ptrace: annotate lock context change on exit_ptrace() Namhyung Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2010-09-26  3:53 UTC (permalink / raw)
  To: Andrew Morton, Ingo Molnar; +Cc: Roland McGrath, Oleg Nesterov, linux-kernel

ptrace_stop() releases and regrabs current->sighand->siglock but
was missing proper annotation. Add it.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: Roland McGrath <roland@redhat.com>
---
 kernel/signal.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index e4e8cfe..dce5c78 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1618,6 +1618,8 @@ static int sigkill_pending(struct task_struct *tsk)
  * is gone, we keep current->exit_code unless clear_code.
  */
 static void ptrace_stop(int exit_code, int clear_code, siginfo_t *info)
+	__releases(&current->sighand->siglock)
+	__acquires(&current->sighand->siglock)
 {
 	if (arch_ptrace_stop_needed(exit_code, info)) {
 		/*
-- 
1.7.2.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH RESEND 2/2] ptrace: annotate lock context change on exit_ptrace()
  2010-09-26  3:53 [PATCH RESEND 1/2] signals: annotate lock context change on ptrace_stop() Namhyung Kim
@ 2010-09-26  3:53 ` Namhyung Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2010-09-26  3:53 UTC (permalink / raw)
  To: Andrew Morton, Ingo Molnar; +Cc: Roland McGrath, Oleg Nesterov, linux-kernel

exit_ptrace() releases and regrabs tasklist_lock but was missing
proper annotation. Add it.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: Roland McGrath <roland@redhat.com>
---
 kernel/ptrace.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/ptrace.c b/kernel/ptrace.c
index f34d798..4afd9b8 100644
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -329,6 +329,8 @@ int ptrace_detach(struct task_struct *child, unsigned int data)
  * and reacquire the lock.
  */
 void exit_ptrace(struct task_struct *tracer)
+	__releases(&tasklist_lock)
+	__acquires(&tasklist_lock)
 {
 	struct task_struct *p, *n;
 	LIST_HEAD(ptrace_dead);
-- 
1.7.2.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-26  3:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-26  3:53 [PATCH RESEND 1/2] signals: annotate lock context change on ptrace_stop() Namhyung Kim
2010-09-26  3:53 ` [PATCH RESEND 2/2] ptrace: annotate lock context change on exit_ptrace() Namhyung Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).