From: Joe Perches <joe@perches.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h
Date: Tue, 09 Nov 2010 12:30:19 -0800 [thread overview]
Message-ID: <1289334619.28590.39.camel@Joe-Laptop> (raw)
In-Reply-To: <1289333413.28590.29.camel@Joe-Laptop>
On Tue, 2010-11-09 at 12:10 -0800, Joe Perches wrote:
> On Tue, 2010-11-09 at 22:01 +0200, Alexey Dobriyan wrote:
> > Why linux_proc_banner is moved?
> It's only used by a printk.
Checking again, linux_proc_banner is only
used in one seq_printf and is not used in
a printk.
$ git grep -w linux_proc_banner *
fs/proc/version.c: seq_printf(m, linux_proc_banner,
include/linux/logging.h:extern const char linux_proc_banner[];
init/version.c:const char linux_proc_banner[] =
I supposed it could be removed from kernel.h
or logging.h/printk.h and just declared extern
in fs/proc/version.c or moved to init.h or
maybe even version.h.
init.h already has other extern variables that
are declared in init/main.c so that might
make some sense.
next prev parent reply other threads:[~2010-11-09 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 5:38 [PATCH] include/linux/kernel.h: Move logging bits to include/linux/logging.h Joe Perches
2010-11-09 18:23 ` Linus Torvalds
2010-11-09 18:43 ` [PATCH V2] " Joe Perches
2010-11-09 18:49 ` Linus Torvalds
2010-11-09 19:17 ` Joe Perches
2010-11-09 21:00 ` Ted Ts'o
2010-11-09 21:08 ` Joe Perches
2010-11-09 23:52 ` [PATCH V3] include/linux/kernel.h: Move logging bits to include/linux/printk.h Joe Perches
2010-11-09 20:01 ` [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h Alexey Dobriyan
2010-11-09 20:10 ` Joe Perches
2010-11-09 20:30 ` Joe Perches [this message]
2010-11-15 18:04 ` [PATCH V4] include/linux/kernel.h: Move logging bits to include/linux/printk.h Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289334619.28590.39.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).