From: Linus Torvalds <torvalds@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include/linux/kernel.h: Move logging bits to include/linux/logging.h
Date: Tue, 9 Nov 2010 10:23:25 -0800 [thread overview]
Message-ID: <AANLkTime8YvyHysZF5sX6V2mXWJ0FUtdecpVFgRGqYm6@mail.gmail.com> (raw)
In-Reply-To: <1289281110-8559-1-git-send-email-joe@perches.com>
On Mon, Nov 8, 2010 at 9:38 PM, Joe Perches <joe@perches.com> wrote:
> Move the logging bits from kernel.h into logging.h so that
> there is a bit more logical separation of the generic from
> the logging specific parts.
>
> Add pr_<level>_once macros to logging.h.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> include/linux/kernel.h | 246 +-----------------------------------
> include/linux/logging.h | 322 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 324 insertions(+), 244 deletions(-)
> create mode 100644 include/linux/logging.h
I detest patches like this.
The code movement makes it really hard to see what changed. So if you
do code movement, please do _only_ code movement, and send a separate
patch that actually changes things.
Linus
next prev parent reply other threads:[~2010-11-09 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 5:38 [PATCH] include/linux/kernel.h: Move logging bits to include/linux/logging.h Joe Perches
2010-11-09 18:23 ` Linus Torvalds [this message]
2010-11-09 18:43 ` [PATCH V2] " Joe Perches
2010-11-09 18:49 ` Linus Torvalds
2010-11-09 19:17 ` Joe Perches
2010-11-09 21:00 ` Ted Ts'o
2010-11-09 21:08 ` Joe Perches
2010-11-09 23:52 ` [PATCH V3] include/linux/kernel.h: Move logging bits to include/linux/printk.h Joe Perches
2010-11-09 20:01 ` [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h Alexey Dobriyan
2010-11-09 20:10 ` Joe Perches
2010-11-09 20:30 ` Joe Perches
2010-11-15 18:04 ` [PATCH V4] include/linux/kernel.h: Move logging bits to include/linux/printk.h Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2010-11-09 5:37 [PATCH] include/linux/kernel.h: Move logging bits to include/linux/logging.h Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTime8YvyHysZF5sX6V2mXWJ0FUtdecpVFgRGqYm6@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).