[PATCH] um: mark CONFIG_HIGHMEM as broken

[PATCH] um: mark CONFIG_HIGHMEM as broken

[Richard Weinberger]

Currently CONFIG_HIGHMEM is broken on User Mode Linux.
I'm not sure if it worked ever.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 arch/um/Kconfig.um |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/Kconfig.um b/arch/um/Kconfig.um
index 50d6aa2..f8d1d0d 100644
--- a/arch/um/Kconfig.um
+++ b/arch/um/Kconfig.um
@@ -131,7 +131,7 @@ config NR_CPUS
 
 config HIGHMEM
 	bool "Highmem support (EXPERIMENTAL)"
-	depends on !64BIT && EXPERIMENTAL
+	depends on !64BIT && BROKEN
 	default n
 	help
 	  This was used to allow UML to run with big amounts of memory.
-- 
1.6.6.1

Re: [PATCH] um: mark CONFIG_HIGHMEM as broken

[Andrew Morton]

On Fri, 12 Nov 2010 00:18:08 +0100
Richard Weinberger <richard@nod.at> wrote:

> Currently CONFIG_HIGHMEM is broken on User Mode Linux.
> I'm not sure if it worked ever.
> 

What is "broken" about it?

Re: [PATCH] um: mark CONFIG_HIGHMEM as broken

[Richard Weinberger]

Am Freitag 12 November 2010, 20:29:04 schrieb Andrew Morton:
> On Fri, 12 Nov 2010 00:18:08 +0100
> 
> Richard Weinberger <richard@nod.at> wrote:
> > Currently CONFIG_HIGHMEM is broken on User Mode Linux.
> > I'm not sure if it worked ever.
> 
> What is "broken" about it?

Currently it does not even build.
This is very annoying when using "make randconfig".

And it was never stable.
See commit ce2d2aed:
commit ce2d2aedcc3ca582fed90f44970e8b3e4f006a7d
Author: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Date:   Wed Jan 18 17:42:59 2006 -0800

    [PATCH] uml: arch Kconfig menu cleanups
    
    *) mark as "EXPERIMENTAL" various items that either aren't very stable or
       that are actively crashing the setup of users which don't really need them
       (i.e.  HIGHMEM and 3-level pagetables on x86 - nobody needs either,
       everybody reports "I'm using it and getting trouble").
    
    *) move net/Kconfig near to the rest of network configurations, and
       drivers/block/Kconfig near "Block layer" submenu.
    
    *) it's useless and doesn't work well to force NETDEVICES on and to disable
       the prompt like it's done.  Better remove the attempt, and change that to a
       simple "default y if UML".
    
    *) drop the warning about "report problems about HPPFS" - it's redundant
       anyway, as that's the usual procedure, and HPPFS users are especially
       technical (i.e.  they know reporting bugs is _good_).
    
    Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    Cc: Jeff Dike <jdike@addtoit.com>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Thanks,
//richard