From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: Patrick McHardy <kaber@trash.net>,
David Lamparter <equinox@diac24.net>,
Eric Paris <eparis@redhat.com>, Hua Zhong <hzhong@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org, paul.moore@hp.com
Subject: Re: a problem tcp_v4_err()
Date: Fri, 12 Nov 2010 19:12:58 +0100 [thread overview]
Message-ID: <1289585578.3185.268.camel@edumazet-laptop> (raw)
In-Reply-To: <20101112175715.GB16544@ms2.inr.ac.ru>
Le vendredi 12 novembre 2010 à 20:57 +0300, Alexey Kuznetsov a écrit :
> Hello!
>
> I looked at tcp_v4_err() and found something strange. Quite non-trivial operations
> are performed on unlocked sockets. It looks like at least this BUG_ON():
>
> skb = tcp_write_queue_head(sk);
> BUG_ON(!skb);
>
> can be easily triggered.
>
> Do I miss something?
>
Hi Alexey !
I see socket is locked around line 368,
bh_lock_sock(sk);
/* If too many ICMPs get dropped on busy
* servers this needs to be solved differently.
*/
if (sock_owned_by_user(sk))
NET_INC_STATS_BH(net, LINUX_MIB_LOCKDROPPEDICMPS);
Hmm, maybe some goto is missing ;)
next prev parent reply other threads:[~2010-11-12 18:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 21:03 [RFC PATCH] network: return errors if we know tcp_connect failed Eric Paris
2010-11-11 21:14 ` Eric Dumazet
2010-11-11 21:58 ` Hua Zhong
2010-11-12 7:36 ` Patrick McHardy
2010-11-12 23:14 ` Hua Zhong
2010-11-15 10:32 ` Patrick McHardy
2010-11-15 15:47 ` Eric Paris
2010-11-15 15:57 ` Patrick McHardy
2010-11-15 16:04 ` Patrick McHardy
2010-11-15 16:36 ` Patrick McHardy
2010-11-15 16:46 ` David Miller
2010-11-15 20:00 ` Alexey Kuznetsov
2010-11-12 16:08 ` Eric Paris
2010-11-12 16:15 ` Eric Dumazet
2010-11-12 16:35 ` David Lamparter
2010-11-12 16:53 ` Eric Paris
2010-11-12 16:54 ` Patrick McHardy
2010-11-12 17:57 ` a problem tcp_v4_err() Alexey Kuznetsov
2010-11-12 18:12 ` Eric Dumazet [this message]
2010-11-12 18:21 ` Eric Dumazet
2010-11-12 18:27 ` Eric Dumazet
2010-11-12 18:31 ` Alexey Kuznetsov
2010-11-12 18:29 ` Alexey Kuznetsov
2010-11-12 18:33 ` Eric Dumazet
2010-11-12 19:22 ` David Miller
2010-11-12 21:18 ` Eric Dumazet
2010-11-12 21:36 ` David Miller
2010-11-12 21:16 ` [RFC PATCH] network: return errors if we know tcp_connect failed David Lamparter
2010-11-12 21:18 ` David Miller
2010-11-12 17:46 ` Alexey Kuznetsov
2010-11-12 19:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289585578.3185.268.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=equinox@diac24.net \
--cc=hzhong@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).