* [PATCH] scripts/checkpatch.pl: Add check for multiple terminating semicolons and casts of vmalloc
@ 2010-11-15 16:57 Joe Perches
0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2010-11-15 16:57 UTC (permalink / raw)
To: Andy Whitcroft; +Cc: Andrew Morton, LKML
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3c7fc0..36d6851 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2785,10 +2785,15 @@ sub process {
}
# check for pointless casting of kmalloc return
- if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) {
+ if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
}
+# check for multiple semicolons
+ if ($line =~ /;\s*;\s*$/) {
+ WARN("Statements terminations use 1 semicolon\n" . $herecurr);
+ }
+
# check for gcc specific __FUNCTION__
if ($line =~ /__FUNCTION__/) {
WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-11-15 16:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-15 16:57 [PATCH] scripts/checkpatch.pl: Add check for multiple terminating semicolons and casts of vmalloc Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).