linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH TRIVIAL] AT91: usb: fix typo in atmel_usba_udc driver
@ 2010-11-16 10:14 Josh Wu
  2010-11-16 10:51 ` Jiri Kosina
  2010-11-16 14:35 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 4+ messages in thread
From: Josh Wu @ 2010-11-16 10:14 UTC (permalink / raw)
  To: jkosina; +Cc: linux-kernel, linux-arm-kernel, nicolas.ferre, plagnioj, Josh Wu

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
fix against 2.6.37-rc1

 drivers/usb/gadget/atmel_usba_udc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
index b5e20e8..717ff65 100644
--- a/drivers/usb/gadget/atmel_usba_udc.c
+++ b/drivers/usb/gadget/atmel_usba_udc.c
@@ -2017,7 +2017,7 @@ static int __init usba_udc_probe(struct platform_device *pdev)
 			}
 		} else {
 			/* gpio_request fail so use -EINVAL for gpio_is_valid */
-			ubc->vbus_pin = -EINVAL;
+			udc->vbus_pin = -EINVAL;
 		}
 	}
 
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH TRIVIAL] AT91: usb: fix typo in atmel_usba_udc driver
  2010-11-16 10:14 [PATCH TRIVIAL] AT91: usb: fix typo in atmel_usba_udc driver Josh Wu
@ 2010-11-16 10:51 ` Jiri Kosina
  2010-11-16 14:09   ` Greg KH
  2010-11-16 14:35 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2010-11-16 10:51 UTC (permalink / raw)
  To: Josh Wu
  Cc: linux-kernel, linux-arm-kernel, nicolas.ferre, plagnioj,
	linux-usb, Greg KH

On Tue, 16 Nov 2010, Josh Wu wrote:

> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> fix against 2.6.37-rc1
> 
>  drivers/usb/gadget/atmel_usba_udc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
> index b5e20e8..717ff65 100644
> --- a/drivers/usb/gadget/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/atmel_usba_udc.c
> @@ -2017,7 +2017,7 @@ static int __init usba_udc_probe(struct platform_device *pdev)
>  			}
>  		} else {
>  			/* gpio_request fail so use -EINVAL for gpio_is_valid */
> -			ubc->vbus_pin = -EINVAL;
> +			udc->vbus_pin = -EINVAL;
>  		}
>  	}
>  

As this is a compile fix (for bug introduced by 969affff547027), I am 
adding Greg and linux-usb@ to CC. I usually don't push trivial changes 
more than once per release, but this needs to go in faster.

Greg, could you please take it?

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH TRIVIAL] AT91: usb: fix typo in atmel_usba_udc driver
  2010-11-16 10:51 ` Jiri Kosina
@ 2010-11-16 14:09   ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2010-11-16 14:09 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Josh Wu, linux-kernel, linux-arm-kernel, nicolas.ferre, plagnioj,
	linux-usb

On Tue, Nov 16, 2010 at 11:51:32AM +0100, Jiri Kosina wrote:
> On Tue, 16 Nov 2010, Josh Wu wrote:
> 
> > Signed-off-by: Josh Wu <josh.wu@atmel.com>
> > ---
> > fix against 2.6.37-rc1
> > 
> >  drivers/usb/gadget/atmel_usba_udc.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
> > index b5e20e8..717ff65 100644
> > --- a/drivers/usb/gadget/atmel_usba_udc.c
> > +++ b/drivers/usb/gadget/atmel_usba_udc.c
> > @@ -2017,7 +2017,7 @@ static int __init usba_udc_probe(struct platform_device *pdev)
> >  			}
> >  		} else {
> >  			/* gpio_request fail so use -EINVAL for gpio_is_valid */
> > -			ubc->vbus_pin = -EINVAL;
> > +			udc->vbus_pin = -EINVAL;
> >  		}
> >  	}
> >  
> 
> As this is a compile fix (for bug introduced by 969affff547027), I am 
> adding Greg and linux-usb@ to CC. I usually don't push trivial changes 
> more than once per release, but this needs to go in faster.
> 
> Greg, could you please take it?

Yes, I will take it.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH TRIVIAL] AT91: usb: fix typo in atmel_usba_udc driver
  2010-11-16 10:14 [PATCH TRIVIAL] AT91: usb: fix typo in atmel_usba_udc driver Josh Wu
  2010-11-16 10:51 ` Jiri Kosina
@ 2010-11-16 14:35 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2010-11-16 14:35 UTC (permalink / raw)
  To: Josh Wu; +Cc: jkosina, linux-kernel, linux-arm-kernel, nicolas.ferre

On 18:14 Tue 16 Nov     , Josh Wu wrote:
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Best Regards,
J.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-11-16 14:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-16 10:14 [PATCH TRIVIAL] AT91: usb: fix typo in atmel_usba_udc driver Josh Wu
2010-11-16 10:51 ` Jiri Kosina
2010-11-16 14:09   ` Greg KH
2010-11-16 14:35 ` Jean-Christophe PLAGNIOL-VILLARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).