* [PATCH] debug_core: cleanup kgdb_cpu_enter() that removing smp_mb()
@ 2010-11-26 9:14 Dongdong Deng
0 siblings, 0 replies; only message in thread
From: Dongdong Deng @ 2010-11-26 9:14 UTC (permalink / raw)
To: jason.wessel; +Cc: kgdb-bugreport, linux-kernel, libfetion
Commit dfee3a7b92208b30f77876068aece9ea571270c2(debug_core:
refactor locking for master/slave cpus) uses spin_lock to replace
the atomic counter lock mechanism, and most kgdb data was designed
to per-cpu, thus the 'smp_mb()' operation is useless here now.
Signed-off-by: Dongdong Deng <libfetion@gmail.com>
---
kernel/debug/debug_core.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index 722968f..1b019b5 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -492,9 +492,6 @@ acquirelock:
kgdb_info[cpu].ret_state = 0;
kgdb_info[cpu].irq_depth = hardirq_count() >> HARDIRQ_SHIFT;
- /* Make sure the above info reaches the primary CPU */
- smp_mb();
-
if (exception_level == 1) {
if (raw_spin_trylock(&dbg_master_lock))
atomic_xchg(&kgdb_active, cpu);
--
1.6.0.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-11-26 9:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-26 9:14 [PATCH] debug_core: cleanup kgdb_cpu_enter() that removing smp_mb() Dongdong Deng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).