linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rtc: at91rm9200: Fix locking in interrupt handler
@ 2015-03-15 10:54 David Dueck
  2015-03-15 12:10 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: David Dueck @ 2015-03-15 10:54 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: linux-kernel, boris.brezillon, alexandre.belloni, a.zummo,
	rtc-linux, nicolas.ferre

Signed-off-by: David Dueck <davidcdueck@googlemail.com>
---
 drivers/rtc/rtc-at91rm9200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index b4f7744..b283a1a 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
 
 		ret = IRQ_HANDLED;
 	}
-	spin_lock(&suspended_lock);
+	spin_unlock(&suspended_lock);
 
 	return ret;
 }
-- 
2.3.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rtc: at91rm9200: Fix locking in interrupt handler
  2015-03-15 10:54 [PATCH] rtc: at91rm9200: Fix locking in interrupt handler David Dueck
@ 2015-03-15 12:10 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-03-15 12:10 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: David Dueck, boris.brezillon, rtc-linux, a.zummo, nicolas.ferre,
	linux-kernel, alexandre.belloni

On Sunday 15 March 2015 11:54:47 David Dueck wrote:
> Signed-off-by: David Dueck <davidcdueck@googlemail.com>
> 

Please always describe why a change is done. Was this a recent
regression? What caused it?

	Arnd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-15 12:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-15 10:54 [PATCH] rtc: at91rm9200: Fix locking in interrupt handler David Dueck
2015-03-15 12:10 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).