From: Steve Longerbeam <slongerbeam@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>, linux-media@vger.kernel.org
Cc: Gael PORTAY <gael.portay@collabora.com>,
Peter Seiderer <ps.report@gmx.net>,
stable@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel
Date: Mon, 21 Jan 2019 10:46:05 -0800 [thread overview]
Message-ID: <12937f2b-e25e-6cc5-0727-59a5e6224fd9@gmail.com> (raw)
In-Reply-To: <7432d18b-12fc-34c6-832f-576fc1b8e2e8@gmail.com>
On 1/21/19 10:43 AM, Steve Longerbeam wrote:
>
>
> On 1/21/19 3:49 AM, Philipp Zabel wrote:
>> Also ipu_smfc_disable is refcounted, so if the other CSI is capturing
>> simultaneously, this change has no effect.
>
> Sigh, you're right. Let me go back to disabling the CSI before the
> channel, the CSI enable/disable is not refcounted (it doesn't need to
> be since it is single use) so it doesn't have this problem.
>
> Should we drop this patch or keep it (with a big comment)? By only
> changing the disable order to "CSI then channel", the hang is reliably
> fixed from my and Gael's testing, but my concern is that by not
> disabling the SMFC before the channel, the SMFC could still empty its
> FIFO to the channel's internal FIFO and still create a hang.
Well, as you said it will have no effect if both CSI's are streaming
with the SMFC, in which case the danger would still exist. Perhaps it
would be best to just drop this patch.
Steve
next prev parent reply other threads:[~2019-01-21 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190119010457.2623-1-slongerbeam@gmail.com>
2019-01-19 1:04 ` [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel Steve Longerbeam
2019-01-21 11:49 ` Philipp Zabel
2019-01-21 15:21 ` Gaël PORTAY
2019-01-21 18:43 ` Steve Longerbeam
2019-01-21 18:46 ` Steve Longerbeam [this message]
2019-01-22 9:58 ` Philipp Zabel
2019-01-22 15:13 ` Gaël PORTAY
2019-01-19 1:04 ` [PATCH v3 2/2] media: imx: prpencvf: Stop upstream " Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12937f2b-e25e-6cc5-0727-59a5e6224fd9@gmail.com \
--to=slongerbeam@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gael.portay@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ps.report@gmx.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).