From: "Gaël PORTAY" <gael.portay@collabora.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
linux-media@vger.kernel.org, Peter Seiderer <ps.report@gmx.net>,
stable@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel
Date: Mon, 21 Jan 2019 10:21:08 -0500 [thread overview]
Message-ID: <20190121152107.gruavvgkabwokvnz@archlinux.localdomain> (raw)
In-Reply-To: <1548071350.3287.3.camel@pengutronix.de>
Philipp,
On Mon, Jan 21, 2019 at 12:49:10PM +0100, Philipp Zabel wrote:
> Hi,
>
> On Fri, 2019-01-18 at 17:04 -0800, Steve Longerbeam wrote:
> > Disable the SMFC before disabling the IDMA channel, instead of after,
> > in csi_idmac_unsetup().
> >
> > This fixes a complete system hard lockup on the SabreAuto when streaming
> > from the ADV7180, by repeatedly sending a stream off immediately followed
> > by stream on:
> >
> > while true; do v4l2-ctl -d4 --stream-mmap --stream-count=3; done
> >
> > Eventually this either causes the system lockup or EOF timeouts at all
> > subsequent stream on, until a system reset.
> >
> > The lockup occurs when disabling the IDMA channel at stream off. Stopping
> > the video data stream entering the IDMA channel before disabling the
> > channel itself appears to be a reliable fix for the hard lockup. That can
> > be done either by disabling the SMFC or the CSI before disabling the
> > channel. Disabling the SMFC before the channel is the easiest solution,
> > so do that.
> >
> > Fixes: 4a34ec8e470cb ("[media] media: imx: Add CSI subdev driver")
> >
> > Suggested-by: Peter Seiderer <ps.report@gmx.net>
> > Reported-by: Gaël PORTAY <gael.portay@collabora.com>
> > Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
>
> Gaël, could we get a Tested-by: for this as well?
>
I have not tested the v3 yet. I have planned to do it later this day for
a all night testing and report the result then.
Gael
next prev parent reply other threads:[~2019-01-21 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190119010457.2623-1-slongerbeam@gmail.com>
2019-01-19 1:04 ` [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel Steve Longerbeam
2019-01-21 11:49 ` Philipp Zabel
2019-01-21 15:21 ` Gaël PORTAY [this message]
2019-01-21 18:43 ` Steve Longerbeam
2019-01-21 18:46 ` Steve Longerbeam
2019-01-22 9:58 ` Philipp Zabel
2019-01-22 15:13 ` Gaël PORTAY
2019-01-19 1:04 ` [PATCH v3 2/2] media: imx: prpencvf: Stop upstream " Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121152107.gruavvgkabwokvnz@archlinux.localdomain \
--to=gael.portay@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ps.report@gmx.net \
--cc=slongerbeam@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).