[PATCH v2 0/3] qcom: add support for SPMI PMICs found on SM8550 platforms

[PATCH v2 0/3] qcom: add support for SPMI PMICs found on SM8550 platforms

[Neil Armstrong]

The SM8550 based platforms sports a bunch of new PMICs:
- pm8550
- pm8550b
- pm8550ve
- pm8550vs
- pmk8550
- pmr735d
- pm8010

With GPIO support on:
- pm8550
- pm8550b
- pm8550ve
- pm8550vs
- pmk8550
- pmr735d

This documents bindings for those SPMI PMIC and adds compatible in the
PMIC pinctrl driver for GPIO support.

To: Andy Gross <agross@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Lee Jones <lee@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

---
Changes in v2:
- Squashed patch 3 & 2 into 1, added Reviewed-by from Krzysztof
- Squashed patch 5 into 4, added Reviewed-by from Krzysztof
- Squashed patch 7 into 6, added Reviewed-by from Konrad
- Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-spmi-v1-0-6338a2b4b241@linaro.org

---
Neil Armstrong (3):
      dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550, pm8010 & pmr735d
      dt-bindings: pinctrl: qcom,pmic-gpio: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550 & pmr735d
      pinctrl: qcom: spmi-gpio: add support for pm8550 & pmr735d gpio control

 .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml        |  7 +++++++
 .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml    | 18 ++++++++++++++++++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c               |  6 ++++++
 3 files changed, 31 insertions(+)
---
base-commit: 8274e19d9db1019f8fac39cf46da6680513fd5d3
change-id: 20221114-narmstrong-sm8550-upstream-spmi-d2c999ec5dc1

Best regards,
-- 
Neil Armstrong <neil.armstrong@linaro.org>

[PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550, pm8010 & pmr735d

[Neil Armstrong]

Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550.
pm8010 & pmr735d SPMI PMICs

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index c8362efd4345..8c9b042b4f30 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -43,6 +43,7 @@ properties:
           - qcom,pm8004
           - qcom,pm8005
           - qcom,pm8009
+          - qcom,pm8010
           - qcom,pm8019
           - qcom,pm8028
           - qcom,pm8110
@@ -54,6 +55,10 @@ properties:
           - qcom,pm8350
           - qcom,pm8350b
           - qcom,pm8350c
+          - qcom,pm8550
+          - qcom,pm8550b
+          - qcom,pm8550ve
+          - qcom,pm8550vs
           - qcom,pm8841
           - qcom,pm8909
           - qcom,pm8916
@@ -70,10 +75,12 @@ properties:
           - qcom,pmi8998
           - qcom,pmk8002
           - qcom,pmk8350
+          - qcom,pmk8550
           - qcom,pmm8155au
           - qcom,pmp8074
           - qcom,pmr735a
           - qcom,pmr735b
+          - qcom,pmr735d
           - qcom,pms405
           - qcom,pmx55
           - qcom,pmx65

-- 
b4 0.10.1

[PATCH v2 2/3] dt-bindings: pinctrl: qcom,pmic-gpio: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550 & pmr735d

[Neil Armstrong]

Document compatible, pin count & pin names for pm8550, pm8550b, pm8550ve,
pm8550vs, pmk8550 & pmr735d SPMI GPIO controllers.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 29dd503f9522..db505fdeac86 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -40,6 +40,10 @@ properties:
           - qcom,pm8350b-gpio
           - qcom,pm8350c-gpio
           - qcom,pm8450-gpio
+          - qcom,pm8550-gpio
+          - qcom,pm8550b-gpio
+          - qcom,pm8550ve-gpio
+          - qcom,pm8550vs-gpio
           - qcom,pm8916-gpio
           - qcom,pm8917-gpio
           - qcom,pm8921-gpio
@@ -52,10 +56,12 @@ properties:
           - qcom,pmi8994-gpio
           - qcom,pmi8998-gpio
           - qcom,pmk8350-gpio
+          - qcom,pmk8550-gpio
           - qcom,pmm8155au-gpio
           - qcom,pmp8074-gpio
           - qcom,pmr735a-gpio
           - qcom,pmr735b-gpio
+          - qcom,pmr735d-gpio
           - qcom,pms405-gpio
           - qcom,pmx55-gpio
           - qcom,pmx65-gpio
@@ -111,6 +117,7 @@ allOf:
             enum:
               - qcom,pm8008-gpio
               - qcom,pmi8950-gpio
+              - qcom,pmr735d-gpio
     then:
       properties:
         gpio-line-names:
@@ -146,6 +153,8 @@ allOf:
             enum:
               - qcom,pm8018-gpio
               - qcom,pm8019-gpio
+              - qcom,pm8550vs-gpio
+              - qcom,pmk8550-gpio
     then:
       properties:
         gpio-line-names:
@@ -162,6 +171,7 @@ allOf:
             enum:
               - qcom,pm8226-gpio
               - qcom,pm8350b-gpio
+              - qcom,pm8550ve-gpio
               - qcom,pm8950-gpio
     then:
       properties:
@@ -236,6 +246,8 @@ allOf:
               - qcom,pm8038-gpio
               - qcom,pm8150b-gpio
               - qcom,pm8150l-gpio
+              - qcom,pm8550-gpio
+              - qcom,pm8550b-gpio
               - qcom,pmc8180c-gpio
               - qcom,pmp8074-gpio
               - qcom,pms405-gpio
@@ -411,6 +423,10 @@ $defs:
                  - gpio1-gpio8 for pm8350b
                  - gpio1-gpio9 for pm8350c
                  - gpio1-gpio4 for pm8450
+                 - gpio1-gpio12 for pm8550
+                 - gpio1-gpio12 for pm8550b
+                 - gpio1-gpio8 for pm8550ve
+                 - gpio1-gpio6 for pm8550vs
                  - gpio1-gpio38 for pm8917
                  - gpio1-gpio44 for pm8921
                  - gpio1-gpio36 for pm8941
@@ -421,10 +437,12 @@ $defs:
                  - gpio1-gpio2 for pmi8950
                  - gpio1-gpio10 for pmi8994
                  - gpio1-gpio4 for pmk8350
+                 - gpio1-gpio6 for pmk8550
                  - gpio1-gpio10 for pmm8155au
                  - gpio1-gpio12 for pmp8074 (holes on gpio1 and gpio12)
                  - gpio1-gpio4 for pmr735a
                  - gpio1-gpio4 for pmr735b
+                 - gpio1-gpio2 for pmr735d
                  - gpio1-gpio12 for pms405 (holes on gpio1, gpio9
                                             and gpio10)
                  - gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10

-- 
b4 0.10.1

[PATCH v2 3/3] pinctrl: qcom: spmi-gpio: add support for pm8550 & pmr735d gpio control

[Neil Armstrong]

Add support for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550 & pmr735d
gpio controllers providing GPIO control over SPMI.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 8c31a8f6b7e4..d65c9f2ece73 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1219,6 +1219,10 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
 	{ .compatible = "qcom,pm8450-gpio", .data = (void *) 4 },
+	{ .compatible = "qcom,pm8550-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm8550b-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm8550ve-gpio", .data = (void *) 8 },
+	{ .compatible = "qcom,pm8550vs-gpio", .data = (void *) 6 },
 	{ .compatible = "qcom,pm8916-gpio", .data = (void *) 4 },
 	{ .compatible = "qcom,pm8941-gpio", .data = (void *) 36 },
 	/* pm8950 has 8 GPIOs with holes on 3 */
@@ -1230,11 +1234,13 @@ static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pmi8994-gpio", .data = (void *) 10 },
 	{ .compatible = "qcom,pmi8998-gpio", .data = (void *) 14 },
 	{ .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
+	{ .compatible = "qcom,pmk8550-gpio", .data = (void *) 6 },
 	{ .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 },
 	/* pmp8074 has 12 GPIOs with holes on 1 and 12 */
 	{ .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
 	{ .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
 	{ .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 },
+	{ .compatible = "qcom,pmr735d-gpio", .data = (void *) 2 },
 	/* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
 	{ .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
 	/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */

-- 
b4 0.10.1

Re: [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550, pm8010 & pmr735d

[Konrad Dybcio]

On 18/11/2022 09:24, Neil Armstrong wrote:
> Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550.
> pm8010 & pmr735d SPMI PMICs
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Didn't checkpatch complain about the length of this patch's subject?
I propose:

dt-bindings: mfd: qcom,spmi-pmic: document SM8550 PMICs

or

dt-bindings: mfd: qcom,spmi-pmic: document PMICs bundled with SM8550


Konrad
>   Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index c8362efd4345..8c9b042b4f30 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -43,6 +43,7 @@ properties:
>             - qcom,pm8004
>             - qcom,pm8005
>             - qcom,pm8009
> +          - qcom,pm8010
>             - qcom,pm8019
>             - qcom,pm8028
>             - qcom,pm8110
> @@ -54,6 +55,10 @@ properties:
>             - qcom,pm8350
>             - qcom,pm8350b
>             - qcom,pm8350c
> +          - qcom,pm8550
> +          - qcom,pm8550b
> +          - qcom,pm8550ve
> +          - qcom,pm8550vs
>             - qcom,pm8841
>             - qcom,pm8909
>             - qcom,pm8916
> @@ -70,10 +75,12 @@ properties:
>             - qcom,pmi8998
>             - qcom,pmk8002
>             - qcom,pmk8350
> +          - qcom,pmk8550
>             - qcom,pmm8155au
>             - qcom,pmp8074
>             - qcom,pmr735a
>             - qcom,pmr735b
> +          - qcom,pmr735d
>             - qcom,pms405
>             - qcom,pmx55
>             - qcom,pmx65
> 

Re: [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550, pm8010 & pmr735d

[Neil Armstrong]

On 18/11/2022 09:52, Konrad Dybcio wrote:
> 
> 
> On 18/11/2022 09:24, Neil Armstrong wrote:
>> Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550.
>> pm8010 & pmr735d SPMI PMICs
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> Didn't checkpatch complain about the length of this patch's subject?

No, not even with --strict

> I propose:
> 
> dt-bindings: mfd: qcom,spmi-pmic: document SM8550 PMICs
> 
> or
> 
> dt-bindings: mfd: qcom,spmi-pmic: document PMICs bundled with SM8550

I'll change to of these if I need to resend,

Thanks,
Neil

> 
> 
> Konrad
>>   Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> index c8362efd4345..8c9b042b4f30 100644
>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> @@ -43,6 +43,7 @@ properties:
>>             - qcom,pm8004
>>             - qcom,pm8005
>>             - qcom,pm8009
>> +          - qcom,pm8010
>>             - qcom,pm8019
>>             - qcom,pm8028
>>             - qcom,pm8110
>> @@ -54,6 +55,10 @@ properties:
>>             - qcom,pm8350
>>             - qcom,pm8350b
>>             - qcom,pm8350c
>> +          - qcom,pm8550
>> +          - qcom,pm8550b
>> +          - qcom,pm8550ve
>> +          - qcom,pm8550vs
>>             - qcom,pm8841
>>             - qcom,pm8909
>>             - qcom,pm8916
>> @@ -70,10 +75,12 @@ properties:
>>             - qcom,pmi8998
>>             - qcom,pmk8002
>>             - qcom,pmk8350
>> +          - qcom,pmk8550
>>             - qcom,pmm8155au
>>             - qcom,pmp8074
>>             - qcom,pmr735a
>>             - qcom,pmr735b
>> +          - qcom,pmr735d
>>             - qcom,pms405
>>             - qcom,pmx55
>>             - qcom,pmx65
>>

Re: [PATCH v2 0/3] qcom: add support for SPMI PMICs found on SM8550 platforms

[Neil Armstrong]

On 18/11/2022 09:24, Neil Armstrong wrote:
> The SM8550 based platforms sports a bunch of new PMICs:
> - pm8550
> - pm8550b
> - pm8550ve
> - pm8550vs
> - pmk8550
> - pmr735d
> - pm8010
> 
> With GPIO support on:
> - pm8550
> - pm8550b
> - pm8550ve
> - pm8550vs
> - pmk8550
> - pmr735d
> 
> This documents bindings for those SPMI PMIC and adds compatible in the
> PMIC pinctrl driver for GPIO support.
> 
> To: Andy Gross <agross@kernel.org>
> To: Bjorn Andersson <andersson@kernel.org>
> To: Konrad Dybcio <konrad.dybcio@somainline.org>
> To: Lee Jones <lee@kernel.org>
> To: Rob Herring <robh+dt@kernel.org>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> To: Stephen Boyd <sboyd@kernel.org>
> To: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> 
> ---
> Changes in v2:
> - Squashed patch 3 & 2 into 1, added Reviewed-by from Krzysztof
> - Squashed patch 5 into 4, added Reviewed-by from Krzysztof
> - Squashed patch 7 into 6, added Reviewed-by from Konrad
> - Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-spmi-v1-0-6338a2b4b241@linaro.org
> 
> ---
> Neil Armstrong (3):
>        dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550, pm8010 & pmr735d
>        dt-bindings: pinctrl: qcom,pmic-gpio: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550 & pmr735d
>        pinctrl: qcom: spmi-gpio: add support for pm8550 & pmr735d gpio control
> 
>   .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml        |  7 +++++++
>   .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml    | 18 ++++++++++++++++++
>   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c               |  6 ++++++
>   3 files changed, 31 insertions(+)
> ---
> base-commit: 8274e19d9db1019f8fac39cf46da6680513fd5d3
> change-id: 20221114-narmstrong-sm8550-upstream-spmi-d2c999ec5dc1
> 
> Best regards,

Gentle ping,

Thanks,
Neil

Re: [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550, pm8010 & pmr735d

[Lee Jones]

I changed the subject line for you.

On Fri, 18 Nov 2022, Neil Armstrong wrote:

> Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550.
> pm8010 & pmr735d SPMI PMICs
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied, thanks

-- 
Lee Jones [李琼斯]

Re: [PATCH v2 0/3] qcom: add support for SPMI PMICs found on SM8550 platforms

[Linus Walleij]

On Fri, Nov 18, 2022 at 9:24 AM Neil Armstrong
<neil.armstrong@linaro.org> wrote:

>       dt-bindings: pinctrl: qcom,pmic-gpio: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550 & pmr735d
>       pinctrl: qcom: spmi-gpio: add support for pm8550 & pmr735d gpio control

These two patches applied to the pinctrl tree!

Yours,
Linus Walleij

Re: [PATCH v2 0/3] qcom: add support for SPMI PMICs found on SM8550 platforms

[Neil Armstrong]

On 09/01/2023 15:18, Linus Walleij wrote:
> On Fri, Nov 18, 2022 at 9:24 AM Neil Armstrong
> <neil.armstrong@linaro.org> wrote:
> 
>>        dt-bindings: pinctrl: qcom,pmic-gpio: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550 & pmr735d
>>        pinctrl: qcom: spmi-gpio: add support for pm8550 & pmr735d gpio control
> 
> These two patches applied to the pinctrl tree!

Thanks !

> 
> Yours,
> Linus Walleij