* [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1
@ 2019-03-15 13:31 Gabriel Lazar
2019-03-15 17:33 ` Andy Shevchenko
2019-03-15 17:47 ` Hans de Goede
0 siblings, 2 replies; 6+ messages in thread
From: Gabriel Lazar @ 2019-03-15 13:31 UTC (permalink / raw)
Cc: Gabriel Lazar, Hans de Goede, Darren Hart, Andy Shevchenko,
linux-input, platform-driver-x86, linux-kernel
Add touchscreen platform data for the Myrya MY8307 2-in-1 laptop.
Signed-off-by: Gabriel Lazar <gabriel.lazar@com.utcluj.ro>
---
drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 2d56ff7c8230..3319f0cbb558 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -265,6 +265,23 @@ static const struct ts_dmi_data jumper_ezpad_mini3_data = {
.properties = jumper_ezpad_mini3_props,
};
+static const struct property_entry myria_my8307_props[] = {
+ PROPERTY_ENTRY_U32("touchscreen-size-x", 1720),
+ PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+ PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+ PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-myria-my8307.fw"),
+ PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+ PROPERTY_ENTRY_BOOL("silead,home-button"),
+ { }
+};
+
+static const struct ts_dmi_data myria_my8307_data = {
+ .acpi_name = "MSSL1680:00",
+ .properties = myria_my8307_props,
+};
+
static const struct property_entry onda_obook_20_plus_props[] = {
PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
@@ -690,6 +707,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "FlexBook edge11 - M-FBE11"),
},
},
+ {
+ /* Myria MY8307 */
+ .driver_data = (void *)&myria_my8307_data,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Complet Electro Serv"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "MY8307"),
+ },
+ },
{
/* Onda oBook 20 Plus */
.driver_data = (void *)&onda_obook_20_plus_data,
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1
2019-03-15 13:31 [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1 Gabriel Lazar
@ 2019-03-15 17:33 ` Andy Shevchenko
2019-03-15 17:39 ` Hans de Goede
2019-03-15 17:47 ` Hans de Goede
1 sibling, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2019-03-15 17:33 UTC (permalink / raw)
To: Gabriel Lazar
Cc: Hans de Goede, Darren Hart, Andy Shevchenko, linux-input,
Platform Driver, Linux Kernel Mailing List
On Fri, Mar 15, 2019 at 3:31 PM Gabriel Lazar
<gabriel.lazar@com.utcluj.ro> wrote:
>
> Add touchscreen platform data for the Myrya MY8307 2-in-1 laptop.
You sent one patch twice or two patches?
Please, clarify this by sending v2 with correct subject line(s) and
amount of patches.
>
> Signed-off-by: Gabriel Lazar <gabriel.lazar@com.utcluj.ro>
> ---
> drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 2d56ff7c8230..3319f0cbb558 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -265,6 +265,23 @@ static const struct ts_dmi_data jumper_ezpad_mini3_data = {
> .properties = jumper_ezpad_mini3_props,
> };
>
> +static const struct property_entry myria_my8307_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1720),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-myria-my8307.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct ts_dmi_data myria_my8307_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = myria_my8307_props,
> +};
> +
> static const struct property_entry onda_obook_20_plus_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
> @@ -690,6 +707,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "FlexBook edge11 - M-FBE11"),
> },
> },
> + {
> + /* Myria MY8307 */
> + .driver_data = (void *)&myria_my8307_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Complet Electro Serv"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "MY8307"),
> + },
> + },
> {
> /* Onda oBook 20 Plus */
> .driver_data = (void *)&onda_obook_20_plus_data,
> --
> 2.21.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1
2019-03-15 17:33 ` Andy Shevchenko
@ 2019-03-15 17:39 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2019-03-15 17:39 UTC (permalink / raw)
To: Andy Shevchenko, Gabriel Lazar
Cc: Darren Hart, Andy Shevchenko, linux-input, Platform Driver,
Linux Kernel Mailing List
Hi,
On 3/15/19 6:33 PM, Andy Shevchenko wrote:
> On Fri, Mar 15, 2019 at 3:31 PM Gabriel Lazar
> <gabriel.lazar@com.utcluj.ro> wrote:
>>
>> Add touchscreen platform data for the Myrya MY8307 2-in-1 laptop.
>
> You sent one patch twice or two patches?
> Please, clarify this by sending v2 with correct subject line(s) and
> amount of patches.
Gabriel send the same patch twice, the first version came from
his yahoo email address, which vger bounced (but the direct addressed
people received), so he send a second copy from his other email address.
Regards,
Hans
>
>>
>> Signed-off-by: Gabriel Lazar <gabriel.lazar@com.utcluj.ro>
>> ---
>> drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
>> index 2d56ff7c8230..3319f0cbb558 100644
>> --- a/drivers/platform/x86/touchscreen_dmi.c
>> +++ b/drivers/platform/x86/touchscreen_dmi.c
>> @@ -265,6 +265,23 @@ static const struct ts_dmi_data jumper_ezpad_mini3_data = {
>> .properties = jumper_ezpad_mini3_props,
>> };
>>
>> +static const struct property_entry myria_my8307_props[] = {
>> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1720),
>> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
>> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
>> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
>> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
>> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-myria-my8307.fw"),
>> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
>> + PROPERTY_ENTRY_BOOL("silead,home-button"),
>> + { }
>> +};
>> +
>> +static const struct ts_dmi_data myria_my8307_data = {
>> + .acpi_name = "MSSL1680:00",
>> + .properties = myria_my8307_props,
>> +};
>> +
>> static const struct property_entry onda_obook_20_plus_props[] = {
>> PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
>> PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
>> @@ -690,6 +707,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
>> DMI_MATCH(DMI_PRODUCT_NAME, "FlexBook edge11 - M-FBE11"),
>> },
>> },
>> + {
>> + /* Myria MY8307 */
>> + .driver_data = (void *)&myria_my8307_data,
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Complet Electro Serv"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "MY8307"),
>> + },
>> + },
>> {
>> /* Onda oBook 20 Plus */
>> .driver_data = (void *)&onda_obook_20_plus_data,
>> --
>> 2.21.0
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1
2019-03-15 13:31 [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1 Gabriel Lazar
2019-03-15 17:33 ` Andy Shevchenko
@ 2019-03-15 17:47 ` Hans de Goede
2019-03-15 18:43 ` Andy Shevchenko
2019-04-05 14:22 ` Andy Shevchenko
1 sibling, 2 replies; 6+ messages in thread
From: Hans de Goede @ 2019-03-15 17:47 UTC (permalink / raw)
To: Gabriel Lazar
Cc: Darren Hart, Andy Shevchenko, linux-input, platform-driver-x86,
linux-kernel
Hi,
On 3/15/19 2:31 PM, Gabriel Lazar wrote:
> Add touchscreen platform data for the Myrya MY8307 2-in-1 laptop.
>
> Signed-off-by: Gabriel Lazar <gabriel.lazar@com.utcluj.ro>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 2d56ff7c8230..3319f0cbb558 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -265,6 +265,23 @@ static const struct ts_dmi_data jumper_ezpad_mini3_data = {
> .properties = jumper_ezpad_mini3_props,
> };
>
> +static const struct property_entry myria_my8307_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1720),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-myria-my8307.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct ts_dmi_data myria_my8307_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = myria_my8307_props,
> +};
> +
> static const struct property_entry onda_obook_20_plus_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
> @@ -690,6 +707,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "FlexBook edge11 - M-FBE11"),
> },
> },
> + {
> + /* Myria MY8307 */
> + .driver_data = (void *)&myria_my8307_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Complet Electro Serv"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "MY8307"),
> + },
> + },
> {
> /* Onda oBook 20 Plus */
> .driver_data = (void *)&onda_obook_20_plus_data,
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1
2019-03-15 17:47 ` Hans de Goede
@ 2019-03-15 18:43 ` Andy Shevchenko
2019-04-05 14:22 ` Andy Shevchenko
1 sibling, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2019-03-15 18:43 UTC (permalink / raw)
To: Hans de Goede
Cc: Gabriel Lazar, Darren Hart, Andy Shevchenko, linux-input,
Platform Driver, Linux Kernel Mailing List
On Fri, Mar 15, 2019 at 7:47 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 3/15/19 2:31 PM, Gabriel Lazar wrote:
> > Add touchscreen platform data for the Myrya MY8307 2-in-1 laptop.
> >
> > Signed-off-by: Gabriel Lazar <gabriel.lazar@com.utcluj.ro>
>
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
OK, thanks for explanation.
I'll take it after merge window will be closed.
> Regards,
>
> Hans
>
>
>
> > ---
> > drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> > index 2d56ff7c8230..3319f0cbb558 100644
> > --- a/drivers/platform/x86/touchscreen_dmi.c
> > +++ b/drivers/platform/x86/touchscreen_dmi.c
> > @@ -265,6 +265,23 @@ static const struct ts_dmi_data jumper_ezpad_mini3_data = {
> > .properties = jumper_ezpad_mini3_props,
> > };
> >
> > +static const struct property_entry myria_my8307_props[] = {
> > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1720),
> > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> > + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> > + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-myria-my8307.fw"),
> > + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> > + PROPERTY_ENTRY_BOOL("silead,home-button"),
> > + { }
> > +};
> > +
> > +static const struct ts_dmi_data myria_my8307_data = {
> > + .acpi_name = "MSSL1680:00",
> > + .properties = myria_my8307_props,
> > +};
> > +
> > static const struct property_entry onda_obook_20_plus_props[] = {
> > PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> > PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
> > @@ -690,6 +707,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "FlexBook edge11 - M-FBE11"),
> > },
> > },
> > + {
> > + /* Myria MY8307 */
> > + .driver_data = (void *)&myria_my8307_data,
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Complet Electro Serv"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "MY8307"),
> > + },
> > + },
> > {
> > /* Onda oBook 20 Plus */
> > .driver_data = (void *)&onda_obook_20_plus_data,
> >
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1
2019-03-15 17:47 ` Hans de Goede
2019-03-15 18:43 ` Andy Shevchenko
@ 2019-04-05 14:22 ` Andy Shevchenko
1 sibling, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2019-04-05 14:22 UTC (permalink / raw)
To: Hans de Goede
Cc: Gabriel Lazar, Darren Hart, Andy Shevchenko, linux-input,
Platform Driver, Linux Kernel Mailing List
On Fri, Mar 15, 2019 at 7:47 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 3/15/19 2:31 PM, Gabriel Lazar wrote:
> > Add touchscreen platform data for the Myrya MY8307 2-in-1 laptop.
> >
> > Signed-off-by: Gabriel Lazar <gabriel.lazar@com.utcluj.ro>
>
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Pushed to my review and testing queue, thanks!
>
> Regards,
>
> Hans
>
>
>
> > ---
> > drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> > index 2d56ff7c8230..3319f0cbb558 100644
> > --- a/drivers/platform/x86/touchscreen_dmi.c
> > +++ b/drivers/platform/x86/touchscreen_dmi.c
> > @@ -265,6 +265,23 @@ static const struct ts_dmi_data jumper_ezpad_mini3_data = {
> > .properties = jumper_ezpad_mini3_props,
> > };
> >
> > +static const struct property_entry myria_my8307_props[] = {
> > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1720),
> > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
> > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> > + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> > + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-myria-my8307.fw"),
> > + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> > + PROPERTY_ENTRY_BOOL("silead,home-button"),
> > + { }
> > +};
> > +
> > +static const struct ts_dmi_data myria_my8307_data = {
> > + .acpi_name = "MSSL1680:00",
> > + .properties = myria_my8307_props,
> > +};
> > +
> > static const struct property_entry onda_obook_20_plus_props[] = {
> > PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> > PROPERTY_ENTRY_U32("touchscreen-size-y", 1148),
> > @@ -690,6 +707,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "FlexBook edge11 - M-FBE11"),
> > },
> > },
> > + {
> > + /* Myria MY8307 */
> > + .driver_data = (void *)&myria_my8307_data,
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Complet Electro Serv"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "MY8307"),
> > + },
> > + },
> > {
> > /* Onda oBook 20 Plus */
> > .driver_data = (void *)&onda_obook_20_plus_data,
> >
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-05 14:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 13:31 [PATCH] platform/x86: touchscreen_dmi: Add info for Myria MY8307 2-in-1 Gabriel Lazar
2019-03-15 17:33 ` Andy Shevchenko
2019-03-15 17:39 ` Hans de Goede
2019-03-15 17:47 ` Hans de Goede
2019-03-15 18:43 ` Andy Shevchenko
2019-04-05 14:22 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).