From: Michael Walle <michael@walle.cc>
To: Saravana Kannan <saravanak@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Guenter Roeck <linux@roeck-us.net>,
Android Kernel Team <kernel-team@android.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II
Date: Wed, 03 Mar 2021 09:59:03 +0100 [thread overview]
Message-ID: <12f31a46e8dc3f0e53c1a7440a4ce087@walle.cc> (raw)
In-Reply-To: <CAGETcx__oG2XrQ8RwZ57cVgV+Ukfni4qUQCe11kbL8E1U+4a_g@mail.gmail.com>
Am 2021-03-02 23:47, schrieb Saravana Kannan:
> On Tue, Mar 2, 2021 at 2:42 PM Saravana Kannan <saravanak@google.com>
> wrote:
>>
>> On Tue, Mar 2, 2021 at 2:24 PM Michael Walle <michael@walle.cc> wrote:
>> >
>> > Am 2021-03-02 22:11, schrieb Saravana Kannan:
>> > > I think Patch 1 should fix [4] without [5]. Can you test the series
>> > > please?
>> >
>> > Mh, I'm on latest linux-next (next-20210302) and I've applied patch 3/3
>> > and
>> > reverted commit 7007b745a508 ("PCI: layerscape: Convert to
>> > builtin_platform_driver()"). I'd assumed that PCIe shouldn't be working,
>> > right? But it is. Did I miss something?
>>
>> You need to revert [5].
>
> My bad. You did revert it. Ah... I wonder if it was due to
> fw_devlink.strict that I added. To break PCI again, also set
> fw_devlink.strict=1 in the kernel command line.
Indeed, adding fw_devlink.strict=1 will break PCI again. But if
I then apply 1/3 and 2/3 again, PCI is still broken. Just to be clear:
I'm keeping the fw_devlink.strict=1 parameter.
-michael
next prev parent reply other threads:[~2021-03-03 14:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 21:11 [PATCH v1 0/3] driver core: Set fw_devlink=on take II Saravana Kannan
2021-03-02 21:11 ` [PATCH v1 1/3] driver core: Avoid pointless deferred probe attempts Saravana Kannan
2021-03-09 23:26 ` Saravana Kannan
2021-03-23 13:58 ` Greg Kroah-Hartman
2021-03-02 21:11 ` [PATCH v1 2/3] driver core: Update device link status properly for device_bind_driver() Saravana Kannan
2021-03-12 16:59 ` Jon Hunter
2021-03-02 21:11 ` [PATCH v1 3/3] Revert "Revert "driver core: Set fw_devlink=on by default"" Saravana Kannan
[not found] ` <161670714806.3012082.14889556041667946511@swboyd.mtv.corp.google.com>
2021-03-25 21:59 ` Saravana Kannan
2021-04-26 20:51 ` Florian Fainelli
2021-04-26 21:33 ` Saravana Kannan
2021-04-26 21:47 ` Florian Fainelli
2021-04-27 7:05 ` Geert Uytterhoeven
2021-04-27 7:48 ` Cristian Marussi
[not found] ` <CA+-6iNz_kL0DnbRb0A=WSSLK0mnqw35S47TDXq5rhwXL_VWdPg@mail.gmail.com>
2021-04-27 14:11 ` Cristian Marussi
2021-04-27 15:10 ` Sudeep Holla
2021-04-27 16:24 ` Saravana Kannan
2021-04-27 16:47 ` Florian Fainelli
2021-04-27 21:05 ` Saravana Kannan
2021-04-28 8:40 ` Sudeep Holla
2021-04-27 16:24 ` Florian Fainelli
2021-04-27 16:28 ` Saravana Kannan
2021-04-27 16:42 ` Sudeep Holla
2021-04-27 16:39 ` Sudeep Holla
2021-04-27 16:50 ` Florian Fainelli
2021-04-27 17:10 ` Geert Uytterhoeven
2021-03-02 22:24 ` [PATCH v1 0/3] driver core: Set fw_devlink=on take II Michael Walle
2021-03-02 22:42 ` Saravana Kannan
2021-03-02 22:47 ` Saravana Kannan
2021-03-03 8:59 ` Michael Walle [this message]
2021-03-03 9:28 ` Saravana Kannan
2021-03-03 10:21 ` Michael Walle
2021-03-05 3:25 ` Saravana Kannan
2021-03-03 9:22 ` Geert Uytterhoeven
2021-03-03 9:24 ` Saravana Kannan
2021-03-03 10:02 ` Geert Uytterhoeven
2021-03-03 16:55 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12f31a46e8dc3f0e53c1a7440a4ce087@walle.cc \
--to=michael@walle.cc \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.szyprowski@samsung.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).