linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] block: remove unwanted semicolons
@ 2011-05-01 12:35 Namhyung Kim
  2011-05-02 14:06 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2011-05-01 12:35 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-kernel, Martin K. Petersen

Since those defined functions require additional semicolon
from the caller, they could cause potential syntax errors
when used in if-else statements.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
---
 include/linux/blkdev.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 2ad95fa1d130..5560454534c6 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1271,8 +1271,8 @@ queue_max_integrity_segments(struct request_queue *q)
 #define blk_get_integrity(a)			(0)
 #define blk_integrity_compare(a, b)		(0)
 #define blk_integrity_register(a, b)		(0)
-#define blk_integrity_unregister(a)		do { } while (0);
-#define blk_queue_max_integrity_segments(a, b)	do { } while (0);
+#define blk_integrity_unregister(a)		do { } while (0)
+#define blk_queue_max_integrity_segments(a, b)	do { } while (0)
 #define queue_max_integrity_segments(a)		(0)
 #define blk_integrity_merge_rq(a, b, c)		(0)
 #define blk_integrity_merge_bio(a, b, c)	(0)
-- 
1.7.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] block: remove unwanted semicolons
  2011-05-01 12:35 [PATCH] block: remove unwanted semicolons Namhyung Kim
@ 2011-05-02 14:06 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2011-05-02 14:06 UTC (permalink / raw)
  To: Namhyung Kim; +Cc: Jens Axboe, linux-kernel, Martin K. Petersen

>>>>> "Namhyung" == Namhyung Kim <namhyung@gmail.com> writes:

Namhyung> Since those defined functions require additional semicolon
Namhyung> from the caller, they could cause potential syntax errors when
Namhyung> used in if-else statements.

Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-02 14:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-01 12:35 [PATCH] block: remove unwanted semicolons Namhyung Kim
2011-05-02 14:06 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).