* Re: [PATCH] fs:update the NOTE of the file_operations structure
@ 2011-07-19 1:48 Wanlong Gao
0 siblings, 0 replies; 4+ messages in thread
From: Wanlong Gao @ 2011-07-19 1:48 UTC (permalink / raw)
To: hch; +Cc: wanlong.gao, linux-fsdevel, linux-kernel, matthew, Wanlong Gao
Big kernel lock had been removed and setlease now use the lock_flocks()
to hold a special spin lock file_lock_lock by Matthew.
So just remove the out-of-date NOTE.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
include/linux/fs.h | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index b5b9792..67b2b21 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1538,11 +1538,6 @@ struct block_device_operations;
#define HAVE_COMPAT_IOCTL 1
#define HAVE_UNLOCKED_IOCTL 1
-/*
- * NOTE:
- * all file operations except setlease can be called without
- * the big kernel lock held in all filesystems.
- */
struct file_operations {
struct module *owner;
loff_t (*llseek) (struct file *, loff_t, int);
--
1.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs:update the NOTE of the file_operations structure
2011-07-18 17:27 ` Christoph Hellwig
@ 2011-07-19 0:36 ` Wanlong Gao
0 siblings, 0 replies; 4+ messages in thread
From: Wanlong Gao @ 2011-07-19 0:36 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Wanlong Gao, linux-fsdevel, linux-kernel, Matthew Wilcox
On 07/19/2011 01:27 AM, Christoph Hellwig wrote:
>> /*
>> * NOTE:
>> * all file operations except setlease can be called without
>> - * the big kernel lock held in all filesystems.
>> + * the special spin_lock file_lock_lock held in all filesystems.
>> */
>> struct file_operations {
>> struct module *owner;
>
> I'd just remove the comment entirely.
>
From 765a06af4b8b4b67238e896fb6b82270d765195d Mon Sep 17 00:00:00 2001
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Date: Tue, 19 Jul 2011 08:30:17 +0800
Subject: [PATCH] fs:remove the out-of-date NOTE of file_operations structure
Big kernel lock had been removed and setlease now use the lock_flocks()
to hold a special spin lock file_lock_lock by Matthew.
So just remove the out-of-date NOTE.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
include/linux/fs.h | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index b5b9792..67b2b21 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1538,11 +1538,6 @@ struct block_device_operations;
#define HAVE_COMPAT_IOCTL 1
#define HAVE_UNLOCKED_IOCTL 1
-/*
- * NOTE:
- * all file operations except setlease can be called without
- * the big kernel lock held in all filesystems.
- */
struct file_operations {
struct module *owner;
loff_t (*llseek) (struct file *, loff_t, int);
--
1.7.6
--
Thanks
Best Regards
Wanlong Gao
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs:update the NOTE of the file_operations structure
2011-07-18 17:23 Wanlong Gao
@ 2011-07-18 17:27 ` Christoph Hellwig
2011-07-19 0:36 ` Wanlong Gao
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2011-07-18 17:27 UTC (permalink / raw)
To: Wanlong Gao; +Cc: linux-fsdevel, linux-kernel, Matthew Wilcox, Wanlong Gao
> /*
> * NOTE:
> * all file operations except setlease can be called without
> - * the big kernel lock held in all filesystems.
> + * the special spin_lock file_lock_lock held in all filesystems.
> */
> struct file_operations {
> struct module *owner;
I'd just remove the comment entirely.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] fs:update the NOTE of the file_operations structure
@ 2011-07-18 17:23 Wanlong Gao
2011-07-18 17:27 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Wanlong Gao @ 2011-07-18 17:23 UTC (permalink / raw)
To: linux-fsdevel, linux-kernel; +Cc: Matthew Wilcox, Wanlong Gao, Wanlong Gao
Big kernel lock had been removed and setlease now use the lock_flocks()
to hold a special spin lock file_lock_lock by Matthew.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
include/linux/fs.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index b5b9792..fdeeb3f 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1541,7 +1541,7 @@ struct block_device_operations;
/*
* NOTE:
* all file operations except setlease can be called without
- * the big kernel lock held in all filesystems.
+ * the special spin_lock file_lock_lock held in all filesystems.
*/
struct file_operations {
struct module *owner;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-19 1:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-19 1:48 [PATCH] fs:update the NOTE of the file_operations structure Wanlong Gao
-- strict thread matches above, loose matches on Subject: below --
2011-07-18 17:23 Wanlong Gao
2011-07-18 17:27 ` Christoph Hellwig
2011-07-19 0:36 ` Wanlong Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).