* [PATCH 0/1] arm: omap: remove obsolete IRQF_DISABLED
@ 2011-10-09 5:46 Michael Opdenacker
2011-10-09 5:46 ` [PATCH 1/1] arm: omap: removed " Michael Opdenacker
0 siblings, 1 reply; 4+ messages in thread
From: Michael Opdenacker @ 2011-10-09 5:46 UTC (permalink / raw)
To: tony, linux, khilman; +Cc: linux-omap, linux-arm-kernel, linux-kernel, patches
Remove all occurrences of IRQF_DISABLED in the OMAP tree.
This flag is deprecated and obsolete and as IRQ handlers now run
with all interrupts disabled since 2.6.36
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] arm: omap: removed obsolete IRQF_DISABLED
2011-10-09 5:46 [PATCH 0/1] arm: omap: remove obsolete IRQF_DISABLED Michael Opdenacker
@ 2011-10-09 5:46 ` Michael Opdenacker
2011-11-03 22:15 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Michael Opdenacker @ 2011-10-09 5:46 UTC (permalink / raw)
To: tony, linux, khilman
Cc: linux-omap, linux-arm-kernel, linux-kernel, patches, Michael Opdenacker
This flag is a NOOP since 2.6.36
Signed-off-by: Michael Opdenacker <michael.opdenacker@linaro.org>
---
arch/arm/mach-omap1/fpga.c | 5 ++---
arch/arm/mach-omap1/pm.c | 1 -
arch/arm/mach-omap1/time.c | 2 +-
arch/arm/mach-omap1/timer32k.c | 2 +-
arch/arm/mach-omap2/omap_l3_noc.c | 4 ++--
arch/arm/mach-omap2/omap_l3_smx.c | 4 ++--
arch/arm/mach-omap2/pm34xx.c | 2 +-
arch/arm/mach-omap2/timer.c | 2 +-
arch/arm/plat-omap/dma.c | 1 -
9 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-omap1/fpga.c b/arch/arm/mach-omap1/fpga.c
index cddbf8b..3786b35 100644
--- a/arch/arm/mach-omap1/fpga.c
+++ b/arch/arm/mach-omap1/fpga.c
@@ -131,9 +131,8 @@ static struct irq_chip omap_fpga_irq = {
* In an attempt to workaround the problem with missed interrupts, the
* mask_ack routine for all of the FPGA interrupts has been changed from
* fpga_mask_ack_irq() to fpga_ack_irq() so that the specific FPGA interrupt
- * being serviced is left unmasked. We can do this because the FPGA cascade
- * interrupt is installed with the IRQF_DISABLED flag, which leaves all
- * interrupts masked at the CPU while an FPGA interrupt handler executes.
+ * being serviced is left unmasked. We can do this because all the interrupts
+ * are masked at the CPU while an FPGA interrupt handler executes.
*
* Limited testing indicates that this workaround appears to be effective
* for the smc9194 Ethernet driver used on the Innovator. It should work
diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
index 6badc29..f842ff2 100644
--- a/arch/arm/mach-omap1/pm.c
+++ b/arch/arm/mach-omap1/pm.c
@@ -641,7 +641,6 @@ static irqreturn_t omap_wakeup_interrupt(int irq, void *dev)
static struct irqaction omap_wakeup_irq = {
.name = "peripheral wakeup",
- .flags = IRQF_DISABLED,
.handler = omap_wakeup_interrupt
};
diff --git a/arch/arm/mach-omap1/time.c b/arch/arm/mach-omap1/time.c
index a183777..a35b4d2 100644
--- a/arch/arm/mach-omap1/time.c
+++ b/arch/arm/mach-omap1/time.c
@@ -163,7 +163,7 @@ static irqreturn_t omap_mpu_timer1_interrupt(int irq, void *dev_id)
static struct irqaction omap_mpu_timer1_irq = {
.name = "mpu_timer1",
- .flags = IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL,
+ .flags = IRQF_TIMER | IRQF_IRQPOLL,
.handler = omap_mpu_timer1_interrupt,
};
diff --git a/arch/arm/mach-omap1/timer32k.c b/arch/arm/mach-omap1/timer32k.c
index 96604a5..db08fd4 100644
--- a/arch/arm/mach-omap1/timer32k.c
+++ b/arch/arm/mach-omap1/timer32k.c
@@ -155,7 +155,7 @@ static irqreturn_t omap_32k_timer_interrupt(int irq, void *dev_id)
static struct irqaction omap_32k_timer_irq = {
.name = "32KHz timer",
- .flags = IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL,
+ .flags = IRQF_TIMER | IRQF_IRQPOLL,
.handler = omap_32k_timer_interrupt,
};
diff --git a/arch/arm/mach-omap2/omap_l3_noc.c b/arch/arm/mach-omap2/omap_l3_noc.c
index c8b1bef..a679437 100644
--- a/arch/arm/mach-omap2/omap_l3_noc.c
+++ b/arch/arm/mach-omap2/omap_l3_noc.c
@@ -186,7 +186,7 @@ static int __devinit omap4_l3_probe(struct platform_device *pdev)
l3->debug_irq = platform_get_irq(pdev, 0);
ret = request_irq(l3->debug_irq,
l3_interrupt_handler,
- IRQF_DISABLED, "l3-dbg-irq", l3);
+ 0, "l3-dbg-irq", l3);
if (ret) {
pr_crit("L3: request_irq failed to register for 0x%x\n",
OMAP44XX_IRQ_L3_DBG);
@@ -196,7 +196,7 @@ static int __devinit omap4_l3_probe(struct platform_device *pdev)
l3->app_irq = platform_get_irq(pdev, 1);
ret = request_irq(l3->app_irq,
l3_interrupt_handler,
- IRQF_DISABLED, "l3-app-irq", l3);
+ 0, "l3-app-irq", l3);
if (ret) {
pr_crit("L3: request_irq failed to register for 0x%x\n",
OMAP44XX_IRQ_L3_APP);
diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
index a05a62f..c1c33bf 100644
--- a/arch/arm/mach-omap2/omap_l3_smx.c
+++ b/arch/arm/mach-omap2/omap_l3_smx.c
@@ -237,7 +237,7 @@ static int __init omap3_l3_probe(struct platform_device *pdev)
l3->debug_irq = platform_get_irq(pdev, 0);
ret = request_irq(l3->debug_irq, omap3_l3_app_irq,
- IRQF_DISABLED | IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING,
"l3-debug-irq", l3);
if (ret) {
dev_err(&pdev->dev, "couldn't request debug irq\n");
@@ -246,7 +246,7 @@ static int __init omap3_l3_probe(struct platform_device *pdev)
l3->app_irq = platform_get_irq(pdev, 1);
ret = request_irq(l3->app_irq, omap3_l3_app_irq,
- IRQF_DISABLED | IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING,
"l3-app-irq", l3);
if (ret) {
dev_err(&pdev->dev, "couldn't request app irq\n");
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index c8cbd00..ea5b37a 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -878,7 +878,7 @@ static int __init omap3_pm_init(void)
ret = request_irq(INT_34XX_PRCM_MPU_IRQ,
(irq_handler_t)prcm_interrupt_handler,
- IRQF_DISABLED, "prcm", NULL);
+ 0, "prcm", NULL);
if (ret) {
printk(KERN_ERR "request_irq failed to register for 0x%x\n",
INT_34XX_PRCM_MPU_IRQ);
diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
index 037b0d7..2bc303c 100644
--- a/arch/arm/mach-omap2/timer.c
+++ b/arch/arm/mach-omap2/timer.c
@@ -91,7 +91,7 @@ static irqreturn_t omap2_gp_timer_interrupt(int irq, void *dev_id)
static struct irqaction omap2_gp_timer_irq = {
.name = "gp timer",
- .flags = IRQF_DISABLED | IRQF_TIMER | IRQF_IRQPOLL,
+ .flags = IRQF_TIMER | IRQF_IRQPOLL,
.handler = omap2_gp_timer_interrupt,
};
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index c22217c..f51e18e 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -1928,7 +1928,6 @@ static irqreturn_t omap2_dma_irq_handler(int irq, void *dev_id)
static struct irqaction omap24xx_dma_irq = {
.name = "DMA",
.handler = omap2_dma_irq_handler,
- .flags = IRQF_DISABLED
};
#else
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm: omap: removed obsolete IRQF_DISABLED
2011-10-09 5:46 ` [PATCH 1/1] arm: omap: removed " Michael Opdenacker
@ 2011-11-03 22:15 ` Tony Lindgren
2011-11-04 14:10 ` Michael Opdenacker
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2011-11-03 22:15 UTC (permalink / raw)
To: Michael Opdenacker
Cc: linux, khilman, linux-omap, linux-arm-kernel, linux-kernel, patches
* Michael Opdenacker <michael.opdenacker@linaro.org> [111008 22:13]:
> This flag is a NOOP since 2.6.36
Looks like there's an ARM wide patch to do this with
"[PATCH 03/55] arm: irq: Remove IRQF_DISABLED".
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm: omap: removed obsolete IRQF_DISABLED
2011-11-03 22:15 ` Tony Lindgren
@ 2011-11-04 14:10 ` Michael Opdenacker
0 siblings, 0 replies; 4+ messages in thread
From: Michael Opdenacker @ 2011-11-04 14:10 UTC (permalink / raw)
To: Tony Lindgren
Cc: khilman, linux, patches, linux-kernel, linux-omap, linux-arm-kernel
Hi Tony,
On 11/03/2011 06:15 PM, Tony Lindgren wrote:
> * Michael Opdenacker <michael.opdenacker@linaro.org> [111008 22:13]:
>> This flag is a NOOP since 2.6.36
> Looks like there's an ARM wide patch to do this with
> "[PATCH 03/55] arm: irq: Remove IRQF_DISABLED".
Good. Let's take this one then. I hadn't gone through all the sub
maintainers yet.
Thanks for your reply,
Cheers,
Michael.
--
Michael Opdenacker - Community Manager
Linaro, http://linaro.org
Phone: +33 484 253 396
IRC: 'opm' in #linaro on irc.freenode.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-04 14:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-09 5:46 [PATCH 0/1] arm: omap: remove obsolete IRQF_DISABLED Michael Opdenacker
2011-10-09 5:46 ` [PATCH 1/1] arm: omap: removed " Michael Opdenacker
2011-11-03 22:15 ` Tony Lindgren
2011-11-04 14:10 ` Michael Opdenacker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).