[PATCH] get_maintainers.pl: Follow renames when looking up commit signers

[PATCH] get_maintainers.pl: Follow renames when looking up commit signers

[Ian Campbell]

I happen to have had a commit to various network drivers since the big
renaming/reorg which happened to drivers/net recently. This means that I
now appear to be in the top few commit signers (by %age) for many of
them so am getting sent all sorts of stuff and people who are involved
with the driver are not. e.g. (to pick one at random):

        $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
        "David S. Miller" <davem@davemloft.net> (commit_signer:5/7=71%)
        Ian Campbell <ian.campbell@citrix.com> (commit_signer:2/7=29%)
        Eric Dumazet <eric.dumazet@gmail.com> (commit_signer:1/7=14%)
        Jeff Kirsher <jeffrey.t.kirsher@intel.com> (commit_signer:1/7=14%)
        Jiri Pirko <jpirko@redhat.com> (commit_signer:1/7=14%)
        netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
        linux-kernel@vger.kernel.org (open list)

With the following patch the renames are followed and the result appears
much more sensible:

        $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
        "David S. Miller" <davem@davemloft.net> (commit_signer:31/34=91%)
        Joe Perches <joe@perches.com> (commit_signer:11/34=32%)
        Szymon Janc <szymon@janc.net.pl> (commit_signer:5/34=15%)
        Jiri Pirko <jpirko@redhat.com> (commit_signer:3/34=9%)
        Paul <paul.gortmaker@windriver.com> (commit_signer:2/34=6%)
        netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
        linux-kernel@vger.kernel.org (open list)
        
Signed-off-by: Ian.Campbell@citrix.com

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 4594f33..f32a04c 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -95,7 +95,7 @@ my %VCS_cmds_git = (
     "execute_cmd" => \&git_execute_cmd,
     "available" => '(which("git") ne "") && (-d ".git")',
     "find_signers_cmd" =>
-	"git log --no-color --since=\$email_git_since " .
+	"git log --no-color --follow --since=\$email_git_since " .
 	    '--format="GitCommit: %H%n' .
 		      'GitAuthor: %an <%ae>%n' .
 		      'GitDate: %aD%n' .

Re: [PATCH] get_maintainers.pl: Follow renames when looking up commit signers

[Joe Perches]

On Fri, 2011-11-11 at 07:59 +0000, Ian Campbell wrote:
[]
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -95,7 +95,7 @@ my %VCS_cmds_git = (
> -	"git log --no-color --since=\$email_git_since " .
> +	"git log --no-color --follow --since=\$email_git_since " .

Signed-off-by: Joe Perches <joe@perches.com>

Mercurial linux-kernel repository at kernel.org?

[Joe Perches]

Prior to intrusion, a mercurial repository essentially
duplicating the Linus' git tree existed at:
http://www.kernel.com/hg/linux-2.6

I do not use it, but are there any plans to restore it?

Re: Mercurial linux-kernel repository at kernel.org?

[Matt Mackall]

[uncrossposting]

On Fri, 2011-11-11 at 04:09 -0800, Joe Perches wrote:
> Prior to intrusion, a mercurial repository essentially
> duplicating the Linus' git tree existed at:
> http://www.kernel.com/hg/linux-2.6
> 
> I do not use it, but are there any plans to restore it?

Not on kernel.org, certainly.

I asked the kernel.org admins a while back to send me a copy of the SHA
map file from my account I needed to continue the mirror elsewhere and
HPA declined, making some handwaving towards "eventually letting people
download tarballs of their old accounts".

As far as I know, "eventually" hasn't happened yet. I guess it's time to
fire up a new mirror from scratch. It'll be incompatible with old clones
due to not having the above file and various minor changes in both git
and hg in the 6 years the original mirror was running. I'll announce it
when it's done - it'll probably take a while.

-- 
Mathematics is the supreme nostalgia of our time.

Re: Mercurial linux-kernel repository at kernel.org?

[Joe Perches]

On Fri, 2011-11-11 at 12:06 -0600, Matt Mackall wrote:
> [uncrossposting]
> 
> On Fri, 2011-11-11 at 04:09 -0800, Joe Perches wrote:
> > Prior to intrusion, a mercurial repository essentially
> > duplicating the Linus' git tree existed at:
> > http://www.kernel.com/hg/linux-2.6
> > 
> > I do not use it, but are there any plans to restore it?
> 
> Not on kernel.org, certainly.
> 
> I asked the kernel.org admins a while back to send me a copy of the SHA
> map file from my account I needed to continue the mirror elsewhere and
> HPA declined, making some handwaving towards "eventually letting people
> download tarballs of their old accounts".
> 
> As far as I know, "eventually" hasn't happened yet. I guess it's time to
> fire up a new mirror from scratch. It'll be incompatible with old clones
> due to not having the above file and various minor changes in both git
> and hg in the 6 years the original mirror was running. I'll announce it
> when it's done - it'll probably take a while.

No worries.  I'm not an hg user.  Ian Campbell sent a patch
to get_maintainer to use git log option --follow for a largish
file rename event in drivers/net/... and I was trying to get
the hg commands in get_maintainer to do the same.

Any idea if tracking file renames in hg needs an additional
command line option and if so what it is?

Re: Mercurial linux-kernel repository at kernel.org?

[John 'Warthog9' Hawley]

>> I do not use it, but are there any plans to restore it?
> 
> Not on kernel.org, certainly.

I'll actually say, it hasn't been an immediate priority given the number
of other tasks that are more immediately pending.

> I asked the kernel.org admins a while back to send me a copy of the SHA
> map file from my account I needed to continue the mirror elsewhere and
> HPA declined, making some handwaving towards "eventually letting people
> download tarballs of their old accounts".

There hasn't been any serious movement on getting you your home
directory for several reasons:

1) You haven't asked for your account to be reinstated on kernel.org.  I
have no record of you having ever sent in a gpg key at all, let alone
one that's been signed so we can verify you and your request

2) Without a gpg key so we can verify you and your request, we can't
encrypt your home dir and get it to you.

3) You asked hpa directly and not ftpadmin@kernel.org

> As far as I know, "eventually" hasn't happened yet. I guess it's time to
> fire up a new mirror from scratch. It'll be incompatible with old clones
> due to not having the above file and various minor changes in both git
> and hg in the 6 years the original mirror was running. I'll announce it
> when it's done - it'll probably take a while.

Re: Mercurial linux-kernel repository at kernel.org?

[Matt Mackall]

On Fri, 2011-11-11 at 11:24 -0800, Joe Perches wrote:
> On Fri, 2011-11-11 at 12:06 -0600, Matt Mackall wrote:
> > [uncrossposting]
> > 
> > On Fri, 2011-11-11 at 04:09 -0800, Joe Perches wrote:
> > > Prior to intrusion, a mercurial repository essentially
> > > duplicating the Linus' git tree existed at:
> > > http://www.kernel.com/hg/linux-2.6
> > > 
> > > I do not use it, but are there any plans to restore it?
> > 
> > Not on kernel.org, certainly.
> > 
> > I asked the kernel.org admins a while back to send me a copy of the SHA
> > map file from my account I needed to continue the mirror elsewhere and
> > HPA declined, making some handwaving towards "eventually letting people
> > download tarballs of their old accounts".
> > 
> > As far as I know, "eventually" hasn't happened yet. I guess it's time to
> > fire up a new mirror from scratch. It'll be incompatible with old clones
> > due to not having the above file and various minor changes in both git
> > and hg in the 6 years the original mirror was running. I'll announce it
> > when it's done - it'll probably take a while.
> 
> No worries.  I'm not an hg user.  Ian Campbell sent a patch
> to get_maintainer to use git log option --follow for a largish
> file rename event in drivers/net/... and I was trying to get
> the hg commands in get_maintainer to do the same.
> 
> Any idea if tracking file renames in hg needs an additional
> command line option and if so what it is?

hg log --follow <some-file> will follow the history across renames.

-- 
Mathematics is the supreme nostalgia of our time.