* [PATCH] ARM: add subname parameter to mfp_set_groupg callers
@ 2011-11-24 3:06 Axel Lin
2011-11-24 10:19 ` Mark Brown
2011-11-24 10:32 ` Russell King
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2011-11-24 3:06 UTC (permalink / raw)
To: linux-kernel
Cc: Wan ZongShun, Russell King, Jean Delvare (PC drivers, core),
Ben Dooks (embedded platforms),
Grant Likely, Liam Girdwood, Mark Brown
commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900"
adds subname parameter for mfp_set_groupg.
Thus add subname parameter to the callers.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
commit 798681bf is in Russell King's tree,
I think this patch should route via Russell's tree.
This patch is against linux-next 20111123.
Axel
drivers/i2c/busses/i2c-nuc900.c | 2 +-
drivers/spi/spi-nuc900.c | 2 +-
sound/soc/nuc900/nuc900-ac97.c | 3 ++-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-nuc900.c b/drivers/i2c/busses/i2c-nuc900.c
index 835e47b..03b6157 100644
--- a/drivers/i2c/busses/i2c-nuc900.c
+++ b/drivers/i2c/busses/i2c-nuc900.c
@@ -593,7 +593,7 @@ static int __devinit nuc900_i2c_probe(struct platform_device *pdev)
i2c->adap.algo_data = i2c;
i2c->adap.dev.parent = &pdev->dev;
- mfp_set_groupg(&pdev->dev);
+ mfp_set_groupg(&pdev->dev, NULL);
clk_get_rate(i2c->clk);
diff --git a/drivers/spi/spi-nuc900.c b/drivers/spi/spi-nuc900.c
index e763254..21c70b2 100644
--- a/drivers/spi/spi-nuc900.c
+++ b/drivers/spi/spi-nuc900.c
@@ -426,7 +426,7 @@ static int __devinit nuc900_spi_probe(struct platform_device *pdev)
goto err_clk;
}
- mfp_set_groupg(&pdev->dev);
+ mfp_set_groupg(&pdev->dev, NULL);
nuc900_init_spi(hw);
err = spi_bitbang_start(&hw->bitbang);
diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index d9343ee..dbf597f 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -365,7 +365,8 @@ static int __devinit nuc900_ac97_drvprobe(struct platform_device *pdev)
if (ret)
goto out3;
- mfp_set_groupg(nuc900_audio->dev); /* enbale ac97 multifunction pin*/
+ /* enbale ac97 multifunction pin */
+ mfp_set_groupg(nuc900_audio->dev, "nuc900-audio");
return 0;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: add subname parameter to mfp_set_groupg callers
2011-11-24 3:06 [PATCH] ARM: add subname parameter to mfp_set_groupg callers Axel Lin
@ 2011-11-24 10:19 ` Mark Brown
2011-11-24 10:32 ` Russell King
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2011-11-24 10:19 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Wan ZongShun, Russell King,
Jean Delvare (PC drivers, core), Ben Dooks (embedded platforms),
Grant Likely, Liam Girdwood
On Thu, Nov 24, 2011 at 11:06:23AM +0800, Axel Lin wrote:
> commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900"
> adds subname parameter for mfp_set_groupg.
>
> Thus add subname parameter to the callers.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: add subname parameter to mfp_set_groupg callers
2011-11-24 3:06 [PATCH] ARM: add subname parameter to mfp_set_groupg callers Axel Lin
2011-11-24 10:19 ` Mark Brown
@ 2011-11-24 10:32 ` Russell King
2011-11-24 10:38 ` Axel Lin
1 sibling, 1 reply; 5+ messages in thread
From: Russell King @ 2011-11-24 10:32 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Wan ZongShun, Jean Delvare (PC drivers, core),
Ben Dooks (embedded platforms),
Grant Likely, Liam Girdwood, Mark Brown
On Thu, Nov 24, 2011 at 11:06:23AM +0800, Axel Lin wrote:
> commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900"
> adds subname parameter for mfp_set_groupg.
>
> Thus add subname parameter to the callers.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> commit 798681bf is in Russell King's tree,
It's in mainline as of 20th November.
> I think this patch should route via Russell's tree.
> This patch is against linux-next 20111123.
Is there a reason why this isn't copied to linux-arm-kernel ?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: add subname parameter to mfp_set_groupg callers
2011-11-24 10:32 ` Russell King
@ 2011-11-24 10:38 ` Axel Lin
2011-11-24 11:59 ` Wan ZongShun
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2011-11-24 10:38 UTC (permalink / raw)
To: Russell King
Cc: linux-kernel, Wan ZongShun, Jean Delvare (PC drivers, core),
Ben Dooks (embedded platforms),
Grant Likely, Liam Girdwood, Mark Brown
2011/11/24 Russell King <rmk@arm.linux.org.uk>:
> On Thu, Nov 24, 2011 at 11:06:23AM +0800, Axel Lin wrote:
>> commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900"
>> adds subname parameter for mfp_set_groupg.
>>
>> Thus add subname parameter to the callers.
>>
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>> ---
>> commit 798681bf is in Russell King's tree,
>
> It's in mainline as of 20th November.
Then this patch should be for 3.2. It fixes build errors.
>
>> I think this patch should route via Russell's tree.
>> This patch is against linux-next 20111123.
>
> Is there a reason why this isn't copied to linux-arm-kernel ?
Sorry.
I don't know why scripts/get_maintainer.pl does not suggest to Cc
linux-arm-kernel
when I run scripts/get_maintainer.pl against this patch.
Regards,
Axel
>
> --
> Russell King
> Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
> maintainer of:
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: add subname parameter to mfp_set_groupg callers
2011-11-24 10:38 ` Axel Lin
@ 2011-11-24 11:59 ` Wan ZongShun
0 siblings, 0 replies; 5+ messages in thread
From: Wan ZongShun @ 2011-11-24 11:59 UTC (permalink / raw)
To: axel.lin
Cc: Russell King, linux-kernel, Jean Delvare (PC drivers, core),
Ben Dooks (embedded platforms),
Grant Likely, Liam Girdwood, Mark Brown
2011/11/24 Axel Lin <axel.lin@gmail.com>:
> 2011/11/24 Russell King <rmk@arm.linux.org.uk>:
>> On Thu, Nov 24, 2011 at 11:06:23AM +0800, Axel Lin wrote:
>>> commit 798681bf "ARM: 7158/1: add new MFP implement for NUC900"
>>> adds subname parameter for mfp_set_groupg.
>>>
>>> Thus add subname parameter to the callers.
>>>
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>>> ---
>>> commit 798681bf is in Russell King's tree,
>>
>> It's in mainline as of 20th November.
>
> Then this patch should be for 3.2. It fixes build errors.
>
>>
>>> I think this patch should route via Russell's tree.
>>> This patch is against linux-next 20111123.
>>
>> Is there a reason why this isn't copied to linux-arm-kernel ?
> Sorry.
> I don't know why scripts/get_maintainer.pl does not suggest to Cc
> linux-arm-kernel
> when I run scripts/get_maintainer.pl against this patch.
>
> Regards,
> Axel
>>
>> --
>> Russell King
>> Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
>> maintainer of:
>>
>
Acked-by :Wan Zongshun <mcuos.com@gmail.com>
This is my omit, thanks Alex!
--
Wan ZongShun.
www.mcuos.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-24 12:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-24 3:06 [PATCH] ARM: add subname parameter to mfp_set_groupg callers Axel Lin
2011-11-24 10:19 ` Mark Brown
2011-11-24 10:32 ` Russell King
2011-11-24 10:38 ` Axel Lin
2011-11-24 11:59 ` Wan ZongShun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).