* [PATCH RESEND] MXSFB: Fix driver registration
@ 2011-12-19 15:37 Marek Vasut
2011-12-19 22:54 ` Shawn Guo
2011-12-21 21:42 ` Florian Tobias Schandinat
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2011-12-19 15:37 UTC (permalink / raw)
To: linux-kernel
Cc: linux-fbdev, FlorianSchandinat, Marek Vasut, Wolfgang Denk,
Stefano Babic, Shawn Guo, Huang Shijie, Axel Lin, Sascha Hauer
The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
This caused obvious null pointer dereference and crash.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Huang Shijie <b32955@freescale.com>
Cc: Axel Lin <axel.lin@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/video/mxsfb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 18742c2..d29c7c0 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
},
};
-module_platform_driver(mxsfb_devtype);
+module_platform_driver(mxsfb_driver);
MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
MODULE_AUTHOR("Sascha Hauer, Pengutronix");
--
1.7.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] MXSFB: Fix driver registration
2011-12-19 15:37 [PATCH RESEND] MXSFB: Fix driver registration Marek Vasut
@ 2011-12-19 22:54 ` Shawn Guo
2011-12-21 21:42 ` Florian Tobias Schandinat
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2011-12-19 22:54 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-kernel, linux-fbdev, FlorianSchandinat, Wolfgang Denk,
Stefano Babic, Huang Shijie, Axel Lin, Sascha Hauer
On 19 December 2011 23:37, Marek Vasut <marek.vasut@gmail.com> wrote:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Huang Shijie <b32955@freescale.com>
> Cc: Axel Lin <axel.lin@gmail.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Acked-by: Axel Lin <axel.lin@gmail.com>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] MXSFB: Fix driver registration
2011-12-19 15:37 [PATCH RESEND] MXSFB: Fix driver registration Marek Vasut
2011-12-19 22:54 ` Shawn Guo
@ 2011-12-21 21:42 ` Florian Tobias Schandinat
1 sibling, 0 replies; 3+ messages in thread
From: Florian Tobias Schandinat @ 2011-12-21 21:42 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-kernel, linux-fbdev, Wolfgang Denk, Stefano Babic,
Shawn Guo, Huang Shijie, Axel Lin, Sascha Hauer
On 12/19/2011 03:37 PM, Marek Vasut wrote:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Huang Shijie <b32955@freescale.com>
> Cc: Axel Lin <axel.lin@gmail.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Acked-by: Axel Lin <axel.lin@gmail.com>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/mxsfb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 18742c2..d29c7c0 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
> },
> };
>
> -module_platform_driver(mxsfb_devtype);
> +module_platform_driver(mxsfb_driver);
>
> MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
> MODULE_AUTHOR("Sascha Hauer, Pengutronix");
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-21 21:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-19 15:37 [PATCH RESEND] MXSFB: Fix driver registration Marek Vasut
2011-12-19 22:54 ` Shawn Guo
2011-12-21 21:42 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).